ViewTest::testViewRequestWithAndStatement() - Code Metrics - Inspection of "EZP-30806: Fixed processing REST logical op. input..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 6.13 ( d8f059...2d8437 )

unknown

created 2019-12-05 14:17 UTC

ViewTest::testViewRequestWithAndStatement() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	31
rs	9.424
c	0
b	0
f	0

<?php

/**
 * File containing the Functional\ViewTest class.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Bundle\EzPublishRestBundle\Tests\Functional;

use stdClass;

class ViewTest extends TestCase
{
    /** @var string[] */
    private static $createdContentRemoteIds = [];

    /**
     * Covers POST /views.
     *
     * @dataProvider providerForTestViewRequest
     *
     * @param string $body
     * @param string $format
     * @param int $expectedResultsCount
     * @param \stdClass[] $contentDataList list of items containing name and remoteId properties
     */
    public function testViewRequest($body, $format, $expectedResultsCount, array $contentDataList)
    {
        $this->createTestContentItems($contentDataList);

        // search for Content
        $request = $this->createHttpRequest(
            'POST',
            '/api/ezp/v2/views',
            "ViewInput+{$format}",
            'View+json'
        );
        $request->setContent($body);
        $response = $this->sendHttpRequest($request);
        $responseData = json_decode($response->getContent(), true);

        if (isset($responseData['ErrorMessage'])) {
            self::fail(var_export($responseData, true));
        }

        self::assertEquals($expectedResultsCount, $responseData['View']['Result']['count']);
    }

    /**
     * Data provider for testViewRequestWithOrStatement.
     *
     * @return array
     */
    public function providerForTestViewRequest()
    {
        $foo = new stdClass();
        $foo->name = uniqid('View test content foo');
        $foo->remoteId = md5($foo->name);

        $bar = new stdClass();
        $bar->name = uniqid('View test content bar');
        $bar->remoteId = md5($bar->name);

        return [
            [
                <<< XML
<?xml version="1.0" encoding="UTF-8"?>
<ViewInput>
  <identifier>TitleView</identifier>
  <Query>
    <Filter>
        <OR>
            <ContentRemoteIdCriterion>{$foo->remoteId}</ContentRemoteIdCriterion>
            <ContentRemoteIdCriterion>{$bar->remoteId}</ContentRemoteIdCriterion>
        </OR>
    </Filter>
    <limit>10</limit>
    <offset>0</offset>
  </Query>
</ViewInput>
XML,
                'xml',
                2,
                [$foo, $bar],
            ],
            [
                <<< JSON
{
  "ViewInput": {
    "identifier": "TitleView",
    "Query": {
      "Filter": {
        "OR": {
          "ContentRemoteIdCriterion": [
            "{$foo->remoteId}",
            "{$bar->remoteId}"
          ]
        }
      },
      "limit": "10",
      "offset": "0"
    }
  }
}
JSON,
                'json',
                2,
                [$foo, $bar],
            ],
            [
                <<< XML
<?xml version="1.0" encoding="UTF-8"?>
<ViewInput>
  <identifier>TitleView</identifier>
  <Query>
    <Filter>
        <AND>
            <OR>
                <ContentRemoteIdCriterion>{$foo->remoteId}</ContentRemoteIdCriterion>
                <ContentRemoteIdCriterion>{$bar->remoteId}</ContentRemoteIdCriterion>
            </OR>
            <ContentRemoteIdCriterion>{$foo->remoteId}</ContentRemoteIdCriterion>
        </AND>
    </Filter>
    <limit>10</limit>
    <offset>0</offset>
  </Query>
</ViewInput>
XML,
                'xml',
                1,
                [$foo, $bar],
            ],
            [
                <<< JSON
{
  "ViewInput": {
    "identifier": "TitleView",
    "public": true,
    "Query": {
      "Filter": {
        "OR": [
          {
            "ContentRemoteIdCriterion": "{$foo->remoteId}"
          },
          {
            "ContentRemoteIdCriterion": "{$bar->remoteId}"
          }
        ]
      },
      "FacetBuilders": {},
      "SortClauses": {},
      "limit": 1000,
      "offset": 0
    }
  }
}
JSON,
                'json',
                2,
                [$foo, $bar],
            ],
            [
                <<< JSON
{
  "ViewInput": {
    "identifier": "udw-locations-by-parent-location-id-1",
    "public": false,
    "Query": {
      "Criteria": {},
      "FacetBuilders": {},
      "SortClauses": {},
      "Filter": {
        "AND": [
          {
            "OR": [
              {
                "ContentTypeIdentifierCriterion": "folder"
              },
              {
                "ContentTypeIdentifierCriterion": "article"
              }
            ]
          },
          {
            "OR": [
              {
                "ContentRemoteIdCriterion": "{$foo->remoteId}"
              },
              {
                "ContentRemoteIdCriterion": "{$bar->remoteId}"
              }
            ]
          }
        ]
      },
      "limit": 50,
      "offset": 0
    }
  }
}
JSON,
                'json',
                2,
                [$foo, $bar],
            ],
        ];
    }

    /**
     * @param \stdClass[] $contentDataList
     */
    private function createTestContentItems(array $contentDataList)
    {
        foreach ($contentDataList as $contentData) {
            // skip creating already created items
            if (in_array($contentData->remoteId, self::$createdContentRemoteIds)) {
                continue;
            }

            $this->createFolder(
                $contentData->name,
                '/api/ezp/v2/content/locations/1/2',
                $contentData->remoteId
            );
            self::$createdContentRemoteIds[] = $contentData->remoteId;

        }
    }
}


1			<?php
2
3			/**
4			* File containing the Functional\ViewTest class.
5			*
6			* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7			* @license For full copyright and license information view LICENSE file distributed with this source code.
8			*/
9			namespace eZ\Bundle\EzPublishRestBundle\Tests\Functional;
10
11			use stdClass;
12
13			class ViewTest extends TestCase
14			{
15			/** @var string[] */
16			private static $createdContentRemoteIds = [];
17
18			/**
19			* Covers POST /views.
20			*
21			* @dataProvider providerForTestViewRequest
22			*
23			* @param string $body
24			* @param string $format
25			* @param int $expectedResultsCount
26			* @param \stdClass[] $contentDataList list of items containing name and remoteId properties
27			*/
28			public function testViewRequest($body, $format, $expectedResultsCount, array $contentDataList)
29			{
30			$this->createTestContentItems($contentDataList);
31
32			// search for Content
33			$request = $this->createHttpRequest(
34			'POST',
35			'/api/ezp/v2/views',
36			"ViewInput+{$format}",
37			'View+json'
38			);
39			$request->setContent($body);
40			$response = $this->sendHttpRequest($request);
41			$responseData = json_decode($response->getContent(), true);
42
43			if (isset($responseData['ErrorMessage'])) {
44			self::fail(var_export($responseData, true));
45			}
46
47			self::assertEquals($expectedResultsCount, $responseData['View']['Result']['count']);
48			}
49
50			/**
51			* Data provider for testViewRequestWithOrStatement.
52			*
53			* @return array
54			*/
55			public function providerForTestViewRequest()
56			{
57			$foo = new stdClass();
58			$foo->name = uniqid('View test content foo');
59			$foo->remoteId = md5($foo->name);
60
61			$bar = new stdClass();
62			$bar->name = uniqid('View test content bar');
63			$bar->remoteId = md5($bar->name);
64
65			return [
66			[
67			<<< XML
68			<?xml version="1.0" encoding="UTF-8"?>
69			<ViewInput>
70			<identifier>TitleView</identifier>
71			<Query>
72			<Filter>
73			<OR>
74			<ContentRemoteIdCriterion>{$foo->remoteId}</ContentRemoteIdCriterion>
75			<ContentRemoteIdCriterion>{$bar->remoteId}</ContentRemoteIdCriterion>
76			</OR>
77			</Filter>
78			<limit>10</limit>
79			<offset>0</offset>
80			</Query>
81			</ViewInput>
82			XML,
83			'xml',
84			2,
85			[$foo, $bar],
86			],
87			[
88			<<< JSON
89			{
90			"ViewInput": {
91			"identifier": "TitleView",
92			"Query": {
93			"Filter": {
94			"OR": {
95			"ContentRemoteIdCriterion": [
96			"{$foo->remoteId}",
97			"{$bar->remoteId}"
98			]
99			}
100			},
101			"limit": "10",
102			"offset": "0"
103			}
104			}
105			}
106			JSON,
107			'json',
108			2,
109			[$foo, $bar],
110			],
111			[
112			<<< XML
113			<?xml version="1.0" encoding="UTF-8"?>
114			<ViewInput>
115			<identifier>TitleView</identifier>
116			<Query>
117			<Filter>
118			<AND>
119			<OR>
120			<ContentRemoteIdCriterion>{$foo->remoteId}</ContentRemoteIdCriterion>
121			<ContentRemoteIdCriterion>{$bar->remoteId}</ContentRemoteIdCriterion>
122			</OR>
123			<ContentRemoteIdCriterion>{$foo->remoteId}</ContentRemoteIdCriterion>
124			</AND>
125			</Filter>
126			<limit>10</limit>
127			<offset>0</offset>
128			</Query>
129			</ViewInput>
130			XML,
131			'xml',
132			1,
133			[$foo, $bar],
134			],
135			[
136			<<< JSON
137			{
138			"ViewInput": {
139			"identifier": "TitleView",
140			"public": true,
141			"Query": {
142			"Filter": {
143			"OR": [
144			{
145			"ContentRemoteIdCriterion": "{$foo->remoteId}"
146			},
147			{
148			"ContentRemoteIdCriterion": "{$bar->remoteId}"
149			}
150			]
151			},
152			"FacetBuilders": {},
153			"SortClauses": {},
154			"limit": 1000,
155			"offset": 0
156			}
157			}
158			}
159			JSON,
160			'json',
161			2,
162			[$foo, $bar],
163			],
164			[
165			<<< JSON
166			{
167			"ViewInput": {
168			"identifier": "udw-locations-by-parent-location-id-1",
169			"public": false,
170			"Query": {
171			"Criteria": {},
172			"FacetBuilders": {},
173			"SortClauses": {},
174			"Filter": {
175			"AND": [
176			{
177			"OR": [
178			{
179			"ContentTypeIdentifierCriterion": "folder"
180			},
181			{
182			"ContentTypeIdentifierCriterion": "article"
183			}
184			]
185			},
186			{
187			"OR": [
188			{
189			"ContentRemoteIdCriterion": "{$foo->remoteId}"
190			},
191			{
192			"ContentRemoteIdCriterion": "{$bar->remoteId}"
193			}
194			]
195			}
196			]
197			},
198			"limit": 50,
199			"offset": 0
200			}
201			}
202			}
203			JSON,
204			'json',
205			2,
206			[$foo, $bar],
207			],
208			];
209			}
210
211			/**
212			* @param \stdClass[] $contentDataList
213			*/
214			private function createTestContentItems(array $contentDataList)
215			{
216			foreach ($contentDataList as $contentData) {
217			// skip creating already created items
218			if (in_array($contentData->remoteId, self::$createdContentRemoteIds)) {
219			continue;
220			}
221
222			$this->createFolder(
223			$contentData->name,
224			'/api/ezp/v2/content/locations/1/2',
225			$contentData->remoteId
226			);
227			self::$createdContentRemoteIds[] = $contentData->remoteId;
			0 ignored issues – show Bug introduced 2019-11-26 18:17 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected ']', expecting T_STRING or T_VARIABLE or T_NUM_STRING Loading history...
228			}
229			}
230			}
231

ezsystems / ezpublish-kernel

Push — 6.13 ( d8f059...2d8437 )

ViewTest::testViewRequestWithAndStatement() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like