EZP28799SubtreeSearchTest::testConflictingConditions() - Code Metrics - Inspection of "Merge branch '6.13' into 7.0" - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 7.0 ( b4367b...19cc1b )

by André

created 2018-03-01 10:33 UTC

testConflictingConditions() A

↳ Parent: EZP28799SubtreeSearchTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	21
Code Lines	13

Duplication

Lines	21
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
eloc	13
nc	1
nop	0
dl	21
loc	21
rs	9.3142
c	0
b	0
f	0

<?php

/**
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Publish\API\Repository\Tests\Regression;

use eZ\Publish\API\Repository\Tests\BaseTest;
use eZ\Publish\API\Repository\Values\Content\Query;

/**
 * @link https://jira.ez.no/browse/EZP-28799
 */
class EZP28799SubtreeSearchTest extends BaseTest
{
    /**
     * @return \eZ\Publish\API\Repository\Values\Content\Content[]
     */
    public function createTestContent()
    {
        $rootLocationId = 2;
        $contentService = $this->getRepository()->getContentService();
        $contentTypeService = $this->getRepository()->getContentTypeService();
        $locationService = $this->getRepository()->getLocationService();

        $contentType = $contentTypeService->loadContentTypeByIdentifier('folder');
        $locationCreateStruct = $locationService->newLocationCreateStruct($rootLocationId);

        $contentCreateStruct = $contentService->newContentCreateStruct($contentType, 'eng-GB');
        $contentCreateStruct->setField('name', 'LEFT');

        $draft = $contentService->createContent($contentCreateStruct, [$locationCreateStruct]);
        $leftFolder = $contentService->publishVersion($draft->versionInfo);

        $contentCreateStruct = $contentService->newContentCreateStruct($contentType, 'eng-GB');
        $contentCreateStruct->setField('name', 'RIGHT');

        $draft = $contentService->createContent($contentCreateStruct, [$locationCreateStruct]);
        $rightFolder = $contentService->publishVersion($draft->versionInfo);

        $contentCreateStruct = $contentService->newContentCreateStruct($contentType, 'eng-GB');
        $contentCreateStruct->setField('name', 'TARGET');

        $locationCreateStructLeft = $locationService->newLocationCreateStruct(
            $leftFolder->contentInfo->mainLocationId
        );
        $locationCreateStructRight = $locationService->newLocationCreateStruct(
            $rightFolder->contentInfo->mainLocationId
        );
        $draft = $contentService->createContent(
            $contentCreateStruct,
            [
                $locationCreateStructLeft,
                $locationCreateStructRight,
            ]
        );
        $targetFolder = $contentService->publishVersion($draft->versionInfo);

        return [$leftFolder, $rightFolder, $targetFolder];
    }

    public function testConflictingConditions()
    {
        list($leftFolder, $rightFolder, $targetFolder) = $this->createTestContent();
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
        $locationService = $this->getRepository()->getLocationService();
        $leftLocation = $locationService->loadLocation($leftFolder->contentInfo->mainLocationId);

        $query = new Query([
            'filter' => new Query\Criterion\LogicalAnd([
                new Query\Criterion\ContentId($targetFolder->contentInfo->id),
                new Query\Criterion\Subtree($leftLocation->pathString),
                new Query\Criterion\LogicalNot(
                    new Query\Criterion\Subtree($leftLocation->pathString)
                ),
            ]),
        ]);

        $searchService = $this->getRepository()->getSearchService();
        $result = $searchService->findContent($query);

        $this->assertSame(0, $result->totalCount);
    }

    public function testNegativeSubtree()
    {
        list($leftFolder, $rightFolder, $targetFolder) = $this->createTestContent();
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
        $locationService = $this->getRepository()->getLocationService();
        $leftLocation = $locationService->loadLocation($leftFolder->contentInfo->mainLocationId);

        $query = new Query([
            'filter' => new Query\Criterion\LogicalAnd([
                new Query\Criterion\ContentId($targetFolder->contentInfo->id),
                new Query\Criterion\LogicalNot(
                    new Query\Criterion\Subtree($leftLocation->pathString)
                ),
            ]),
        ]);

        $searchService = $this->getRepository()->getSearchService();
        $result = $searchService->findContent($query);

        $this->assertSame(0, $result->totalCount);
    }
}


1		<?php
2
3		/**
4		* @copyright Copyright (C) eZ Systems AS. All rights reserved.
5		* @license For full copyright and license information view LICENSE file distributed with this source code.
6		*/
7		namespace eZ\Publish\API\Repository\Tests\Regression;
8
9		use eZ\Publish\API\Repository\Tests\BaseTest;
10		use eZ\Publish\API\Repository\Values\Content\Query;
11
12		/**
13		* @link https://jira.ez.no/browse/EZP-28799
14		*/
15		class EZP28799SubtreeSearchTest extends BaseTest
16		{
17		/**
18		* @return \eZ\Publish\API\Repository\Values\Content\Content[]
19		*/
20		public function createTestContent()
21		{
22		$rootLocationId = 2;
23		$contentService = $this->getRepository()->getContentService();
24		$contentTypeService = $this->getRepository()->getContentTypeService();
25		$locationService = $this->getRepository()->getLocationService();
26
27		$contentType = $contentTypeService->loadContentTypeByIdentifier('folder');
28		$locationCreateStruct = $locationService->newLocationCreateStruct($rootLocationId);
29
30		$contentCreateStruct = $contentService->newContentCreateStruct($contentType, 'eng-GB');
31		$contentCreateStruct->setField('name', 'LEFT');
32
33		$draft = $contentService->createContent($contentCreateStruct, [$locationCreateStruct]);
34		$leftFolder = $contentService->publishVersion($draft->versionInfo);
35
36		$contentCreateStruct = $contentService->newContentCreateStruct($contentType, 'eng-GB');
37		$contentCreateStruct->setField('name', 'RIGHT');
38
39		$draft = $contentService->createContent($contentCreateStruct, [$locationCreateStruct]);
40		$rightFolder = $contentService->publishVersion($draft->versionInfo);
41
42		$contentCreateStruct = $contentService->newContentCreateStruct($contentType, 'eng-GB');
43		$contentCreateStruct->setField('name', 'TARGET');
44
45		$locationCreateStructLeft = $locationService->newLocationCreateStruct(
46		$leftFolder->contentInfo->mainLocationId
47		);
48		$locationCreateStructRight = $locationService->newLocationCreateStruct(
49		$rightFolder->contentInfo->mainLocationId
50		);
51		$draft = $contentService->createContent(
52		$contentCreateStruct,
53		[
54		$locationCreateStructLeft,
55		$locationCreateStructRight,
56		]
57		);
58		$targetFolder = $contentService->publishVersion($draft->versionInfo);
59
60		return [$leftFolder, $rightFolder, $targetFolder];
61		}
62
63	View Code Duplication	public function testConflictingConditions()
64		{
65		list($leftFolder, $rightFolder, $targetFolder) = $this->createTestContent();
		0 ignored issues – show Unused Code introduced 2018-03-01 10:43 UTC by Report Bug Copy Issue Report The assignment to `$rightFolder` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
66		$locationService = $this->getRepository()->getLocationService();
67		$leftLocation = $locationService->loadLocation($leftFolder->contentInfo->mainLocationId);
68
69		$query = new Query([
70		'filter' => new Query\Criterion\LogicalAnd([
71		new Query\Criterion\ContentId($targetFolder->contentInfo->id),
72		new Query\Criterion\Subtree($leftLocation->pathString),
73		new Query\Criterion\LogicalNot(
74		new Query\Criterion\Subtree($leftLocation->pathString)
75		),
76		]),
77		]);
78
79		$searchService = $this->getRepository()->getSearchService();
80		$result = $searchService->findContent($query);
81
82		$this->assertSame(0, $result->totalCount);
83		}
84
85	View Code Duplication	public function testNegativeSubtree()
86		{
87		list($leftFolder, $rightFolder, $targetFolder) = $this->createTestContent();
		0 ignored issues – show Unused Code introduced 2018-03-01 10:43 UTC by Report Bug Copy Issue Report The assignment to `$rightFolder` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
88		$locationService = $this->getRepository()->getLocationService();
89		$leftLocation = $locationService->loadLocation($leftFolder->contentInfo->mainLocationId);
90
91		$query = new Query([
92		'filter' => new Query\Criterion\LogicalAnd([
93		new Query\Criterion\ContentId($targetFolder->contentInfo->id),
94		new Query\Criterion\LogicalNot(
95		new Query\Criterion\Subtree($leftLocation->pathString)
96		),
97		]),
98		]);
99
100		$searchService = $this->getRepository()->getSearchService();
101		$result = $searchService->findContent($query);
102
103		$this->assertSame(0, $result->totalCount);
104		}
105		}
106

ezsystems / ezpublish-kernel

Push — 7.0 ( b4367b...19cc1b )

testConflictingConditions() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like