| Conditions | 1 |
| Paths | 1 |
| Total Lines | 63 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 163 | public function matchProvider() |
||
| 164 | { |
||
| 165 | return array( |
||
| 166 | array(SimplifiedRequest::fromUrl('http://example.com'), 'default_sa'), |
||
| 167 | array(SimplifiedRequest::fromUrl('https://example.com'), 'default_sa'), |
||
| 168 | array(SimplifiedRequest::fromUrl('http://example.com/'), 'default_sa'), |
||
| 169 | array(SimplifiedRequest::fromUrl('https://example.com/'), 'default_sa'), |
||
| 170 | array(SimplifiedRequest::fromUrl('http://example.com//'), 'default_sa'), |
||
| 171 | array(SimplifiedRequest::fromUrl('https://example.com//'), 'default_sa'), |
||
| 172 | array(SimplifiedRequest::fromUrl('http://example.com:8080/'), 'default_sa'), |
||
| 173 | array(SimplifiedRequest::fromUrl('http://example.com/first_siteaccess/'), 'default_sa'), |
||
| 174 | array(SimplifiedRequest::fromUrl('http://example.com/?first_siteaccess'), 'default_sa'), |
||
| 175 | array(SimplifiedRequest::fromUrl('http://example.com/?first_sa'), 'default_sa'), |
||
| 176 | array(SimplifiedRequest::fromUrl('http://example.com/first_salt'), 'default_sa'), |
||
| 177 | array(SimplifiedRequest::fromUrl('http://example.com/first_sa.foo'), 'default_sa'), |
||
| 178 | array(SimplifiedRequest::fromUrl('http://example.com/test'), 'default_sa'), |
||
| 179 | array(SimplifiedRequest::fromUrl('http://example.com/test/foo/'), 'default_sa'), |
||
| 180 | array(SimplifiedRequest::fromUrl('http://example.com/test/foo/bar/'), 'default_sa'), |
||
| 181 | array(SimplifiedRequest::fromUrl('http://example.com/test/foo/bar/first_sa'), 'default_sa'), |
||
| 182 | array(SimplifiedRequest::fromUrl('http://example.com/default_sa'), 'default_sa'), |
||
| 183 | |||
| 184 | array(SimplifiedRequest::fromUrl('http://example.com/first_sa'), 'first_sa'), |
||
| 185 | array(SimplifiedRequest::fromUrl('http://example.com/first_sa/'), 'first_sa'), |
||
| 186 | array(SimplifiedRequest::fromUrl('http://example.com/first_sa//'), 'first_sa'), |
||
| 187 | // Double slashes shouldn't be considered as one |
||
| 188 | array(SimplifiedRequest::fromUrl('http://example.com//first_sa//'), 'default_sa'), |
||
| 189 | array(SimplifiedRequest::fromUrl('http://example.com/first_sa///test'), 'first_sa'), |
||
| 190 | array(SimplifiedRequest::fromUrl('http://example.com/first_sa/foo'), 'first_sa'), |
||
| 191 | array(SimplifiedRequest::fromUrl('http://example.com/first_sa/foo/bar'), 'first_sa'), |
||
| 192 | array(SimplifiedRequest::fromUrl('http://example.com:82/first_sa/'), 'first_sa'), |
||
| 193 | array(SimplifiedRequest::fromUrl('http://third_siteaccess/first_sa/'), 'first_sa'), |
||
| 194 | array(SimplifiedRequest::fromUrl('http://first_sa/'), 'first_sa'), |
||
| 195 | array(SimplifiedRequest::fromUrl('https://first_sa/'), 'first_sa'), |
||
| 196 | array(SimplifiedRequest::fromUrl('http://first_sa:81/'), 'first_sa'), |
||
| 197 | array(SimplifiedRequest::fromUrl('http://first_siteaccess/'), 'first_sa'), |
||
| 198 | array(SimplifiedRequest::fromUrl('http://first_siteaccess:82/'), 'first_sa'), |
||
| 199 | array(SimplifiedRequest::fromUrl('http://first_siteaccess:83/'), 'first_sa'), |
||
| 200 | array(SimplifiedRequest::fromUrl('http://first_siteaccess/foo/'), 'first_sa'), |
||
| 201 | array(SimplifiedRequest::fromUrl('http://first_siteaccess:82/foo/'), 'first_sa'), |
||
| 202 | array(SimplifiedRequest::fromUrl('http://first_siteaccess:83/foo/'), 'first_sa'), |
||
| 203 | |||
| 204 | array(SimplifiedRequest::fromUrl('http://example.com/second_sa'), 'second_sa'), |
||
| 205 | array(SimplifiedRequest::fromUrl('http://example.com/second_sa/'), 'second_sa'), |
||
| 206 | array(SimplifiedRequest::fromUrl('http://example.com/second_sa?param1=foo'), 'second_sa'), |
||
| 207 | array(SimplifiedRequest::fromUrl('http://example.com/second_sa/foo/'), 'second_sa'), |
||
| 208 | array(SimplifiedRequest::fromUrl('http://example.com:82/second_sa/'), 'second_sa'), |
||
| 209 | array(SimplifiedRequest::fromUrl('http://example.com:83/second_sa/'), 'second_sa'), |
||
| 210 | array(SimplifiedRequest::fromUrl('http://first_siteaccess:82/second_sa/'), 'second_sa'), |
||
| 211 | array(SimplifiedRequest::fromUrl('http://first_siteaccess:83/second_sa/'), 'second_sa'), |
||
| 212 | |||
| 213 | array(SimplifiedRequest::fromUrl('http://example.com:81/'), 'third_sa'), |
||
| 214 | array(SimplifiedRequest::fromUrl('https://example.com:81/'), 'third_sa'), |
||
| 215 | array(SimplifiedRequest::fromUrl('http://example.com:81/foo'), 'third_sa'), |
||
| 216 | array(SimplifiedRequest::fromUrl('http://example.com:81/foo/bar'), 'third_sa'), |
||
| 217 | |||
| 218 | array(SimplifiedRequest::fromUrl('http://example.com:82/'), 'fourth_sa'), |
||
| 219 | array(SimplifiedRequest::fromUrl('https://example.com:82/'), 'fourth_sa'), |
||
| 220 | array(SimplifiedRequest::fromUrl('https://example.com:82/foo'), 'fourth_sa'), |
||
| 221 | |||
| 222 | array(SimplifiedRequest::fromUrl('http://fr.ezpublish.dev/eng'), 'fr_eng'), |
||
| 223 | array(SimplifiedRequest::fromUrl('http://us.ezpublish.dev/fre'), 'fr_us'), |
||
| 224 | ); |
||
| 225 | } |
||
| 226 | |||
| 309 |