InlineFragmentRendererTest::getRenderer() - Code Metrics - Inspection of "EZP-31644: Fixed serialization of Compound SiteAcc..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 6.13 ( fed935...f81640 )

unknown

created 2020-05-25 14:34 UTC

InlineFragmentRendererTest::getRenderer() A

↳ Parent: InlineFragmentRendererTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

/**
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Bundle\EzPublishCoreBundle\Tests\Fragment;

use eZ\Bundle\EzPublishCoreBundle\Fragment\InlineFragmentRenderer;
use eZ\Publish\Core\MVC\Symfony\SiteAccess;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Controller\ControllerReference;

class InlineFragmentRendererTest extends DecoratedFragmentRendererTest
{
    public function testRendererControllerReference()
    {
        $reference = new ControllerReference('FooBundle:bar:baz');
        $matcher = new SiteAccess\Matcher\HostElement(1);
        $siteAccess = new SiteAccess(
            'test',
            'test',
            $matcher
        );
        $request = new Request();
        $request->attributes->set('siteaccess', $siteAccess);
        $request->attributes->set('semanticPathinfo', '/foo/bar');
        $request->attributes->set('viewParametersString', '/(foo)/bar');
        $options = ['foo' => 'bar'];
        $expectedReturn = '/_fragment?foo=bar';
        $this->innerRenderer
            ->expects($this->once())
            ->method('render')
            ->with($reference, $request, $options)
            ->will($this->returnValue($expectedReturn));

        $renderer = new InlineFragmentRenderer($this->innerRenderer);
        $this->assertSame($expectedReturn, $renderer->render($reference, $request, $options));
        $this->assertTrue(isset($reference->attributes['serialized_siteaccess']));
        $serializedSiteAccess = json_encode($siteAccess);
        $this->assertSame($serializedSiteAccess, $reference->attributes['serialized_siteaccess']);
        $this->assertTrue(isset($reference->attributes['serialized_siteaccess_matcher']));
        $this->assertSame(
            $this->getSerializer()->serialize(
                $siteAccess->matcher,
                'json'
            ),
            $reference->attributes['serialized_siteaccess_matcher']
        );
        $this->assertTrue(isset($reference->attributes['semanticPathinfo']));
        $this->assertSame('/foo/bar', $reference->attributes['semanticPathinfo']);
        $this->assertTrue(isset($reference->attributes['viewParametersString']));
        $this->assertSame('/(foo)/bar', $reference->attributes['viewParametersString']);
    }

    public function testRendererControllerReferenceWithCompoundMatcher()
    {
        $reference = parent::testRendererControllerReferenceWithCompoundMatcher();

        $this->assertArrayHasKey('semanticPathinfo', $reference->attributes);
        $this->assertSame('/foo/bar', $reference->attributes['semanticPathinfo']);
        $this->assertArrayHasKey('viewParametersString', $reference->attributes);
        $this->assertSame('/(foo)/bar', $reference->attributes['viewParametersString']);

        return $reference;
    }

    public function getRequest(SiteAccess $siteAccess)
    {
        $request = new Request();
        $request->attributes->set('siteaccess', $siteAccess);
        $request->attributes->set('semanticPathinfo', '/foo/bar');
        $request->attributes->set('viewParametersString', '/(foo)/bar');

        return $request;
    }

    public function getRenderer()
    {
        return new InlineFragmentRenderer($this->innerRenderer);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1			<?php
2
3			/**
4			* @copyright Copyright (C) eZ Systems AS. All rights reserved.
5			* @license For full copyright and license information view LICENSE file distributed with this source code.
6			*/
7			namespace eZ\Bundle\EzPublishCoreBundle\Tests\Fragment;
8
9			use eZ\Bundle\EzPublishCoreBundle\Fragment\InlineFragmentRenderer;
10			use eZ\Publish\Core\MVC\Symfony\SiteAccess;
11			use Symfony\Component\HttpFoundation\Request;
12			use Symfony\Component\HttpKernel\Controller\ControllerReference;
13
14			class InlineFragmentRendererTest extends DecoratedFragmentRendererTest
15			{
16			public function testRendererControllerReference()
17			{
18			$reference = new ControllerReference('FooBundle:bar:baz');
19			$matcher = new SiteAccess\Matcher\HostElement(1);
20			$siteAccess = new SiteAccess(
21			'test',
22			'test',
23			$matcher
24			);
25			$request = new Request();
26			$request->attributes->set('siteaccess', $siteAccess);
27			$request->attributes->set('semanticPathinfo', '/foo/bar');
28			$request->attributes->set('viewParametersString', '/(foo)/bar');
29			$options = ['foo' => 'bar'];
30			$expectedReturn = '/_fragment?foo=bar';
31			$this->innerRenderer
32			->expects($this->once())
33			->method('render')
34			->with($reference, $request, $options)
35			->will($this->returnValue($expectedReturn));
36
37			$renderer = new InlineFragmentRenderer($this->innerRenderer);
38			$this->assertSame($expectedReturn, $renderer->render($reference, $request, $options));
39			$this->assertTrue(isset($reference->attributes['serialized_siteaccess']));
40			$serializedSiteAccess = json_encode($siteAccess);
41			$this->assertSame($serializedSiteAccess, $reference->attributes['serialized_siteaccess']);
42			$this->assertTrue(isset($reference->attributes['serialized_siteaccess_matcher']));
43			$this->assertSame(
44			$this->getSerializer()->serialize(
45			$siteAccess->matcher,
46			'json'
47			),
48			$reference->attributes['serialized_siteaccess_matcher']
49			);
50			$this->assertTrue(isset($reference->attributes['semanticPathinfo']));
51			$this->assertSame('/foo/bar', $reference->attributes['semanticPathinfo']);
52			$this->assertTrue(isset($reference->attributes['viewParametersString']));
53			$this->assertSame('/(foo)/bar', $reference->attributes['viewParametersString']);
54			}
55
56			public function testRendererControllerReferenceWithCompoundMatcher()
57			{
58			$reference = parent::testRendererControllerReferenceWithCompoundMatcher();
59
60			$this->assertArrayHasKey('semanticPathinfo', $reference->attributes);
61			$this->assertSame('/foo/bar', $reference->attributes['semanticPathinfo']);
62			$this->assertArrayHasKey('viewParametersString', $reference->attributes);
63			$this->assertSame('/(foo)/bar', $reference->attributes['viewParametersString']);
64
65			return $reference;
66			}
67
68			public function getRequest(SiteAccess $siteAccess)
69			{
70			$request = new Request();
71			$request->attributes->set('siteaccess', $siteAccess);
72			$request->attributes->set('semanticPathinfo', '/foo/bar');
73			$request->attributes->set('viewParametersString', '/(foo)/bar');
74
75			return $request;
76			}
77
78			public function getRenderer()
79			{
80			return new InlineFragmentRenderer($this->innerRenderer);
			0 ignored issues – show Bug Best Practice introduced 2020-05-21 14:31 UTC by Report Bug Copy Issue Report The return type of `return new \eZ\Bundle\Ez...($this->innerRenderer);` (`eZ\Bundle\EzPublishCoreB...\InlineFragmentRenderer`) is incompatible with the return type of the parent method `eZ\Bundle\EzPublishCoreB...ndererTest::getRenderer` of type `eZ\Bundle\EzPublishCoreB...coratedFragmentRenderer`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
81			}
82			}
83

ezsystems / ezpublish-kernel

Push — 6.13 ( fed935...f81640 )

InlineFragmentRendererTest::getRenderer() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like