ezsystems / ezpublish-kernel

eZ/Publish/Core/Persistence/Legacy/Content/Type/Gateway/DoctrineDatabase.php

Doc Comments +14 added lines, -15 removed lines

@@ -128,7 +128,7 @@ 
      *
      * @param \eZ\Publish\SPI\Persistence\Content\Type\Group $group
      *
-     * @return mixed Group ID
+     * @return string Group ID
      */
     public function insertGroup(Group $group)
     {
@@ -421,8 +421,8 @@ 
     /**
      * Insert assignment of $typeId to $groupId.
      *
-     * @param mixed $groupId
-     * @param mixed $typeId
+     * @param integer $groupId
+     * @param integer $typeId
      * @param int $status
      */
     public function insertGroupAssignment($groupId, $typeId, $status)
@@ -453,8 +453,8 @@ 
     /**
      * Deletes a group assignments for a Type.
      *
-     * @param mixed $groupId
-     * @param mixed $typeId
+     * @param integer $groupId
+     * @param integer $typeId
      * @param int $status
      */
     public function deleteGroupAssignment($groupId, $typeId, $status)
@@ -503,7 +503,7 @@ 
     /**
      * Loads data about Group with $identifier.
      *
-     * @param mixed $identifier
+     * @param string $identifier
      *
      * @return string[][]
      */
@@ -562,7 +562,7 @@ 
     /**
      * Loads data for all Types in $status in $groupId.
      *
-     * @param mixed $groupId
+     * @param integer $groupId
      * @param int $status
      *
      * @return string[][]
@@ -583,7 +583,7 @@ 
     /**
      * Inserts a $fieldDefinition for $typeId.
      *
-     * @param mixed $typeId
+     * @param integer $typeId
      * @param int $status
      * @param \eZ\Publish\SPI\Persistence\Content\Type\FieldDefinition $fieldDefinition
      * @param \eZ\Publish\Core\Persistence\Legacy\Content\StorageFieldDefinition $storageFieldDef
@@ -744,9 +744,9 @@ 
     /**
      * Deletes a field definition.
      *
-     * @param mixed $typeId
+     * @param integer $typeId
      * @param int $status
-     * @param mixed $fieldDefinitionId
+     * @param integer $fieldDefinitionId
      */
     public function deleteFieldDefinition($typeId, $status, $fieldDefinitionId)
     {
@@ -777,7 +777,7 @@ 
     /**
      * Updates a $fieldDefinition for $typeId.
      *
-     * @param mixed $typeId
+     * @param integer $typeId
      * @param int $status
      * @param \eZ\Publish\SPI\Persistence\Content\Type\FieldDefinition $fieldDefinition
      * @param \eZ\Publish\Core\Persistence\Legacy\Content\StorageFieldDefinition $storageFieldDef
@@ -840,9 +840,8 @@ 
     /**
      * Update a type with $updateStruct.
      *
-     * @param mixed $typeId
+     * @param integer $typeId
      * @param int $status
-     * @param \eZ\Publish\SPI\Persistence\Content\Type\UpdateStruct $updateStruct
      */
     public function updateType($typeId, $status, Type $type)
     {
@@ -885,7 +884,7 @@ 
     /**
      * Loads an array with data about $typeId in $status.
      *
-     * @param mixed $typeId
+     * @param integer $typeId
      * @param int $status
      *
      * @return array Data rows.
@@ -927,7 +926,7 @@ 
      * Loads an array with data about the type referred to by $remoteId in
      * $status.
      *
-     * @param mixed $remoteId
+     * @param string $remoteId
      * @param int $status
      *
      * @return array(int=>array(string=>mixed)) Data rows.

eZ/Publish/Core/REST/Client/ContentTypeService.php

Doc Comments +5 added lines, -5 removed lines

@@ -513,9 +513,9 @@ 
      * ATTENTION: This is not an API method and only meant for internal use in
      * the REST Client implementation.
      *
-     * @param mixed $fieldDefinitionListReference
+     * @param string $fieldDefinitionListReference
      *
-     * @return \eZ\Publish\Core\REST\Client\Values\FieldDefinitionList
+     * @return \eZ\Publish\API\Repository\Values\ValueObject
      */
     public function loadFieldDefinitionList($fieldDefinitionListReference)
     {
@@ -536,9 +536,9 @@ 
      * ATTENTION: This is not an API method and only meant for internal use in
      * the REST Client implementation.
      *
-     * @param mixed $contentTypeGroupListReference
+     * @param string $contentTypeGroupListReference
      *
-     * @return \eZ\Publish\Core\REST\Client\Values\ContentTypeGroupRefList
+     * @return \eZ\Publish\API\Repository\Values\ValueObject
      */
     public function loadContentTypeGroupList($contentTypeGroupListReference)
     {
@@ -856,7 +856,7 @@ 
 
     /**
      * @param \eZ\Publish\API\Repository\Values\ContentType\ContentTypeDraft $contentTypeDraft
-     * @param string $languageCodes
+     * @param string $languageCode
      *
      * @return \eZ\Publish\API\Repository\Values\ContentType\ContentTypeDraft
      */

eZ/Publish/Core/Persistence/Legacy/Tests/Content/FieldValueConverterRegistryTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
     /**
      * Returns a mock for Storage.
      *
-     * @return Storage
+     * @return \PHPUnit\Framework\MockObject\MockObject
      */
     protected function getFieldValueConverterMock()
     {

eZ/Publish/Core/Persistence/Legacy/Tests/Content/StorageRegistryTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
     /**
      * Returns a mock for Storage.
      *
-     * @return Storage
+     * @return \PHPUnit\Framework\MockObject\MockObject
      */
     protected function getStorageMock()
     {

eZ/Publish/Core/Persistence/Tests/FieldTypeRegistryTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -130,7 +130,7 @@
     /**
      * Returns a mock for persistence field type.
      *
-     * @return \eZ\Publish\SPI\Persistence\FieldType
+     * @return \PHPUnit\Framework\MockObject\MockObject
      */
     protected function getFieldTypeMock()
     {

eZ/Publish/Core/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php

Doc Comments +20 added lines, -17 removed lines

@@ -247,7 +247,7 @@ 
     /**
      * Returns data for the first level children of the location identified by given $locationId.
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      *
      * @return array
      */
@@ -374,6 +374,9 @@ 
         }
     }
 
+    /**
+     * @param string $pathString
+     */
     private function isHiddenByParent($pathString, array $rows)
     {
         $parentNodeIds = explode('/', trim($pathString, '/'));
@@ -751,7 +754,7 @@ 
      * Create an entry in the node assignment table.
      *
      * @param \eZ\Publish\SPI\Persistence\Content\Location\CreateStruct $createStruct
-     * @param mixed $parentNodeId
+     * @param string $parentNodeId
      * @param int $type
      */
     public function createNodeAssignment(CreateStruct $createStruct, $parentNodeId, $type = self::NODE_ASSIGNMENT_OP_CODE_CREATE_NOP)
@@ -879,8 +882,8 @@ 
      *
      * Convert existing node assignments into real locations.
      *
-     * @param mixed $contentId
-     * @param mixed $versionNo
+     * @param integer $contentId
+     * @param integer $versionNo
      */
     public function createLocationsFromNodeAssignments($contentId, $versionNo)
     {
@@ -948,8 +951,8 @@ 
     /**
      * Updates all Locations of content identified with $contentId with $versionNo.
      *
-     * @param mixed $contentId
-     * @param mixed $versionNo
+     * @param integer $contentId
+     * @param integer $versionNo
      */
     public function updateLocationsContentVersionNo($contentId, $versionNo)
     {
@@ -1108,8 +1111,8 @@ 
      * the node identified by given $locationId (current main node).
      * Assumes that content has more than one location.
      *
-     * @param mixed $contentId
-     * @param mixed $locationId
+     * @param integer $contentId
+     * @param integer $locationId
      *
      * @return array
      */
@@ -1145,9 +1148,9 @@ 
      *
      * The associated content object is left untouched.
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      *
-     * @return bool
+     * @return boolean|null
      */
     public function trashLocation($locationId)
     {
@@ -1177,8 +1180,8 @@ 
      * at the old position. If this is not possible ( because the old location
      * does not exist any more) and exception is thrown.
      *
-     * @param mixed $locationId
-     * @param mixed|null $newParentId
+     * @param integer $locationId
+     * @param integer $newParentId
      *
      * @return \eZ\Publish\SPI\Persistence\Content\Location
      */
@@ -1431,10 +1434,10 @@ 
      * Updates ezcontentobject_tree table for the given $contentId and eznode_assignment table for the given
      * $contentId, $parentLocationId and $versionNo
      *
-     * @param mixed $contentId
-     * @param mixed $locationId
-     * @param mixed $versionNo version number, needed to update eznode_assignment table
-     * @param mixed $parentLocationId parent location of location identified by $locationId, needed to update
+     * @param integer $contentId
+     * @param integer $locationId
+     * @param integer $versionNo version number, needed to update eznode_assignment table
+     * @param integer $parentLocationId parent location of location identified by $locationId, needed to update
      *        eznode_assignment table
      */
     public function changeMainLocation($contentId, $locationId, $versionNo, $parentLocationId)
@@ -1564,7 +1567,7 @@ 
      *
      * @todo Align with createNodeQueryBuilder, removing the need for both(?)
      *
-     * @param array $columns list of columns to fetch
+     * @param string[] $columns list of columns to fetch
      *
      * @return \Doctrine\DBAL\Query\QueryBuilder
      */

eZ/Publish/Core/Persistence/Legacy/Content/Type/Handler.php

Doc Comments +13 added lines, -14 removed lines

@@ -94,7 +94,7 @@ 
     }
 
     /**
-     * @param mixed $groupId
+     * @param integer $groupId
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\BadStateException If type group contains types
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException If type group with id is not found
@@ -175,7 +175,7 @@ 
     }
 
     /**
-     * @param mixed $groupId
+     * @param integer $groupId
      * @param int $status
      *
      * @return Type[]
@@ -237,7 +237,7 @@ 
      *
      * Note: This method is responsible of having the Field Definitions of the loaded ContentType sorted by placement.
      *
-     * @param mixed $remoteId
+     * @param string $remoteId
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException If defined type is not found
      *
@@ -338,7 +338,6 @@ 
     /**
      * @param mixed $typeId
      * @param int $status
-     * @param \eZ\Publish\SPI\Persistence\Content\Type\UpdateStruct $contentType
      *
      * @return Type
      */
@@ -355,7 +354,7 @@ 
     /**
      * @throws \eZ\Publish\API\Repository\Exceptions\BadStateException If type is defined and still has content
      *
-     * @param mixed $contentTypeId
+     * @param integer $contentTypeId
      * @param int $status
      *
      * @return bool
@@ -437,8 +436,8 @@ 
     /**
      * Unlink a content type group from a content type.
      *
-     * @param mixed $groupId
-     * @param mixed $contentTypeId
+     * @param integer $groupId
+     * @param integer $contentTypeId
      * @param int $status
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException If group or type with provided status is not found
@@ -462,8 +461,8 @@ 
     /**
      * Link a content type group with a content type.
      *
-     * @param mixed $groupId
-     * @param mixed $contentTypeId
+     * @param integer $groupId
+     * @param integer $contentTypeId
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException If group or type with provided status is not found
      * @throws \eZ\Publish\API\Repository\Exceptions\BadStateException If type is already part of group
@@ -509,7 +508,7 @@ 
     /**
      * Counts the number of Content instances of the ContentType identified by given $contentTypeId.
      *
-     * @param mixed $contentTypeId
+     * @param integer $contentTypeId
      *
      * @return int
      */
@@ -525,7 +524,7 @@ 
      * added. It does not update existing content objects depending on the
      * field (default) values.
      *
-     * @param mixed $contentTypeId
+     * @param integer $contentTypeId
      * @param int $status One of Type::STATUS_DEFINED|Type::STATUS_DRAFT|Type::STATUS_MODIFIED
      * @param \eZ\Publish\SPI\Persistence\Content\Type\FieldDefinition $fieldDefinition
      */
@@ -548,8 +547,8 @@ 
      * referred to by $fieldDefinitionId removed. It does not update existing
      * content objects depending on the field (default) values.
      *
-     * @param mixed $contentTypeId
-     * @param mixed $fieldDefinitionId
+     * @param integer $contentTypeId
+     * @param integer $fieldDefinitionId
      *
      * @return bool
      */
@@ -568,7 +567,7 @@ 
      * on the
      * field (default) values.
      *
-     * @param mixed $contentTypeId
+     * @param integer $contentTypeId
      * @param \eZ\Publish\SPI\Persistence\Content\Type\FieldDefinition $fieldDefinition
      */
     public function updateFieldDefinition($contentTypeId, $status, FieldDefinition $fieldDefinition)