UserGroupRefList::visit() - Code Metrics - Inspection of "Added Vary header X-eZ-Embed-Value to ResourceLink..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — ezp26352-skip_csrf_check_on_re... ( 19f37a )

unknown

created 2016-09-21 12:01 UTC

UserGroupRefList::visit() B

↳ Parent: UserGroupRefList

Complexity

Conditions	4
Paths	3

Size

Total Lines	48
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	27
nc	3
nop	3
dl	0
loc	48
rs	8.7396
c	0
b	0
f	0

<?php

/**
 * File containing the UserGroupRefList ValueObjectVisitor class.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 *
 * @version //autogentag//
 */
namespace eZ\Publish\Core\REST\Server\Output\ValueObjectVisitor;

use eZ\Publish\Core\REST\Common\Output\ValueObjectVisitor;
use eZ\Publish\Core\REST\Common\Output\Generator;
use eZ\Publish\Core\REST\Common\Output\Visitor;
use eZ\Publish\Core\REST\Server\Values\ResourceRouteReference;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

/**
 * UserGroupRefList value object visitor.
 */
class UserGroupRefList extends ValueObjectVisitor
{
    /**
     * Visit struct returned by controllers.
     *
     * @param \eZ\Publish\Core\REST\Common\Output\Visitor $visitor
     * @param \eZ\Publish\Core\REST\Common\Output\Generator $generator
     * @param \eZ\Publish\Core\REST\Server\Values\UserGroupRefList $data
     */
    public function visit(Visitor $visitor, Generator $generator, $data)
    {
        $generator->startObjectElement('UserGroupRefList');
        $visitor->setHeader('Content-Type', $generator->getMediaType('UserGroupRefList'));
        //@todo Needs refactoring, disabling certain headers should not be done this way
        $visitor->setHeader('Accept-Patch', false);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $generator->startAttribute('href', $data->path);
        $generator->endAttribute('href');

        $groupCount = count($data->userGroups);

        $generator->startList('UserGroup');
        foreach ($data->userGroups as $userGroup) {
            $generator->startObjectElement('UserGroup');

            $visitor->visitValueObject(
                new ResourceRouteReference(
                    'ezpublish_rest_loadUserGroup',
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    ['groupPath' => trim($userGroup->mainLocation->pathString, '/')]
                )
            );

            if ($data->userId !== null && $groupCount > 1) {
                $generator->startHashElement('unassign');

                $visitor->visitValueObject(
                    new ResourceRouteReference(
                        'ezpublish_rest_unassignUserFromUserGroup',
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                        [
                            'userId' => $data->userId,
                            'groupPath' => $userGroup->mainLocation->path[count($userGroup->mainLocation->path) - 1],
                        ]
                    )
                );

                $generator->startAttribute('method', 'DELETE');
                $generator->endAttribute('method');

                $generator->endHashElement('unassign');
            }

            $generator->endObjectElement('UserGroup');
        }
        $generator->endList('UserGroup');

        $generator->endObjectElement('UserGroupRefList');
    }
}


1			<?php
2
3			/**
4			* File containing the UserGroupRefList ValueObjectVisitor class.
5			*
6			* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7			* @license For full copyright and license information view LICENSE file distributed with this source code.
8			*
9			* @version //autogentag//
10			*/
11			namespace eZ\Publish\Core\REST\Server\Output\ValueObjectVisitor;
12
13			use eZ\Publish\Core\REST\Common\Output\ValueObjectVisitor;
14			use eZ\Publish\Core\REST\Common\Output\Generator;
15			use eZ\Publish\Core\REST\Common\Output\Visitor;
16			use eZ\Publish\Core\REST\Server\Values\ResourceRouteReference;
			0 ignored issues – show Bug introduced 2016-07-27 23:26 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `eZ\Publish\Core\REST\Ser...\ResourceRouteReference`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
17
18			/**
19			* UserGroupRefList value object visitor.
20			*/
21			class UserGroupRefList extends ValueObjectVisitor
22			{
23			/**
24			* Visit struct returned by controllers.
25			*
26			* @param \eZ\Publish\Core\REST\Common\Output\Visitor $visitor
27			* @param \eZ\Publish\Core\REST\Common\Output\Generator $generator
28			* @param \eZ\Publish\Core\REST\Server\Values\UserGroupRefList $data
29			*/
30			public function visit(Visitor $visitor, Generator $generator, $data)
31			{
32			$generator->startObjectElement('UserGroupRefList');
33			$visitor->setHeader('Content-Type', $generator->getMediaType('UserGroupRefList'));
34			//@todo Needs refactoring, disabling certain headers should not be done this way
35			$visitor->setHeader('Accept-Patch', false);
			0 ignored issues – show Documentation introduced 2015-11-21 14:37 UTC by Report Bug Copy Issue Report `false` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36
37			$generator->startAttribute('href', $data->path);
38			$generator->endAttribute('href');
39
40			$groupCount = count($data->userGroups);
41
42			$generator->startList('UserGroup');
43			foreach ($data->userGroups as $userGroup) {
44			$generator->startObjectElement('UserGroup');
45
46			$visitor->visitValueObject(
47			new ResourceRouteReference(
48			'ezpublish_rest_loadUserGroup',
			0 ignored issues – show Documentation introduced 2016-09-01 18:39 UTC by Report Bug Copy Issue Report `'ezpublish_rest_loadUserGroup'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
49			['groupPath' => trim($userGroup->mainLocation->pathString, '/')]
50			)
51			);
52
53			if ($data->userId !== null && $groupCount > 1) {
54			$generator->startHashElement('unassign');
55
56			$visitor->visitValueObject(
57			new ResourceRouteReference(
58			'ezpublish_rest_unassignUserFromUserGroup',
			0 ignored issues – show Documentation introduced 2016-09-01 18:39 UTC by Report Bug Copy Issue Report `'ezpublish_rest_unassignUserFromUserGroup'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
59			[
60			'userId' => $data->userId,
61			'groupPath' => $userGroup->mainLocation->path[count($userGroup->mainLocation->path) - 1],
62			]
63			)
64			);
65
66			$generator->startAttribute('method', 'DELETE');
67			$generator->endAttribute('method');
68
69			$generator->endHashElement('unassign');
70			}
71
72			$generator->endObjectElement('UserGroup');
73			}
74			$generator->endList('UserGroup');
75
76			$generator->endObjectElement('UserGroupRefList');
77			}
78			}
79

ezsystems / ezpublish-kernel

Push — ezp26352-skip_csrf_check_on_re... ( 19f37a )

UserGroupRefList::visit() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like