Generator - Code Metrics - Inspection of "Added Vary header X-eZ-Embed-Value to ResourceLink..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — ezp26352-skip_csrf_check_on_re... ( 19f37a )

unknown

created 2016-09-21 12:01 UTC

Generator A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	411
Duplicated Lines	7.3 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
dl	30
loc	411
rs	10
c	0
b	0
f	0
wmc	27
lcom	1
cbo	1

34 Methods

Rating	Name	Duplication	Size	Complexity
A	setFormatOutput()	0	4	1
A	reset()	0	5	1
	startDocument()	0	1	?
	isEmpty()	0	1	?
A	checkStartDocument()	0	10	2
	endDocument()	0	1	?
A	checkEndDocument()	0	4	1
	startObjectElement()	0	1	?
A	checkStartObjectElement()	15	15	3
	endObjectElement()	0	1	?
A	checkEndObjectElement()	0	4	1
	startHashElement()	0	1	?
A	checkStartHashElement()	15	15	3
	endHashElement()	0	1	?
A	checkEndHashElement()	0	4	1
	startValueElement()	0	1	?
A	checkStartValueElement()	0	4	1
	endValueElement()	0	1	?
A	checkEndValueElement()	0	4	1
	startList()	0	1	?
A	checkStartList()	0	4	1
	endList()	0	1	?
A	checkEndList()	0	4	1
	startAttribute()	0	1	?
A	checkStartAttribute()	0	4	1
	endAttribute()	0	1	?
A	checkEndAttribute()	0	4	1
	getMediaType()	0	1	?
A	generateMediaType()	0	4	1
	generateFieldTypeHash()	0	1	?
B	checkStart()	0	25	3
B	checkEnd()	0	24	3
	serializeBool()	0	1	?
A	getStackPath()	0	18	1

How to fix Duplicated Code

<?php

/**
 * File containing the Generator base class.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 *
 * @version //autogentag//
 */
namespace eZ\Publish\Core\REST\Common\Output;

/**
 * Output generator.
 */
abstract class Generator
{
    /**
     * Generator creation stack.
     *
     * Use to check if it is OK to start / close the requested element in the
     * current state.
     *
     * @var array
     */
    protected $stack = array();

    /**
     * If set to true, output will be formatted and indented.
     *
     * @var bool
     */
    protected $formatOutput = false;

    public function setFormatOutput($formatOutput)
    {
        $this->formatOutput = (bool)$formatOutput;
    }

    /**
     * Reset output visitor to a virgin state.
     */
    public function reset()
    {
        $this->stack = array();
        $this->isEmpty = true;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Start document.
     *
     * @param mixed $data
     */
    abstract public function startDocument($data);

    /**
     * Returns if the document is empty or already contains data.
     *
     * @return bool
     */
    abstract public function isEmpty();

    /**
     * Check start document.
     *
     * @param mixed $data
     */
    protected function checkStartDocument($data)
    {
        if (count($this->stack)) {
            throw new Exceptions\OutputGeneratorException(
                'Starting a document may only be the very first operation.'
            );
        }

        $this->stack[] = array('document', $data, array());
    }

    /**
     * End document.
     *
     * Returns the generated document as a string.
     *
     * @param mixed $data
     *
     * @return string
     */
    abstract public function endDocument($data);

    /**
     * Check end document.
     *
     * @param mixed $data
     */
    protected function checkEndDocument($data)
    {
        $this->checkEnd('document', $data);
    }

    /**
     * Start object element.
     *
     * @param string $name
     * @param string $mediaTypeName
     */
    abstract public function startObjectElement($name, $mediaTypeName = null);

    /**
     * Check start object element.
     *
     * @param mixed $data
     */
    protected function checkStartObjectElement($data)
    {
        $this->checkStart('objectElement', $data, array('document', 'objectElement', 'hashElement', 'list'));

        $last = count($this->stack) - 2;
        if ($this->stack[$last][0] !== 'list') {
            // Ensure object element type only occurs once outside of lists
            if (isset($this->stack[$last][2][$data])) {
                throw new Exceptions\OutputGeneratorException(
                    "Element {$data} may only occur once inside of {$this->stack[$last][0]}."
                );
            }
        }
        $this->stack[$last][2][$data] = true;
    }

    /**
     * End object element.
     *
     * @param string $name
     */
    abstract public function endObjectElement($name);

    /**
     * Check end object element.
     *
     * @param mixed $data
     */
    protected function checkEndObjectElement($data)
    {
        $this->checkEnd('objectElement', $data);
    }

    /**
     * Start hash element.
     *
     * @param string $name
     */
    abstract public function startHashElement($name);

    /**
     * Check start hash element.
     *
     * @param mixed $data
     */
    protected function checkStartHashElement($data)
    {
        $this->checkStart('hashElement', $data, array('document', 'objectElement', 'hashElement', 'list'));

        $last = count($this->stack) - 2;
        if ($this->stack[$last][0] !== 'list') {
            // Ensure hash element type only occurs once outside of lists
            if (isset($this->stack[$last][2][$data])) {
                throw new Exceptions\OutputGeneratorException(
                    "Element {$data} may only occur once inside of {$this->stack[$last][0]}."
                );
            }
        }
        $this->stack[$last][2][$data] = true;
    }

    /**
     * End hash element.
     *
     * @param string $name
     */
    abstract public function endHashElement($name);

    /**
     * Check end hash element.
     *
     * @param mixed $data
     */
    protected function checkEndHashElement($data)
    {
        $this->checkEnd('hashElement', $data);
    }

    /**
     * Start value element.
     *
     * @param string $name
     * @param string $value
     */
    abstract public function startValueElement($name, $value);

    /**
     * Check start value element.
     *
     * @param mixed $data
     */
    protected function checkStartValueElement($data)
    {
        $this->checkStart('valueElement', $data, array('objectElement', 'hashElement', 'list'));
    }

    /**
     * End value element.
     *
     * @param string $name
     */
    abstract public function endValueElement($name);

    /**
     * Check end value element.
     *
     * @param mixed $data
     */
    protected function checkEndValueElement($data)
    {
        $this->checkEnd('valueElement', $data);
    }

    /**
     * Start list.
     *
     * @param string $name
     */
    abstract public function startList($name);

    /**
     * Check start list.
     *
     * @param mixed $data
     */
    protected function checkStartList($data)
    {
        $this->checkStart('list', $data, array('objectElement', 'hashElement'));
    }

    /**
     * End list.
     *
     * @param string $name
     */
    abstract public function endList($name);

    /**
     * Check end list.
     *
     * @param mixed $data
     */
    protected function checkEndList($data)
    {
        $this->checkEnd('list', $data);
    }

    /**
     * Start attribute.
     *
     * @param string $name
     * @param string $value
     */
    abstract public function startAttribute($name, $value);

    /**
     * Check start attribute.
     *
     * @param mixed $data
     */
    protected function checkStartAttribute($data)
    {
        $this->checkStart('attribute', $data, array('objectElement', 'hashElement'));
    }

    /**
     * End attribute.
     *
     * @param string $name
     */
    abstract public function endAttribute($name);

    /**
     * Check end attribute.
     *
     * @param mixed $data
     */
    protected function checkEndAttribute($data)
    {
        $this->checkEnd('attribute', $data);
    }

    /**
     * Get media type.
     *
     * @param string $name
     *
     * @return string
     */
    abstract public function getMediaType($name);

    /**
     * Generates a media type from $name and $type.
     *
     * @param string $name
     * @param string $type
     *
     * @return string
     */
    protected function generateMediaType($name, $type)
    {
        return "application/vnd.ez.api.{$name}+{$type}";
    }

    /**
     * Generates a generic representation of the scalar, hash or list given in
     * $hashValue into the document, using an element of $hashElementName as
     * its parent.
     *
     * @param string $hashElementName
     * @param mixed $hashValue
     */
    abstract public function generateFieldTypeHash($hashElementName, $hashValue);

    /**
     * Check close / end operation.
     *
     * @param string $type
     * @param mixed $data
     * @param array $validParents
     */
    protected function checkStart($type, $data, array $validParents)
    {
        $lastTag = end($this->stack);

        if (!is_array($lastTag)) {
            throw new Exceptions\OutputGeneratorException(
                sprintf(
                    'Invalid start: Trying to open outside of a document.'
                )
            );
        }

        if (!in_array($lastTag[0], $validParents)) {
            throw new Exceptions\OutputGeneratorException(
                sprintf(
                    'Invalid start: Trying to open %s inside %s, valid parent nodes are: %s.',
                    $type,
                    $lastTag[0],
                    implode(', ', $validParents)
                )
            );
        }

        $this->stack[] = array($type, $data, array());
    }

    /**
     * Check close / end operation.
     *
     * @param string $type
     * @param mixed $data
     */
    protected function checkEnd($type, $data)
    {
        $lastTag = array_pop($this->stack);

        if (!is_array($lastTag)) {
            throw new Exceptions\OutputGeneratorException(
                sprintf(
                    'Invalid close: Trying to close on empty stack.'
                )
            );
        }

        if (array($lastTag[0], $lastTag[1]) !== array($type, $data)) {
            throw new Exceptions\OutputGeneratorException(
                sprintf(
                    'Invalid close: Trying to close %s:%s, while last element was %s:%s.',
                    $type,
                    $data,
                    $lastTag[0],
                    $lastTag[1]
                )
            );
        }
    }

    /**
     * Serializes a boolean value.
     *
     * @param bool $boolValue
     *
     * @return mixed
     */
    abstract public function serializeBool($boolValue);

    /**
     * Returns a string representation of the current stack of the document.
     *
     * Example: "Location.ContentInfo'.
     * Elements of type 'attribute', 'document' and 'list' are ignored.
     *
     * @return string
     */
    public function getStackPath()
    {
        $relevantNodes = array_filter(
            $this->stack,
            function ($value) {
                return !in_array($value[0], ['attribute', 'document', 'list']);
            }
        );

        $names = array_map(
            function ($value) {
                return $value[1];
            },
            $relevantNodes
        );

        return implode('.', $names);
    }
}


1		<?php
2
3		/**
4		* File containing the Generator base class.
5		*
6		* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7		* @license For full copyright and license information view LICENSE file distributed with this source code.
8		*
9		* @version //autogentag//
10		*/
11		namespace eZ\Publish\Core\REST\Common\Output;
12
13		/**
14		* Output generator.
15		*/
16		abstract class Generator
17		{
18		/**
19		* Generator creation stack.
20		*
21		* Use to check if it is OK to start / close the requested element in the
22		* current state.
23		*
24		* @var array
25		*/
26		protected $stack = array();
27
28		/**
29		* If set to true, output will be formatted and indented.
30		*
31		* @var bool
32		*/
33		protected $formatOutput = false;
34
35		public function setFormatOutput($formatOutput)
36		{
37		$this->formatOutput = (bool)$formatOutput;
38		}
39
40		/**
41		* Reset output visitor to a virgin state.
42		*/
43		public function reset()
44		{
45		$this->stack = array();
46		$this->isEmpty = true;
		0 ignored issues – show Bug introduced 2015-11-21 14:37 UTC by Report Bug Copy Issue Report The property `isEmpty` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
47		}
48
49		/**
50		* Start document.
51		*
52		* @param mixed $data
53		*/
54		abstract public function startDocument($data);
55
56		/**
57		* Returns if the document is empty or already contains data.
58		*
59		* @return bool
60		*/
61		abstract public function isEmpty();
62
63		/**
64		* Check start document.
65		*
66		* @param mixed $data
67		*/
68		protected function checkStartDocument($data)
69		{
70		if (count($this->stack)) {
71		throw new Exceptions\OutputGeneratorException(
72		'Starting a document may only be the very first operation.'
73		);
74		}
75
76		$this->stack[] = array('document', $data, array());
77		}
78
79		/**
80		* End document.
81		*
82		* Returns the generated document as a string.
83		*
84		* @param mixed $data
85		*
86		* @return string
87		*/
88		abstract public function endDocument($data);
89
90		/**
91		* Check end document.
92		*
93		* @param mixed $data
94		*/
95		protected function checkEndDocument($data)
96		{
97		$this->checkEnd('document', $data);
98		}
99
100		/**
101		* Start object element.
102		*
103		* @param string $name
104		* @param string $mediaTypeName
105		*/
106		abstract public function startObjectElement($name, $mediaTypeName = null);
107
108		/**
109		* Check start object element.
110		*
111		* @param mixed $data
112		*/
113	View Code Duplication	protected function checkStartObjectElement($data)
114		{
115		$this->checkStart('objectElement', $data, array('document', 'objectElement', 'hashElement', 'list'));
116
117		$last = count($this->stack) - 2;
118		if ($this->stack[$last][0] !== 'list') {
119		// Ensure object element type only occurs once outside of lists
120		if (isset($this->stack[$last][2][$data])) {
121		throw new Exceptions\OutputGeneratorException(
122		"Element {$data} may only occur once inside of {$this->stack[$last][0]}."
123		);
124		}
125		}
126		$this->stack[$last][2][$data] = true;
127		}
128
129		/**
130		* End object element.
131		*
132		* @param string $name
133		*/
134		abstract public function endObjectElement($name);
135
136		/**
137		* Check end object element.
138		*
139		* @param mixed $data
140		*/
141		protected function checkEndObjectElement($data)
142		{
143		$this->checkEnd('objectElement', $data);
144		}
145
146		/**
147		* Start hash element.
148		*
149		* @param string $name
150		*/
151		abstract public function startHashElement($name);
152
153		/**
154		* Check start hash element.
155		*
156		* @param mixed $data
157		*/
158	View Code Duplication	protected function checkStartHashElement($data)
159		{
160		$this->checkStart('hashElement', $data, array('document', 'objectElement', 'hashElement', 'list'));
161
162		$last = count($this->stack) - 2;
163		if ($this->stack[$last][0] !== 'list') {
164		// Ensure hash element type only occurs once outside of lists
165		if (isset($this->stack[$last][2][$data])) {
166		throw new Exceptions\OutputGeneratorException(
167		"Element {$data} may only occur once inside of {$this->stack[$last][0]}."
168		);
169		}
170		}
171		$this->stack[$last][2][$data] = true;
172		}
173
174		/**
175		* End hash element.
176		*
177		* @param string $name
178		*/
179		abstract public function endHashElement($name);
180
181		/**
182		* Check end hash element.
183		*
184		* @param mixed $data
185		*/
186		protected function checkEndHashElement($data)
187		{
188		$this->checkEnd('hashElement', $data);
189		}
190
191		/**
192		* Start value element.
193		*
194		* @param string $name
195		* @param string $value
196		*/
197		abstract public function startValueElement($name, $value);
198
199		/**
200		* Check start value element.
201		*
202		* @param mixed $data
203		*/
204		protected function checkStartValueElement($data)
205		{
206		$this->checkStart('valueElement', $data, array('objectElement', 'hashElement', 'list'));
207		}
208
209		/**
210		* End value element.
211		*
212		* @param string $name
213		*/
214		abstract public function endValueElement($name);
215
216		/**
217		* Check end value element.
218		*
219		* @param mixed $data
220		*/
221		protected function checkEndValueElement($data)
222		{
223		$this->checkEnd('valueElement', $data);
224		}
225
226		/**
227		* Start list.
228		*
229		* @param string $name
230		*/
231		abstract public function startList($name);
232
233		/**
234		* Check start list.
235		*
236		* @param mixed $data
237		*/
238		protected function checkStartList($data)
239		{
240		$this->checkStart('list', $data, array('objectElement', 'hashElement'));
241		}
242
243		/**
244		* End list.
245		*
246		* @param string $name
247		*/
248		abstract public function endList($name);
249
250		/**
251		* Check end list.
252		*
253		* @param mixed $data
254		*/
255		protected function checkEndList($data)
256		{
257		$this->checkEnd('list', $data);
258		}
259
260		/**
261		* Start attribute.
262		*
263		* @param string $name
264		* @param string $value
265		*/
266		abstract public function startAttribute($name, $value);
267
268		/**
269		* Check start attribute.
270		*
271		* @param mixed $data
272		*/
273		protected function checkStartAttribute($data)
274		{
275		$this->checkStart('attribute', $data, array('objectElement', 'hashElement'));
276		}
277
278		/**
279		* End attribute.
280		*
281		* @param string $name
282		*/
283		abstract public function endAttribute($name);
284
285		/**
286		* Check end attribute.
287		*
288		* @param mixed $data
289		*/
290		protected function checkEndAttribute($data)
291		{
292		$this->checkEnd('attribute', $data);
293		}
294
295		/**
296		* Get media type.
297		*
298		* @param string $name
299		*
300		* @return string
301		*/
302		abstract public function getMediaType($name);
303
304		/**
305		* Generates a media type from $name and $type.
306		*
307		* @param string $name
308		* @param string $type
309		*
310		* @return string
311		*/
312		protected function generateMediaType($name, $type)
313		{
314		return "application/vnd.ez.api.{$name}+{$type}";
315		}
316
317		/**
318		* Generates a generic representation of the scalar, hash or list given in
319		* $hashValue into the document, using an element of $hashElementName as
320		* its parent.
321		*
322		* @param string $hashElementName
323		* @param mixed $hashValue
324		*/
325		abstract public function generateFieldTypeHash($hashElementName, $hashValue);
326
327		/**
328		* Check close / end operation.
329		*
330		* @param string $type
331		* @param mixed $data
332		* @param array $validParents
333		*/
334		protected function checkStart($type, $data, array $validParents)
335		{
336		$lastTag = end($this->stack);
337
338		if (!is_array($lastTag)) {
339		throw new Exceptions\OutputGeneratorException(
340		sprintf(
341		'Invalid start: Trying to open outside of a document.'
342		)
343		);
344		}
345
346		if (!in_array($lastTag[0], $validParents)) {
347		throw new Exceptions\OutputGeneratorException(
348		sprintf(
349		'Invalid start: Trying to open %s inside %s, valid parent nodes are: %s.',
350		$type,
351		$lastTag[0],
352		implode(', ', $validParents)
353		)
354		);
355		}
356
357		$this->stack[] = array($type, $data, array());
358		}
359
360		/**
361		* Check close / end operation.
362		*
363		* @param string $type
364		* @param mixed $data
365		*/
366		protected function checkEnd($type, $data)
367		{
368		$lastTag = array_pop($this->stack);
369
370		if (!is_array($lastTag)) {
371		throw new Exceptions\OutputGeneratorException(
372		sprintf(
373		'Invalid close: Trying to close on empty stack.'
374		)
375		);
376		}
377
378		if (array($lastTag[0], $lastTag[1]) !== array($type, $data)) {
379		throw new Exceptions\OutputGeneratorException(
380		sprintf(
381		'Invalid close: Trying to close %s:%s, while last element was %s:%s.',
382		$type,
383		$data,
384		$lastTag[0],
385		$lastTag[1]
386		)
387		);
388		}
389		}
390
391		/**
392		* Serializes a boolean value.
393		*
394		* @param bool $boolValue
395		*
396		* @return mixed
397		*/
398		abstract public function serializeBool($boolValue);
399
400		/**
401		* Returns a string representation of the current stack of the document.
402		*
403		* Example: "Location.ContentInfo'.
404		* Elements of type 'attribute', 'document' and 'list' are ignored.
405		*
406		* @return string
407		*/
408		public function getStackPath()
409		{
410		$relevantNodes = array_filter(
411		$this->stack,
412		function ($value) {
413		return !in_array($value[0], ['attribute', 'document', 'list']);
414		}
415		);
416
417		$names = array_map(
418		function ($value) {
419		return $value[1];
420		},
421		$relevantNodes
422		);
423
424		return implode('.', $names);
425		}
426		}
427

ezsystems / ezpublish-kernel

Push — ezp26352-skip_csrf_check_on_re... ( 19f37a )

Generator A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

34 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like