PermissionsCriterionHandler - Code Metrics - Inspection of "fixup! EZP-28048: Moving to trash shouldn't give e..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — ezp28048_trash_move_when_cant_... ( f2b086...c48dd6 )

unknown

created 2017-11-16 12:43 UTC

PermissionsCriterionHandler A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	33
Duplicated Lines	63.64 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
dl	21
loc	33
rs	10
c	0
b	0
f	0
wmc	4
lcom	0
cbo	2

1 Method

Rating	Name	Duplication	Size	Complexity
A	addPermissionsCriterion()	21	21	4

How to fix Duplicated Code

<?php

/**
 * File containing the eZ\Publish\Core\Repository\PermissionsCriterionHandler class.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Publish\Core\Repository;

use eZ\Publish\API\Repository\Values\Content\Query\Criterion;
use eZ\Publish\API\Repository\Values\Content\Query\Criterion\LogicalAnd;
use eZ\Publish\Core\Repository\Permission\PermissionCriterionResolver;

/**
 * Handler for permissions Criterion.
 *
 * @deprecated 6.7.7
 */
class PermissionsCriterionHandler extends PermissionCriterionResolver
{
    /**
     * Adds content, read Permission criteria if needed and return false if no access at all.
     *
     * @uses \eZ\Publish\Core\Repository\Permission\PermissionCriterionResolver::getPermissionsCriterion()
     *
     * @param \eZ\Publish\API\Repository\Values\Content\Query\Criterion $criterion
     *
     * @return bool|\eZ\Publish\API\Repository\Values\Content\Query\Criterion
     */
    public function addPermissionsCriterion(Criterion &$criterion)
    {
        $permissionCriterion = $this->getPermissionsCriterion();
        if ($permissionCriterion === true || $permissionCriterion === false) {
            return $permissionCriterion;
        }

        // Merge with original $criterion
        if ($criterion instanceof LogicalAnd) {
            $criterion->criteria[] = $permissionCriterion;
        } else {
            $criterion = new LogicalAnd(
                array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    $criterion,
                    $permissionCriterion,
                )
            );
        }

        return true;
    }
}


1		<?php
2
3		/**
4		* File containing the eZ\Publish\Core\Repository\PermissionsCriterionHandler class.
5		*
6		* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7		* @license For full copyright and license information view LICENSE file distributed with this source code.
8		*/
9		namespace eZ\Publish\Core\Repository;
10
11		use eZ\Publish\API\Repository\Values\Content\Query\Criterion;
12		use eZ\Publish\API\Repository\Values\Content\Query\Criterion\LogicalAnd;
13		use eZ\Publish\Core\Repository\Permission\PermissionCriterionResolver;
14
15		/**
16		* Handler for permissions Criterion.
17		*
18		* @deprecated 6.7.7
19		*/
20		class PermissionsCriterionHandler extends PermissionCriterionResolver
21		{
22		/**
23		* Adds content, read Permission criteria if needed and return false if no access at all.
24		*
25		* @uses \eZ\Publish\Core\Repository\Permission\PermissionCriterionResolver::getPermissionsCriterion()
26		*
27		* @param \eZ\Publish\API\Repository\Values\Content\Query\Criterion $criterion
28		*
29		* @return bool\|\eZ\Publish\API\Repository\Values\Content\Query\Criterion
30		*/
31	View Code Duplication	public function addPermissionsCriterion(Criterion &$criterion)
32		{
33		$permissionCriterion = $this->getPermissionsCriterion();
34		if ($permissionCriterion === true \|\| $permissionCriterion === false) {
35		return $permissionCriterion;
36		}
37
38		// Merge with original $criterion
39		if ($criterion instanceof LogicalAnd) {
40		$criterion->criteria[] = $permissionCriterion;
41		} else {
42		$criterion = new LogicalAnd(
43		array(
		0 ignored issues – show Documentation introduced 2015-11-21 14:37 UTC by Report Bug Copy Issue Report `array($criterion, $permissionCriterion)` is of type `array<integer,object<eZ\...t\\Query\\Criterion>"}>`, but the function expects a `array<integer,object<eZ\...ntent\Query\Criterion>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
44		$criterion,
45		$permissionCriterion,
46		)
47		);
48		}
49
50		return true;
51		}
52		}
53

ezsystems / ezpublish-kernel

Push — ezp28048_trash_move_when_cant_... ( f2b086...c48dd6 )

PermissionsCriterionHandler A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like