CachedValue::visit() - Code Metrics - Inspection of "fixup! EZP-26297: Added REST HttpCache controllers" - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — ezp26297-rest_embedding_http_c... ( 123323 )

unknown

created 2016-09-28 12:53 UTC

CachedValue::visit() D

↳ Parent: CachedValue

Complexity

Conditions	9
Paths	16

Size

Total Lines	39
Code Lines	23

Duplication

Lines	18
Ratio	46.15 %

Importance

Changes

Metric	Value
cc	9
eloc	23
nc	16
nop	3
dl	18
loc	39
rs	4.909
c	0
b	0
f	0

<?php

/**
 * File containing the ContentList ValueObjectVisitor class.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 *
 * @version //autogentag//
 */
namespace eZ\Publish\Core\REST\Server\Output\ValueObjectVisitor;

use eZ\Publish\Core\MVC\ConfigResolverInterface;
use eZ\Publish\Core\MVC\Symfony\RequestStackAware;
use eZ\Publish\Core\REST\Common\Output\ValueObjectVisitor;
use eZ\Publish\Core\REST\Common\Output\Generator;
use eZ\Publish\Core\REST\Common\Output\Visitor;

/**
 * CachedValue value object visitor.
 */
class CachedValue extends ValueObjectVisitor
{
    use RequestStackAware;

    /** @var ConfigResolverInterface */
    protected $configResolver;

    public function __construct(ConfigResolverInterface $configResolver)
    {
        $this->configResolver = $configResolver;
    }

    /**
     * @param Visitor   $visitor
     * @param Generator $generator
     * @param \eZ\Publish\Core\REST\Server\Values\CachedValue $data
     */
    public function visit(Visitor $visitor, Generator $generator, $data)
    {
        $visitor->visitValueObject($data->value, $generator, $visitor);

        if ($this->getParameter('content.view_cache') !== true) {
            return;
        }

        $response = $visitor->getResponse();
        $response->setPublic();
        $response->setVary('Accept', false);

        if ($this->getParameter('content.ttl_cache') === true) {
            $response->setSharedMaxAge($this->getParameter('content.default_ttl'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $request = $this->getCurrentRequest();
            if (isset($request) && $request->headers->has('X-User-Hash')) {
                $response->setVary('X-User-Hash', false);
            }
        }

        if (!empty($data->cacheTags)) {

            // See doc/specifications/cache/multi_tagging.md
            $tags = [];
            foreach ($data->cacheTags as $tag => $values) {
                foreach ((array)$values as $value) {
                    $tagValue = $tag . '-' . $value;
                    if (!$response->headers->contains('xkey', $tagValue)) {
                        $tags[] = $tag . '-' . $value;
                    }
                }
            }

            $response->headers->set(
                'xkey',
                $tags,
                false
            );
        }
    }

    public function getParameter($parameterName, $defaultValue = null)
    {
        if ($this->configResolver->hasParameter($parameterName)) {
            return $this->configResolver->getParameter($parameterName);
        }

        return $defaultValue;
    }
}


1		<?php
2
3		/**
4		* File containing the ContentList ValueObjectVisitor class.
5		*
6		* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7		* @license For full copyright and license information view LICENSE file distributed with this source code.
8		*
9		* @version //autogentag//
10		*/
11		namespace eZ\Publish\Core\REST\Server\Output\ValueObjectVisitor;
12
13		use eZ\Publish\Core\MVC\ConfigResolverInterface;
14		use eZ\Publish\Core\MVC\Symfony\RequestStackAware;
15		use eZ\Publish\Core\REST\Common\Output\ValueObjectVisitor;
16		use eZ\Publish\Core\REST\Common\Output\Generator;
17		use eZ\Publish\Core\REST\Common\Output\Visitor;
18
19		/**
20		* CachedValue value object visitor.
21		*/
22		class CachedValue extends ValueObjectVisitor
23		{
24		use RequestStackAware;
25
26		/** @var ConfigResolverInterface */
27		protected $configResolver;
28
29		public function __construct(ConfigResolverInterface $configResolver)
30		{
31		$this->configResolver = $configResolver;
32		}
33
34		/**
35		* @param Visitor $visitor
36		* @param Generator $generator
37		* @param \eZ\Publish\Core\REST\Server\Values\CachedValue $data
38		*/
39		public function visit(Visitor $visitor, Generator $generator, $data)
40		{
41		$visitor->visitValueObject($data->value, $generator, $visitor);
42
43		if ($this->getParameter('content.view_cache') !== true) {
44		return;
45		}
46
47		$response = $visitor->getResponse();
48		$response->setPublic();
49		$response->setVary('Accept', false);
50
51		if ($this->getParameter('content.ttl_cache') === true) {
52		$response->setSharedMaxAge($this->getParameter('content.default_ttl'));
		0 ignored issues – show Documentation introduced 2015-11-21 14:37 UTC by Report Bug Copy Issue Report `$this->getParameter('content.default_ttl')` is of type `boolean`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
53		$request = $this->getCurrentRequest();
54		if (isset($request) && $request->headers->has('X-User-Hash')) {
55		$response->setVary('X-User-Hash', false);
56		}
57		}
58
59	View Code Duplication	if (!empty($data->cacheTags)) {
		0 ignored issues – show Duplication introduced 2016-09-28 14:13 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
60		// See doc/specifications/cache/multi_tagging.md
61		$tags = [];
62		foreach ($data->cacheTags as $tag => $values) {
63		foreach ((array)$values as $value) {
64		$tagValue = $tag . '-' . $value;
65		if (!$response->headers->contains('xkey', $tagValue)) {
66		$tags[] = $tag . '-' . $value;
67		}
68		}
69		}
70
71		$response->headers->set(
72		'xkey',
73		$tags,
74		false
75		);
76		}
77		}
78
79		public function getParameter($parameterName, $defaultValue = null)
80		{
81		if ($this->configResolver->hasParameter($parameterName)) {
82		return $this->configResolver->getParameter($parameterName);
83		}
84
85		return $defaultValue;
86		}
87		}
88

ezsystems / ezpublish-kernel

Push — ezp26297-rest_embedding_http_c... ( 123323 )

CachedValue::visit() D

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like