LogicalOperator::__construct() - Code Metrics - Inspection of "EZP-27743: Criterion should implement CriterionInt..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bea266...37d41f )

unknown

created 2018-06-15 13:23 UTC

LogicalOperator::__construct() B

↳ Parent: LogicalOperator

Complexity

Conditions	6
Paths	6

Size

Total Lines	21
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
eloc	14
nc	6
nop	1
dl	0
loc	21
rs	8.7624
c	0
b	0
f	0

<?php

/**
 * File containing the eZ\Publish\API\Repository\Values\Content\Query\Criterion\LogicalOperator class.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Publish\API\Repository\Values\Content\Query\Criterion;

use eZ\Publish\API\Repository\Exceptions\NotImplementedException;
use eZ\Publish\API\Repository\Values\Content\Query\Criterion;
use InvalidArgumentException;

/**
 * Note that the class should ideally have been in a Logical namespace, but it would have then be named 'And',
 * and 'And' is a PHP reserved word.
 */
abstract class LogicalOperator extends Criterion
{
    /**
     * The set of criteria combined by the logical operator.
     *
     * @var Criterion[]
     */
    public $criteria = array();

    /**
     * Creates a Logic operation with the given criteria.
     *
     * @param Criterion[] $criteria
     *
     * @throws \InvalidArgumentException
     */
    public function __construct(array $criteria)
    {
        foreach ($criteria as $key => $criterion) {
            if (!$criterion instanceof Criterion) {
                if ($criterion === null) {
                    $type = 'null';
                } elseif (is_object($criterion)) {
                    $type = get_class($criterion);
                } elseif (is_array($criterion)) {
                    $type = 'Array, with keys: ' . implode(', ', array_keys($criterion));
                } else {
                    $type = gettype($criterion) . ", with value: '{$criterion}'";
                }

                throw new InvalidArgumentException(
                    "Only Criterion objects are accepted, at index '{$key}': " . $type
                );
            }
            $this->criteria[] = $criterion;
        }
    }

    /**
     * @deprecated in LogicalOperators since 7.2.
     * It will be removed in 8.0 when Logical Operator no longer extends Criterion.
     */
    public function getSpecifications()
    {
        @trigger_error('The ' . __METHOD__ . ' method is deprecated since version 7.2 and will be removed in 8.0.', E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        throw new NotImplementedException('getSpecifications() not implemented for LogicalOperators');
    }
}


1			<?php
2
3			/**
4			* File containing the eZ\Publish\API\Repository\Values\Content\Query\Criterion\LogicalOperator class.
5			*
6			* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7			* @license For full copyright and license information view LICENSE file distributed with this source code.
8			*/
9			namespace eZ\Publish\API\Repository\Values\Content\Query\Criterion;
10
11			use eZ\Publish\API\Repository\Exceptions\NotImplementedException;
12			use eZ\Publish\API\Repository\Values\Content\Query\Criterion;
13			use InvalidArgumentException;
14
15			/**
16			* Note that the class should ideally have been in a Logical namespace, but it would have then be named 'And',
17			* and 'And' is a PHP reserved word.
18			*/
19			abstract class LogicalOperator extends Criterion
20			{
21			/**
22			* The set of criteria combined by the logical operator.
23			*
24			* @var Criterion[]
25			*/
26			public $criteria = array();
27
28			/**
29			* Creates a Logic operation with the given criteria.
30			*
31			* @param Criterion[] $criteria
32			*
33			* @throws \InvalidArgumentException
34			*/
35			public function __construct(array $criteria)
36			{
37			foreach ($criteria as $key => $criterion) {
38			if (!$criterion instanceof Criterion) {
39			if ($criterion === null) {
40			$type = 'null';
41			} elseif (is_object($criterion)) {
42			$type = get_class($criterion);
43			} elseif (is_array($criterion)) {
44			$type = 'Array, with keys: ' . implode(', ', array_keys($criterion));
45			} else {
46			$type = gettype($criterion) . ", with value: '{$criterion}'";
47			}
48
49			throw new InvalidArgumentException(
50			"Only Criterion objects are accepted, at index '{$key}': " . $type
51			);
52			}
53			$this->criteria[] = $criterion;
54			}
55			}
56
57			/**
58			* @deprecated in LogicalOperators since 7.2.
59			* It will be removed in 8.0 when Logical Operator no longer extends Criterion.
60			*/
61			public function getSpecifications()
62			{
63			@trigger_error('The ' . __METHOD__ . ' method is deprecated since version 7.2 and will be removed in 8.0.', E_USER_DEPRECATED);
			0 ignored issues – show Security Best Practice introduced 2018-06-15 13:54 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
64
65			throw new NotImplementedException('getSpecifications() not implemented for LogicalOperators');
66			}
67			}
68

ezsystems / ezpublish-kernel

Push — master ( bea266...37d41f )

LogicalOperator::__construct() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like