DoctrineDatabaseTest::testCountRoleAssignmentsUsingSection() - Code Metrics - Inspection of "Fix EZP-23733: The delete button in section view/l..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — ezp-23733_disable_section_dele... ( 6e64a4...9f6957 )

unknown

created 2015-11-27 15:10 UTC

testCountRoleAssignmentsUsingSection() A

↳ Parent: DoctrineDatabaseTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	8

Duplication

Lines	15
Ratio	100 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	15
loc	15
rs	9.4286
cc	1
eloc	8
nc	1
nop	0

<?php

/**
 * File contains: eZ\Publish\Core\Persistence\Legacy\Tests\Content\Section\Gateway\DoctrineDatabaseTest class.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 *
 * @version //autogentag//
 */
namespace eZ\Publish\Core\Persistence\Legacy\Tests\Content\Section\Gateway;

use eZ\Publish\Core\Persistence\Legacy\Tests\TestCase;
use eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase;

/**
 * Test case for eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase.
 */
class DoctrineDatabaseTest extends TestCase
{
    /**
     * Database gateway to test.
     *
     * @var \eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase
     */
    protected $databaseGateway;

    /**
     * Inserts DB fixture.
     */
    public function setUp()
    {
        parent::setUp();

        $this->insertDatabaseFixture(
            __DIR__ . '/../../_fixtures/sections.php'
        );
    }

    /**
     * @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::__construct
     */
    public function testCtor()
    {
        $handler = $this->getDatabaseHandler();
        $gateway = $this->getDatabaseGateway();

        $this->assertAttributeSame(
            $handler,
            'dbHandler',
            $gateway
        );
    }

    /**
     * @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::insertSection
     */
    public function testInsertSection()
    {
        $gateway = $this->getDatabaseGateway();

        $gateway->insertSection('New Section', 'new_section');
        $query = $this->getDatabaseHandler()->createSelectQuery();

        $this->assertQueryResult(
            array(
                array(
                    'id' => '7',
                    'identifier' => 'new_section',
                    'name' => 'New Section',
                    'locale' => '',
                ),
            ),
            $query
                ->select('id', 'identifier', 'name', 'locale')
                ->from('ezsection')
                ->where($query->expr->eq('identifier', $query->bindValue('new_section')))
        );
    }

    /**
     * @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::updateSection
     */
    public function testUpdateSection()
    {
        $gateway = $this->getDatabaseGateway();

        $gateway->updateSection(2, 'New Section', 'new_section');

        $this->assertQueryResult(
            array(
                array(
                    'id' => '2',
                    'identifier' => 'new_section',
                    'name' => 'New Section',
                    'locale' => '',
                ),
            ),
            $this->getDatabaseHandler()->createSelectQuery()
                ->select('id', 'identifier', 'name', 'locale')
                ->from('ezsection')
                ->where('id=2')
        );
    }

    /**
     * @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::loadSectionData
     */
    public function testLoadSectionData()
    {
        $gateway = $this->getDatabaseGateway();

        $result = $gateway->loadSectionData(2);

        $this->assertEquals(
            array(
                array(
                    'id' => '2',
                    'identifier' => 'users',
                    'name' => 'Users',
                ),
            ),
            $result
        );
    }

    /**
     * @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::loadAllSectionData
     */
    public function testLoadAllSectionData()
    {
        $gateway = $this->getDatabaseGateway();

        $result = $gateway->loadAllSectionData();

        $expected = array(
            array(
                'id' => '1',
                'identifier' => 'standard',
                'name' => 'Standard',
            ),

            array(
                'id' => '2',
                'identifier' => 'users',
                'name' => 'Users',
            ),

            array(
                'id' => '3',
                'identifier' => 'media',
                'name' => 'Media',
            ),

            array(
                'id' => '4',
                'identifier' => 'setup',
                'name' => 'Setup',
            ),

            array(
                'id' => '5',
                'identifier' => 'design',
                'name' => 'Design',
            ),

            array(
                'id' => '6',
                'identifier' => '',
                'name' => 'Restricted',
            ),
        );
        $this->assertEquals(
            $expected,
            $result
        );
    }

    /**
     * @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::loadSectionDataByIdentifier
     */
    public function testLoadSectionDataByIdentifier()
    {
        $gateway = $this->getDatabaseGateway();

        $result = $gateway->loadSectionDataByIdentifier('users');

        $this->assertEquals(
            array(
                array(
                    'id' => '2',
                    'identifier' => 'users',
                    'name' => 'Users',
                ),
            ),
            $result
        );
    }

    /**
     * @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::countContentObjectsInSection
     */
    public function testCountContentObjectsInSection()
    {
        $this->insertDatabaseFixture(
            __DIR__ . '/../../_fixtures/contentobjects.php'
        );

        $gateway = $this->getDatabaseGateway();

        $result = $gateway->countContentObjectsInSection(2);

        $this->assertSame(
            7,
            $result
        );
    }

    /**
     * @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::countRoleAssignmentsUsingSection
     */
    public function testCountRoleAssignmentsUsingSection()
    {
        $this->insertDatabaseFixture(
            __DIR__ . '/../../../User/_fixtures/roles.php'
        );

        $gateway = $this->getDatabaseGateway();

        $result = $gateway->countRoleAssignmentsUsingSection(2);

        $this->assertSame(
            1,
            $result
        );
    }

    /**
     * @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::deleteSection
     */
    public function testDeleteSection()
    {
        $gateway = $this->getDatabaseGateway();

        $result = $gateway->deleteSection(2);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        $this->assertQueryResult(
            array(
                array(
                    'count' => '5',
                ),
            ),
            $this->getDatabaseHandler()->createSelectQuery()
                ->select('COUNT( * ) AS count')
                ->from('ezsection')
        );

        $this->assertQueryResult(
            array(
                array(
                    'count' => '0',
                ),
            ),
            $this->getDatabaseHandler()->createSelectQuery()
                ->select('COUNT( * ) AS count')
                ->from('ezsection')
                ->where('id=2')
        );
    }

    /**
     * @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::assignSectionToContent
     * @depends testCountContentObjectsInSection
     */
    public function testAssignSectionToContent()
    {
        $this->insertDatabaseFixture(
            __DIR__ . '/../../_fixtures/contentobjects.php'
        );

        $gateway = $this->getDatabaseGateway();

        $beforeCount = $gateway->countContentObjectsInSection(4);

        $result = $gateway->assignSectionToContent(4, 10);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        $this->assertSame(
            $beforeCount + 1,
            $gateway->countContentObjectsInSection(4)
        );
    }

    /**
     * Returns a ready to test DoctrineDatabase gateway.
     *
     * @return \eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase
     */
    protected function getDatabaseGateway()
    {
        if (!isset($this->databaseGateway)) {
            $this->databaseGateway = new DoctrineDatabase(
                $this->getDatabaseHandler()
            );
        }

        return $this->databaseGateway;
    }
}


1		<?php
2
3		/**
4		* File contains: eZ\Publish\Core\Persistence\Legacy\Tests\Content\Section\Gateway\DoctrineDatabaseTest class.
5		*
6		* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7		* @license For full copyright and license information view LICENSE file distributed with this source code.
8		*
9		* @version //autogentag//
10		*/
11		namespace eZ\Publish\Core\Persistence\Legacy\Tests\Content\Section\Gateway;
12
13		use eZ\Publish\Core\Persistence\Legacy\Tests\TestCase;
14		use eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase;
15
16		/**
17		* Test case for eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase.
18		*/
19		class DoctrineDatabaseTest extends TestCase
20		{
21		/**
22		* Database gateway to test.
23		*
24		* @var \eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase
25		*/
26		protected $databaseGateway;
27
28		/**
29		* Inserts DB fixture.
30		*/
31		public function setUp()
32		{
33		parent::setUp();
34
35		$this->insertDatabaseFixture(
36		__DIR__ . '/../../_fixtures/sections.php'
37		);
38		}
39
40		/**
41		* @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::__construct
42		*/
43		public function testCtor()
44		{
45		$handler = $this->getDatabaseHandler();
46		$gateway = $this->getDatabaseGateway();
47
48		$this->assertAttributeSame(
49		$handler,
50		'dbHandler',
51		$gateway
52		);
53		}
54
55		/**
56		* @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::insertSection
57		*/
58	View Code Duplication	public function testInsertSection()
59		{
60		$gateway = $this->getDatabaseGateway();
61
62		$gateway->insertSection('New Section', 'new_section');
63		$query = $this->getDatabaseHandler()->createSelectQuery();
64
65		$this->assertQueryResult(
66		array(
67		array(
68		'id' => '7',
69		'identifier' => 'new_section',
70		'name' => 'New Section',
71		'locale' => '',
72		),
73		),
74		$query
75		->select('id', 'identifier', 'name', 'locale')
76		->from('ezsection')
77		->where($query->expr->eq('identifier', $query->bindValue('new_section')))
78		);
79		}
80
81		/**
82		* @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::updateSection
83		*/
84	View Code Duplication	public function testUpdateSection()
85		{
86		$gateway = $this->getDatabaseGateway();
87
88		$gateway->updateSection(2, 'New Section', 'new_section');
89
90		$this->assertQueryResult(
91		array(
92		array(
93		'id' => '2',
94		'identifier' => 'new_section',
95		'name' => 'New Section',
96		'locale' => '',
97		),
98		),
99		$this->getDatabaseHandler()->createSelectQuery()
100		->select('id', 'identifier', 'name', 'locale')
101		->from('ezsection')
102		->where('id=2')
103		);
104		}
105
106		/**
107		* @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::loadSectionData
108		*/
109	View Code Duplication	public function testLoadSectionData()
110		{
111		$gateway = $this->getDatabaseGateway();
112
113		$result = $gateway->loadSectionData(2);
114
115		$this->assertEquals(
116		array(
117		array(
118		'id' => '2',
119		'identifier' => 'users',
120		'name' => 'Users',
121		),
122		),
123		$result
124		);
125		}
126
127		/**
128		* @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::loadAllSectionData
129		*/
130		public function testLoadAllSectionData()
131		{
132		$gateway = $this->getDatabaseGateway();
133
134		$result = $gateway->loadAllSectionData();
135
136		$expected = array(
137		array(
138		'id' => '1',
139		'identifier' => 'standard',
140		'name' => 'Standard',
141		),
142
143		array(
144		'id' => '2',
145		'identifier' => 'users',
146		'name' => 'Users',
147		),
148
149		array(
150		'id' => '3',
151		'identifier' => 'media',
152		'name' => 'Media',
153		),
154
155		array(
156		'id' => '4',
157		'identifier' => 'setup',
158		'name' => 'Setup',
159		),
160
161		array(
162		'id' => '5',
163		'identifier' => 'design',
164		'name' => 'Design',
165		),
166
167		array(
168		'id' => '6',
169		'identifier' => '',
170		'name' => 'Restricted',
171		),
172		);
173		$this->assertEquals(
174		$expected,
175		$result
176		);
177		}
178
179		/**
180		* @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::loadSectionDataByIdentifier
181		*/
182	View Code Duplication	public function testLoadSectionDataByIdentifier()
183		{
184		$gateway = $this->getDatabaseGateway();
185
186		$result = $gateway->loadSectionDataByIdentifier('users');
187
188		$this->assertEquals(
189		array(
190		array(
191		'id' => '2',
192		'identifier' => 'users',
193		'name' => 'Users',
194		),
195		),
196		$result
197		);
198		}
199
200		/**
201		* @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::countContentObjectsInSection
202		*/
203	View Code Duplication	public function testCountContentObjectsInSection()
204		{
205		$this->insertDatabaseFixture(
206		__DIR__ . '/../../_fixtures/contentobjects.php'
207		);
208
209		$gateway = $this->getDatabaseGateway();
210
211		$result = $gateway->countContentObjectsInSection(2);
212
213		$this->assertSame(
214		7,
215		$result
216		);
217		}
218
219		/**
220		* @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::countRoleAssignmentsUsingSection
221		*/
222	View Code Duplication	public function testCountRoleAssignmentsUsingSection()
223		{
224		$this->insertDatabaseFixture(
225		__DIR__ . '/../../../User/_fixtures/roles.php'
226		);
227
228		$gateway = $this->getDatabaseGateway();
229
230		$result = $gateway->countRoleAssignmentsUsingSection(2);
231
232		$this->assertSame(
233		1,
234		$result
235		);
236		}
237
238		/**
239		* @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::deleteSection
240		*/
241	View Code Duplication	public function testDeleteSection()
242		{
243		$gateway = $this->getDatabaseGateway();
244
245		$result = $gateway->deleteSection(2);
		0 ignored issues – show Bug introduced 2015-11-21 14:37 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$result` is correct as `$gateway->deleteSection(2)` (which targets `eZ\Publish\Core\Persiste...tabase::deleteSection()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history... Unused Code introduced 2015-11-21 14:37 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
246
247		$this->assertQueryResult(
248		array(
249		array(
250		'count' => '5',
251		),
252		),
253		$this->getDatabaseHandler()->createSelectQuery()
254		->select('COUNT( * ) AS count')
255		->from('ezsection')
256		);
257
258		$this->assertQueryResult(
259		array(
260		array(
261		'count' => '0',
262		),
263		),
264		$this->getDatabaseHandler()->createSelectQuery()
265		->select('COUNT( * ) AS count')
266		->from('ezsection')
267		->where('id=2')
268		);
269		}
270
271		/**
272		* @covers eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase::assignSectionToContent
273		* @depends testCountContentObjectsInSection
274		*/
275		public function testAssignSectionToContent()
276		{
277		$this->insertDatabaseFixture(
278		__DIR__ . '/../../_fixtures/contentobjects.php'
279		);
280
281		$gateway = $this->getDatabaseGateway();
282
283		$beforeCount = $gateway->countContentObjectsInSection(4);
284
285		$result = $gateway->assignSectionToContent(4, 10);
		0 ignored issues – show Bug introduced 2015-11-21 14:37 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$result` is correct as `$gateway->assignSectionToContent(4, 10)` (which targets `eZ\Publish\Core\Persiste...ssignSectionToContent()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history... Unused Code introduced 2015-11-21 14:37 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
286
287		$this->assertSame(
288		$beforeCount + 1,
289		$gateway->countContentObjectsInSection(4)
290		);
291		}
292
293		/**
294		* Returns a ready to test DoctrineDatabase gateway.
295		*
296		* @return \eZ\Publish\Core\Persistence\Legacy\Content\Section\Gateway\DoctrineDatabase
297		*/
298		protected function getDatabaseGateway()
299		{
300		if (!isset($this->databaseGateway)) {
301		$this->databaseGateway = new DoctrineDatabase(
302		$this->getDatabaseHandler()
303		);
304		}
305
306		return $this->databaseGateway;
307		}
308		}
309

ezsystems / ezpublish-kernel

Push — ezp-23733_disable_section_dele... ( 6e64a4...9f6957 )

testCountRoleAssignmentsUsingSection() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like