RoleContextProviderTest::testSetIdentity() - Code Metrics - Inspection of "Update tests to work PHPUnit v5.7 (#2102)" - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 28c8cd...7e44c6 )

by André

created 2017-10-31 20:14 UTC

RoleContextProviderTest::testSetIdentity() B

↳ Parent: RoleContextProviderTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	78
Code Lines	53

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	53
nc	1
nop	0
dl	0
loc	78
rs	8.9019
c	0
b	0
f	0

How to fix Long Method

<?php

/**
 * File containing the RoleIdTest class.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Publish\Core\MVC\Symfony\Security\Tests\User\Identifier;

use eZ\Publish\API\Repository\RoleService;
use eZ\Publish\API\Repository\Values\User\Limitation\RoleLimitation;
use eZ\Publish\API\Repository\Values\User\Role;
use eZ\Publish\API\Repository\Values\User\User as APIUser;
use eZ\Publish\API\Repository\Values\User\UserReference;
use eZ\Publish\Core\MVC\Symfony\Security\User\ContextProvider\RoleContextProvider;
use eZ\Publish\Core\Repository\Helper\LimitationService;
use eZ\Publish\Core\Repository\Helper\RoleDomainMapper;
use eZ\Publish\Core\Repository\Permission\PermissionResolver;
use eZ\Publish\Core\Repository\Repository;
use eZ\Publish\Core\Repository\Values\User\UserRoleAssignment;
use eZ\Publish\SPI\Persistence\User\Handler as SPIUserHandler;
use FOS\HttpCache\UserContext\UserContext;
use PHPUnit\Framework\TestCase;

class RoleContextProviderTest extends TestCase
{
    /**
     * @var \PHPUnit_Framework_MockObject_MockObject
     */
    private $repositoryMock;

    /**
     * @var \PHPUnit_Framework_MockObject_MockObject
     */
    private $roleServiceMock;

    protected function setUp()
    {
        parent::setUp();
        $this->repositoryMock = $this
            ->getMockBuilder(Repository::class)
            ->disableOriginalConstructor()
            ->setMethods(array('getRoleService', 'getCurrentUser', 'getPermissionResolver'))
            ->getMock();

        $this->roleServiceMock = $this->createMock(RoleService::class);

        $this->repositoryMock
            ->expects($this->any())
            ->method('getRoleService')
            ->will($this->returnValue($this->roleServiceMock));
        $this->repositoryMock
            ->expects($this->any())
            ->method('getPermissionResolver')
            ->will($this->returnValue($this->getPermissionResolverMock()));
    }

    public function testSetIdentity()
    {
        $user = $this->createMock(APIUser::class);
        $userContext = new UserContext();

        $this->repositoryMock
            ->expects($this->once())
            ->method('getCurrentUser')
            ->will($this->returnValue($user));

        $roleId1 = 123;
        $roleId2 = 456;
        $roleId3 = 789;
        $limitationForRole2 = $this->generateLimitationMock(
            array(
                'limitationValues' => array('/1/2', '/1/2/43'),
            )
        );
        $limitationForRole3 = $this->generateLimitationMock(
            array(
                'limitationValues' => array('foo', 'bar'),
            )
        );
        $returnedRoleAssignments = array(
            $this->generateRoleAssignmentMock(
                array(
                    'role' => $this->generateRoleMock(
                        array(
                            'id' => $roleId1,
                        )
                    ),
                )
            ),
            $this->generateRoleAssignmentMock(
                array(
                    'role' => $this->generateRoleMock(
                        array(
                            'id' => $roleId2,
                        )
                    ),
                    'limitation' => $limitationForRole2,
                )
            ),
            $this->generateRoleAssignmentMock(
                array(
                    'role' => $this->generateRoleMock(
                        array(
                            'id' => $roleId3,
                        )
                    ),
                    'limitation' => $limitationForRole3,
                )
            ),
        );

        $this->roleServiceMock
            ->expects($this->once())
            ->method('getRoleAssignmentsForUser')
            ->with($user, true)
            ->will($this->returnValue($returnedRoleAssignments));

        $this->assertSame(array(), $userContext->getParameters());
        $contextProvider = new RoleContextProvider($this->repositoryMock);
        $contextProvider->updateUserContext($userContext);
        $userContextParams = $userContext->getParameters();
        $this->assertArrayHasKey('roleIdList', $userContextParams);
        $this->assertSame(array($roleId1, $roleId2, $roleId3), $userContextParams['roleIdList']);
        $this->assertArrayHasKey('roleLimitationList', $userContextParams);
        $limitationIdentifierForRole2 = get_class($limitationForRole2);
        $limitationIdentifierForRole3 = get_class($limitationForRole3);
        $this->assertSame(
            array(
                "$roleId2-$limitationIdentifierForRole2" => array('/1/2', '/1/2/43'),
                "$roleId3-$limitationIdentifierForRole3" => array('foo', 'bar'),
            ),
            $userContextParams['roleLimitationList']
        );
    }

    private function generateRoleAssignmentMock(array $properties = array())
    {
        return $this
            ->getMockBuilder(UserRoleAssignment::class)
            ->setConstructorArgs(array($properties))
            ->getMockForAbstractClass();
    }

    private function generateRoleMock(array $properties = array())
    {
        return $this
            ->getMockBuilder(Role::class)
            ->setConstructorArgs(array($properties))
            ->getMockForAbstractClass();
    }

    private function generateLimitationMock(array $properties = array())
    {
        $limitationMock = $this
            ->getMockBuilder(RoleLimitation::class)
            ->setConstructorArgs(array($properties))
            ->getMockForAbstractClass();
        $limitationMock
            ->expects($this->any())
            ->method('getIdentifier')
            ->will($this->returnValue(get_class($limitationMock)));

        return $limitationMock;
    }

    protected function getPermissionResolverMock()
    {
        return $this
            ->getMockBuilder(PermissionResolver::class)
            ->setMethods(null)
            ->setConstructorArgs(
                [
                    $this->createMock(RoleDomainMapper::class),
                    $this->createMock(LimitationService::class),
                    $this->createMock(SPIUserHandler::class),
                    $this->createMock(UserReference::class),
                ]
            )
            ->getMock();
    }
}


1			<?php
2
3			/**
4			* File containing the RoleIdTest class.
5			*
6			* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7			* @license For full copyright and license information view LICENSE file distributed with this source code.
8			*/
9			namespace eZ\Publish\Core\MVC\Symfony\Security\Tests\User\Identifier;
10
11			use eZ\Publish\API\Repository\RoleService;
12			use eZ\Publish\API\Repository\Values\User\Limitation\RoleLimitation;
13			use eZ\Publish\API\Repository\Values\User\Role;
14			use eZ\Publish\API\Repository\Values\User\User as APIUser;
15			use eZ\Publish\API\Repository\Values\User\UserReference;
16			use eZ\Publish\Core\MVC\Symfony\Security\User\ContextProvider\RoleContextProvider;
17			use eZ\Publish\Core\Repository\Helper\LimitationService;
18			use eZ\Publish\Core\Repository\Helper\RoleDomainMapper;
19			use eZ\Publish\Core\Repository\Permission\PermissionResolver;
20			use eZ\Publish\Core\Repository\Repository;
21			use eZ\Publish\Core\Repository\Values\User\UserRoleAssignment;
22			use eZ\Publish\SPI\Persistence\User\Handler as SPIUserHandler;
23			use FOS\HttpCache\UserContext\UserContext;
24			use PHPUnit\Framework\TestCase;
25
26			class RoleContextProviderTest extends TestCase
27			{
28			/**
29			* @var \PHPUnit_Framework_MockObject_MockObject
30			*/
31			private $repositoryMock;
32
33			/**
34			* @var \PHPUnit_Framework_MockObject_MockObject
35			*/
36			private $roleServiceMock;
37
38			protected function setUp()
39			{
40			parent::setUp();
41			$this->repositoryMock = $this
42			->getMockBuilder(Repository::class)
43			->disableOriginalConstructor()
44			->setMethods(array('getRoleService', 'getCurrentUser', 'getPermissionResolver'))
45			->getMock();
46
47			$this->roleServiceMock = $this->createMock(RoleService::class);
48
49			$this->repositoryMock
50			->expects($this->any())
51			->method('getRoleService')
52			->will($this->returnValue($this->roleServiceMock));
53			$this->repositoryMock
54			->expects($this->any())
55			->method('getPermissionResolver')
56			->will($this->returnValue($this->getPermissionResolverMock()));
57			}
58
59			public function testSetIdentity()
60			{
61			$user = $this->createMock(APIUser::class);
62			$userContext = new UserContext();
63
64			$this->repositoryMock
65			->expects($this->once())
66			->method('getCurrentUser')
67			->will($this->returnValue($user));
68
69			$roleId1 = 123;
70			$roleId2 = 456;
71			$roleId3 = 789;
72			$limitationForRole2 = $this->generateLimitationMock(
73			array(
74			'limitationValues' => array('/1/2', '/1/2/43'),
75			)
76			);
77			$limitationForRole3 = $this->generateLimitationMock(
78			array(
79			'limitationValues' => array('foo', 'bar'),
80			)
81			);
82			$returnedRoleAssignments = array(
83			$this->generateRoleAssignmentMock(
84			array(
85			'role' => $this->generateRoleMock(
86			array(
87			'id' => $roleId1,
88			)
89			),
90			)
91			),
92			$this->generateRoleAssignmentMock(
93			array(
94			'role' => $this->generateRoleMock(
95			array(
96			'id' => $roleId2,
97			)
98			),
99			'limitation' => $limitationForRole2,
100			)
101			),
102			$this->generateRoleAssignmentMock(
103			array(
104			'role' => $this->generateRoleMock(
105			array(
106			'id' => $roleId3,
107			)
108			),
109			'limitation' => $limitationForRole3,
110			)
111			),
112			);
113
114			$this->roleServiceMock
115			->expects($this->once())
116			->method('getRoleAssignmentsForUser')
117			->with($user, true)
118			->will($this->returnValue($returnedRoleAssignments));
119
120			$this->assertSame(array(), $userContext->getParameters());
121			$contextProvider = new RoleContextProvider($this->repositoryMock);
122			$contextProvider->updateUserContext($userContext);
123			$userContextParams = $userContext->getParameters();
124			$this->assertArrayHasKey('roleIdList', $userContextParams);
125			$this->assertSame(array($roleId1, $roleId2, $roleId3), $userContextParams['roleIdList']);
126			$this->assertArrayHasKey('roleLimitationList', $userContextParams);
127			$limitationIdentifierForRole2 = get_class($limitationForRole2);
128			$limitationIdentifierForRole3 = get_class($limitationForRole3);
129			$this->assertSame(
130			array(
131			"$roleId2-$limitationIdentifierForRole2" => array('/1/2', '/1/2/43'),
132			"$roleId3-$limitationIdentifierForRole3" => array('foo', 'bar'),
133			),
134			$userContextParams['roleLimitationList']
135			);
136			}
137
138			private function generateRoleAssignmentMock(array $properties = array())
139			{
140			return $this
141			->getMockBuilder(UserRoleAssignment::class)
142			->setConstructorArgs(array($properties))
143			->getMockForAbstractClass();
144			}
145
146			private function generateRoleMock(array $properties = array())
147			{
148			return $this
149			->getMockBuilder(Role::class)
150			->setConstructorArgs(array($properties))
151			->getMockForAbstractClass();
152			}
153
154			private function generateLimitationMock(array $properties = array())
155			{
156			$limitationMock = $this
157			->getMockBuilder(RoleLimitation::class)
158			->setConstructorArgs(array($properties))
159			->getMockForAbstractClass();
160			$limitationMock
161			->expects($this->any())
162			->method('getIdentifier')
163			->will($this->returnValue(get_class($limitationMock)));
164
165			return $limitationMock;
166			}
167
168			protected function getPermissionResolverMock()
169			{
170			return $this
171			->getMockBuilder(PermissionResolver::class)
172			->setMethods(null)
173			->setConstructorArgs(
174			[
175			$this->createMock(RoleDomainMapper::class),
176			$this->createMock(LimitationService::class),
177			$this->createMock(SPIUserHandler::class),
178			$this->createMock(UserReference::class),
179			]
180			)
181			->getMock();
182			}
183			}
184

ezsystems / ezpublish-kernel

Push — master ( 28c8cd...7e44c6 )

RoleContextProviderTest::testSetIdentity() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like