Aggregate - Code Metrics - Inspection of "fixup! Fix EZP-26175: Exception instead of 404 whe..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — ezp26175-exception_on_non_defa... ( 77d2f3...ca5fc8 )

unknown

created 2016-10-31 11:49 UTC

Aggregate A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	0
loc	65
rs	10
c	0
b	0
f	0
wmc	7
lcom	1
cbo	2

4 Methods

Rating	Name	Size	Complexity
A	__construct()	6	2
A	addMapper()	4	1
A	canMap()	4	1
A	map()	12	3

<?php

/**
 * This file is part of the eZ Publish Kernel package.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 *
 * @version //autogentag//
 */
namespace eZ\Publish\Core\Search\Common\FieldValueMapper;

use eZ\Publish\Core\Search\Common\FieldValueMapper;
use eZ\Publish\SPI\Search\Field;
use eZ\Publish\API\Repository\Exceptions\NotImplementedException;

/**
 * Common aggregate mapper implementation.
 */
class Aggregate extends FieldValueMapper
{
    /**
     * Array of available mappers.
     *
     * @var \eZ\Publish\Core\Search\Common\FieldValueMapper[]
     */
    protected $mappers = array();

    /**
     * Construct from optional mapper array.
     *
     * @param \eZ\Publish\Core\Search\Common\FieldValueMapper[] $mappers
     */
    public function __construct(array $mappers = array())
    {
        foreach ($mappers as $mapper) {
            $this->addMapper($mapper);
        }
    }

    /**
     * Adds mapper.
     *
     * @param \eZ\Publish\Core\Search\Common\FieldValueMapper $mapper
     */
    public function addMapper(FieldValueMapper $mapper)
    {
        $this->mappers[] = $mapper;
    }

    /**
     * Check if field can be mapped.
     *
     * @param \eZ\Publish\SPI\Search\Field $field
     *
     * @return bool
     */
    public function canMap(Field $field)
    {
        return true;
    }

    /**
     * Map field value to a proper search engine representation.
     *
     * @throws \eZ\Publish\API\Repository\Exceptions\NotImplementedException
     *
     * @param \eZ\Publish\SPI\Search\Field $field
     *
     * @return mixed
     */
    public function map(Field $field)
    {
        foreach ($this->mappers as $mapper) {
            if ($mapper->canMap($field)) {
                return $mapper->map($field);
            }
        }

        throw new NotImplementedException(
            'No mapper available for: ' . get_class($field->type)
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        );
    }
}


1			<?php
2
3			/**
4			* This file is part of the eZ Publish Kernel package.
5			*
6			* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7			* @license For full copyright and license information view LICENSE file distributed with this source code.
8			*
9			* @version //autogentag//
10			*/
11			namespace eZ\Publish\Core\Search\Common\FieldValueMapper;
12
13			use eZ\Publish\Core\Search\Common\FieldValueMapper;
14			use eZ\Publish\SPI\Search\Field;
15			use eZ\Publish\API\Repository\Exceptions\NotImplementedException;
16
17			/**
18			* Common aggregate mapper implementation.
19			*/
20			class Aggregate extends FieldValueMapper
21			{
22			/**
23			* Array of available mappers.
24			*
25			* @var \eZ\Publish\Core\Search\Common\FieldValueMapper[]
26			*/
27			protected $mappers = array();
28
29			/**
30			* Construct from optional mapper array.
31			*
32			* @param \eZ\Publish\Core\Search\Common\FieldValueMapper[] $mappers
33			*/
34			public function __construct(array $mappers = array())
35			{
36			foreach ($mappers as $mapper) {
37			$this->addMapper($mapper);
38			}
39			}
40
41			/**
42			* Adds mapper.
43			*
44			* @param \eZ\Publish\Core\Search\Common\FieldValueMapper $mapper
45			*/
46			public function addMapper(FieldValueMapper $mapper)
47			{
48			$this->mappers[] = $mapper;
49			}
50
51			/**
52			* Check if field can be mapped.
53			*
54			* @param \eZ\Publish\SPI\Search\Field $field
55			*
56			* @return bool
57			*/
58			public function canMap(Field $field)
59			{
60			return true;
61			}
62
63			/**
64			* Map field value to a proper search engine representation.
65			*
66			* @throws \eZ\Publish\API\Repository\Exceptions\NotImplementedException
67			*
68			* @param \eZ\Publish\SPI\Search\Field $field
69			*
70			* @return mixed
71			*/
72			public function map(Field $field)
73			{
74			foreach ($this->mappers as $mapper) {
75			if ($mapper->canMap($field)) {
76			return $mapper->map($field);
77			}
78			}
79
80			throw new NotImplementedException(
81			'No mapper available for: ' . get_class($field->type)
			0 ignored issues – show Documentation introduced 2015-11-21 14:37 UTC by Report Bug Copy Issue Report The property `$type` is declared protected in `eZ\Publish\SPI\Search\Field`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
82			);
83			}
84			}
85

ezsystems / ezpublish-kernel

Push — ezp26175-exception_on_non_defa... ( 77d2f3...ca5fc8 )

Aggregate A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like