VersionTest::testVisit() - Code Metrics - Inspection of "EZP-28253: [REST] As a frontend developer I would..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 6.13 ( 055733...f64074 )

by André

created 2017-11-28 17:19 UTC

VersionTest::testVisit() B

↳ Parent: VersionTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	77
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	50
nc	1
nop	0
dl	0
loc	77
rs	8.9342
c	0
b	0
f	0

How to fix Long Method

<?php

/**
 * File containing a test class.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Publish\Core\REST\Server\Tests\Output\ValueObjectVisitor;

use eZ\Publish\API\Repository\Values\ContentType\ContentType;
use eZ\Publish\Core\REST\Common\Output\Generator;
use eZ\Publish\Core\REST\Common\Tests\Output\ValueObjectVisitorBaseTest;
use eZ\Publish\Core\REST\Server\Output\ValueObjectVisitor;
use eZ\Publish\Core\Repository\Values;
use eZ\Publish\Core\REST\Server\Values\Version;
use eZ\Publish\API\Repository\Values\Content\Field;
use eZ\Publish\API\Repository\Values\Content\ContentInfo;
use eZ\Publish\Core\REST\Common\Output\FieldTypeSerializer;

class VersionTest extends ValueObjectVisitorBaseTest
{
    protected $fieldTypeSerializerMock;

    public function setUp()
    {
        $this->fieldTypeSerializerMock = $this->createMock(FieldTypeSerializer::class);
    }

    /**
     * Test the Version visitor.
     *
     * @return string
     */
    public function testVisit()
    {
        $visitor = $this->getVisitor();
        $generator = $this->getGenerator();

        $generator->startDocument(null);

        $version = new Version(
            new Values\Content\Content(
                array(
                    'versionInfo' => new Values\Content\VersionInfo(
                        array(
                            'versionNo' => 5,
                            'contentInfo' => new ContentInfo(
                                array(
                                    'id' => 23,
                                    'contentTypeId' => 42,
                                )
                            ),
                        )
                    ),
                    'internalFields' => array(
                        new Field(
                            array(
                                'id' => 1,
                                'languageCode' => 'eng-US',
                                'fieldDefIdentifier' => 'ezauthor',
                                'typeIdentifier' => 'ezauthor',
                            )
                        ),
                        new Field(
                            array(
                                'id' => 2,
                                'languageCode' => 'eng-US',
                                'fieldDefIdentifier' => 'ezimage',
                                'typeIdentifier' => 'ezauthor',
                            )
                        ),
                    ),
                )
            ),
            $this->getMockForAbstractClass(ContentType::class),
            array()
        );

        $this->fieldTypeSerializerMock->expects($this->exactly(2))
            ->method('serializeFieldValue')
            ->with(
                $this->isInstanceOf(Generator::class),
                $this->isInstanceOf(ContentType::class),
                $this->isInstanceOf(Field::class)
            );

        $this->getVisitorMock()->expects($this->exactly(2))
            ->method('visitValueObject');

        $this->addRouteExpectation(
            'ezpublish_rest_loadContentInVersion',
            array(
                'contentId' => $version->content->id,
                'versionNumber' => $version->content->versionInfo->versionNo,
            ),
            "/content/objects/{$version->content->id}/versions/{$version->content->versionInfo->versionNo}"
        );

        $visitor->visit(
            $this->getVisitorMock(),

            $generator,
            $version
        );

        $result = $generator->endDocument(null);

        $this->assertNotNull($result);

        return $result;
    }

    /**
     * @param string $result
     *
     * @depends testVisit
     */
    public function testResultContainsVersionChildren($result)
    {
        $this->assertXMLTag(
            array(
                'tag' => 'Version',
                'children' => array(
                    'less_than' => 2,
                    'greater_than' => 0,
                ),
            ),
            $result,
            'Invalid <Version> element.',
            false
        );
    }

    /**
     * @param string $result
     *
     * @depends testVisit
     */
    public function testResultVersionAttributes($result)
    {
        $this->assertXMLTag(
            array(
                'tag' => 'Version',
                'attributes' => array(
                    'media-type' => 'application/vnd.ez.api.Version+xml',
                    'href' => '/content/objects/23/versions/5',
                ),
            ),
            $result,
            'Invalid <Version> attributes.',
            false
        );
    }

    /**
     * @param string $result
     *
     * @depends testVisit
     */
    public function testResultContainsFieldsChildren($result)
    {
        $this->assertXMLTag(
            array(
                'tag' => 'Fields',
                'children' => array(
                    'less_than' => 3,
                    'greater_than' => 1,
                ),
            ),
            $result,
            'Invalid <Fields> element.',
            false
        );
    }

    /**
     * Get the Version visitor.
     *
     * @return \eZ\Publish\Core\REST\Server\Output\ValueObjectVisitor\Version
     */
    protected function internalGetVisitor()
    {
        return new ValueObjectVisitor\Version($this->fieldTypeSerializerMock);
    }
}


1			<?php
2
3			/**
4			* File containing a test class.
5			*
6			* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7			* @license For full copyright and license information view LICENSE file distributed with this source code.
8			*/
9			namespace eZ\Publish\Core\REST\Server\Tests\Output\ValueObjectVisitor;
10
11			use eZ\Publish\API\Repository\Values\ContentType\ContentType;
12			use eZ\Publish\Core\REST\Common\Output\Generator;
13			use eZ\Publish\Core\REST\Common\Tests\Output\ValueObjectVisitorBaseTest;
14			use eZ\Publish\Core\REST\Server\Output\ValueObjectVisitor;
15			use eZ\Publish\Core\Repository\Values;
16			use eZ\Publish\Core\REST\Server\Values\Version;
17			use eZ\Publish\API\Repository\Values\Content\Field;
18			use eZ\Publish\API\Repository\Values\Content\ContentInfo;
19			use eZ\Publish\Core\REST\Common\Output\FieldTypeSerializer;
20
21			class VersionTest extends ValueObjectVisitorBaseTest
22			{
23			protected $fieldTypeSerializerMock;
24
25			public function setUp()
26			{
27			$this->fieldTypeSerializerMock = $this->createMock(FieldTypeSerializer::class);
28			}
29
30			/**
31			* Test the Version visitor.
32			*
33			* @return string
34			*/
35			public function testVisit()
36			{
37			$visitor = $this->getVisitor();
38			$generator = $this->getGenerator();
39
40			$generator->startDocument(null);
41
42			$version = new Version(
43			new Values\Content\Content(
44			array(
45			'versionInfo' => new Values\Content\VersionInfo(
46			array(
47			'versionNo' => 5,
48			'contentInfo' => new ContentInfo(
49			array(
50			'id' => 23,
51			'contentTypeId' => 42,
52			)
53			),
54			)
55			),
56			'internalFields' => array(
57			new Field(
58			array(
59			'id' => 1,
60			'languageCode' => 'eng-US',
61			'fieldDefIdentifier' => 'ezauthor',
62			'typeIdentifier' => 'ezauthor',
63			)
64			),
65			new Field(
66			array(
67			'id' => 2,
68			'languageCode' => 'eng-US',
69			'fieldDefIdentifier' => 'ezimage',
70			'typeIdentifier' => 'ezauthor',
71			)
72			),
73			),
74			)
75			),
76			$this->getMockForAbstractClass(ContentType::class),
77			array()
78			);
79
80			$this->fieldTypeSerializerMock->expects($this->exactly(2))
81			->method('serializeFieldValue')
82			->with(
83			$this->isInstanceOf(Generator::class),
84			$this->isInstanceOf(ContentType::class),
85			$this->isInstanceOf(Field::class)
86			);
87
88			$this->getVisitorMock()->expects($this->exactly(2))
89			->method('visitValueObject');
90
91			$this->addRouteExpectation(
92			'ezpublish_rest_loadContentInVersion',
93			array(
94			'contentId' => $version->content->id,
95			'versionNumber' => $version->content->versionInfo->versionNo,
96			),
97			"/content/objects/{$version->content->id}/versions/{$version->content->versionInfo->versionNo}"
98			);
99
100			$visitor->visit(
101			$this->getVisitorMock(),
			0 ignored issues – show Bug introduced 2015-11-21 14:37 UTC by Report Bug Copy Issue Report It seems like `$this->getVisitorMock()` targeting `eZ\Publish\Core\REST\Com...eTest::getVisitorMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `eZ\Publish\Core\REST\Com...eObjectVisitor::visit()` does only seem to accept `object<eZ\Publish\Core\R...\Common\Output\Visitor>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
102			$generator,
103			$version
104			);
105
106			$result = $generator->endDocument(null);
107
108			$this->assertNotNull($result);
109
110			return $result;
111			}
112
113			/**
114			* @param string $result
115			*
116			* @depends testVisit
117			*/
118			public function testResultContainsVersionChildren($result)
119			{
120			$this->assertXMLTag(
121			array(
122			'tag' => 'Version',
123			'children' => array(
124			'less_than' => 2,
125			'greater_than' => 0,
126			),
127			),
128			$result,
129			'Invalid <Version> element.',
130			false
131			);
132			}
133
134			/**
135			* @param string $result
136			*
137			* @depends testVisit
138			*/
139			public function testResultVersionAttributes($result)
140			{
141			$this->assertXMLTag(
142			array(
143			'tag' => 'Version',
144			'attributes' => array(
145			'media-type' => 'application/vnd.ez.api.Version+xml',
146			'href' => '/content/objects/23/versions/5',
147			),
148			),
149			$result,
150			'Invalid <Version> attributes.',
151			false
152			);
153			}
154
155			/**
156			* @param string $result
157			*
158			* @depends testVisit
159			*/
160			public function testResultContainsFieldsChildren($result)
161			{
162			$this->assertXMLTag(
163			array(
164			'tag' => 'Fields',
165			'children' => array(
166			'less_than' => 3,
167			'greater_than' => 1,
168			),
169			),
170			$result,
171			'Invalid <Fields> element.',
172			false
173			);
174			}
175
176			/**
177			* Get the Version visitor.
178			*
179			* @return \eZ\Publish\Core\REST\Server\Output\ValueObjectVisitor\Version
180			*/
181			protected function internalGetVisitor()
182			{
183			return new ValueObjectVisitor\Version($this->fieldTypeSerializerMock);
184			}
185			}
186

ezsystems / ezpublish-kernel

Push — 6.13 ( 055733...f64074 )

VersionTest::testVisit() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like