Inspection of "EZP-23281: Add max archive versions limit & enforc..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — EZP-23281 ( d976e8...bb7535 )

by André

created 2016-11-08 12:49 UTC

Status

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -151,7 +151,7 @@  discard block
 block discarded – undo
     /**
      * Get initial field data for valid object creation.
      *
-     * @return mixed
+     * @return ImageValue
      */
     public function getValidCreationFieldData()
     {
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
     /**
      * Get update field externals data.
      *
-     * @return array
+     * @return ImageValue
      */
     public function getValidUpdateFieldData()
     {

Please login to merge, or discard this patch.

eZ/Publish/API/Repository/Tests/FieldType/IntegerIntegrationTest.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -116,7 +116,7 @@  discard block
 block discarded – undo
     /**
      * Get initial field data for valid object creation.
      *
-     * @return mixed
+     * @return IntegerValue
      */
     public function getValidCreationFieldData()
     {
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
     /**
      * Get update field externals data.
      *
-     * @return array
+     * @return IntegerValue
      */
     public function getValidUpdateFieldData()
     {

Please login to merge, or discard this patch.

eZ/Publish/API/Repository/Tests/FieldType/ISBNIntegrationTest.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -105,7 +105,7 @@  discard block
 block discarded – undo
     /**
      * Get initial field data for valid object creation.
      *
-     * @return mixed
+     * @return ISBNValue
      */
     public function getValidCreationFieldData()
     {
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
     /**
      * Get update field externals data.
      *
-     * @return array
+     * @return ISBNValue
      */
     public function getValidUpdateFieldData()
     {

Please login to merge, or discard this patch.

eZ/Publish/API/Repository/Tests/FieldType/KeywordIntegrationTest.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -98,7 +98,7 @@  discard block
 block discarded – undo
     /**
      * Get initial field data for valid object creation.
      *
-     * @return mixed
+     * @return KeywordValue
      */
     public function getValidCreationFieldData()
     {
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
     /**
      * Get update field externals data.
      *
-     * @return array
+     * @return KeywordValue
      */
     public function getValidUpdateFieldData()
     {

Please login to merge, or discard this patch.

eZ/Publish/API/Repository/Tests/FieldType/MapLocationIntegrationTest.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -98,7 +98,7 @@  discard block
 block discarded – undo
     /**
      * Get initial field data for valid object creation.
      *
-     * @return mixed
+     * @return MapLocationValue
      */
     public function getValidCreationFieldData()
     {
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
     /**
      * Get update field externals data.
      *
-     * @return array
+     * @return MapLocationValue
      */
     public function getValidUpdateFieldData()
     {

Please login to merge, or discard this patch.

eZ/Publish/API/Repository/Tests/FieldType/MediaIntegrationTest.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -168,7 +168,7 @@  discard block
 block discarded – undo
     /**
      * Get initial field data for valid object creation.
      *
-     * @return mixed
+     * @return MediaValue
      */
     public function getValidCreationFieldData()
     {
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
     /**
      * Get update field externals data.
      *
-     * @return array
+     * @return MediaValue
      */
     public function getValidUpdateFieldData()
     {

Please login to merge, or discard this patch.

eZ/Publish/API/Repository/Tests/FieldType/RatingIntegrationTest.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -98,7 +98,7 @@  discard block
 block discarded – undo
     /**
      * Get initial field data for valid object creation.
      *
-     * @return mixed
+     * @return RatingValue
      */
     public function getValidCreationFieldData()
     {
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
     /**
      * Get update field externals data.
      *
-     * @return array
+     * @return RatingValue
      */
     public function getValidUpdateFieldData()
     {

Please login to merge, or discard this patch.

eZ/Publish/API/Repository/Tests/FieldType/RelationIntegrationTest.php 1 patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@  discard block
 block discarded – undo
     /**
      * @param \eZ\Publish\API\Repository\Values\Content\Content $content
      *
-     * @return array|\eZ\Publish\API\Repository\Values\Content\Relation[]
+     * @return Relation[]
      */
     public function getCreateExpectedRelations(Content $content)
     {
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
     /**
      * @param \eZ\Publish\API\Repository\Values\Content\Content $content
      *
-     * @return array|\eZ\Publish\API\Repository\Values\Content\Relation[]
+     * @return Relation[]
      */
     public function getUpdateExpectedRelations(Content $content)
     {
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
     /**
      * Get initial field data for valid object creation.
      *
-     * @return mixed
+     * @return RelationValue
      */
     public function getValidCreationFieldData()
     {
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
     /**
      * Get update field externals data.
      *
-     * @return array
+     * @return RelationValue
      */
     public function getValidUpdateFieldData()
     {

Please login to merge, or discard this patch.

eZ/Publish/API/Repository/Tests/FieldType/RelationListIntegrationTest.php 1 patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -37,7 +37,7 @@  discard block
 block discarded – undo
     /**
      * @param \eZ\Publish\API\Repository\Values\Content\Content $content
      *
-     * @return array|\eZ\Publish\API\Repository\Values\Content\Relation[]
+     * @return Relation[]
      */
     public function getCreateExpectedRelations(Content $content)
     {
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
     /**
      * @param \eZ\Publish\API\Repository\Values\Content\Content $content
      *
-     * @return array|\eZ\Publish\API\Repository\Values\Content\Relation[]
+     * @return Relation[]
      */
     public function getUpdateExpectedRelations(Content $content)
     {
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
     /**
      * Get initial field data for valid object creation.
      *
-     * @return mixed
+     * @return RelationListValue
      */
     public function getValidCreationFieldData()
     {
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
     /**
      * Get update field externals data.
      *
-     * @return array
+     * @return RelationListValue
      */
     public function getValidUpdateFieldData()
     {

Please login to merge, or discard this patch.

		@@ -151,7 +151,7 @@ discard block
		block discarded – undo
151	151	/**
152	152	* Get initial field data for valid object creation.
153	153	*
154		- * @return mixed
	154	+ * @return ImageValue
155	155	*/
156	156	public function getValidCreationFieldData()
157	157	{
		@@ -233,7 +233,7 @@ discard block
		block discarded – undo
233	233	/**
234	234	* Get update field externals data.
235	235	*
236		- * @return array
	236	+ * @return ImageValue
237	237	*/
238	238	public function getValidUpdateFieldData()
239	239	{

		@@ -98,7 +98,7 @@ discard block
		block discarded – undo
98	98	/**
99	99	* Get initial field data for valid object creation.
100	100	*
101		- * @return mixed
	101	+ * @return MapLocationValue
102	102	*/
103	103	public function getValidCreationFieldData()
104	104	{
		@@ -192,7 +192,7 @@ discard block
		block discarded – undo
192	192	/**
193	193	* Get update field externals data.
194	194	*
195		- * @return array
	195	+ * @return MapLocationValue
196	196	*/
197	197	public function getValidUpdateFieldData()
198	198	{

		@@ -168,7 +168,7 @@ discard block
		block discarded – undo
168	168	/**
169	169	* Get initial field data for valid object creation.
170	170	*
171		- * @return mixed
	171	+ * @return MediaValue
172	172	*/
173	173	public function getValidCreationFieldData()
174	174	{
		@@ -257,7 +257,7 @@ discard block
		block discarded – undo
257	257	/**
258	258	* Get update field externals data.
259	259	*
260		- * @return array
	260	+ * @return MediaValue
261	261	*/
262	262	public function getValidUpdateFieldData()
263	263	{

		@@ -36,7 +36,7 @@ discard block
		block discarded – undo
36	36	/**
37	37	* @param \eZ\Publish\API\Repository\Values\Content\Content $content
38	38	*
39		- * @return array\|\eZ\Publish\API\Repository\Values\Content\Relation[]
	39	+ * @return Relation[]
40	40	*/
41	41	public function getCreateExpectedRelations(Content $content)
42	42	{
		@@ -57,7 +57,7 @@ discard block
		block discarded – undo
57	57	/**
58	58	* @param \eZ\Publish\API\Repository\Values\Content\Content $content
59	59	*
60		- * @return array\|\eZ\Publish\API\Repository\Values\Content\Relation[]
	60	+ * @return Relation[]
61	61	*/
62	62	public function getUpdateExpectedRelations(Content $content)
63	63	{
		@@ -151,7 +151,7 @@ discard block
		block discarded – undo
151	151	/**
152	152	* Get initial field data for valid object creation.
153	153	*
154		- * @return mixed
	154	+ * @return RelationValue
155	155	*/
156	156	public function getValidCreationFieldData()
157	157	{
		@@ -216,7 +216,7 @@ discard block
		block discarded – undo
216	216	/**
217	217	* Get update field externals data.
218	218	*
219		- * @return array
	219	+ * @return RelationValue
220	220	*/
221	221	public function getValidUpdateFieldData()
222	222	{

		@@ -116,7 +116,7 @@ discard block
		block discarded – undo
116	116	/**
117	117	* Get initial field data for valid object creation.
118	118	*
119		- * @return mixed
	119	+ * @return IntegerValue
120	120	*/
121	121	public function getValidCreationFieldData()
122	122	{
		@@ -189,7 +189,7 @@ discard block
		block discarded – undo
189	189	/**
190	190	* Get update field externals data.
191	191	*
192		- * @return array
	192	+ * @return IntegerValue
193	193	*/
194	194	public function getValidUpdateFieldData()
195	195	{

		@@ -105,7 +105,7 @@ discard block
		block discarded – undo
105	105	/**
106	106	* Get initial field data for valid object creation.
107	107	*
108		- * @return mixed
	108	+ * @return ISBNValue
109	109	*/
110	110	public function getValidCreationFieldData()
111	111	{
		@@ -181,7 +181,7 @@ discard block
		block discarded – undo
181	181	/**
182	182	* Get update field externals data.
183	183	*
184		- * @return array
	184	+ * @return ISBNValue
185	185	*/
186	186	public function getValidUpdateFieldData()
187	187	{

		@@ -37,7 +37,7 @@ discard block
		block discarded – undo
37	37	/**
38	38	* @param \eZ\Publish\API\Repository\Values\Content\Content $content
39	39	*
40		- * @return array\|\eZ\Publish\API\Repository\Values\Content\Relation[]
	40	+ * @return Relation[]
41	41	*/
42	42	public function getCreateExpectedRelations(Content $content)
43	43	{
		@@ -66,7 +66,7 @@ discard block
		block discarded – undo
66	66	/**
67	67	* @param \eZ\Publish\API\Repository\Values\Content\Content $content
68	68	*
69		- * @return array\|\eZ\Publish\API\Repository\Values\Content\Relation[]
	69	+ * @return Relation[]
70	70	*/
71	71	public function getUpdateExpectedRelations(Content $content)
72	72	{
		@@ -186,7 +186,7 @@ discard block
		block discarded – undo
186	186	/**
187	187	* Get initial field data for valid object creation.
188	188	*
189		- * @return mixed
	189	+ * @return RelationListValue
190	190	*/
191	191	public function getValidCreationFieldData()
192	192	{
		@@ -251,7 +251,7 @@ discard block
		block discarded – undo
251	251	/**
252	252	* Get update field externals data.
253	253	*
254		- * @return array
	254	+ * @return RelationListValue
255	255	*/
256	256	public function getValidUpdateFieldData()
257	257	{

ezsystems / ezpublish-kernel

Push — EZP-23281 ( d976e8...bb7535 )

Status

Category

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch