Complex classes like RootTest often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use RootTest, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
16 | class RootTest extends RESTFunctionalTestCase |
||
17 | { |
||
18 | use AssertXmlTagTrait; |
||
19 | |||
20 | /** |
||
21 | * @covers GET / |
||
22 | */ |
||
23 | public function testLoadRootResource() |
||
32 | |||
33 | /** |
||
34 | * @dataProvider getRandomUriSet |
||
35 | * @covers GET /<wrongUri> |
||
36 | */ |
||
37 | public function testCatchAll($uri) |
||
|
|||
38 | { |
||
39 | self::markTestSkipped('@todo fixme'); |
||
40 | $response = $this->sendHttpRequest( |
||
41 | $this->createHttpRequest('GET', '/api/ezp/v2/' . uniqid('rest'), '', 'Stuff+json') |
||
42 | ); |
||
43 | self::assertHttpResponseCodeEquals($response, 404); |
||
44 | $responseArray = json_decode($response->getContent(), true); |
||
45 | self::assertArrayHasKey('ErrorMessage', $responseArray); |
||
46 | self::assertEquals('No such route', $responseArray['ErrorMessage']['errorDescription']); |
||
47 | } |
||
48 | |||
49 | /** |
||
50 | * @depends testLoadRootResource |
||
51 | */ |
||
52 | public function testResultContainsRootElement($result) |
||
61 | |||
62 | /** |
||
63 | * Test if result contains Role element attributes. |
||
64 | * |
||
65 | * @param string $result |
||
66 | * |
||
67 | * @depends testLoadRootResource |
||
68 | */ |
||
69 | public function testResultContainsRootAttributes($result) |
||
83 | |||
84 | /** |
||
85 | * @depends testLoadRootResource |
||
86 | */ |
||
87 | public function testResultContainsContentTag($result) |
||
98 | |||
99 | /** |
||
100 | * @depends testLoadRootResource |
||
101 | */ |
||
102 | public function testResultContainsContentTagAttributes($result) |
||
117 | |||
118 | /** |
||
119 | * @depends testLoadRootResource |
||
120 | */ |
||
121 | public function testResultContainsContentByRemoteIdTag($result) |
||
132 | |||
133 | /** |
||
134 | * @depends testLoadRootResource |
||
135 | */ |
||
136 | public function testResultContainsContentByRemoteIdTagAttributes($result) |
||
151 | |||
152 | /** |
||
153 | * @depends testLoadRootResource |
||
154 | */ |
||
155 | public function testResultContainsContentTypesTag($result) |
||
166 | |||
167 | /** |
||
168 | * @depends testLoadRootResource |
||
169 | */ |
||
170 | public function testResultContainsContentTypesTagAttributes($result) |
||
185 | |||
186 | /** |
||
187 | * @depends testLoadRootResource |
||
188 | */ |
||
189 | public function testResultContainsContentTypeByIdentifierTag($result) |
||
200 | |||
201 | /** |
||
202 | * @depends testLoadRootResource |
||
203 | */ |
||
204 | public function testResultContainsContentTypeByIdentifierTagAttributes($result) |
||
219 | |||
220 | /** |
||
221 | * @depends testLoadRootResource |
||
222 | */ |
||
223 | public function testResultContainsContentTypeGroupsTag($result) |
||
234 | |||
235 | /** |
||
236 | * @depends testLoadRootResource |
||
237 | */ |
||
238 | public function testResultContainsContentTypeGroupsTagAttributes($result) |
||
253 | |||
254 | /** |
||
255 | * @depends testLoadRootResource |
||
256 | */ |
||
257 | public function testResultContainsContentTypeGroupByIdentifierTag($result) |
||
268 | |||
269 | /** |
||
270 | * @depends testLoadRootResource |
||
271 | */ |
||
272 | public function testResultContainsContentTypeGroupByIdentifierTagAttributes($result) |
||
287 | |||
288 | /** |
||
289 | * @depends testLoadRootResource |
||
290 | */ |
||
291 | public function testResultContainsUsersTag($result) |
||
302 | |||
303 | /** |
||
304 | * @depends testLoadRootResource |
||
305 | */ |
||
306 | public function testResultContainsUsersTagAttributes($result) |
||
321 | |||
322 | /** |
||
323 | * @depends testLoadRootResource |
||
324 | */ |
||
325 | public function testResultContainsUsersByRoleIdentifierTag($result) |
||
336 | |||
337 | /** |
||
338 | * @depends testLoadRootResource |
||
339 | */ |
||
340 | public function testResultContainsUsersByRoleIdentifierTagAttributes($result) |
||
355 | |||
356 | /** |
||
357 | * @depends testLoadRootResource |
||
358 | */ |
||
359 | public function testResultContainsUsersByRemoteIdentifierTag($result) |
||
370 | |||
371 | /** |
||
372 | * @depends testLoadRootResource |
||
373 | */ |
||
374 | public function testResultContainsUsersByRemoteIdentifierTagAttributes($result) |
||
389 | |||
390 | /** |
||
391 | * @depends testLoadRootResource |
||
392 | */ |
||
393 | public function testResultContainsUsersByEmailTag($result) |
||
404 | |||
405 | /** |
||
406 | * @depends testLoadRootResource |
||
407 | */ |
||
408 | public function testResultContainsUsersByEmailTagAttributes($result) |
||
423 | |||
424 | /** |
||
425 | * @depends testLoadRootResource |
||
426 | */ |
||
427 | public function testResultContainsUsersByLoginTag($result) |
||
438 | |||
439 | /** |
||
440 | * @depends testLoadRootResource |
||
441 | */ |
||
442 | public function testResultContainsUsersByLoginTagAttributes($result) |
||
457 | |||
458 | /** |
||
459 | * @depends testLoadRootResource |
||
460 | */ |
||
461 | public function testResultContainsRolesTag($result) |
||
472 | |||
473 | /** |
||
474 | * @depends testLoadRootResource |
||
475 | */ |
||
476 | public function testResultContainsRolesTagAttributes($result) |
||
491 | |||
492 | /** |
||
493 | * @depends testLoadRootResource |
||
494 | */ |
||
495 | public function testResultContainsRootLocationTag($result) |
||
506 | |||
507 | /** |
||
508 | * @depends testLoadRootResource |
||
509 | */ |
||
510 | public function testResultContainsRootLocationTagAttributes($result) |
||
525 | |||
526 | /** |
||
527 | * @depends testLoadRootResource |
||
528 | */ |
||
529 | public function testResultContainsRootUserGroupTag($result) |
||
540 | |||
541 | /** |
||
542 | * @depends testLoadRootResource |
||
543 | */ |
||
544 | public function testResultContainsRootUserGroupTagAttributes($result) |
||
559 | |||
560 | /** |
||
561 | * @depends testLoadRootResource |
||
562 | */ |
||
563 | public function testResultContainsRootMediaFolderTag($result) |
||
574 | |||
575 | /** |
||
576 | * @depends testLoadRootResource |
||
577 | */ |
||
578 | public function testResultContainsRootMediaFolderTagAttributes($result) |
||
593 | |||
594 | /** |
||
595 | * @depends testLoadRootResource |
||
596 | */ |
||
597 | public function testResultContainsLocationByRemoteIdTag($result) |
||
608 | |||
609 | /** |
||
610 | * @depends testLoadRootResource |
||
611 | */ |
||
612 | public function testResultContainsLocationByRemoteIdTagAttributes($result) |
||
627 | |||
628 | /** |
||
629 | * @depends testLoadRootResource |
||
630 | */ |
||
631 | public function testResultContainsLocationByPathTag($result) |
||
642 | |||
643 | /** |
||
644 | * @depends testLoadRootResource |
||
645 | */ |
||
646 | public function testResultContainsLocationByPathTagAttributes($result) |
||
661 | |||
662 | /** |
||
663 | * @depends testLoadRootResource |
||
664 | */ |
||
665 | public function testResultContainsTrashTag($result) |
||
676 | |||
677 | /** |
||
678 | * @depends testLoadRootResource |
||
679 | */ |
||
680 | public function testResultContainsTrashTagAttributes($result) |
||
695 | |||
696 | /** |
||
697 | * @depends testLoadRootResource |
||
698 | */ |
||
699 | public function testResultContainsSectionsTag($result) |
||
710 | |||
711 | /** |
||
712 | * @depends testLoadRootResource |
||
713 | */ |
||
714 | public function testResultContainsSectionTagAttributes($result) |
||
729 | |||
730 | /** |
||
731 | * @depends testLoadRootResource |
||
732 | */ |
||
733 | public function testResultContainsViewsTag($result) |
||
744 | |||
745 | /** |
||
746 | * @depends testLoadRootResource |
||
747 | */ |
||
748 | public function testResultContainsViewsTagAttributes($result) |
||
763 | |||
764 | /** |
||
765 | * @depends testLoadRootResource |
||
766 | */ |
||
767 | public function testResultContainsObjectStateGroupsTag($result) |
||
778 | |||
779 | /** |
||
780 | * @depends testLoadRootResource |
||
781 | */ |
||
782 | public function testResultContainsObjectStateGroupsTagAttributes($result) |
||
797 | |||
798 | /** |
||
799 | * @depends testLoadRootResource |
||
800 | */ |
||
801 | public function testResultContainsObjectStatesTag($result) |
||
812 | |||
813 | /** |
||
814 | * @depends testLoadRootResource |
||
815 | */ |
||
816 | public function testResultContainsObjectStatesTagAttributes($result) |
||
831 | |||
832 | /** |
||
833 | * @depends testLoadRootResource |
||
834 | */ |
||
835 | public function testResultContainsGlobalUrlAliasesTag($result) |
||
846 | |||
847 | /** |
||
848 | * @depends testLoadRootResource |
||
849 | */ |
||
850 | public function testResultContainsGlobalUrlAliasesTagAttributes($result) |
||
865 | |||
866 | /** |
||
867 | * @depends testLoadRootResource |
||
868 | */ |
||
869 | public function testResultContainsUrlWildcardsTag($result) |
||
880 | |||
881 | /** |
||
882 | * @depends testLoadRootResource |
||
883 | */ |
||
884 | public function testResultContainsUrlWildcardsTagAttributes($result) |
||
899 | |||
900 | /** |
||
901 | * @depends testLoadRootResource |
||
902 | */ |
||
903 | public function testResultContainsCreateSessionTag($result) |
||
914 | |||
915 | /** |
||
916 | * @depends testLoadRootResource |
||
917 | */ |
||
918 | public function testResultContainsCreateSessionTagAttributes($result) |
||
933 | |||
934 | /** |
||
935 | * @depends testLoadRootResource |
||
936 | */ |
||
937 | public function testResultContainsRefreshSessionTag($result) |
||
948 | |||
949 | /** |
||
950 | * @depends testLoadRootResource |
||
951 | */ |
||
952 | public function testResultContainsRefreshSessionTagAttributes($result) |
||
967 | |||
968 | public function getRandomUriSet() |
||
976 | } |
||
977 |
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.