ezsystems / ezpublish-kernel

eZ/Publish/Core/MVC/Symfony/FieldType/ImageAsset/ParameterProvider.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 namespace eZ\Publish\Core\MVC\Symfony\FieldType\ImageAsset;
 
 use eZ\Publish\API\Repository\ContentService;
-use eZ\Publish\API\Repository\Exceptions\NotFoundException;
 use eZ\Publish\API\Repository\Exceptions\UnauthorizedException;
 use eZ\Publish\API\Repository\Values\Content\Field;
 use eZ\Publish\Core\MVC\Symfony\FieldType\View\ParameterProviderInterface;

eZ/Publish/Core/Repository/Tests/Service/Mock/Base.php

Doc Comments +2 added lines, -2 removed lines

@@ -139,7 +139,7 @@ 
     }
 
     /**
-     * @return \PHPUnit\Framework\MockObject\MockObject|\eZ\Publish\Core\Repository\Helper\ContentTypeDomainMapper
+     * @return ContentTypeDomainMapper
      */
     protected function getContentTypeDomainMapperMock()
     {
@@ -250,7 +250,7 @@ 
      *
      * @param int $id
      *
-     * @return \eZ\Publish\API\Repository\Values\User\User
+     * @return null|\eZ\Publish\API\Repository\Values\User\UserReference
      */
     protected function getStubbedUser($id)
     {

eZ/Publish/API/Repository/Tests/URLAliasServiceTest.php

Doc Comments +5 added lines, -1 removed lines

@@ -1270,7 +1270,7 @@ 
 
     /**
      * @param \eZ\Publish\API\Repository\Values\Content\ContentInfo $contentInfo
-     * @param $fieldDefinitionIdentifier
+     * @param string $fieldDefinitionIdentifier
      * @param array $fieldValues
      *
      * @return \eZ\Publish\API\Repository\Values\Content\Content
@@ -1387,6 +1387,10 @@ 
         $contentTypeService->publishContentTypeDraft($contentTypeDraft);
     }
 
+    /**
+     * @param string $expectedPath
+     * @param boolean $expectedIsHistory
+     */
     private function assertUrlAliasPropertiesCorrect(
         Location $expectedDestinationLocation,
         $expectedPath,

eZ/Publish/Core/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php

Doc Comments +24 added lines, -21 removed lines

@@ -95,7 +95,7 @@ 
      *
      * @todo optimize
      *
-     * @param mixed $remoteId
+     * @param string $remoteId
      *
      * @return array
      */
@@ -249,7 +249,7 @@ 
     /**
      * Returns data for the first level children of the location identified by given $locationId.
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      *
      * @return array
      */
@@ -376,6 +376,9 @@ 
         }
     }
 
+    /**
+     * @param string $pathString
+     */
     private function isHiddenByParent($pathString, array $rows)
     {
         $parentNodeIds = explode('/', trim($pathString, '/'));
@@ -576,10 +579,10 @@ 
      * Make the location identified by $locationId1 refer to the Content
      * referred to by $locationId2 and vice versa.
      *
-     * @param mixed $locationId1
-     * @param mixed $locationId2
+     * @param integer $locationId1
+     * @param integer $locationId2
      *
-     * @return bool
+     * @return boolean|null
      */
     public function swap($locationId1, $locationId2)
     {
@@ -736,7 +739,7 @@ 
      * Create an entry in the node assignment table.
      *
      * @param \eZ\Publish\SPI\Persistence\Content\Location\CreateStruct $createStruct
-     * @param mixed $parentNodeId
+     * @param string $parentNodeId
      * @param int $type
      */
     public function createNodeAssignment(CreateStruct $createStruct, $parentNodeId, $type = self::NODE_ASSIGNMENT_OP_CODE_CREATE_NOP)
@@ -864,8 +867,8 @@ 
      *
      * Convert existing node assignments into real locations.
      *
-     * @param mixed $contentId
-     * @param mixed $versionNo
+     * @param integer $contentId
+     * @param integer $versionNo
      */
     public function createLocationsFromNodeAssignments($contentId, $versionNo)
     {
@@ -933,8 +936,8 @@ 
     /**
      * Updates all Locations of content identified with $contentId with $versionNo.
      *
-     * @param mixed $contentId
-     * @param mixed $versionNo
+     * @param integer $contentId
+     * @param integer $versionNo
      */
     public function updateLocationsContentVersionNo($contentId, $versionNo)
     {
@@ -1093,8 +1096,8 @@ 
      * the node identified by given $locationId (current main node).
      * Assumes that content has more than one location.
      *
-     * @param mixed $contentId
-     * @param mixed $locationId
+     * @param integer $contentId
+     * @param integer $locationId
      *
      * @return array
      */
@@ -1130,9 +1133,9 @@ 
      *
      * The associated content object is left untouched.
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      *
-     * @return bool
+     * @return boolean|null
      */
     public function trashLocation($locationId)
     {
@@ -1161,8 +1164,8 @@ 
      * at the old position. If this is not possible ( because the old location
      * does not exist any more) and exception is thrown.
      *
-     * @param mixed $locationId
-     * @param mixed|null $newParentId
+     * @param integer $locationId
+     * @param integer $newParentId
      *
      * @return \eZ\Publish\SPI\Persistence\Content\Location
      */
@@ -1415,10 +1418,10 @@ 
      * Updates ezcontentobject_tree table for the given $contentId and eznode_assignment table for the given
      * $contentId, $parentLocationId and $versionNo
      *
-     * @param mixed $contentId
-     * @param mixed $locationId
-     * @param mixed $versionNo version number, needed to update eznode_assignment table
-     * @param mixed $parentLocationId parent location of location identified by $locationId, needed to update
+     * @param integer $contentId
+     * @param integer $locationId
+     * @param integer $versionNo version number, needed to update eznode_assignment table
+     * @param integer $parentLocationId parent location of location identified by $locationId, needed to update
      *        eznode_assignment table
      */
     public function changeMainLocation($contentId, $locationId, $versionNo, $parentLocationId)
@@ -1546,7 +1549,7 @@ 
     /**
      * Get Query Builder for fetching data of all Locations except the Root node.
      *
-     * @param array $columns list of columns to fetch
+     * @param string[] $columns list of columns to fetch
      *
      * @return \Doctrine\DBAL\Query\QueryBuilder
      */

eZ/Publish/Core/Repository/Tests/Service/Mock/UrlAliasTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -3803,7 +3803,7 @@
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|\eZ\Publish\Core\Repository\Helper\NameSchemaService
+     * @return NameSchemaService
      */
     protected function getNameSchemaServiceMock()
     {

eZ/Publish/Core/Search/Legacy/Tests/Content/AbstractTestCase.php

Doc Comments +1 added lines

@@ -56,6 +56,7 @@
 
     /**
      * Assert that the elements are.
+     * @param \eZ\Publish\API\Repository\Values\Content\Search\SearchResult $searchResult
      */
     protected function assertSearchResults($expectedIds, $searchResult)
     {

eZ/Publish/Core/Search/Legacy/Tests/Content/HandlerContentSortTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -93,7 +93,7 @@ 
     /**
      * Returns a content mapper mock.
      *
-     * @return \eZ\Publish\Core\Persistence\Legacy\Content\Mapper
+     * @return \PHPUnit\Framework\MockObject\MockObject
      */
     protected function getContentMapperMock()
     {
@@ -149,7 +149,7 @@ 
     /**
      * Returns a content field handler mock.
      *
-     * @return \eZ\Publish\Core\Persistence\Legacy\Content\FieldHandler
+     * @return \PHPUnit\Framework\MockObject\MockObject
      */
     protected function getContentFieldHandlerMock()
     {

eZ/Publish/Core/Search/Legacy/Tests/Content/HandlerLocationSortTest.php

Doc Comments +8 added lines, -1 removed lines

@@ -28,9 +28,16 @@ 
  */
 class HandlerLocationSortTest extends AbstractTestCase
 {
+    /**
+     * @param \eZ\Publish\API\Repository\Values\Content\Search\SearchResult $searchResult
+     */
     protected function getIds($searchResult)
     {
         $ids = array_map(
+
+            /**
+             * @param \eZ\Publish\API\Repository\Values\Content\Search\SearchResult $hit
+             */
             function ($hit) {
                 return $hit->valueObject->id;
             },
@@ -106,7 +113,7 @@ 
     /**
      * Returns a location mapper mock.
      *
-     * @return \eZ\Publish\Core\Persistence\Legacy\Content\Location\Mapper
+     * @return \PHPUnit\Framework\MockObject\MockObject
      */
     protected function getLocationMapperMock()
     {

eZ/Publish/Core/Search/Legacy/Tests/Content/HandlerLocationTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -166,7 +166,7 @@
     /**
      * Returns a location mapper mock.
      *
-     * @return \eZ\Publish\Core\Persistence\Legacy\Content\Location\Mapper
+     * @return \PHPUnit\Framework\MockObject\MockObject
      */
     protected function getLocationMapperMock()
     {