ezsystems /
ezpublish-kernel
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like EzPublishCoreExtension often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use EzPublishCoreExtension, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 28 | class EzPublishCoreExtension extends Extension |
||
| 29 | { |
||
| 30 | const RICHTEXT_CUSTOM_STYLES_PARAMETER = 'ezplatform.ezrichtext.custom_styles'; |
||
| 31 | const RICHTEXT_CUSTOM_TAGS_PARAMETER = 'ezplatform.ezrichtext.custom_tags'; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * @var \eZ\Bundle\EzPublishCoreBundle\DependencyInjection\Configuration\Suggestion\Collector\SuggestionCollector |
||
| 35 | */ |
||
| 36 | private $suggestionCollector; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * @var \eZ\Bundle\EzPublishCoreBundle\DependencyInjection\Configuration\ParserInterface |
||
| 40 | */ |
||
| 41 | private $mainConfigParser; |
||
| 42 | |||
| 43 | /** |
||
| 44 | * @var \eZ\Bundle\EzPublishCoreBundle\DependencyInjection\Configuration\ParserInterface[] |
||
| 45 | */ |
||
| 46 | private $configParsers; |
||
| 47 | |||
| 48 | /** |
||
| 49 | * @var PolicyProviderInterface[] |
||
| 50 | */ |
||
| 51 | private $policyProviders = []; |
||
| 52 | |||
| 53 | /** |
||
| 54 | * Holds a collection of YAML files, as an array with directory path as a |
||
| 55 | * key to the array of contained file names. |
||
| 56 | * |
||
| 57 | * @var array |
||
| 58 | */ |
||
| 59 | private $defaultSettingsCollection = []; |
||
| 60 | |||
| 61 | /** |
||
| 62 | * @var \eZ\Bundle\EzPublishCoreBundle\SiteAccess\SiteAccessConfigurationFilter[] |
||
| 63 | */ |
||
| 64 | private $siteaccessConfigurationFilters = []; |
||
| 65 | |||
| 66 | public function __construct(array $configParsers = array()) |
||
| 71 | |||
| 72 | public function getAlias() |
||
| 76 | |||
| 77 | /** |
||
| 78 | * Loads a specific configuration. |
||
| 79 | * |
||
| 80 | * @param mixed[] $configs An array of configuration values |
||
| 81 | * @param \Symfony\Component\DependencyInjection\ContainerBuilder $container A ContainerBuilder instance |
||
| 82 | * |
||
| 83 | * @throws \InvalidArgumentException When provided tag is not defined in this extension |
||
| 84 | * |
||
| 85 | * @api |
||
| 86 | */ |
||
| 87 | public function load(array $configs, ContainerBuilder $container) |
||
| 147 | |||
| 148 | /** |
||
| 149 | * @param array $config |
||
| 150 | * @param \Symfony\Component\DependencyInjection\ContainerBuilder $container |
||
| 151 | * |
||
| 152 | * @return \eZ\Bundle\EzPublishCoreBundle\DependencyInjection\Configuration |
||
| 153 | */ |
||
| 154 | public function getConfiguration(array $config, ContainerBuilder $container) |
||
| 161 | |||
| 162 | /** |
||
| 163 | * @return \eZ\Bundle\EzPublishCoreBundle\DependencyInjection\Configuration\ParserInterface |
||
| 164 | */ |
||
| 165 | private function getMainConfigParser() |
||
| 179 | |||
| 180 | /** |
||
| 181 | * Handle default settings. |
||
| 182 | * |
||
| 183 | * @param \Symfony\Component\DependencyInjection\ContainerBuilder $container |
||
| 184 | * @param \Symfony\Component\DependencyInjection\Loader\FileLoader $loader |
||
| 185 | * |
||
| 186 | * @throws \Exception |
||
| 187 | */ |
||
| 188 | private function handleDefaultSettingsLoading(ContainerBuilder $container, FileLoader $loader) |
||
| 203 | |||
| 204 | private function registerRepositoriesConfiguration(array $config, ContainerBuilder $container) |
||
| 218 | |||
| 219 | private function registerSiteAccessConfiguration(array $config, ContainerBuilder $container) |
||
| 249 | |||
| 250 | private function registerImageMagickConfiguration(array $config, ContainerBuilder $container) |
||
| 264 | |||
| 265 | private function registerPageConfiguration(array $config, ContainerBuilder $container) |
||
| 292 | |||
| 293 | /** |
||
| 294 | * Register parameters of global RichText configuration. |
||
| 295 | * |
||
| 296 | * @param array $config |
||
| 297 | * @param \Symfony\Component\DependencyInjection\ContainerBuilder $container |
||
| 298 | */ |
||
| 299 | private function registerRichTextConfiguration(array $config, ContainerBuilder $container) |
||
| 324 | |||
| 325 | /** |
||
| 326 | * Handle routing parameters. |
||
| 327 | * |
||
| 328 | * @param array $config |
||
| 329 | * @param \Symfony\Component\DependencyInjection\ContainerBuilder $container |
||
| 330 | * @param \Symfony\Component\DependencyInjection\Loader\FileLoader $loader |
||
| 331 | */ |
||
| 332 | private function handleRouting(array $config, ContainerBuilder $container, FileLoader $loader) |
||
| 347 | |||
| 348 | /** |
||
| 349 | * Handle public API loading. |
||
| 350 | * |
||
| 351 | * @param \Symfony\Component\DependencyInjection\ContainerBuilder $container |
||
| 352 | * @param \Symfony\Component\DependencyInjection\Loader\FileLoader $loader |
||
| 353 | */ |
||
| 354 | private function handleApiLoading(ContainerBuilder $container, FileLoader $loader) |
||
| 399 | |||
| 400 | /** |
||
| 401 | * Handle templating parameters. |
||
| 402 | * |
||
| 403 | * @param \Symfony\Component\DependencyInjection\ContainerBuilder $container |
||
| 404 | * @param \Symfony\Component\DependencyInjection\Loader\FileLoader $loader |
||
| 405 | */ |
||
| 406 | private function handleTemplating(ContainerBuilder $container, FileLoader $loader) |
||
| 410 | |||
| 411 | /** |
||
| 412 | * Handle session parameters. |
||
| 413 | * |
||
| 414 | * @param \Symfony\Component\DependencyInjection\ContainerBuilder $container |
||
| 415 | * @param \Symfony\Component\DependencyInjection\Loader\FileLoader $loader |
||
| 416 | */ |
||
| 417 | private function handleSessionLoading(ContainerBuilder $container, FileLoader $loader) |
||
| 421 | |||
| 422 | /** |
||
| 423 | * Handle cache parameters. |
||
| 424 | * |
||
| 425 | * @param array $config |
||
| 426 | * @param \Symfony\Component\DependencyInjection\ContainerBuilder $container |
||
| 427 | * @param \Symfony\Component\DependencyInjection\Loader\FileLoader $loader |
||
| 428 | * |
||
| 429 | * @throws \InvalidArgumentException |
||
| 430 | */ |
||
| 431 | private function handleCache(array $config, ContainerBuilder $container, FileLoader $loader) |
||
| 440 | |||
| 441 | /** |
||
| 442 | * Handle locale parameters. |
||
| 443 | * |
||
| 444 | * @param array $config |
||
| 445 | * @param \Symfony\Component\DependencyInjection\ContainerBuilder $container |
||
| 446 | * @param \Symfony\Component\DependencyInjection\Loader\FileLoader $loader |
||
| 447 | */ |
||
| 448 | private function handleLocale(array $config, ContainerBuilder $container, FileLoader $loader) |
||
| 456 | |||
| 457 | /** |
||
| 458 | * Handle helpers. |
||
| 459 | * |
||
| 460 | * @param array $config |
||
| 461 | * @param \Symfony\Component\DependencyInjection\ContainerBuilder $container |
||
| 462 | * @param \Symfony\Component\DependencyInjection\Loader\FileLoader $loader |
||
| 463 | */ |
||
| 464 | private function handleHelpers(array $config, ContainerBuilder $container, FileLoader $loader) |
||
| 468 | |||
| 469 | /** |
||
| 470 | * Handles relation between SiteAccesses. |
||
| 471 | * Related SiteAccesses share the same repository and root location id. |
||
| 472 | * |
||
| 473 | * @param \Symfony\Component\DependencyInjection\ContainerBuilder $container |
||
| 474 | */ |
||
| 475 | private function handleSiteAccessesRelation(ContainerBuilder $container) |
||
| 507 | |||
| 508 | /** |
||
| 509 | * @param array $config |
||
| 510 | * @param \Symfony\Component\DependencyInjection\ContainerBuilder $container |
||
| 511 | * @param \Symfony\Component\DependencyInjection\Loader\FileLoader $loader |
||
| 512 | */ |
||
| 513 | private function handleImage(array $config, ContainerBuilder $container, FileLoader $loader) |
||
| 530 | |||
| 531 | private function handleUrlChecker($config, ContainerBuilder $container, FileLoader $loader) |
||
| 535 | |||
| 536 | private function buildPolicyMap(ContainerBuilder $container) |
||
| 543 | |||
| 544 | /** |
||
| 545 | * Adds a new policy provider to the internal collection. |
||
| 546 | * One can call this method from a bundle `build()` method. |
||
| 547 | * |
||
| 548 | * ```php |
||
| 549 | * public function build(ContainerBuilder $container) |
||
| 550 | * { |
||
| 551 | * $ezExtension = $container->getExtension('ezpublish'); |
||
| 552 | * $ezExtension->addPolicyProvider($myPolicyProvider); |
||
| 553 | * } |
||
| 554 | * ``` |
||
| 555 | * |
||
| 556 | * @since 6.0 |
||
| 557 | * |
||
| 558 | * @param PolicyProviderInterface $policyProvider |
||
| 559 | */ |
||
| 560 | public function addPolicyProvider(PolicyProviderInterface $policyProvider) |
||
| 564 | |||
| 565 | /** |
||
| 566 | * Adds a new config parser to the internal collection. |
||
| 567 | * One can call this method from a bundle `build()` method. |
||
| 568 | * |
||
| 569 | * ```php |
||
| 570 | * public function build(ContainerBuilder $container) |
||
| 571 | * { |
||
| 572 | * $ezExtension = $container->getExtension('ezpublish'); |
||
| 573 | * $ezExtension->addConfigParser($myConfigParser); |
||
| 574 | * } |
||
| 575 | * ``` |
||
| 576 | * |
||
| 577 | * @since 6.0 |
||
| 578 | * |
||
| 579 | * @param \eZ\Bundle\EzPublishCoreBundle\DependencyInjection\Configuration\ParserInterface $configParser |
||
| 580 | */ |
||
| 581 | public function addConfigParser(ParserInterface $configParser) |
||
| 585 | |||
| 586 | /** |
||
| 587 | * Adds new default settings to the internal collection. |
||
| 588 | * One can call this method from a bundle `build()` method. |
||
| 589 | * |
||
| 590 | * ```php |
||
| 591 | * public function build(ContainerBuilder $container) |
||
| 592 | * { |
||
| 593 | * $ezExtension = $container->getExtension('ezpublish'); |
||
| 594 | * $ezExtension->addDefaultSettings( |
||
| 595 | * __DIR__ . '/Resources/config', |
||
| 596 | * ['default_settings.yml'] |
||
| 597 | * ); |
||
| 598 | * } |
||
| 599 | * ``` |
||
| 600 | * |
||
| 601 | * @since 6.0 |
||
| 602 | * |
||
| 603 | * @param string $fileLocation |
||
| 604 | * @param array $files |
||
| 605 | */ |
||
| 606 | public function addDefaultSettings($fileLocation, array $files) |
||
| 610 | |||
| 611 | public function addSiteAccessConfigurationFilter(SiteAccessConfigurationFilter $filter) |
||
| 615 | |||
| 616 | /** |
||
| 617 | * @param array $config |
||
| 618 | * @param \Symfony\Component\DependencyInjection\ContainerBuilder $container |
||
| 619 | */ |
||
| 620 | private function registerUrlAliasConfiguration(array $config, ContainerBuilder $container) |
||
| 628 | |||
| 629 | private function isRichTextBundleEnabled(ContainerBuilder $container) |
||
| 637 | } |
||
| 638 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.