ISBNTest::testToFieldDefinition() - Code Metrics - Inspection of "Fix EZP-27152: show REST exceptions in Symfony pro..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — ezp27152-rest_exception_symfon... ( d7d9ca...5c9060 )

by André

created 2017-08-01 10:46 UTC

ISBNTest::testToFieldDefinition() A

↳ Parent: ISBNTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	7
c	1
b	0
f	0
nc	1
nop	2
dl	0
loc	13
rs	9.4285

<?php

/**
 * File containing the ISBNTest class.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Publish\Core\Persistence\Legacy\Tests\Content\FieldValue\Converter;

use eZ\Publish\Core\FieldType\FieldSettings;
use eZ\Publish\Core\Persistence\Legacy\Content\FieldValue\Converter\ISBNConverter;
use eZ\Publish\Core\Persistence\Legacy\Content\StorageFieldDefinition;
use eZ\Publish\SPI\Persistence\Content\Type\FieldDefinition as PersistenceFieldDefinition;
use PHPUnit\Framework\TestCase;

/**
 * Test for ISBNConverter in Legacy Storage.
 */
class ISBNTest extends TestCase
{
    /**
     * @var \eZ\Publish\Core\Persistence\Legacy\Content\FieldValue\Converter\ISBNConverter
     */
    protected $converter;

    protected function setUp()
    {
        $this->converter = new ISBNConverter();
    }

    /**
     * @dataProvider providerForTestToFieldDefinition
     *
     * @covers \eZ\Publish\Core\Persistence\Legacy\Content\FieldValue\Converter\ISBNConverter::toFieldDefinition
     */
    public function testToFieldDefinition($dataInt, $excpectedIsbn13Value)
    {
        $fieldDef = new PersistenceFieldDefinition();
        $storageDefinition = new StorageFieldDefinition([
            'dataInt1' => $dataInt,
        ]);

        $this->converter->toFieldDefinition($storageDefinition, $fieldDef);

        /** @var FieldSettings $fieldSettings */
        $fieldSettings = $fieldDef->fieldTypeConstraints->fieldSettings;
        self::assertSame($excpectedIsbn13Value, $fieldSettings['isISBN13']);
    }

    public function providerForTestToFieldDefinition()
    {
        return [
            [1, true],
            [0, false],
            [null, false],
        ];
    }
}


1		<?php
2
3		/**
4		* File containing the ISBNTest class.
5		*
6		* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7		* @license For full copyright and license information view LICENSE file distributed with this source code.
8		*/
9		namespace eZ\Publish\Core\Persistence\Legacy\Tests\Content\FieldValue\Converter;
10
11		use eZ\Publish\Core\FieldType\FieldSettings;
12		use eZ\Publish\Core\Persistence\Legacy\Content\FieldValue\Converter\ISBNConverter;
13		use eZ\Publish\Core\Persistence\Legacy\Content\StorageFieldDefinition;
14		use eZ\Publish\SPI\Persistence\Content\Type\FieldDefinition as PersistenceFieldDefinition;
15		use PHPUnit\Framework\TestCase;
16
17		/**
18		* Test for ISBNConverter in Legacy Storage.
19		*/
20		class ISBNTest extends TestCase
21		{
22		/**
23		* @var \eZ\Publish\Core\Persistence\Legacy\Content\FieldValue\Converter\ISBNConverter
24		*/
25		protected $converter;
26
27		protected function setUp()
28		{
29		$this->converter = new ISBNConverter();
30		}
31
32		/**
33		* @dataProvider providerForTestToFieldDefinition
34		*
35		* @covers \eZ\Publish\Core\Persistence\Legacy\Content\FieldValue\Converter\ISBNConverter::toFieldDefinition
36		*/
37		public function testToFieldDefinition($dataInt, $excpectedIsbn13Value)
38		{
39		$fieldDef = new PersistenceFieldDefinition();
40		$storageDefinition = new StorageFieldDefinition([
41		'dataInt1' => $dataInt,
42		]);
43
44		$this->converter->toFieldDefinition($storageDefinition, $fieldDef);
45
46		/** @var FieldSettings $fieldSettings */
47		$fieldSettings = $fieldDef->fieldTypeConstraints->fieldSettings;
48		self::assertSame($excpectedIsbn13Value, $fieldSettings['isISBN13']);
49		}
50
51	View Code Duplication	public function providerForTestToFieldDefinition()
52		{
53		return [
54		[1, true],
55		[0, false],
56		[null, false],
57		];
58		}
59		}
60

ezsystems / ezpublish-kernel

Push — ezp27152-rest_exception_symfon... ( d7d9ca...5c9060 )

ISBNTest::testToFieldDefinition() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like