ObjectStateTest::testMissingProperty() - Code Metrics - Inspection of "Merge pull request #1878 from alongosz/ezp-20057-r..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7c0e42...8c347f )

by André

created 2017-01-25 10:06 UTC

ObjectStateTest::testMissingProperty() A

↳ Parent: ObjectStateTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	6
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	0
dl	6
loc	6
rs	9.4285
c	0
b	0
f	0

<?php

/**
 * This file is part of the eZ Publish Kernel package.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Publish\Core\Repository\Tests\Values\ObjectState;

use eZ\Publish\API\Repository\Tests\Values\ValueObjectTestTrait;
use eZ\Publish\Core\Repository\Values\ObjectState\ObjectState;
use PHPUnit_Framework_TestCase;

/**
 * Test internal integrity of @see \eZ\Publish\Core\Repository\Values\ObjectState\ObjectState ValueObject.
 */
class ObjectStateTest extends PHPUnit_Framework_TestCase

{
    use ValueObjectTestTrait;

    /**
     * Test a new class and default values on properties.
     *
     * @covers \eZ\Publish\API\Repository\Values\ObjectState\ObjectState::__construct
     */
    public function testNewClass()
    {
        $objectState = new ObjectState();

        $this->assertPropertiesCorrect(
            [
                'id' => null,
                'identifier' => null,
                'priority' => null,
                'defaultLanguageCode' => null,
                'languageCodes' => null,
                'names' => [],
                'descriptions' => [],
            ],
            $objectState
        );
    }

    /**
     * Test retrieving missing property.
     *
     * @covers \eZ\Publish\API\Repository\Values\ObjectState\ObjectState::__get
     * @covers \eZ\Publish\API\Repository\Values\ObjectState\ObjectStateGroup::__get
     * @expectedException \eZ\Publish\API\Repository\Exceptions\PropertyNotFoundException
     */
    public function testMissingProperty()
    {
        $objectState = new ObjectState();
        $value = $objectState->notDefined;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->fail('Succeeded getting non existing property');
    }

    /**
     * Test setting read only property.
     *
     * @covers \eZ\Publish\API\Repository\Values\ObjectState\ObjectState::__set
     * @covers \eZ\Publish\API\Repository\Values\ObjectState\ObjectStateGroup::__set
     * @expectedException \eZ\Publish\API\Repository\Exceptions\PropertyReadOnlyException
     */
    public function testReadOnlyProperty()
    {
        $objectState = new ObjectState();
        $objectState->id = 42;
        $this->fail('Succeeded setting read only property');
    }

    /**
     * Test if property exists.
     *
     * @covers \eZ\Publish\API\Repository\Values\ObjectState\ObjectState::__isset
     * @covers \eZ\Publish\API\Repository\Values\ObjectState\ObjectStateGroup::__isset
     */
    public function testIsPropertySet()
    {
        $objectState = new ObjectState();
        $value = isset($objectState->notDefined);
        $this->assertEquals(false, $value);

        $value = isset($objectState->id);
        $this->assertEquals(true, $value);
    }

    /**
     * Test unsetting a property.
     *
     * @covers \eZ\Publish\API\Repository\Values\ObjectState\ObjectState::__unset
     * @covers \eZ\Publish\API\Repository\Values\ObjectState\ObjectStateGroup::__unset
     * @expectedException \eZ\Publish\API\Repository\Exceptions\PropertyReadOnlyException
     */
    public function testUnsetProperty()
    {
        $objectState = new ObjectState(array('id' => 2));
        unset($objectState->id);
        $this->fail('Unsetting read-only property succeeded');
    }
}


1		<?php
2
3		/**
4		* This file is part of the eZ Publish Kernel package.
5		*
6		* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7		* @license For full copyright and license information view LICENSE file distributed with this source code.
8		*/
9		namespace eZ\Publish\Core\Repository\Tests\Values\ObjectState;
10
11		use eZ\Publish\API\Repository\Tests\Values\ValueObjectTestTrait;
12		use eZ\Publish\Core\Repository\Values\ObjectState\ObjectState;
13		use PHPUnit_Framework_TestCase;
14
15		/**
16		* Test internal integrity of @see \eZ\Publish\Core\Repository\Values\ObjectState\ObjectState ValueObject.
17		*/
18	View Code Duplication	class ObjectStateTest extends PHPUnit_Framework_TestCase
		0 ignored issues – show Duplication introduced 2017-01-25 10:19 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		{
20		use ValueObjectTestTrait;
21
22		/**
23		* Test a new class and default values on properties.
24		*
25		* @covers \eZ\Publish\API\Repository\Values\ObjectState\ObjectState::__construct
26		*/
27		public function testNewClass()
28		{
29		$objectState = new ObjectState();
30
31		$this->assertPropertiesCorrect(
32		[
33		'id' => null,
34		'identifier' => null,
35		'priority' => null,
36		'defaultLanguageCode' => null,
37		'languageCodes' => null,
38		'names' => [],
39		'descriptions' => [],
40		],
41		$objectState
42		);
43		}
44
45		/**
46		* Test retrieving missing property.
47		*
48		* @covers \eZ\Publish\API\Repository\Values\ObjectState\ObjectState::__get
49		* @covers \eZ\Publish\API\Repository\Values\ObjectState\ObjectStateGroup::__get
50		* @expectedException \eZ\Publish\API\Repository\Exceptions\PropertyNotFoundException
51		*/
52		public function testMissingProperty()
53		{
54		$objectState = new ObjectState();
55		$value = $objectState->notDefined;
		0 ignored issues – show Documentation introduced 2017-01-25 10:19 UTC by Report Bug Copy Issue Report The property `notDefined` does not exist on `object<eZ\Publish\Core\R...bjectState\ObjectState>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Unused Code introduced 2017-01-25 10:19 UTC by Report Bug Copy Issue Report `$value` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
56		$this->fail('Succeeded getting non existing property');
57		}
58
59		/**
60		* Test setting read only property.
61		*
62		* @covers \eZ\Publish\API\Repository\Values\ObjectState\ObjectState::__set
63		* @covers \eZ\Publish\API\Repository\Values\ObjectState\ObjectStateGroup::__set
64		* @expectedException \eZ\Publish\API\Repository\Exceptions\PropertyReadOnlyException
65		*/
66		public function testReadOnlyProperty()
67		{
68		$objectState = new ObjectState();
69		$objectState->id = 42;
70		$this->fail('Succeeded setting read only property');
71		}
72
73		/**
74		* Test if property exists.
75		*
76		* @covers \eZ\Publish\API\Repository\Values\ObjectState\ObjectState::__isset
77		* @covers \eZ\Publish\API\Repository\Values\ObjectState\ObjectStateGroup::__isset
78		*/
79		public function testIsPropertySet()
80		{
81		$objectState = new ObjectState();
82		$value = isset($objectState->notDefined);
83		$this->assertEquals(false, $value);
84
85		$value = isset($objectState->id);
86		$this->assertEquals(true, $value);
87		}
88
89		/**
90		* Test unsetting a property.
91		*
92		* @covers \eZ\Publish\API\Repository\Values\ObjectState\ObjectState::__unset
93		* @covers \eZ\Publish\API\Repository\Values\ObjectState\ObjectStateGroup::__unset
94		* @expectedException \eZ\Publish\API\Repository\Exceptions\PropertyReadOnlyException
95		*/
96		public function testUnsetProperty()
97		{
98		$objectState = new ObjectState(array('id' => 2));
99		unset($objectState->id);
100		$this->fail('Unsetting read-only property succeeded');
101		}
102		}
103

ezsystems / ezpublish-kernel

Push — master ( 7c0e42...8c347f )

ObjectStateTest::testMissingProperty() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like