ezsystems / ezpublish-kernel

eZ/Publish/API/Repository/Tests/TrashServiceAuthorizationTest.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 namespace eZ\Publish\API\Repository\Tests;
 
 use eZ\Publish\API\Repository\Exceptions\UnauthorizedException;
-use eZ\Publish\API\Repository\Values\Content\Location;
 use eZ\Publish\API\Repository\Values\User\Limitation\ObjectStateLimitation;
 use eZ\Publish\Core\Repository\Repository;
 use eZ\Publish\Core\Repository\TrashService;

eZ/Publish/Core/Persistence/Legacy/Content/Type/Handler.php

Doc Comments +13 added lines, -14 removed lines

@@ -94,7 +94,7 @@ 
     }
 
     /**
-     * @param mixed $groupId
+     * @param integer $groupId
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\BadStateException If type group contains types
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException If type group with id is not found
@@ -175,7 +175,7 @@ 
     }
 
     /**
-     * @param mixed $groupId
+     * @param integer $groupId
      * @param int $status
      *
      * @return Type[]
@@ -237,7 +237,7 @@ 
      *
      * Note: This method is responsible of having the Field Definitions of the loaded ContentType sorted by placement.
      *
-     * @param mixed $remoteId
+     * @param string $remoteId
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException If defined type is not found
      *
@@ -338,7 +338,6 @@ 
     /**
      * @param mixed $typeId
      * @param int $status
-     * @param \eZ\Publish\SPI\Persistence\Content\Type\UpdateStruct $contentType
      *
      * @return Type
      */
@@ -355,7 +354,7 @@ 
     /**
      * @throws \eZ\Publish\API\Repository\Exceptions\BadStateException If type is defined and still has content
      *
-     * @param mixed $contentTypeId
+     * @param integer $contentTypeId
      * @param int $status
      *
      * @return bool
@@ -437,8 +436,8 @@ 
     /**
      * Unlink a content type group from a content type.
      *
-     * @param mixed $groupId
-     * @param mixed $contentTypeId
+     * @param integer $groupId
+     * @param integer $contentTypeId
      * @param int $status
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException If group or type with provided status is not found
@@ -462,8 +461,8 @@ 
     /**
      * Link a content type group with a content type.
      *
-     * @param mixed $groupId
-     * @param mixed $contentTypeId
+     * @param integer $groupId
+     * @param integer $contentTypeId
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException If group or type with provided status is not found
      * @throws \eZ\Publish\API\Repository\Exceptions\BadStateException If type is already part of group
@@ -509,7 +508,7 @@ 
     /**
      * Counts the number of Content instances of the ContentType identified by given $contentTypeId.
      *
-     * @param mixed $contentTypeId
+     * @param integer $contentTypeId
      *
      * @return int
      */
@@ -525,7 +524,7 @@ 
      * added. It does not update existing content objects depending on the
      * field (default) values.
      *
-     * @param mixed $contentTypeId
+     * @param integer $contentTypeId
      * @param int $status One of Type::STATUS_DEFINED|Type::STATUS_DRAFT|Type::STATUS_MODIFIED
      * @param \eZ\Publish\SPI\Persistence\Content\Type\FieldDefinition $fieldDefinition
      */
@@ -548,8 +547,8 @@ 
      * referred to by $fieldDefinitionId removed. It does not update existing
      * content objects depending on the field (default) values.
      *
-     * @param mixed $contentTypeId
-     * @param mixed $fieldDefinitionId
+     * @param integer $contentTypeId
+     * @param integer $fieldDefinitionId
      *
      * @return bool
      */
@@ -568,7 +567,7 @@ 
      * on the
      * field (default) values.
      *
-     * @param mixed $contentTypeId
+     * @param integer $contentTypeId
      * @param \eZ\Publish\SPI\Persistence\Content\Type\FieldDefinition $fieldDefinition
      */
     public function updateFieldDefinition($contentTypeId, $status, FieldDefinition $fieldDefinition)

eZ/Publish/Core/MVC/Symfony/Templating/Twig/Extension/FileSizeExtension.php

Doc Comments +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
     /**
      * Returns a list of filters to add to the existing list.
      *
-     * @return array An array of filters
+     * @return Twig_SimpleFilter[] An array of filters
      */
     public function getFilters()
     {

eZ/Bundle/EzPublishCoreBundle/Features/Context/ConsoleContext.php

Doc Comments +3 added lines

@@ -104,6 +104,9 @@
         $this->it['siteaccess'] = $this->scriptOutput;
     }
 
+    /**
+     * @param string $command
+     */
     private function iRunTheCommand($command, $siteaccess = null)
     {
         $phpFinder = new PhpExecutableFinder();

eZ/Publish/Core/Persistence/Cache/UrlAliasHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -383,7 +383,7 @@
      * @param \eZ\Publish\SPI\Persistence\Content\UrlAlias $urlAlias
      * @param array $tags Optional, can be used to specify other tags.
      *
-     * @return array
+     * @return string[]
      */
     private function getCacheTags(UrlAlias $urlAlias, array $tags = [])
     {

eZ/Publish/Core/Persistence/Legacy/Content/Handler.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 
 use Exception;
 use eZ\Publish\Core\Persistence\Legacy\Content\Location\Gateway as LocationGateway;
-use eZ\Publish\SPI\Persistence\Content\Field;
 use eZ\Publish\SPI\Persistence\Content\Handler as BaseContentHandler;
 use eZ\Publish\SPI\Persistence\Content\Type\Handler as ContentTypeHandler;
 use eZ\Publish\Core\Persistence\Legacy\Content\UrlAlias\SlugConverter;

Doc Comments +9 added lines, -9 removed lines

@@ -150,7 +150,7 @@ 
      * Will contain always a complete list of fields.
      *
      * @param \eZ\Publish\SPI\Persistence\Content\CreateStruct $struct Content creation struct.
-     * @param mixed $versionNo Used by self::copy() to maintain version numbers
+     * @param integer $versionNo Used by self::copy() to maintain version numbers
      *
      * @return \eZ\Publish\SPI\Persistence\Content Content value object
      */
@@ -437,7 +437,7 @@ 
     /**
      * Returns the metadata object for a content identified by $remoteId.
      *
-     * @param mixed $remoteId
+     * @param string $remoteId
      *
      * @return \eZ\Publish\SPI\Persistence\Content\ContentInfo
      */
@@ -634,7 +634,7 @@ 
      *
      * @param int $contentId
      *
-     * @return bool
+     * @return boolean|null
      */
     public function deleteContent($contentId)
     {
@@ -666,7 +666,7 @@ 
      * @param int $contentId
      * @param int $versionNo
      *
-     * @return bool
+     * @return boolean|null
      */
     public function deleteVersion($contentId, $versionNo)
     {
@@ -704,8 +704,8 @@ 
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException If content or version is not found
      *
-     * @param mixed $contentId
-     * @param mixed|null $versionNo Copy all versions if left null
+     * @param integer $contentId
+     * @param integer $versionNo Copy all versions if left null
      * @param int|null $newOwnerId
      *
      * @return \eZ\Publish\SPI\Persistence\Content
@@ -793,7 +793,7 @@ 
      *
      * @todo Should the existence verifications happen here or is this supposed to be handled at a higher level?
      *
-     * @param mixed $relationId
+     * @param integer $relationId
      * @param int $type {@see \eZ\Publish\API\Repository\Values\Content\Relation::COMMON,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::EMBED,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::LINK,
@@ -807,7 +807,7 @@ 
     /**
      * Loads relations from $sourceContentId. Optionally, loads only those with $type and $sourceContentVersionNo.
      *
-     * @param mixed $sourceContentId Source Content ID
+     * @param integer $sourceContentId Source Content ID
      * @param mixed|null $sourceContentVersionNo Source Content Version, null if not specified
      * @param int|null $type {@see \eZ\Publish\API\Repository\Values\Content\Relation::COMMON,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::EMBED,
@@ -836,7 +836,7 @@ 
      *
      * Only loads relations against published versions.
      *
-     * @param mixed $destinationContentId Destination Content ID
+     * @param integer $destinationContentId Destination Content ID
      * @param int|null $type {@see \eZ\Publish\API\Repository\Values\Content\Relation::COMMON,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::EMBED,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::LINK,

eZ/Publish/Core/Repository/ContentService.php

Doc Comments +4 added lines, -4 removed lines

@@ -1416,7 +1416,7 @@ 
      *
      * @param \eZ\Publish\API\Repository\Values\Content\ContentUpdateStruct $contentUpdateStruct
      *
-     * @return array
+     * @return string[]
      */
     private function getUpdatedLanguageCodes(APIContentUpdateStruct $contentUpdateStruct)
     {
@@ -1443,7 +1443,7 @@ 
      * @param \eZ\Publish\API\Repository\Values\Content\ContentUpdateStruct $contentUpdateStruct
      * @param \eZ\Publish\API\Repository\Values\Content\Content $content
      *
-     * @return array
+     * @return string[]
      */
     protected function getLanguageCodesForUpdate(APIContentUpdateStruct $contentUpdateStruct, APIContent $content)
     {
@@ -1572,7 +1572,7 @@ 
 
     /**
      * @param \eZ\Publish\API\Repository\Values\Content\VersionInfo $versionInfo
-     * @param array $translations
+     * @param string[] $translations
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\BadStateException
      * @throws \eZ\Publish\API\Repository\Exceptions\ContentFieldValidationException
@@ -1642,7 +1642,7 @@ 
      * @param \eZ\Publish\API\Repository\Values\Content\VersionInfo $versionInfo
      * @param int|null $publicationDate If null existing date is kept if there is one, otherwise current time is used.
      *
-     * @return \eZ\Publish\API\Repository\Values\Content\Content
+     * @return LocationCreateStruct
      */
     protected function internalPublishVersion(APIVersionInfo $versionInfo, $publicationDate = null)
     {

eZ/Bundle/EzPublishCoreBundle/Features/Context/UserContext.php

Doc Comments +11 added lines, -8 removed lines

@@ -62,9 +62,9 @@ 
      * Search User with given username, optionally at given location.
      *
      * @param string $username name of User to search for
-     * @param string $parentGroupLocationId where to search, in User Group tree
+     * @param string $parentGroupId where to search, in User Group tree
      *
-     * @return User found
+     * @return null|\eZ\Publish\API\Repository\Values\User\User found
      */
     public function searchUserByLogin($username, $parentGroupId = null)
     {
@@ -95,7 +95,7 @@ 
      * @param string $name name of User Group to search for
      * @param string $parentLocationId (optional) parent location id to search in
      *
-     * @return search results
+     * @return \eZ\Publish\API\Repository\Values\Content\Search\SearchHit[] results
      */
     public function searchUserGroups($name, $parentLocationId = null)
     {
@@ -118,12 +118,12 @@ 
     /**
      * Create user inside given User Group; DELETES existing User if login already exists!
      *
-     * @param $username username of the user to create
-     * @param $email email address of user to create
-     * @param $password account password for user to create
-     * @param $parentGroup pathstring wherein to create user
+     * @param string $username username of the user to create
+     * @param string $email email address of user to create
+     * @param string $password account password for user to create
+     * @param \eZ\Publish\API\Repository\Values\User\UserGroup $parentGroup pathstring wherein to create user
      *
-     * @return eZ\Publish\API\Repository\Values\User\User
+     * @return \eZ\Publish\API\Repository\Values\User\User
      */
     protected function createUser($username, $email, $password, $parentGroup = null, $fields = [])
     {
@@ -317,6 +317,9 @@ 
         return false;
     }
 
+    /**
+     * @param integer $type
+     */
     public function createPasswordHash($login, $password, $type)
     {
         switch ($type) {

eZ/Publish/API/Repository/Tests/BaseTest.php

Doc Comments +1 added lines, -2 removed lines

@@ -215,7 +215,6 @@ 
      *
      * @param \eZ\Publish\API\Repository\Values\ValueObject $expectedValues
      * @param \eZ\Publish\API\Repository\Values\ValueObject $actualObject
-     * @param array $propertyNames
      */
     protected function assertStructPropertiesCorrect(ValueObject $expectedValues, ValueObject $actualObject, array $additionalProperties = [])
     {
@@ -477,7 +476,7 @@ 
     /**
      * Create role of a given name with the given policies described by an array.
      *
-     * @param $roleName
+     * @param string $roleName
      * @param array $policiesData [['module' => 'content', 'function' => 'read', 'limitations' => []]
      *
      * @return \eZ\Publish\API\Repository\Values\User\Role