NotificationServiceTest::serviceProvider() - Code Metrics - Inspection of "EZEE-2081: Move NotificationBundle into Kernel (#2..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7d9afb...4e0ac6 )

by Łukasz

created 2018-06-27 14:02 UTC

NotificationServiceTest::serviceProvider() B

↳ Parent: NotificationServiceTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	67
rs	8.72
c	0
b	0
f	0

How to fix Long Method

<?php

/**
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
declare(strict_types=1);

namespace eZ\Publish\Core\SignalSlot\Tests;

use eZ\Publish\API\Repository\NotificationService as APINotificationService;
use eZ\Publish\API\Repository\Values\Notification\CreateStruct;
use eZ\Publish\API\Repository\Values\Notification\Notification;
use eZ\Publish\API\Repository\Values\Notification\NotificationList;
use eZ\Publish\Core\SignalSlot\NotificationService;
use eZ\Publish\Core\SignalSlot\Signal\NotificationService\NotificationCreateSignal;
use eZ\Publish\Core\SignalSlot\Signal\NotificationService\NotificationDeleteSignal;
use eZ\Publish\Core\SignalSlot\Signal\NotificationService\NotificationReadSignal;
use eZ\Publish\Core\SignalSlot\SignalDispatcher;

class NotificationServiceTest extends ServiceTest
{
    public function serviceProvider()
    {
        $notificationId = 5;

        $notification = new Notification([
            'id' => $notificationId,
        ]);

        $createStruct = new CreateStruct([
            'ownerId' => 10,
            'type' => 'Foo',
            'data' => [],
        ]);

        return [
            [
                'loadNotifications',
                [0, 25],
                new NotificationList(),
                0,
            ],
            [
                'getNotification',
                [$notificationId],
                new Notification(),
                0,
            ],
            [
                'markNotificationAsRead',
                [$notification],
                null,
                1,
                NotificationReadSignal::class,
                [
                    'notificationId' => $notificationId,
                ],
            ],
            [
                'getPendingNotificationCount',
                [],
                10,
                0,
            ],
            [
                'deleteNotification',
                [$notification],
                null,
                1,
                NotificationDeleteSignal::class,
                [
                    'notificationId' => $notificationId,
                ],
            ],
            [
                'createNotification',
                [$createStruct],
                $notification,
                1,
                NotificationCreateSignal::class,
                [
                    'ownerId' => $createStruct->ownerId,
                    'type' => $createStruct->type,
                    'data' => $createStruct->data,
                ],
            ],
        ];
    }

    /**
     * {@inheritdoc}
     */
    protected function getServiceMock()
    {
        return $this->createMock(APINotificationService::class);
    }

    /**
     * {@inheritdoc}
     */
    protected function getSignalSlotService($innerService, SignalDispatcher $dispatcher)
    {
        return new NotificationService($innerService, $dispatcher);
    }
}


1			<?php
2
3			/**
4			* @copyright Copyright (C) eZ Systems AS. All rights reserved.
5			* @license For full copyright and license information view LICENSE file distributed with this source code.
6			*/
7			declare(strict_types=1);
8
9			namespace eZ\Publish\Core\SignalSlot\Tests;
10
11			use eZ\Publish\API\Repository\NotificationService as APINotificationService;
12			use eZ\Publish\API\Repository\Values\Notification\CreateStruct;
13			use eZ\Publish\API\Repository\Values\Notification\Notification;
14			use eZ\Publish\API\Repository\Values\Notification\NotificationList;
15			use eZ\Publish\Core\SignalSlot\NotificationService;
16			use eZ\Publish\Core\SignalSlot\Signal\NotificationService\NotificationCreateSignal;
17			use eZ\Publish\Core\SignalSlot\Signal\NotificationService\NotificationDeleteSignal;
18			use eZ\Publish\Core\SignalSlot\Signal\NotificationService\NotificationReadSignal;
19			use eZ\Publish\Core\SignalSlot\SignalDispatcher;
20
21			class NotificationServiceTest extends ServiceTest
22			{
23			public function serviceProvider()
24			{
25			$notificationId = 5;
26
27			$notification = new Notification([
28			'id' => $notificationId,
29			]);
30
31			$createStruct = new CreateStruct([
32			'ownerId' => 10,
33			'type' => 'Foo',
34			'data' => [],
35			]);
36
37			return [
38			[
39			'loadNotifications',
40			[0, 25],
41			new NotificationList(),
42			0,
43			],
44			[
45			'getNotification',
46			[$notificationId],
47			new Notification(),
48			0,
49			],
50			[
51			'markNotificationAsRead',
52			[$notification],
53			null,
54			1,
55			NotificationReadSignal::class,
56			[
57			'notificationId' => $notificationId,
58			],
59			],
60			[
61			'getPendingNotificationCount',
62			[],
63			10,
64			0,
65			],
66			[
67			'deleteNotification',
68			[$notification],
69			null,
70			1,
71			NotificationDeleteSignal::class,
72			[
73			'notificationId' => $notificationId,
74			],
75			],
76			[
77			'createNotification',
78			[$createStruct],
79			$notification,
80			1,
81			NotificationCreateSignal::class,
82			[
83			'ownerId' => $createStruct->ownerId,
84			'type' => $createStruct->type,
85			'data' => $createStruct->data,
86			],
87			],
88			];
89			}
90
91			/**
92			* {@inheritdoc}
93			*/
94			protected function getServiceMock()
95			{
96			return $this->createMock(APINotificationService::class);
97			}
98
99			/**
100			* {@inheritdoc}
101			*/
102			protected function getSignalSlotService($innerService, SignalDispatcher $dispatcher)
103			{
104			return new NotificationService($innerService, $dispatcher);
105			}
106			}
107

ezsystems / ezpublish-kernel

Push — master ( 7d9afb...4e0ac6 )

NotificationServiceTest::serviceProvider() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like