RouterSpecialPortsTest::matchProvider() - Code Metrics - Inspection of "Implemented SiteAccess providers (#2838)" - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 609783...50563c )

unknown

created 2019-11-26 11:56 UTC

RouterSpecialPortsTest::matchProvider() B

↳ Parent: RouterSpecialPortsTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	60
rs	8.8727
c	0
b	0
f	0

How to fix Long Method

<?php

/**
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Publish\Core\MVC\Symfony\SiteAccess\Tests;

use eZ\Publish\Core\MVC\Symfony\SiteAccess\Router;
use eZ\Publish\Core\MVC\Symfony\SiteAccess\Matcher\Map\Port as PortMatcher;
use eZ\Publish\Core\MVC\Symfony\Routing\SimplifiedRequest;
use Psr\Log\LoggerInterface;

class RouterSpecialPortsTest extends RouterBaseTest
{
    public function matchProvider(): array
    {
        return [
            [SimplifiedRequest::fromUrl('http://example.com'), 'fifth_sa'],
            [SimplifiedRequest::fromUrl('https://example.com'), 'fourth_sa'],
            [SimplifiedRequest::fromUrl('http://example.com/'), 'fifth_sa'],
            [SimplifiedRequest::fromUrl('https://example.com/'), 'fourth_sa'],
            [SimplifiedRequest::fromUrl('http://example.com//'), 'fifth_sa'],
            [SimplifiedRequest::fromUrl('https://example.com//'), 'fourth_sa'],
            [SimplifiedRequest::fromUrl('http://example.com:8080/'), 'default_sa'],
            [SimplifiedRequest::fromUrl('http://example.com/first_siteaccess/'), 'fifth_sa'],
            [SimplifiedRequest::fromUrl('http://example.com/?first_siteaccess'), 'fifth_sa'],
            [SimplifiedRequest::fromUrl('http://example.com/?first_sa'), 'fifth_sa'],
            [SimplifiedRequest::fromUrl('http://example.com/first_salt'), 'fifth_sa'],
            [SimplifiedRequest::fromUrl('http://example.com/first_sa.foo'), 'fifth_sa'],
            [SimplifiedRequest::fromUrl('http://example.com/test'), 'fifth_sa'],
            [SimplifiedRequest::fromUrl('http://example.com/test/foo/'), 'fifth_sa'],
            [SimplifiedRequest::fromUrl('http://example.com/test/foo/bar/'), 'fifth_sa'],
            [SimplifiedRequest::fromUrl('http://example.com/test/foo/bar/first_sa'), 'fifth_sa'],
            [SimplifiedRequest::fromUrl('http://example.com/default_sa'), 'fifth_sa'],

            [SimplifiedRequest::fromUrl('http://example.com/first_sa'), 'first_sa'],
            [SimplifiedRequest::fromUrl('http://example.com/first_sa/'), 'first_sa'],
            // Shouldn't match "first_sa" because of double slash
            [SimplifiedRequest::fromUrl('http://example.com//first_sa/'), 'fifth_sa'],
            [SimplifiedRequest::fromUrl('http://example.com/first_sa//'), 'first_sa'],
            [SimplifiedRequest::fromUrl('http://example.com/first_sa///test'), 'first_sa'],
            [SimplifiedRequest::fromUrl('http://example.com/first_sa/foo'), 'first_sa'],
            [SimplifiedRequest::fromUrl('http://example.com/first_sa/foo/bar'), 'first_sa'],
            [SimplifiedRequest::fromUrl('http://example.com:82/first_sa/'), 'first_sa'],
            [SimplifiedRequest::fromUrl('http://third_siteaccess/first_sa/'), 'first_sa'],
            [SimplifiedRequest::fromUrl('http://first_sa/'), 'first_sa'],
            [SimplifiedRequest::fromUrl('https://first_sa/'), 'first_sa'],
            [SimplifiedRequest::fromUrl('http://first_sa:81/'), 'first_sa'],
            [SimplifiedRequest::fromUrl('http://first_siteaccess/'), 'first_sa'],
            [SimplifiedRequest::fromUrl('http://first_siteaccess:82/'), 'first_sa'],
            [SimplifiedRequest::fromUrl('http://first_siteaccess:83/'), 'first_sa'],
            [SimplifiedRequest::fromUrl('http://first_siteaccess/foo/'), 'first_sa'],
            [SimplifiedRequest::fromUrl('http://first_siteaccess:82/foo/'), 'first_sa'],
            [SimplifiedRequest::fromUrl('http://first_siteaccess:83/foo/'), 'first_sa'],

            [SimplifiedRequest::fromUrl('http://example.com/second_sa'), 'second_sa'],
            [SimplifiedRequest::fromUrl('http://example.com/second_sa/'), 'second_sa'],
            [SimplifiedRequest::fromUrl('http://example.com/second_sa?param1=foo'), 'second_sa'],
            [SimplifiedRequest::fromUrl('http://example.com/second_sa/foo/'), 'second_sa'],
            [SimplifiedRequest::fromUrl('http://example.com:82/second_sa/'), 'second_sa'],
            [SimplifiedRequest::fromUrl('http://example.com:83/second_sa/'), 'second_sa'],
            [SimplifiedRequest::fromUrl('http://first_siteaccess:82/second_sa/'), 'second_sa'],
            [SimplifiedRequest::fromUrl('http://first_siteaccess:83/second_sa/'), 'second_sa'],

            [SimplifiedRequest::fromUrl('http://example.com:81/'), 'third_sa'],
            [SimplifiedRequest::fromUrl('https://example.com:81/'), 'third_sa'],
            [SimplifiedRequest::fromUrl('http://example.com:81/foo'), 'third_sa'],
            [SimplifiedRequest::fromUrl('http://example.com:81/foo/bar'), 'third_sa'],

            [SimplifiedRequest::fromUrl('http://example.com:82/'), 'fourth_sa'],
            [SimplifiedRequest::fromUrl('https://example.com:82/'), 'fourth_sa'],
            [SimplifiedRequest::fromUrl('https://example.com:82/foo'), 'fourth_sa'],
        ];
    }

    public function testGetName()
    {
        $matcher = new PortMatcher(['port' => '8080', 'scheme' => 'http'], []);
        $this->assertSame('port', $matcher->getName());
    }

    protected function createRouter(): Router
    {
        return new Router(
            $this->matcherBuilder,
            $this->createMock(LoggerInterface::class),
            'default_sa',
            [
                'Map\\URI' => [
                    'first_sa' => 'first_sa',
                    'second_sa' => 'second_sa',
                ],
                'Map\\Host' => [
                    'first_sa' => 'first_sa',
                    'first_siteaccess' => 'first_sa',
                    'third_siteaccess' => 'third_sa',
                ],
                'Map\\Port' => [
                    80 => 'fifth_sa',
                    81 => 'third_sa',
                    82 => 'fourth_sa',
                    83 => 'first_sa',
                    85 => 'first_sa',
                    443 => 'fourth_sa',
                ],
            ],
            $this->siteAccessProvider
        );
    }

    /**
     * @return \eZ\Publish\Core\MVC\Symfony\SiteAccess\Tests\SiteAccessSetting[]
     */
    public function getSiteAccessProviderSettings(): array
    {
        return [
            new SiteAccessSetting('first_sa', true),
            new SiteAccessSetting('second_sa', true),
            new SiteAccessSetting('third_sa', true),
            new SiteAccessSetting('fourth_sa', true),
            new SiteAccessSetting('fifth_sa', true),
        ];
    }
}


1		<?php
2
3		/**
4		* @copyright Copyright (C) eZ Systems AS. All rights reserved.
5		* @license For full copyright and license information view LICENSE file distributed with this source code.
6		*/
7		namespace eZ\Publish\Core\MVC\Symfony\SiteAccess\Tests;
8
9		use eZ\Publish\Core\MVC\Symfony\SiteAccess\Router;
10		use eZ\Publish\Core\MVC\Symfony\SiteAccess\Matcher\Map\Port as PortMatcher;
11		use eZ\Publish\Core\MVC\Symfony\Routing\SimplifiedRequest;
12		use Psr\Log\LoggerInterface;
13
14		class RouterSpecialPortsTest extends RouterBaseTest
15		{
16		public function matchProvider(): array
17		{
18		return [
19		[SimplifiedRequest::fromUrl('http://example.com'), 'fifth_sa'],
20		[SimplifiedRequest::fromUrl('https://example.com'), 'fourth_sa'],
21		[SimplifiedRequest::fromUrl('http://example.com/'), 'fifth_sa'],
22		[SimplifiedRequest::fromUrl('https://example.com/'), 'fourth_sa'],
23		[SimplifiedRequest::fromUrl('http://example.com//'), 'fifth_sa'],
24		[SimplifiedRequest::fromUrl('https://example.com//'), 'fourth_sa'],
25		[SimplifiedRequest::fromUrl('http://example.com:8080/'), 'default_sa'],
26		[SimplifiedRequest::fromUrl('http://example.com/first_siteaccess/'), 'fifth_sa'],
27		[SimplifiedRequest::fromUrl('http://example.com/?first_siteaccess'), 'fifth_sa'],
28		[SimplifiedRequest::fromUrl('http://example.com/?first_sa'), 'fifth_sa'],
29		[SimplifiedRequest::fromUrl('http://example.com/first_salt'), 'fifth_sa'],
30		[SimplifiedRequest::fromUrl('http://example.com/first_sa.foo'), 'fifth_sa'],
31		[SimplifiedRequest::fromUrl('http://example.com/test'), 'fifth_sa'],
32		[SimplifiedRequest::fromUrl('http://example.com/test/foo/'), 'fifth_sa'],
33		[SimplifiedRequest::fromUrl('http://example.com/test/foo/bar/'), 'fifth_sa'],
34		[SimplifiedRequest::fromUrl('http://example.com/test/foo/bar/first_sa'), 'fifth_sa'],
35		[SimplifiedRequest::fromUrl('http://example.com/default_sa'), 'fifth_sa'],
36
37		[SimplifiedRequest::fromUrl('http://example.com/first_sa'), 'first_sa'],
38		[SimplifiedRequest::fromUrl('http://example.com/first_sa/'), 'first_sa'],
39		// Shouldn't match "first_sa" because of double slash
40		[SimplifiedRequest::fromUrl('http://example.com//first_sa/'), 'fifth_sa'],
41		[SimplifiedRequest::fromUrl('http://example.com/first_sa//'), 'first_sa'],
42		[SimplifiedRequest::fromUrl('http://example.com/first_sa///test'), 'first_sa'],
43		[SimplifiedRequest::fromUrl('http://example.com/first_sa/foo'), 'first_sa'],
44		[SimplifiedRequest::fromUrl('http://example.com/first_sa/foo/bar'), 'first_sa'],
45		[SimplifiedRequest::fromUrl('http://example.com:82/first_sa/'), 'first_sa'],
46		[SimplifiedRequest::fromUrl('http://third_siteaccess/first_sa/'), 'first_sa'],
47		[SimplifiedRequest::fromUrl('http://first_sa/'), 'first_sa'],
48		[SimplifiedRequest::fromUrl('https://first_sa/'), 'first_sa'],
49		[SimplifiedRequest::fromUrl('http://first_sa:81/'), 'first_sa'],
50		[SimplifiedRequest::fromUrl('http://first_siteaccess/'), 'first_sa'],
51		[SimplifiedRequest::fromUrl('http://first_siteaccess:82/'), 'first_sa'],
52		[SimplifiedRequest::fromUrl('http://first_siteaccess:83/'), 'first_sa'],
53		[SimplifiedRequest::fromUrl('http://first_siteaccess/foo/'), 'first_sa'],
54		[SimplifiedRequest::fromUrl('http://first_siteaccess:82/foo/'), 'first_sa'],
55		[SimplifiedRequest::fromUrl('http://first_siteaccess:83/foo/'), 'first_sa'],
56
57		[SimplifiedRequest::fromUrl('http://example.com/second_sa'), 'second_sa'],
58		[SimplifiedRequest::fromUrl('http://example.com/second_sa/'), 'second_sa'],
59		[SimplifiedRequest::fromUrl('http://example.com/second_sa?param1=foo'), 'second_sa'],
60		[SimplifiedRequest::fromUrl('http://example.com/second_sa/foo/'), 'second_sa'],
61		[SimplifiedRequest::fromUrl('http://example.com:82/second_sa/'), 'second_sa'],
62		[SimplifiedRequest::fromUrl('http://example.com:83/second_sa/'), 'second_sa'],
63		[SimplifiedRequest::fromUrl('http://first_siteaccess:82/second_sa/'), 'second_sa'],
64		[SimplifiedRequest::fromUrl('http://first_siteaccess:83/second_sa/'), 'second_sa'],
65
66		[SimplifiedRequest::fromUrl('http://example.com:81/'), 'third_sa'],
67		[SimplifiedRequest::fromUrl('https://example.com:81/'), 'third_sa'],
68		[SimplifiedRequest::fromUrl('http://example.com:81/foo'), 'third_sa'],
69		[SimplifiedRequest::fromUrl('http://example.com:81/foo/bar'), 'third_sa'],
70
71		[SimplifiedRequest::fromUrl('http://example.com:82/'), 'fourth_sa'],
72		[SimplifiedRequest::fromUrl('https://example.com:82/'), 'fourth_sa'],
73		[SimplifiedRequest::fromUrl('https://example.com:82/foo'), 'fourth_sa'],
74		];
75		}
76
77		public function testGetName()
78		{
79		$matcher = new PortMatcher(['port' => '8080', 'scheme' => 'http'], []);
80		$this->assertSame('port', $matcher->getName());
81		}
82
83	View Code Duplication	protected function createRouter(): Router
84		{
85		return new Router(
86		$this->matcherBuilder,
87		$this->createMock(LoggerInterface::class),
88		'default_sa',
89		[
90		'Map\\URI' => [
91		'first_sa' => 'first_sa',
92		'second_sa' => 'second_sa',
93		],
94		'Map\\Host' => [
95		'first_sa' => 'first_sa',
96		'first_siteaccess' => 'first_sa',
97		'third_siteaccess' => 'third_sa',
98		],
99		'Map\\Port' => [
100		80 => 'fifth_sa',
101		81 => 'third_sa',
102		82 => 'fourth_sa',
103		83 => 'first_sa',
104		85 => 'first_sa',
105		443 => 'fourth_sa',
106		],
107		],
108		$this->siteAccessProvider
109		);
110		}
111
112		/**
113		* @return \eZ\Publish\Core\MVC\Symfony\SiteAccess\Tests\SiteAccessSetting[]
114		*/
115	View Code Duplication	public function getSiteAccessProviderSettings(): array
116		{
117		return [
118		new SiteAccessSetting('first_sa', true),
119		new SiteAccessSetting('second_sa', true),
120		new SiteAccessSetting('third_sa', true),
121		new SiteAccessSetting('fourth_sa', true),
122		new SiteAccessSetting('fifth_sa', true),
123		];
124		}
125		}
126

ezsystems / ezpublish-kernel

Push — master ( 609783...50563c )

RouterSpecialPortsTest::matchProvider() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like