ezsystems / ezpublish-kernel

eZ/Publish/Core/Persistence/Legacy/Content/UrlAlias/Handler.php

Doc Comments +9 added lines, -9 removed lines

@@ -311,7 +311,7 @@ 
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException
      * @throws \eZ\Publish\API\Repository\Exceptions\ForbiddenException
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      * @param string $path
      * @param bool $forwarding
      * @param string $languageCode
@@ -479,7 +479,7 @@ 
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\BadStateException
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      * @param bool $custom if true the user generated aliases are listed otherwise the autogenerated
      *
      * @return \eZ\Publish\SPI\Persistence\Content\UrlAlias[]
@@ -615,9 +615,9 @@ 
      *
      * This method triggers the change of the autogenerated aliases.
      *
-     * @param mixed $locationId
-     * @param mixed $oldParentId
-     * @param mixed $newParentId
+     * @param integer $locationId
+     * @param integer $oldParentId
+     * @param integer $newParentId
      */
     public function locationMoved($locationId, $oldParentId, $newParentId)
     {
@@ -645,9 +645,9 @@ 
      *
      * This method triggers the creation of the autogenerated aliases for the copied locations
      *
-     * @param mixed $locationId
-     * @param mixed $newLocationId
-     * @param mixed $newParentId
+     * @param integer $locationId
+     * @param integer $newLocationId
+     * @param integer $newParentId
      */
     public function locationCopied($locationId, $newLocationId, $newParentId)
     {
@@ -976,7 +976,7 @@ 
     /**
      * Notifies the underlying engine that a location was deleted or moved to trash.
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      */
     public function locationDeleted($locationId)
     {

eZ/Publish/Core/Repository/LocationService.php

Doc Comments +1 added lines, -1 removed lines

@@ -723,7 +723,7 @@
      * Instantiates a new location create class.
      *
      * @param mixed $parentLocationId the parent under which the new location should be created
-     * @param eZ\Publish\API\Repository\Values\ContentType\ContentType|null $contentType
+     * @param null|ContentType $contentType
      *
      * @return \eZ\Publish\API\Repository\Values\Content\LocationCreateStruct
      */

eZ/Publish/Core/REST/Client/LocationService.php

Doc Comments +2 added lines, -2 removed lines

@@ -80,7 +80,7 @@ 
      * Instantiates a new location create class.
      *
      * @param mixed $parentLocationId the parent under which the new location should be created
-     * @param eZ\Publish\API\Repository\Values\ContentType\ContentType|null $contentType
+     * @param null|ContentType $contentType
      *
      * @return \eZ\Publish\API\Repository\Values\Content\LocationCreateStruct
      */
@@ -218,7 +218,7 @@ 
      * @param \eZ\Publish\API\Repository\Values\Content\ContentInfo $contentInfo
      * @param \eZ\Publish\API\Repository\Values\Content\Location $rootLocation
      *
-     * @return \eZ\Publish\API\Repository\Values\Content\Location[]
+     * @return \eZ\Publish\API\Repository\Values\ValueObject
      */
     public function loadLocations(ContentInfo $contentInfo, Location $rootLocation = null)
     {

eZ/Publish/Core/SignalSlot/LocationService.php

Doc Comments +1 added lines, -1 removed lines

@@ -723,7 +723,7 @@
      * Instantiates a new location create class.
      *
      * @param mixed $parentLocationId the parent under which the new location should be created
-     * @param eZ\Publish\API\Repository\Values\ContentType\ContentType|null $contentType
+     * @param null|ContentType $contentType
      *
      * @return \eZ\Publish\API\Repository\Values\Content\LocationCreateStruct
      */

eZ/Publish/Core/Persistence/Legacy/Content/Location/Handler.php

Doc Comments +13 added lines, -13 removed lines

@@ -209,8 +209,8 @@ 
      * @todo Either move to async/batch or find ways toward optimizing away operations per object.
      * @todo Optionally retain dates and set creator
      *
-     * @param mixed $sourceId
-     * @param mixed $destinationParentId
+     * @param integer $sourceId
+     * @param integer $destinationParentId
      * @param int|null $newOwnerId
      *
      * @return Location the newly created Location.
@@ -368,10 +368,10 @@ 
      * destination, identified by $destinationParentId. Relations do not need
      * to be updated, since they refer to Content. URLs are not touched.
      *
-     * @param mixed $sourceId
-     * @param mixed $destinationParentId
+     * @param integer $sourceId
+     * @param integer $destinationParentId
      *
-     * @return bool
+     * @return boolean|null
      */
     public function move($sourceId, $destinationParentId)
     {
@@ -414,7 +414,7 @@ 
     /**
      * Sets a location to be hidden, and it self + all children to invisible.
      *
-     * @param mixed $id Location ID
+     * @param integer $id Location ID
      */
     public function hide($id)
     {
@@ -427,7 +427,7 @@ 
      * Sets a location to be unhidden, and self + children to visible unless a parent is hiding the tree.
      * If not make sure only children down to first hidden node is marked visible.
      *
-     * @param mixed $id
+     * @param integer $id
      */
     public function unHide($id)
     {
@@ -442,10 +442,10 @@ 
      * Make the location identified by $locationId1 refer to the Content
      * referred to by $locationId2 and vice versa.
      *
-     * @param mixed $locationId1
-     * @param mixed $locationId2
+     * @param integer $locationId1
+     * @param integer $locationId2
      *
-     * @return bool
+     * @return boolean|null
      */
     public function swap($locationId1, $locationId2)
     {
@@ -492,9 +492,9 @@ 
      * main Location will get the first of its other Locations assigned as the
      * new main Location.
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      *
-     * @return bool
+     * @return boolean|null
      */
     public function removeSubtree($locationId)
     {
@@ -505,7 +505,7 @@ 
      * Set section on all content objects in the subtree.
      *
      * @param mixed $locationId
-     * @param mixed $sectionId
+     * @param integer $sectionId
      */
     public function setSectionForSubtree($locationId, $sectionId)
     {

eZ/Publish/Core/Search/Elasticsearch/Content/CriterionVisitor/FieldFilterBase.php

Doc Comments +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
      *
      * @param array $languageFilter
      *
-     * @return array|null
+     * @return \eZ\Publish\API\Repository\Values\Content\Query\Criterion
      */
     protected function getFieldFilter(array $languageFilter)
     {

eZ/Publish/Core/Search/Elasticsearch/Content/SortClauseVisitor/FieldBase.php

Doc Comments +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
      * @param string $fieldDefinitionIdentifier
      * @param string $name
      *
-     * @return array
+     * @return SortClause
      */
     protected function getSortFieldName(
         SortClause $sortClause,

eZ/Publish/Core/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php

Doc Comments +23 added lines, -20 removed lines

@@ -96,7 +96,7 @@ 
      *
      * @todo optimize
      *
-     * @param mixed $remoteId
+     * @param string $remoteId
      *
      * @return array
      */
@@ -250,7 +250,7 @@ 
     /**
      * Returns data for the first level children of the location identified by given $locationId.
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      *
      * @return array
      */
@@ -377,6 +377,9 @@ 
         }
     }
 
+    /**
+     * @param string $pathString
+     */
     private function isHiddenByParent($pathString, array $rows)
     {
         $parentNodeIds = explode('/', trim($pathString, '/'));
@@ -577,8 +580,8 @@ 
      * Make the location identified by $locationId1 refer to the Content
      * referred to by $locationId2 and vice versa.
      *
-     * @param mixed $locationId1
-     * @param mixed $locationId2
+     * @param integer $locationId1
+     * @param integer $locationId2
      *
      * @return bool
      */
@@ -754,7 +757,7 @@ 
      * Create an entry in the node assignment table.
      *
      * @param \eZ\Publish\SPI\Persistence\Content\Location\CreateStruct $createStruct
-     * @param mixed $parentNodeId
+     * @param string $parentNodeId
      * @param int $type
      */
     public function createNodeAssignment(CreateStruct $createStruct, $parentNodeId, $type = self::NODE_ASSIGNMENT_OP_CODE_CREATE_NOP)
@@ -882,8 +885,8 @@ 
      *
      * Convert existing node assignments into real locations.
      *
-     * @param mixed $contentId
-     * @param mixed $versionNo
+     * @param integer $contentId
+     * @param integer $versionNo
      */
     public function createLocationsFromNodeAssignments($contentId, $versionNo)
     {
@@ -951,8 +954,8 @@ 
     /**
      * Updates all Locations of content identified with $contentId with $versionNo.
      *
-     * @param mixed $contentId
-     * @param mixed $versionNo
+     * @param integer $contentId
+     * @param integer $versionNo
      */
     public function updateLocationsContentVersionNo($contentId, $versionNo)
     {
@@ -1111,8 +1114,8 @@ 
      * the node identified by given $locationId (current main node).
      * Assumes that content has more than one location.
      *
-     * @param mixed $contentId
-     * @param mixed $locationId
+     * @param integer $contentId
+     * @param integer $locationId
      *
      * @return array
      */
@@ -1148,9 +1151,9 @@ 
      *
      * The associated content object is left untouched.
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      *
-     * @return bool
+     * @return boolean|null
      */
     public function trashLocation($locationId)
     {
@@ -1179,8 +1182,8 @@ 
      * at the old position. If this is not possible ( because the old location
      * does not exist any more) and exception is thrown.
      *
-     * @param mixed $locationId
-     * @param mixed|null $newParentId
+     * @param integer $locationId
+     * @param integer $newParentId
      *
      * @return \eZ\Publish\SPI\Persistence\Content\Location
      */
@@ -1433,10 +1436,10 @@ 
      * Updates ezcontentobject_tree table for the given $contentId and eznode_assignment table for the given
      * $contentId, $parentLocationId and $versionNo
      *
-     * @param mixed $contentId
-     * @param mixed $locationId
-     * @param mixed $versionNo version number, needed to update eznode_assignment table
-     * @param mixed $parentLocationId parent location of location identified by $locationId, needed to update
+     * @param integer $contentId
+     * @param integer $locationId
+     * @param integer $versionNo version number, needed to update eznode_assignment table
+     * @param integer $parentLocationId parent location of location identified by $locationId, needed to update
      *        eznode_assignment table
      */
     public function changeMainLocation($contentId, $locationId, $versionNo, $parentLocationId)
@@ -1564,7 +1567,7 @@ 
     /**
      * Get Query Builder for fetching data of all Locations except the Root node.
      *
-     * @param array $columns list of columns to fetch
+     * @param string[] $columns list of columns to fetch
      *
      * @return \Doctrine\DBAL\Query\QueryBuilder
      */

eZ/Publish/API/Repository/Tests/TrashServiceAuthorizationTest.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 namespace eZ\Publish\API\Repository\Tests;
 
 use eZ\Publish\API\Repository\Exceptions\UnauthorizedException;
-use eZ\Publish\API\Repository\Values\Content\Location;
 use eZ\Publish\API\Repository\Values\User\Limitation\ObjectStateLimitation;
 use eZ\Publish\Core\Repository\Repository;
 use eZ\Publish\Core\Repository\TrashService;