Completed
Push — lazy-loading-not-avail-content ( 189e64...1dbb7d )
by André
17:36
created
eZ/Publish/Core/Persistence/Legacy/Content/Gateway/DoctrineDatabase.php 1 patch
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -117,9 +117,9 @@  discard block
 block discarded – undo
117 117
      * Inserts a new content object.
118 118
      *
119 119
      * @param \eZ\Publish\SPI\Persistence\Content\CreateStruct $struct
120
-     * @param mixed $currentVersionNo
120
+     * @param integer $currentVersionNo
121 121
      *
122
-     * @return int ID
122
+     * @return string ID
123 123
      */
124 124
     public function insertContentObject(CreateStruct $struct, $currentVersionNo = 1)
125 125
     {
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
      * @param \eZ\Publish\SPI\Persistence\Content\VersionInfo $versionInfo
222 222
      * @param \eZ\Publish\SPI\Persistence\Content\Field[] $fields
223 223
      *
224
-     * @return int ID
224
+     * @return string ID
225 225
      */
226 226
     public function insertVersion(VersionInfo $versionInfo, array $fields)
227 227
     {
@@ -615,7 +615,7 @@  discard block
 block discarded – undo
615 615
      * @param \eZ\Publish\SPI\Persistence\Content\Field $field
616 616
      * @param \eZ\Publish\Core\Persistence\Legacy\Content\StorageFieldValue $value
617 617
      *
618
-     * @return int ID
618
+     * @return string ID
619 619
      */
620 620
     public function insertNewField(Content $content, Field $field, StorageFieldValue $value)
621 621
     {
@@ -1094,7 +1094,7 @@  discard block
 block discarded – undo
1094 1094
      *
1095 1095
      * Result is returned with oldest version first (using version id as it has index and is auto increment).
1096 1096
      *
1097
-     * @param mixed $contentId
1097
+     * @param integer $contentId
1098 1098
      * @param mixed|null $status Optional argument to filter versions by status, like {@see VersionInfo::STATUS_ARCHIVED}.
1099 1099
      * @param int $limit Limit for items returned, -1 means none.
1100 1100
      *
@@ -1162,7 +1162,7 @@  discard block
 block discarded – undo
1162 1162
     /**
1163 1163
      * Returns all version numbers for the given $contentId.
1164 1164
      *
1165
-     * @param mixed $contentId
1165
+     * @param integer $contentId
1166 1166
      *
1167 1167
      * @return int[]
1168 1168
      */
@@ -1860,7 +1860,7 @@  discard block
 block discarded – undo
1860 1860
      *
1861 1861
      * @param \eZ\Publish\SPI\Persistence\Content\Relation\CreateStruct $createStruct
1862 1862
      *
1863
-     * @return int ID the inserted ID
1863
+     * @return string ID the inserted ID
1864 1864
      */
1865 1865
     public function insertRelation(RelationCreateStruct $createStruct)
1866 1866
     {
Please login to merge, or discard this patch.
eZ/Publish/API/Repository/Tests/URLAliasServiceTest.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1270,7 +1270,7 @@  discard block
 block discarded – undo
1270 1270
 
1271 1271
     /**
1272 1272
      * @param \eZ\Publish\API\Repository\Values\Content\ContentInfo $contentInfo
1273
-     * @param $fieldDefinitionIdentifier
1273
+     * @param string $fieldDefinitionIdentifier
1274 1274
      * @param array $fieldValues
1275 1275
      *
1276 1276
      * @return \eZ\Publish\API\Repository\Values\Content\Content
@@ -1387,6 +1387,10 @@  discard block
 block discarded – undo
1387 1387
         $contentTypeService->publishContentTypeDraft($contentTypeDraft);
1388 1388
     }
1389 1389
 
1390
+    /**
1391
+     * @param string $expectedPath
1392
+     * @param boolean $expectedIsHistory
1393
+     */
1390 1394
     private function assertUrlAliasPropertiesCorrect(
1391 1395
         Location $expectedDestinationLocation,
1392 1396
         $expectedPath,
Please login to merge, or discard this patch.
eZ/Publish/Core/Repository/Tests/Service/Mock/UrlAliasTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3803,7 +3803,7 @@
 block discarded – undo
3803 3803
     }
3804 3804
 
3805 3805
     /**
3806
-     * @return \PHPUnit_Framework_MockObject_MockObject|\eZ\Publish\Core\Repository\Helper\NameSchemaService
3806
+     * @return NameSchemaService
3807 3807
      */
3808 3808
     protected function getNameSchemaServiceMock()
3809 3809
     {
Please login to merge, or discard this patch.
eZ/Publish/Core/Persistence/Legacy/Content/UrlAlias/Handler.php 1 patch
Doc Comments   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
311 311
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException
312 312
      * @throws \eZ\Publish\API\Repository\Exceptions\ForbiddenException
313 313
      *
314
-     * @param mixed $locationId
314
+     * @param integer $locationId
315 315
      * @param string $path
316 316
      * @param bool $forwarding
317 317
      * @param string $languageCode
@@ -479,7 +479,7 @@  discard block
 block discarded – undo
479 479
      *
480 480
      * @throws \eZ\Publish\API\Repository\Exceptions\BadStateException
481 481
      *
482
-     * @param mixed $locationId
482
+     * @param integer $locationId
483 483
      * @param bool $custom if true the user generated aliases are listed otherwise the autogenerated
484 484
      *
485 485
      * @return \eZ\Publish\SPI\Persistence\Content\UrlAlias[]
@@ -615,9 +615,9 @@  discard block
 block discarded – undo
615 615
      *
616 616
      * This method triggers the change of the autogenerated aliases.
617 617
      *
618
-     * @param mixed $locationId
619
-     * @param mixed $oldParentId
620
-     * @param mixed $newParentId
618
+     * @param integer $locationId
619
+     * @param integer $oldParentId
620
+     * @param integer $newParentId
621 621
      */
622 622
     public function locationMoved($locationId, $oldParentId, $newParentId)
623 623
     {
@@ -645,9 +645,9 @@  discard block
 block discarded – undo
645 645
      *
646 646
      * This method triggers the creation of the autogenerated aliases for the copied locations
647 647
      *
648
-     * @param mixed $locationId
649
-     * @param mixed $newLocationId
650
-     * @param mixed $newParentId
648
+     * @param integer $locationId
649
+     * @param integer $newLocationId
650
+     * @param integer $newParentId
651 651
      */
652 652
     public function locationCopied($locationId, $newLocationId, $newParentId)
653 653
     {
@@ -976,7 +976,7 @@  discard block
 block discarded – undo
976 976
     /**
977 977
      * Notifies the underlying engine that a location was deleted or moved to trash.
978 978
      *
979
-     * @param mixed $locationId
979
+     * @param integer $locationId
980 980
      */
981 981
     public function locationDeleted($locationId)
982 982
     {
Please login to merge, or discard this patch.
eZ/Publish/Core/Repository/LocationService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -723,7 +723,7 @@
 block discarded – undo
723 723
      * Instantiates a new location create class.
724 724
      *
725 725
      * @param mixed $parentLocationId the parent under which the new location should be created
726
-     * @param eZ\Publish\API\Repository\Values\ContentType\ContentType|null $contentType
726
+     * @param null|ContentType $contentType
727 727
      *
728 728
      * @return \eZ\Publish\API\Repository\Values\Content\LocationCreateStruct
729 729
      */
Please login to merge, or discard this patch.
eZ/Publish/Core/REST/Client/LocationService.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
      * Instantiates a new location create class.
81 81
      *
82 82
      * @param mixed $parentLocationId the parent under which the new location should be created
83
-     * @param eZ\Publish\API\Repository\Values\ContentType\ContentType|null $contentType
83
+     * @param null|ContentType $contentType
84 84
      *
85 85
      * @return \eZ\Publish\API\Repository\Values\Content\LocationCreateStruct
86 86
      */
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
      * @param \eZ\Publish\API\Repository\Values\Content\ContentInfo $contentInfo
219 219
      * @param \eZ\Publish\API\Repository\Values\Content\Location $rootLocation
220 220
      *
221
-     * @return \eZ\Publish\API\Repository\Values\Content\Location[]
221
+     * @return \eZ\Publish\API\Repository\Values\ValueObject
222 222
      */
223 223
     public function loadLocations(ContentInfo $contentInfo, Location $rootLocation = null)
224 224
     {
Please login to merge, or discard this patch.
eZ/Publish/Core/SignalSlot/LocationService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -723,7 +723,7 @@
 block discarded – undo
723 723
      * Instantiates a new location create class.
724 724
      *
725 725
      * @param mixed $parentLocationId the parent under which the new location should be created
726
-     * @param eZ\Publish\API\Repository\Values\ContentType\ContentType|null $contentType
726
+     * @param null|ContentType $contentType
727 727
      *
728 728
      * @return \eZ\Publish\API\Repository\Values\Content\LocationCreateStruct
729 729
      */
Please login to merge, or discard this patch.
Core/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php 1 patch
Doc Comments   +23 added lines, -20 removed lines patch added patch discarded remove patch
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
     /**
248 248
      * Returns data for the first level children of the location identified by given $locationId.
249 249
      *
250
-     * @param mixed $locationId
250
+     * @param integer $locationId
251 251
      *
252 252
      * @return array
253 253
      */
@@ -374,6 +374,9 @@  discard block
 block discarded – undo
374 374
         }
375 375
     }
376 376
 
377
+    /**
378
+     * @param string $pathString
379
+     */
377 380
     private function isHiddenByParent($pathString, array $rows)
378 381
     {
379 382
         $parentNodeIds = explode('/', trim($pathString, '/'));
@@ -574,10 +577,10 @@  discard block
 block discarded – undo
574 577
      * Make the location identified by $locationId1 refer to the Content
575 578
      * referred to by $locationId2 and vice versa.
576 579
      *
577
-     * @param mixed $locationId1
578
-     * @param mixed $locationId2
580
+     * @param integer $locationId1
581
+     * @param integer $locationId2
579 582
      *
580
-     * @return bool
583
+     * @return boolean|null
581 584
      */
582 585
     public function swap($locationId1, $locationId2)
583 586
     {
@@ -734,7 +737,7 @@  discard block
 block discarded – undo
734 737
      * Create an entry in the node assignment table.
735 738
      *
736 739
      * @param \eZ\Publish\SPI\Persistence\Content\Location\CreateStruct $createStruct
737
-     * @param mixed $parentNodeId
740
+     * @param string $parentNodeId
738 741
      * @param int $type
739 742
      */
740 743
     public function createNodeAssignment(CreateStruct $createStruct, $parentNodeId, $type = self::NODE_ASSIGNMENT_OP_CODE_CREATE_NOP)
@@ -862,8 +865,8 @@  discard block
 block discarded – undo
862 865
      *
863 866
      * Convert existing node assignments into real locations.
864 867
      *
865
-     * @param mixed $contentId
866
-     * @param mixed $versionNo
868
+     * @param integer $contentId
869
+     * @param integer $versionNo
867 870
      */
868 871
     public function createLocationsFromNodeAssignments($contentId, $versionNo)
869 872
     {
@@ -931,8 +934,8 @@  discard block
 block discarded – undo
931 934
     /**
932 935
      * Updates all Locations of content identified with $contentId with $versionNo.
933 936
      *
934
-     * @param mixed $contentId
935
-     * @param mixed $versionNo
937
+     * @param integer $contentId
938
+     * @param integer $versionNo
936 939
      */
937 940
     public function updateLocationsContentVersionNo($contentId, $versionNo)
938 941
     {
@@ -1091,8 +1094,8 @@  discard block
 block discarded – undo
1091 1094
      * the node identified by given $locationId (current main node).
1092 1095
      * Assumes that content has more than one location.
1093 1096
      *
1094
-     * @param mixed $contentId
1095
-     * @param mixed $locationId
1097
+     * @param integer $contentId
1098
+     * @param integer $locationId
1096 1099
      *
1097 1100
      * @return array
1098 1101
      */
@@ -1128,9 +1131,9 @@  discard block
 block discarded – undo
1128 1131
      *
1129 1132
      * The associated content object is left untouched.
1130 1133
      *
1131
-     * @param mixed $locationId
1134
+     * @param integer $locationId
1132 1135
      *
1133
-     * @return bool
1136
+     * @return boolean|null
1134 1137
      */
1135 1138
     public function trashLocation($locationId)
1136 1139
     {
@@ -1159,8 +1162,8 @@  discard block
 block discarded – undo
1159 1162
      * at the old position. If this is not possible ( because the old location
1160 1163
      * does not exist any more) and exception is thrown.
1161 1164
      *
1162
-     * @param mixed $locationId
1163
-     * @param mixed|null $newParentId
1165
+     * @param integer $locationId
1166
+     * @param integer $newParentId
1164 1167
      *
1165 1168
      * @return \eZ\Publish\SPI\Persistence\Content\Location
1166 1169
      */
@@ -1413,10 +1416,10 @@  discard block
 block discarded – undo
1413 1416
      * Updates ezcontentobject_tree table for the given $contentId and eznode_assignment table for the given
1414 1417
      * $contentId, $parentLocationId and $versionNo
1415 1418
      *
1416
-     * @param mixed $contentId
1417
-     * @param mixed $locationId
1418
-     * @param mixed $versionNo version number, needed to update eznode_assignment table
1419
-     * @param mixed $parentLocationId parent location of location identified by $locationId, needed to update
1419
+     * @param integer $contentId
1420
+     * @param integer $locationId
1421
+     * @param integer $versionNo version number, needed to update eznode_assignment table
1422
+     * @param integer $parentLocationId parent location of location identified by $locationId, needed to update
1420 1423
      *        eznode_assignment table
1421 1424
      */
1422 1425
     public function changeMainLocation($contentId, $locationId, $versionNo, $parentLocationId)
@@ -1546,7 +1549,7 @@  discard block
 block discarded – undo
1546 1549
      *
1547 1550
      * @todo Align with createNodeQueryBuilder, removing the need for both(?)
1548 1551
      *
1549
-     * @param array $columns list of columns to fetch
1552
+     * @param string[] $columns list of columns to fetch
1550 1553
      *
1551 1554
      * @return \Doctrine\DBAL\Query\QueryBuilder
1552 1555
      */
Please login to merge, or discard this patch.
eZ/Publish/Core/Persistence/Cache/LocationHandler.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -339,9 +339,9 @@
 block discarded – undo
339 339
      * Return relevant content and location tags so cache can be purged reliably.
340 340
      *
341 341
      * @param \eZ\Publish\SPI\Persistence\Content\Location $location
342
-     * @param array $tags Optional, can be used to specify additional tags.
342
+     * @param string[] $tags Optional, can be used to specify additional tags.
343 343
      *
344
-     * @return array
344
+     * @return string[]
345 345
      */
346 346
     private function getCacheTags(Location $location, $tags = [])
347 347
     {
Please login to merge, or discard this patch.