Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 18 | class MaskGenerator |
||
| 19 | { |
||
| 20 | /** |
||
| 21 | * Language lookup. |
||
| 22 | * |
||
| 23 | * @var \eZ\Publish\Core\Persistence\Legacy\Content\Language\Handler |
||
| 24 | */ |
||
| 25 | protected $languageHandler; |
||
| 26 | |||
| 27 | /** |
||
| 28 | * Creates a new Language MaskGenerator. |
||
| 29 | * |
||
| 30 | * @param \eZ\Publish\SPI\Persistence\Content\Language\Handler $languageHandler |
||
| 31 | */ |
||
| 32 | public function __construct(LanguageHandler $languageHandler) |
||
| 36 | |||
| 37 | /** |
||
| 38 | * @deprecated Move towards using {@see generateLanguageMaskFromLanguageMap()} |
||
| 39 | */ |
||
| 40 | public function generateLanguageMask(array $languageMap) |
||
| 44 | |||
| 45 | /** |
||
| 46 | * Generates a language mask from the keys of $languages. |
||
| 47 | * |
||
| 48 | * Typically used for ->name values to get language mask directly from such structure. |
||
| 49 | * |
||
| 50 | * @param array $languageMap Key values are language code, value is ignored. |
||
| 51 | * Exception is 'always-available' key, if set and true, always available flag is added. |
||
| 52 | * |
||
| 53 | * @throws \RuntimeException If non allowed values are provided as keys. |
||
| 54 | * |
||
| 55 | * @return int |
||
| 56 | */ |
||
| 57 | public function generateLanguageMaskFromLanguageMap(array $languageMap): int |
||
| 77 | |||
| 78 | /** |
||
| 79 | * Generates a language mask for $translations argument. |
||
| 80 | * |
||
| 81 | * @param string[] $languageCodes Array of Language codes. |
||
| 82 | * @param bool $useAlwaysAvailable |
||
| 83 | * |
||
| 84 | * @return int |
||
| 85 | */ |
||
| 86 | public function generateLanguageMaskFromLanguageCodes(array $languageCodes, bool $useAlwaysAvailable): int |
||
| 99 | |||
| 100 | /** |
||
| 101 | * Generates a language mask from pre-loaded Language Ids. |
||
| 102 | * |
||
| 103 | * @param int[] $languageIds |
||
| 104 | * @param bool $alwaysAvailable |
||
| 105 | * |
||
| 106 | * @return int |
||
| 107 | */ |
||
| 108 | public function generateLanguageMaskFromLanguageIds(array $languageIds, $alwaysAvailable): int |
||
| 119 | |||
| 120 | /** |
||
| 121 | * Generates a language indicator from $languageCode and $alwaysAvailable. |
||
| 122 | * |
||
| 123 | * @param string $languageCode |
||
| 124 | * @param bool $alwaysAvailable |
||
| 125 | * |
||
| 126 | * @return int |
||
| 127 | */ |
||
| 128 | public function generateLanguageIndicator($languageCode, $alwaysAvailable) |
||
| 132 | |||
| 133 | /** |
||
| 134 | * Checks if $language is always available in $languages;. |
||
| 135 | * |
||
| 136 | * @param string $language |
||
| 137 | * @param array $languages |
||
| 138 | * |
||
| 139 | * @return bool |
||
| 140 | */ |
||
| 141 | public function isLanguageAlwaysAvailable($language, array $languages) |
||
| 147 | |||
| 148 | /** |
||
| 149 | * Checks if $languageMask contains the alwaysAvailable bit field. |
||
| 150 | * |
||
| 151 | * @param int $languageMask |
||
| 152 | * |
||
| 153 | * @return bool |
||
| 154 | */ |
||
| 155 | public function isAlwaysAvailable($languageMask) |
||
| 159 | |||
| 160 | /** |
||
| 161 | * Removes the alwaysAvailable flag from $languageId and returns cleaned up $languageId. |
||
| 162 | * |
||
| 163 | * @param int $languageId |
||
| 164 | * |
||
| 165 | * @return int |
||
| 166 | */ |
||
| 167 | public function removeAlwaysAvailableFlag($languageId) |
||
| 171 | |||
| 172 | /** |
||
| 173 | * Extracts every language Ids contained in $languageMask. |
||
| 174 | * |
||
| 175 | * @param int $languageMask |
||
| 176 | * |
||
| 177 | * @return array Array of language Id |
||
| 178 | */ |
||
| 179 | View Code Duplication | public function extractLanguageIdsFromMask($languageMask) |
|
| 195 | |||
| 196 | /** |
||
| 197 | * Extracts Language codes contained in given $languageMask. |
||
| 198 | * |
||
| 199 | * @param int $languageMask |
||
| 200 | * |
||
| 201 | * @return array |
||
| 202 | */ |
||
| 203 | public function extractLanguageCodesFromMask($languageMask) |
||
| 213 | |||
| 214 | /** |
||
| 215 | * Checks if given $languageMask consists of multiple languages. |
||
| 216 | * |
||
| 217 | * @param int $languageMask |
||
| 218 | * |
||
| 219 | * @return bool |
||
| 220 | */ |
||
| 221 | public function isLanguageMaskComposite($languageMask) |
||
| 234 | } |
||
| 235 |
Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly.
Either this assignment is in error or an instanceof check should be added for that assignment.