Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 18 | class UserGroup extends APIUserGroup |
||
| 19 | { |
||
| 20 | /** |
||
| 21 | * Internal content representation. |
||
| 22 | * |
||
| 23 | * @var \eZ\Publish\API\Repository\Values\Content\Content |
||
| 24 | */ |
||
| 25 | protected $content; |
||
| 26 | |||
| 27 | /** |
||
| 28 | * Returns the VersionInfo for this version. |
||
| 29 | * |
||
| 30 | * @return \eZ\Publish\API\Repository\Values\Content\VersionInfo |
||
| 31 | */ |
||
| 32 | public function getVersionInfo() |
||
| 36 | |||
| 37 | /** |
||
| 38 | * Returns a field value for the given value |
||
| 39 | * $version->fields[$fieldDefId][$languageCode] is an equivalent call |
||
| 40 | * if no language is given on a translatable field this method returns |
||
| 41 | * the value of the initial language of the version if present, otherwise null. |
||
| 42 | * On non translatable fields this method ignores the languageCode parameter. |
||
| 43 | * |
||
| 44 | * @param string $fieldDefIdentifier |
||
| 45 | * @param string $languageCode |
||
| 46 | * |
||
| 47 | * @return mixed a primitive type or a field type Value object depending on the field type. |
||
| 48 | */ |
||
| 49 | public function getFieldValue($fieldDefIdentifier, $languageCode = null) |
||
| 53 | |||
| 54 | /** |
||
| 55 | * This method returns the complete fields collection. |
||
| 56 | * |
||
| 57 | * @return \eZ\Publish\API\Repository\Values\Content\Field[] |
||
| 58 | */ |
||
| 59 | public function getFields() |
||
| 63 | |||
| 64 | /** |
||
| 65 | * This method returns the fields for a given language and non translatable fields. |
||
| 66 | * |
||
| 67 | * If note set the initialLanguage of the content version is used. |
||
| 68 | * |
||
| 69 | * @param string $languageCode |
||
| 70 | * |
||
| 71 | * @return \eZ\Publish\API\Repository\Values\Content\Field[] with field identifier as keys |
||
| 72 | */ |
||
| 73 | public function getFieldsByLanguage($languageCode = null) |
||
| 77 | |||
| 78 | /** |
||
| 79 | * This method returns the field for a given field definition identifier and language. |
||
| 80 | * |
||
| 81 | * If not set the initialLanguage of the content version is used. |
||
| 82 | * |
||
| 83 | * @param string $fieldDefIdentifier |
||
| 84 | * @param string|null $languageCode |
||
| 85 | * |
||
| 86 | * @return \eZ\Publish\API\Repository\Values\Content\Field|null A {@link Field} or null if nothing is found |
||
| 87 | */ |
||
| 88 | public function getField($fieldDefIdentifier, $languageCode = null) |
||
| 89 | { |
||
| 90 | return $this->content->getField($fieldDefIdentifier, $languageCode); |
||
| 91 | } |
||
| 92 | |||
| 93 | /** |
||
| 94 | * Function where list of properties are returned. |
||
| 95 | * |
||
| 96 | * Override to add dynamic properties |
||
| 97 | * |
||
| 98 | * @uses \parent::getProperties() |
||
| 99 | * |
||
| 100 | * @param array $dynamicProperties |
||
| 101 | * |
||
| 102 | * @return array |
||
| 103 | */ |
||
| 104 | protected function getProperties($dynamicProperties = array('id', 'contentInfo')) |
||
| 108 | |||
| 109 | /** |
||
| 110 | * Magic getter for retrieving convenience properties. |
||
| 111 | * |
||
| 112 | * @param string $property The name of the property to retrieve |
||
| 113 | * |
||
| 114 | * @return mixed |
||
| 115 | */ |
||
| 116 | View Code Duplication | public function __get($property) |
|
| 139 | |||
| 140 | /** |
||
| 141 | * Magic isset for signaling existence of convenience properties. |
||
| 142 | * |
||
| 143 | * @param string $property |
||
| 144 | * |
||
| 145 | * @return bool |
||
| 146 | */ |
||
| 147 | View Code Duplication | public function __isset($property) |
|
| 167 | } |
||
| 168 |