PublishVersionSlot - Code Metrics - Inspection of "[Tests] Refactor tests to use OOP and not static g..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature-EZP-25696 ( 605ead...1ad329 )

by André

created 2016-09-08 14:18 UTC

PublishVersionSlot A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	48
rs	10
wmc	4
lcom	1
cbo	3

3 Methods

Rating	Name	Size	Complexity
A	__construct()	5	1
A	generateTags()	16	2
A	supports()	4	1

<?php

/**
 * This file is part of the eZ Publish Kernel package.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 *
 * @version //autogentag//
 */
namespace eZ\Publish\Core\MVC\Symfony\Cache\Http\SignalSlot;

use eZ\Publish\Core\MVC\Symfony\Cache\PurgeClientInterface;
use eZ\Publish\Core\SignalSlot\Signal;
use eZ\Publish\SPI\Persistence\Content\Location\Handler;


/**
 * A slot handling PublishVersionSignal.
 */
class PublishVersionSlot extends AbstractContentSlot
{
    /**
     * @var \eZ\Publish\SPI\Persistence\Content\Location\Handler
     */
    private $locationHandler;

    /**
     * @param \eZ\Publish\Core\MVC\Symfony\Cache\PurgeClientInterface $purgeClient
     * @param \eZ\Publish\SPI\Persistence\Content\Location\Handler $spiLocationHandler
     */
    public function __construct(PurgeClientInterface $purgeClient, Handler $spiLocationHandler)
    {
        parent::__construct($purgeClient);
        $this->locationHandler = $spiLocationHandler;
    }

    /**
     * Default provides tags to clear content, relation, location, parent and sibling cache.
     *
     * Overload for tree operations where you also need to clear whole path.
     *
     * @param \eZ\Publish\Core\SignalSlot\Signal\ContentService\PublishVersionSignal $signal
     *
     * @return array
     */
    protected function generateTags(Signal $signal)
    {
        $tags = parent::generateTags($signal);
        foreach ($this->locationHandler->loadLocationsByContent($signal->contentId) as $location) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            // self
            $tags[] = 'location-'.$location->id;
            // children
            $tags[] = 'parent-'.$location->id;
            // parent
            $tags[] = 'location-'.$location->parentId;
            // siblings
            $tags[] = 'parent-'.$location->parentId;
        }

        return $tags;
    }

    protected function supports(Signal $signal)
    {
        return $signal instanceof Signal\ContentService\PublishVersionSignal;
    }
}


1			<?php
2
3			/**
4			* This file is part of the eZ Publish Kernel package.
5			*
6			* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7			* @license For full copyright and license information view LICENSE file distributed with this source code.
8			*
9			* @version //autogentag//
10			*/
11			namespace eZ\Publish\Core\MVC\Symfony\Cache\Http\SignalSlot;
12
13			use eZ\Publish\Core\MVC\Symfony\Cache\PurgeClientInterface;
14			use eZ\Publish\Core\SignalSlot\Signal;
15			use eZ\Publish\SPI\Persistence\Content\Location\Handler;
16
17
18			/**
19			* A slot handling PublishVersionSignal.
20			*/
21			class PublishVersionSlot extends AbstractContentSlot
22			{
23			/**
24			* @var \eZ\Publish\SPI\Persistence\Content\Location\Handler
25			*/
26			private $locationHandler;
27
28			/**
29			* @param \eZ\Publish\Core\MVC\Symfony\Cache\PurgeClientInterface $purgeClient
30			* @param \eZ\Publish\SPI\Persistence\Content\Location\Handler $spiLocationHandler
31			*/
32			public function __construct(PurgeClientInterface $purgeClient, Handler $spiLocationHandler)
33			{
34			parent::__construct($purgeClient);
35			$this->locationHandler = $spiLocationHandler;
36			}
37
38			/**
39			* Default provides tags to clear content, relation, location, parent and sibling cache.
40			*
41			* Overload for tree operations where you also need to clear whole path.
42			*
43			* @param \eZ\Publish\Core\SignalSlot\Signal\ContentService\PublishVersionSignal $signal
44			*
45			* @return array
46			*/
47			protected function generateTags(Signal $signal)
48			{
49			$tags = parent::generateTags($signal);
50			foreach ($this->locationHandler->loadLocationsByContent($signal->contentId) as $location) {
			0 ignored issues – show Documentation introduced 2016-09-08 07:35 UTC by Report Bug Copy Issue Report The property `contentId` does not exist on `object<eZ\Publish\Core\SignalSlot\Signal>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
51			// self
52			$tags[] = 'location-'.$location->id;
53			// children
54			$tags[] = 'parent-'.$location->id;
55			// parent
56			$tags[] = 'location-'.$location->parentId;
57			// siblings
58			$tags[] = 'parent-'.$location->parentId;
59			}
60
61			return $tags;
62			}
63
64			protected function supports(Signal $signal)
65			{
66			return $signal instanceof Signal\ContentService\PublishVersionSignal;
67			}
68			}
69

ezsystems / ezpublish-kernel

Push — feature-EZP-25696 ( 605ead...1ad329 )

PublishVersionSlot A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like