ezsystems /
ezpublish-kernel
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 57 |
| Code Lines | 48 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 32 | public function providerForPassTroughMethods() |
||
| 33 | { |
||
| 34 | $roleCreateStruct = new RoleCreateStruct(); |
||
| 35 | $roleUpdateStruct = new RoleUpdateStruct(); |
||
| 36 | $role = new Role(); |
||
| 37 | $roleDraft = new RoleDraft(); |
||
| 38 | |||
| 39 | $policyCreateStruct = new PolicyCreateStruct(); |
||
| 40 | $policyUpdateStruct = new PolicyUpdateStruct(); |
||
| 41 | $policyDraft = new PolicyDraft(); |
||
| 42 | $policy = new Policy(); |
||
| 43 | |||
| 44 | $roleLimitation = new SubtreeLimitation(); |
||
| 45 | |||
| 46 | $userGroup = new UserGroup(); |
||
| 47 | $user = new User(); |
||
| 48 | |||
| 49 | $roleAssignment = new UserRoleAssignment(); |
||
| 50 | |||
| 51 | // string $method, array $arguments, bool $return = true |
||
| 52 | return [ |
||
| 53 | ['createRole', [$roleCreateStruct]], |
||
| 54 | ['createRoleDraft', [$role]], |
||
| 55 | ['loadRoleDraft', [24]], |
||
| 56 | ['loadRoleDraftByRoleId', [24]], |
||
| 57 | ['updateRoleDraft', [$roleDraft, $roleUpdateStruct]], |
||
| 58 | ['addPolicyByRoleDraft', [$roleDraft, $policyCreateStruct]], |
||
| 59 | ['removePolicyByRoleDraft', [$roleDraft, $policyDraft]], |
||
| 60 | ['updatePolicyByRoleDraft', [$roleDraft, $policyDraft, $policyUpdateStruct]], |
||
| 61 | ['deleteRoleDraft', [$roleDraft]], |
||
| 62 | ['publishRoleDraft', [$roleDraft]], |
||
| 63 | ['updateRole', [$role, $roleUpdateStruct]], |
||
| 64 | ['addPolicy', [$role, $policyCreateStruct]], |
||
| 65 | ['deletePolicy', [$policy]], |
||
| 66 | ['updatePolicy', [$policy, $policyUpdateStruct]], |
||
| 67 | ['loadRole', [24]], |
||
| 68 | ['loadRoleByIdentifier', ['admin']], |
||
| 69 | ['loadRoles', []], |
||
| 70 | ['deleteRole', [$role]], |
||
| 71 | ['loadPoliciesByUserId', [10]], |
||
| 72 | ['assignRoleToUserGroup', [$role, $userGroup, $roleLimitation]], |
||
| 73 | ['unassignRoleFromUserGroup', [$role, $userGroup]], |
||
| 74 | ['assignRoleToUser', [$role, $user, $roleLimitation]], |
||
| 75 | ['unassignRoleFromUser', [$role, $user]], |
||
| 76 | ['removeRoleAssignment', [$roleAssignment]], |
||
| 77 | ['loadRoleAssignment', [55]], |
||
| 78 | ['getRoleAssignments', [$role]], |
||
| 79 | ['getRoleAssignmentsForUser', [$user, true]], |
||
| 80 | ['getRoleAssignmentsForUserGroup', [$userGroup]], |
||
| 81 | ['newRoleCreateStruct', ['Editor']], |
||
| 82 | ['newPolicyCreateStruct', ['content', 'edit']], |
||
| 83 | ['newPolicyUpdateStruct', []], |
||
| 84 | ['newRoleUpdateStruct', []], |
||
| 85 | ['getLimitationType', ['subtree']], |
||
| 86 | ['getLimitationTypesByModuleFunction', ['content', 'edit']], |
||
| 87 | ]; |
||
| 88 | } |
||
| 89 | |||
| 96 |
