ezsystems / ezpublish-kernel

eZ/Publish/Core/Persistence/Legacy/Content/Handler.php

Doc Comments +7 added lines, -7 removed lines

@@ -150,7 +150,7 @@ 
      * Will contain always a complete list of fields.
      *
      * @param \eZ\Publish\SPI\Persistence\Content\CreateStruct $struct Content creation struct.
-     * @param mixed $versionNo Used by self::copy() to maintain version numbers
+     * @param integer $versionNo Used by self::copy() to maintain version numbers
      *
      * @return \eZ\Publish\SPI\Persistence\Content Content value object
      */
@@ -432,7 +432,7 @@ 
     /**
      * Returns the metadata object for a content identified by $remoteId.
      *
-     * @param mixed $remoteId
+     * @param string $remoteId
      *
      * @return \eZ\Publish\SPI\Persistence\Content\ContentInfo
      */
@@ -593,7 +593,7 @@ 
      *
      * @param int $contentId
      *
-     * @return bool
+     * @return boolean|null
      */
     public function deleteContent($contentId)
     {
@@ -625,7 +625,7 @@ 
      * @param int $contentId
      * @param int $versionNo
      *
-     * @return bool
+     * @return boolean|null
      */
     public function deleteVersion($contentId, $versionNo)
     {
@@ -750,7 +750,7 @@ 
      *
      * @todo Should the existence verifications happen here or is this supposed to be handled at a higher level?
      *
-     * @param mixed $relationId
+     * @param integer $relationId
      * @param int $type {@see \eZ\Publish\API\Repository\Values\Content\Relation::COMMON,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::EMBED,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::LINK,
@@ -764,7 +764,7 @@ 
     /**
      * Loads relations from $sourceContentId. Optionally, loads only those with $type and $sourceContentVersionNo.
      *
-     * @param mixed $sourceContentId Source Content ID
+     * @param integer $sourceContentId Source Content ID
      * @param mixed|null $sourceContentVersionNo Source Content Version, null if not specified
      * @param int|null $type {@see \eZ\Publish\API\Repository\Values\Content\Relation::COMMON,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::EMBED,
@@ -785,7 +785,7 @@ 
      *
      * Only loads relations against published versions.
      *
-     * @param mixed $destinationContentId Destination Content ID
+     * @param integer $destinationContentId Destination Content ID
      * @param int|null $type {@see \eZ\Publish\API\Repository\Values\Content\Relation::COMMON,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::EMBED,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::LINK,

eZ/Publish/Core/MVC/Symfony/Security/Authorization/Voter/ValueObjectVoter.php

Doc Comments +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
      * @see \eZ\Publish\API\Repository\PermissionResolver::canUser()
      *
      * @param TokenInterface $token      A TokenInterface instance
-     * @param object         $object     The object to secure
+     * @param \stdClass         $object     The object to secure
      * @param array          $attributes An array of attributes associated with the method being invoked
      *
      * @return int either ACCESS_GRANTED, ACCESS_ABSTAIN, or ACCESS_DENIED

eZ/Publish/Core/Repository/ContentService.php

Doc Comments +4 added lines, -4 removed lines

@@ -220,7 +220,7 @@ 
      * @param mixed $contentId
      * @param int $versionNo the version number. If not given the current version is returned.
      *
-     * @return \eZ\Publish\API\Repository\Values\Content\VersionInfo
+     * @return \eZ\Publish\API\Repository\Values\ValueObject
      */
     public function loadVersionInfoById($contentId, $versionNo = null)
     {
@@ -1397,7 +1397,7 @@ 
      *
      * @param \eZ\Publish\API\Repository\Values\Content\ContentUpdateStruct $contentUpdateStruct
      *
-     * @return array
+     * @return string[]
      */
     private function getUpdatedLanguageCodes(APIContentUpdateStruct $contentUpdateStruct)
     {
@@ -1424,7 +1424,7 @@ 
      * @param \eZ\Publish\API\Repository\Values\Content\ContentUpdateStruct $contentUpdateStruct
      * @param \eZ\Publish\API\Repository\Values\Content\Content $content
      *
-     * @return array
+     * @return string[]
      */
     protected function getLanguageCodesForUpdate(APIContentUpdateStruct $contentUpdateStruct, APIContent $content)
     {
@@ -1553,7 +1553,7 @@ 
 
     /**
      * @param \eZ\Publish\API\Repository\Values\Content\VersionInfo $versionInfo
-     * @param array $translations
+     * @param string[] $translations
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\BadStateException
      * @throws \eZ\Publish\API\Repository\Exceptions\ContentFieldValidationException

eZ/Publish/Core/Repository/Tests/Service/Mock/ContentTest.php

Doc Comments +12 added lines, -5 removed lines

@@ -1038,7 +1038,7 @@ 
      * @param string $mainLanguageCode
      * @param \eZ\Publish\API\Repository\Values\Content\Field[] $structFields
      * @param \eZ\Publish\API\Repository\Values\ContentType\FieldDefinition[] $fieldDefinitions
-     * @param array $languageCodes
+     * @param string[] $languageCodes
      *
      * @return array
      */
@@ -1112,10 +1112,9 @@ 
      * @param \eZ\Publish\SPI\Persistence\Content\Field[] $spiFields
      * @param \eZ\Publish\API\Repository\Values\ContentType\FieldDefinition[] $fieldDefinitions
      * @param \eZ\Publish\API\Repository\Values\Content\LocationCreateStruct[] $locationCreateStructs
-     * @param \eZ\Publish\SPI\Persistence\Content\ObjectState\Group[] $objectStateGroups
      * @param bool $execute
      *
-     * @return mixed
+     * @return ContentCreateStruct
      */
     protected function assertForTestCreateContentNonRedundantFieldSet(
         $mainLanguageCode,
@@ -2000,7 +1999,7 @@ 
      * @param \eZ\Publish\API\Repository\Values\Content\Field[] $structFields
      * @param \eZ\Publish\API\Repository\Values\ContentType\FieldDefinition[] $fieldDefinitions
      *
-     * @return mixed
+     * @return ContentCreateStruct
      */
     protected function assertForTestCreateContentRequiredField(
         $mainLanguageCode,
@@ -4809,6 +4808,10 @@ 
         );
     }
 
+    /**
+     * @param Field[] $existingFields
+     * @param FieldDefinition[] $fieldDefinitions
+     */
     public function assertForTestUpdateContentRequiredField(
         $initialLanguageCode,
         $structFields,
@@ -5010,6 +5013,10 @@ 
         }
     }
 
+    /**
+     * @param Field[] $existingFields
+     * @param FieldDefinition[] $fieldDefinitions
+     */
     public function assertForTestUpdateContentThrowsContentFieldValidationException(
         $initialLanguageCode,
         $structFields,
@@ -5740,7 +5747,7 @@ 
      * @param array $translations
      * @param bool $useAlwaysAvailable
      *
-     * @return \PHPUnit\Framework\MockObject\MockObject|\eZ\Publish\API\Repository\Values\Content\Content
+     * @return APIContent
      */
     private function mockBuildContentDomainObject(SPIContent $spiContent, array $translations = null, bool $useAlwaysAvailable = null)
     {

eZ/Publish/API/Repository/Tests/BaseTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -236,7 +236,6 @@ 
      *
      * @param \eZ\Publish\API\Repository\Values\ValueObject $expectedValues
      * @param \eZ\Publish\API\Repository\Values\ValueObject $actualObject
-     * @param array $propertyNames
      */
     protected function assertStructPropertiesCorrect(ValueObject $expectedValues, ValueObject $actualObject, array $additionalProperties = [])
     {
@@ -297,6 +296,7 @@ 
 
     /**
      * Create a user in editor user group.
+     * @param string $email
      */
     protected function createUserVersion1(string $login = 'user', ?string $email = null): User
     {
@@ -525,7 +525,7 @@ 
     /**
      * Create role of a given name with the given policies described by an array.
      *
-     * @param $roleName
+     * @param string $roleName
      * @param array $policiesData [['module' => 'content', 'function' => 'read', 'limitations' => []]
      *
      * @return \eZ\Publish\API\Repository\Values\User\Role

eZ/Publish/Core/Persistence/Legacy/User/Gateway/DoctrineDatabase.php

Doc Comments +1 added lines, -1 removed lines

@@ -349,7 +349,7 @@
     /**
      * Remove role from user or user group, by assignment ID.
      *
-     * @param mixed $roleAssignmentId
+     * @param integer $roleAssignmentId
      */
     public function removeRoleAssignmentById($roleAssignmentId)
     {

eZ/Publish/Core/Persistence/Legacy/User/Handler.php

Doc Comments +4 added lines, -4 removed lines

@@ -200,7 +200,7 @@ 
     /**
      * Delete user with the given ID.
      *
-     * @param mixed $userId
+     * @param integer $userId
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\NotImplementedException
      */
@@ -326,7 +326,7 @@ 
     /**
      * Loads a role draft by the original role ID.
      *
-     * @param mixed $roleId ID of the role the draft was created from.
+     * @param integer $roleId ID of the role the draft was created from.
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException If role is not found
      *
@@ -502,7 +502,7 @@ 
     /**
      * Returns the user policies associated with the user (including inherited policies from user groups).
      *
-     * @param mixed $userId
+     * @param integer $userId
      *
      * @return \eZ\Publish\SPI\Persistence\User\Policy[]
      */
@@ -613,7 +613,7 @@ 
      *
      * Role Assignments with same roleId and limitationIdentifier will be merged together into one.
      *
-     * @param mixed $groupId In legacy storage engine this is the content object id roles are assigned to in ezuser_role.
+     * @param integer $groupId In legacy storage engine this is the content object id roles are assigned to in ezuser_role.
      *                      By the nature of legacy this can currently also be used to get by $userId.
      * @param bool $inherit If true also return inherited role assignments from user groups.
      *

eZ/Publish/Core/Persistence/Doctrine/ConnectionHandler.php

Doc Comments +4 added lines, -3 removed lines

@@ -69,7 +69,7 @@ 
     /**
      * Create a Connection Handler with corresponding Doctrine connection from DSN.
      *
-     * @param string|array $dsn
+     * @param string $dsn
      *
      * @return ConnectionHandler
      */
@@ -460,8 +460,9 @@ 
      *
      * This is an optimization and works around the ezcDB implementation.
      *
-     * @param string $identifier
      *
+     * @param string $name
+     * @param string $alias
      * @return string
      */
     public function alias($name, $alias)
@@ -496,7 +497,7 @@ 
      * @param string $table
      * @param string $column
      *
-     * @return mixed
+     * @return string
      */
     public function getAutoIncrementValue($table, $column)
     {

eZ/Publish/Core/Persistence/Legacy/Content/Gateway/ExceptionConversion.php

Doc Comments +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
      * Inserts a new content object.
      *
      * @param \eZ\Publish\SPI\Persistence\Content\CreateStruct $struct
-     * @param mixed $currentVersionNo
+     * @param integer $currentVersionNo
      *
      * @return int ID
      */