Completed
Push — 6.7 ( bac3e8...9d44b5 )
by André
41:23 queued 19:45
created
eZ/Publish/API/Repository/Tests/BaseTest.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -212,7 +212,6 @@  discard block
 block discarded – undo
212 212
      *
213 213
      * @param \eZ\Publish\API\Repository\Values\ValueObject $expectedValues
214 214
      * @param \eZ\Publish\API\Repository\Values\ValueObject $actualObject
215
-     * @param array $propertyNames
216 215
      */
217 216
     protected function assertStructPropertiesCorrect(ValueObject $expectedValues, ValueObject $actualObject, array $additionalProperties = array())
218 217
     {
@@ -474,7 +473,7 @@  discard block
 block discarded – undo
474 473
     /**
475 474
      * Create role of a given name with the given policies described by an array.
476 475
      *
477
-     * @param $roleName
476
+     * @param string $roleName
478 477
      * @param array $policiesData [['module' => 'content', 'function' => 'read', 'limitations' => []]
479 478
      *
480 479
      * @return \eZ\Publish\API\Repository\Values\User\Role
Please login to merge, or discard this patch.
eZ/Bundle/EzPublishRestBundle/Features/Context/RestClient/BuzzDriver.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@
 block discarded – undo
123 123
     /**
124 124
      * Get response status code.
125 125
      *
126
-     * @return string
126
+     * @return integer
127 127
      *
128 128
      * @throws \RuntimeException If request hasn't been send already
129 129
      */
Please login to merge, or discard this patch.
eZ/Publish/Core/Repository/ContentService.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1345,7 +1345,7 @@  discard block
 block discarded – undo
1345 1345
      *
1346 1346
      * @param \eZ\Publish\API\Repository\Values\Content\ContentUpdateStruct $contentUpdateStruct
1347 1347
      *
1348
-     * @return array
1348
+     * @return string[]
1349 1349
      */
1350 1350
     private function getUpdatedLanguageCodes(APIContentUpdateStruct $contentUpdateStruct)
1351 1351
     {
@@ -1372,7 +1372,7 @@  discard block
 block discarded – undo
1372 1372
      * @param \eZ\Publish\API\Repository\Values\Content\ContentUpdateStruct $contentUpdateStruct
1373 1373
      * @param \eZ\Publish\API\Repository\Values\Content\Content $content
1374 1374
      *
1375
-     * @return array
1375
+     * @return string[]
1376 1376
      */
1377 1377
     protected function getLanguageCodesForUpdate(APIContentUpdateStruct $contentUpdateStruct, APIContent $content)
1378 1378
     {
@@ -1491,7 +1491,7 @@  discard block
 block discarded – undo
1491 1491
      * @param \eZ\Publish\API\Repository\Values\Content\VersionInfo $versionInfo
1492 1492
      * @param int|null $publicationDate If null existing date is kept if there is one, otherwise current time is used.
1493 1493
      *
1494
-     * @return \eZ\Publish\API\Repository\Values\Content\Content
1494
+     * @return LocationCreateStruct
1495 1495
      */
1496 1496
     protected function internalPublishVersion(APIVersionInfo $versionInfo, $publicationDate = null)
1497 1497
     {
Please login to merge, or discard this patch.
eZ/Publish/Core/Repository/Tests/Service/Mock/Base.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -205,6 +205,9 @@  discard block
 block discarded – undo
205 205
         return $this->persistenceMock;
206 206
     }
207 207
 
208
+    /**
209
+     * @return RelationProcessor
210
+     */
208 211
     protected function getRelationProcessorMock()
209 212
     {
210 213
         return $this->getMock(RelationProcessor::class,
@@ -254,7 +257,7 @@  discard block
 block discarded – undo
254 257
      *
255 258
      * @param int $id
256 259
      *
257
-     * @return \eZ\Publish\API\Repository\Values\User\User
260
+     * @return null|\eZ\Publish\API\Repository\Values\User\UserReference
258 261
      */
259 262
     protected function getStubbedUser($id)
260 263
     {
Please login to merge, or discard this patch.
eZ/Publish/Core/REST/Server/Controller/Content.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -677,7 +677,7 @@  discard block
 block discarded – undo
677 677
      *
678 678
      * @deprecated Since platform 1.0. Forwards the request to the new /views location, but returns a 301.
679 679
      *
680
-     * @return \eZ\Publish\Core\REST\Server\Values\RestExecutedView
680
+     * @return \Symfony\Component\HttpFoundation\Response
681 681
      */
682 682
     public function createView()
683 683
     {
@@ -706,7 +706,7 @@  discard block
 block discarded – undo
706 706
     /**
707 707
      * @param \Symfony\Component\HttpFoundation\Request $request
708 708
      *
709
-     * @return mixed
709
+     * @return \eZ\Publish\API\Repository\Values\ValueObject
710 710
      */
711 711
     protected function parseContentRequest(Request $request)
712 712
     {
Please login to merge, or discard this patch.
eZ/Publish/Core/Persistence/Legacy/Content/Gateway/DoctrineDatabase.php 1 patch
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -117,9 +117,9 @@  discard block
 block discarded – undo
117 117
      * Inserts a new content object.
118 118
      *
119 119
      * @param \eZ\Publish\SPI\Persistence\Content\CreateStruct $struct
120
-     * @param mixed $currentVersionNo
120
+     * @param integer $currentVersionNo
121 121
      *
122
-     * @return int ID
122
+     * @return string ID
123 123
      */
124 124
     public function insertContentObject(CreateStruct $struct, $currentVersionNo = 1)
125 125
     {
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
      * @param \eZ\Publish\SPI\Persistence\Content\VersionInfo $versionInfo
222 222
      * @param \eZ\Publish\SPI\Persistence\Content\Field[] $fields
223 223
      *
224
-     * @return int ID
224
+     * @return string ID
225 225
      */
226 226
     public function insertVersion(VersionInfo $versionInfo, array $fields)
227 227
     {
@@ -615,7 +615,7 @@  discard block
 block discarded – undo
615 615
      * @param \eZ\Publish\SPI\Persistence\Content\Field $field
616 616
      * @param \eZ\Publish\Core\Persistence\Legacy\Content\StorageFieldValue $value
617 617
      *
618
-     * @return int ID
618
+     * @return string ID
619 619
      */
620 620
     public function insertNewField(Content $content, Field $field, StorageFieldValue $value)
621 621
     {
@@ -1094,7 +1094,7 @@  discard block
 block discarded – undo
1094 1094
      *
1095 1095
      * Result is returned with oldest version first (using version id as it has index and is auto increment).
1096 1096
      *
1097
-     * @param mixed $contentId
1097
+     * @param integer $contentId
1098 1098
      * @param mixed|null $status Optional argument to filter versions by status, like {@see VersionInfo::STATUS_ARCHIVED}.
1099 1099
      * @param int $limit Limit for items returned, -1 means none.
1100 1100
      *
@@ -1162,7 +1162,7 @@  discard block
 block discarded – undo
1162 1162
     /**
1163 1163
      * Returns all version numbers for the given $contentId.
1164 1164
      *
1165
-     * @param mixed $contentId
1165
+     * @param integer $contentId
1166 1166
      *
1167 1167
      * @return int[]
1168 1168
      */
@@ -1860,7 +1860,7 @@  discard block
 block discarded – undo
1860 1860
      *
1861 1861
      * @param \eZ\Publish\SPI\Persistence\Content\Relation\CreateStruct $createStruct
1862 1862
      *
1863
-     * @return int ID the inserted ID
1863
+     * @return string ID the inserted ID
1864 1864
      */
1865 1865
     public function insertRelation(RelationCreateStruct $createStruct)
1866 1866
     {
Please login to merge, or discard this patch.
eZ/Publish/API/Repository/Tests/URLAliasServiceTest.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1270,7 +1270,7 @@  discard block
 block discarded – undo
1270 1270
 
1271 1271
     /**
1272 1272
      * @param \eZ\Publish\API\Repository\Values\Content\ContentInfo $contentInfo
1273
-     * @param $fieldDefinitionIdentifier
1273
+     * @param string $fieldDefinitionIdentifier
1274 1274
      * @param array $fieldValues
1275 1275
      *
1276 1276
      * @return \eZ\Publish\API\Repository\Values\Content\Content
@@ -1387,6 +1387,10 @@  discard block
 block discarded – undo
1387 1387
         $contentTypeService->publishContentTypeDraft($contentTypeDraft);
1388 1388
     }
1389 1389
 
1390
+    /**
1391
+     * @param string $expectedPath
1392
+     * @param boolean $expectedIsHistory
1393
+     */
1390 1394
     private function assertUrlAliasPropertiesCorrect(
1391 1395
         Location $expectedDestinationLocation,
1392 1396
         $expectedPath,
Please login to merge, or discard this patch.
Core/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php 1 patch
Doc Comments   +24 added lines, -21 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
      *
96 96
      * @todo optimize
97 97
      *
98
-     * @param mixed $remoteId
98
+     * @param string $remoteId
99 99
      *
100 100
      * @return array
101 101
      */
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
     /**
250 250
      * Returns data for the first level children of the location identified by given $locationId.
251 251
      *
252
-     * @param mixed $locationId
252
+     * @param integer $locationId
253 253
      *
254 254
      * @return array
255 255
      */
@@ -376,6 +376,9 @@  discard block
 block discarded – undo
376 376
         }
377 377
     }
378 378
 
379
+    /**
380
+     * @param string $pathString
381
+     */
379 382
     private function isHiddenByParent($pathString, array $rows)
380 383
     {
381 384
         $parentNodeIds = explode('/', trim($pathString, '/'));
@@ -576,10 +579,10 @@  discard block
 block discarded – undo
576 579
      * Make the location identified by $locationId1 refer to the Content
577 580
      * referred to by $locationId2 and vice versa.
578 581
      *
579
-     * @param mixed $locationId1
580
-     * @param mixed $locationId2
582
+     * @param integer $locationId1
583
+     * @param integer $locationId2
581 584
      *
582
-     * @return bool
585
+     * @return boolean|null
583 586
      */
584 587
     public function swap($locationId1, $locationId2)
585 588
     {
@@ -736,7 +739,7 @@  discard block
 block discarded – undo
736 739
      * Create an entry in the node assignment table.
737 740
      *
738 741
      * @param \eZ\Publish\SPI\Persistence\Content\Location\CreateStruct $createStruct
739
-     * @param mixed $parentNodeId
742
+     * @param string $parentNodeId
740 743
      * @param int $type
741 744
      */
742 745
     public function createNodeAssignment(CreateStruct $createStruct, $parentNodeId, $type = self::NODE_ASSIGNMENT_OP_CODE_CREATE_NOP)
@@ -864,8 +867,8 @@  discard block
 block discarded – undo
864 867
      *
865 868
      * Convert existing node assignments into real locations.
866 869
      *
867
-     * @param mixed $contentId
868
-     * @param mixed $versionNo
870
+     * @param integer $contentId
871
+     * @param integer $versionNo
869 872
      */
870 873
     public function createLocationsFromNodeAssignments($contentId, $versionNo)
871 874
     {
@@ -933,8 +936,8 @@  discard block
 block discarded – undo
933 936
     /**
934 937
      * Updates all Locations of content identified with $contentId with $versionNo.
935 938
      *
936
-     * @param mixed $contentId
937
-     * @param mixed $versionNo
939
+     * @param integer $contentId
940
+     * @param integer $versionNo
938 941
      */
939 942
     public function updateLocationsContentVersionNo($contentId, $versionNo)
940 943
     {
@@ -1093,8 +1096,8 @@  discard block
 block discarded – undo
1093 1096
      * the node identified by given $locationId (current main node).
1094 1097
      * Assumes that content has more than one location.
1095 1098
      *
1096
-     * @param mixed $contentId
1097
-     * @param mixed $locationId
1099
+     * @param integer $contentId
1100
+     * @param integer $locationId
1098 1101
      *
1099 1102
      * @return array
1100 1103
      */
@@ -1130,9 +1133,9 @@  discard block
 block discarded – undo
1130 1133
      *
1131 1134
      * The associated content object is left untouched.
1132 1135
      *
1133
-     * @param mixed $locationId
1136
+     * @param integer $locationId
1134 1137
      *
1135
-     * @return bool
1138
+     * @return boolean|null
1136 1139
      */
1137 1140
     public function trashLocation($locationId)
1138 1141
     {
@@ -1161,8 +1164,8 @@  discard block
 block discarded – undo
1161 1164
      * at the old position. If this is not possible ( because the old location
1162 1165
      * does not exist any more) and exception is thrown.
1163 1166
      *
1164
-     * @param mixed $locationId
1165
-     * @param mixed|null $newParentId
1167
+     * @param integer $locationId
1168
+     * @param integer $newParentId
1166 1169
      *
1167 1170
      * @return \eZ\Publish\SPI\Persistence\Content\Location
1168 1171
      */
@@ -1415,10 +1418,10 @@  discard block
 block discarded – undo
1415 1418
      * Updates ezcontentobject_tree table for the given $contentId and eznode_assignment table for the given
1416 1419
      * $contentId, $parentLocationId and $versionNo
1417 1420
      *
1418
-     * @param mixed $contentId
1419
-     * @param mixed $locationId
1420
-     * @param mixed $versionNo version number, needed to update eznode_assignment table
1421
-     * @param mixed $parentLocationId parent location of location identified by $locationId, needed to update
1421
+     * @param integer $contentId
1422
+     * @param integer $locationId
1423
+     * @param integer $versionNo version number, needed to update eznode_assignment table
1424
+     * @param integer $parentLocationId parent location of location identified by $locationId, needed to update
1422 1425
      *        eznode_assignment table
1423 1426
      */
1424 1427
     public function changeMainLocation($contentId, $locationId, $versionNo, $parentLocationId)
@@ -1546,7 +1549,7 @@  discard block
 block discarded – undo
1546 1549
     /**
1547 1550
      * Get Query Builder for fetching data of all Locations except the Root node.
1548 1551
      *
1549
-     * @param array $columns list of columns to fetch
1552
+     * @param string[] $columns list of columns to fetch
1550 1553
      *
1551 1554
      * @return \Doctrine\DBAL\Query\QueryBuilder
1552 1555
      */
Please login to merge, or discard this patch.
Core/Persistence/Legacy/Content/UrlAlias/Gateway/DoctrineDatabase.php 1 patch
Doc Comments   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
      *
271 271
      * @param string $action
272 272
      * @param mixed $languageId
273
-     * @param mixed $newId
273
+     * @param integer $newId
274 274
      * @param mixed $parentId
275 275
      * @param string $textMD5
276 276
      */
@@ -444,9 +444,9 @@  discard block
 block discarded – undo
444 444
      *
445 445
      * Removes given $languageId from entry's language mask
446 446
      *
447
-     * @param mixed $parentId
447
+     * @param integer $parentId
448 448
      * @param string $textMD5
449
-     * @param mixed $languageId
449
+     * @param integer $languageId
450 450
      */
451 451
     protected function removeTranslation($parentId, $textMD5, $languageId)
452 452
     {
@@ -529,8 +529,8 @@  discard block
 block discarded – undo
529 529
      *
530 530
      * Update includes history entries.
531 531
      *
532
-     * @param mixed $oldParentId
533
-     * @param mixed $newParentId
532
+     * @param integer $oldParentId
533
+     * @param integer $newParentId
534 534
      */
535 535
     public function reparent($oldParentId, $newParentId)
536 536
     {
@@ -676,7 +676,7 @@  discard block
 block discarded – undo
676 676
     /**
677 677
      * Returns next value for "id" column.
678 678
      *
679
-     * @return mixed
679
+     * @return string
680 680
      */
681 681
     public function getNextId()
682 682
     {
@@ -819,7 +819,7 @@  discard block
 block discarded – undo
819 819
      * Loads autogenerated entry id by given $action and optionally $parentId.
820 820
      *
821 821
      * @param string $action
822
-     * @param mixed|null $parentId
822
+     * @param integer $parentId
823 823
      *
824 824
      * @return array
825 825
      */
@@ -1003,7 +1003,7 @@  discard block
 block discarded – undo
1003 1003
     /**
1004 1004
      * Deletes single custom alias row matched by composite primary key.
1005 1005
      *
1006
-     * @param mixed $parentId
1006
+     * @param integer $parentId
1007 1007
      * @param string $textMD5
1008 1008
      *
1009 1009
      * @return bool
@@ -1041,10 +1041,10 @@  discard block
 block discarded – undo
1041 1041
      *
1042 1042
      * If $id is set only autogenerated entries will be removed.
1043 1043
      *
1044
-     * @param mixed $action
1045
-     * @param mixed|null $id
1044
+     * @param string $action
1045
+     * @param integer $id
1046 1046
      *
1047
-     * @return bool
1047
+     * @return boolean|null
1048 1048
      */
1049 1049
     public function remove($action, $id = null)
1050 1050
     {
Please login to merge, or discard this patch.