ServiceAwareMatcherFactory::__construct() - Code Metrics - Inspection of "EZP-30880: Refactored MatcherFactory to avoid usin..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ca8025...177d87 )

by Łukasz

created 2019-08-28 22:22 UTC

ServiceAwareMatcherFactory::__construct() A

↳ Parent: ServiceAwareMatcherFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	4
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0

<?php
/**
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Bundle\EzPublishCoreBundle\Matcher;

use eZ\Publish\API\Repository\Repository;
use eZ\Publish\Core\MVC\Symfony\Matcher\ClassNameMatcherFactory;

/**
 * A view matcher factory that also accepts services as matchers.
 *
 * If a service id is passed as the MatcherIdentifier, this service will be used for the matching.
 * Otherwise, it will fallback to the class name based matcher factory.
 */
final class ServiceAwareMatcherFactory extends ClassNameMatcherFactory
{
    /** @var \eZ\Bundle\EzPublishCoreBundle\Matcher\ViewMatcherRegistry */
    private $viewMatcherRegistry;

    public function __construct(
        ViewMatcherRegistry $viewMatcherRegistry,
        Repository $repository,
        $relativeNamespace = null,
        array $matchConfig = []
    ) {
        $this->viewMatcherRegistry = $viewMatcherRegistry;

        parent::__construct($repository, $relativeNamespace, $matchConfig);
    }

    /**
     * @param string $matcherIdentifier
     *
     * @return \eZ\Publish\Core\MVC\Symfony\Matcher\ContentBased\MatcherInterface
     */
    protected function getMatcher($matcherIdentifier)
    {
        if (strpos($matcherIdentifier, '@') === 0) {
            return $this->viewMatcherRegistry->getMatcher(substr($matcherIdentifier, 1));
        }

        return parent::getMatcher($matcherIdentifier);

    }
}


1			<?php
2			/**
3			* @license For full copyright and license information view LICENSE file distributed with this source code.
4			*/
5			namespace eZ\Bundle\EzPublishCoreBundle\Matcher;
6
7			use eZ\Publish\API\Repository\Repository;
8			use eZ\Publish\Core\MVC\Symfony\Matcher\ClassNameMatcherFactory;
9
10			/**
11			* A view matcher factory that also accepts services as matchers.
12			*
13			* If a service id is passed as the MatcherIdentifier, this service will be used for the matching.
14			* Otherwise, it will fallback to the class name based matcher factory.
15			*/
16			final class ServiceAwareMatcherFactory extends ClassNameMatcherFactory
17			{
18			/** @var \eZ\Bundle\EzPublishCoreBundle\Matcher\ViewMatcherRegistry */
19			private $viewMatcherRegistry;
20
21			public function __construct(
22			ViewMatcherRegistry $viewMatcherRegistry,
23			Repository $repository,
24			$relativeNamespace = null,
25			array $matchConfig = []
26			) {
27			$this->viewMatcherRegistry = $viewMatcherRegistry;
28
29			parent::__construct($repository, $relativeNamespace, $matchConfig);
30			}
31
32			/**
33			* @param string $matcherIdentifier
34			*
35			* @return \eZ\Publish\Core\MVC\Symfony\Matcher\ContentBased\MatcherInterface
36			*/
37			protected function getMatcher($matcherIdentifier)
38			{
39			if (strpos($matcherIdentifier, '@') === 0) {
40			return $this->viewMatcherRegistry->getMatcher(substr($matcherIdentifier, 1));
41			}
42
43			return parent::getMatcher($matcherIdentifier);
			0 ignored issues – show Bug Compatibility introduced 2016-02-05 12:09 UTC by Report Bug Copy Issue Report The expression `parent::getMatcher($matcherIdentifier);` of type `eZ\Publish\Core\MVC\Symf...er\ViewMatcherInterface` adds the type `eZ\Publish\Core\MVC\Symf...er\ViewMatcherInterface` to the return on line 43 which is incompatible with the return type documented by `eZ\Bundle\EzPublishCoreB...cherFactory::getMatcher` of type `eZ\Publish\Core\MVC\Symf...tBased\MatcherInterface`. Loading history...
44			}
45			}
46

ezsystems / ezpublish-kernel

Push — master ( ca8025...177d87 )

ServiceAwareMatcherFactory::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like