Complex classes like Handler often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Handler, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
26 | class Handler implements BaseLocationHandler |
||
27 | { |
||
28 | /** |
||
29 | * Gateway for handling location data. |
||
30 | * |
||
31 | * @var \eZ\Publish\Core\Persistence\Legacy\Content\Location\Gateway |
||
32 | */ |
||
33 | protected $locationGateway; |
||
34 | |||
35 | /** |
||
36 | * Location locationMapper. |
||
37 | * |
||
38 | * @var \eZ\Publish\Core\Persistence\Legacy\Content\Location\Mapper |
||
39 | */ |
||
40 | protected $locationMapper; |
||
41 | |||
42 | /** |
||
43 | * Content handler. |
||
44 | * |
||
45 | * @var \eZ\Publish\Core\Persistence\Legacy\Content\Handler |
||
46 | */ |
||
47 | protected $contentHandler; |
||
48 | |||
49 | /** |
||
50 | * Object state handler. |
||
51 | * |
||
52 | * @var \eZ\Publish\Core\Persistence\Legacy\Content\ObjectState\Handler |
||
53 | */ |
||
54 | protected $objectStateHandler; |
||
55 | |||
56 | /** |
||
57 | * Tree handler. |
||
58 | * |
||
59 | * @var \eZ\Publish\Core\Persistence\Legacy\Content\TreeHandler |
||
60 | */ |
||
61 | protected $treeHandler; |
||
62 | |||
63 | /** |
||
64 | * Construct from userGateway. |
||
65 | * |
||
66 | * @param \eZ\Publish\Core\Persistence\Legacy\Content\Location\Gateway $locationGateway |
||
67 | * @param \eZ\Publish\Core\Persistence\Legacy\Content\Location\Mapper $locationMapper |
||
68 | * @param \eZ\Publish\Core\Persistence\Legacy\Content\Handler $contentHandler |
||
69 | * @param \eZ\Publish\Core\Persistence\Legacy\Content\ObjectState\Handler $objectStateHandler |
||
70 | * @param \eZ\Publish\Core\Persistence\Legacy\Content\TreeHandler $treeHandler |
||
71 | * |
||
72 | * @return \eZ\Publish\Core\Persistence\Legacy\Content\Location\Handler |
||
|
|||
73 | */ |
||
74 | public function __construct( |
||
87 | |||
88 | /** |
||
89 | * Returns parent path string for a path string. |
||
90 | * |
||
91 | * @param string $pathString |
||
92 | * |
||
93 | * @return string |
||
94 | */ |
||
95 | protected function getParentPathString($pathString) |
||
99 | |||
100 | /** |
||
101 | * {@inheritdoc} |
||
102 | */ |
||
103 | public function load($locationId, array $translations = null, bool $useAlwaysAvailable = true) |
||
107 | |||
108 | /** |
||
109 | * Loads the subtree ids of the location identified by $locationId. |
||
110 | * |
||
111 | * @param int $locationId |
||
112 | * |
||
113 | * @return array Location ids are in the index, Content ids in the value. |
||
114 | */ |
||
115 | public function loadSubtreeIds($locationId) |
||
119 | |||
120 | /** |
||
121 | * {@inheritdoc} |
||
122 | */ |
||
123 | public function loadByRemoteId($remoteId, array $translations = null, bool $useAlwaysAvailable = true) |
||
129 | |||
130 | /** |
||
131 | * Loads all locations for $contentId, optionally limited to a sub tree |
||
132 | * identified by $rootLocationId. |
||
133 | * |
||
134 | * @param int $contentId |
||
135 | * @param int $rootLocationId |
||
136 | * |
||
137 | * @return \eZ\Publish\SPI\Persistence\Content\Location[] |
||
138 | */ |
||
139 | public function loadLocationsByContent($contentId, $rootLocationId = null) |
||
145 | |||
146 | /** |
||
147 | * @see \eZ\Publish\SPI\Persistence\Content\Location\Handler::loadParentLocationsForDraftContent |
||
148 | */ |
||
149 | public function loadParentLocationsForDraftContent($contentId) |
||
155 | |||
156 | /** |
||
157 | * Returns an array of default content states with content state group id as key. |
||
158 | * |
||
159 | * @return \eZ\Publish\SPI\Persistence\Content\ObjectState[] |
||
160 | */ |
||
161 | protected function getDefaultContentStates() |
||
175 | |||
176 | /** |
||
177 | * @param Content $content |
||
178 | * @param \eZ\Publish\SPI\Persistence\Content\ObjectState[] $contentStates |
||
179 | */ |
||
180 | protected function setContentStates(Content $content, array $contentStates) |
||
190 | |||
191 | /** |
||
192 | * Copy location object identified by $sourceId, into destination identified by $destinationParentId. |
||
193 | * |
||
194 | * Performs a deep copy of the location identified by $sourceId and all of |
||
195 | * its child locations, copying the most recent published content object |
||
196 | * for each location to a new content object without any additional version |
||
197 | * information. Relations are not copied. URLs are not touched at all. |
||
198 | * |
||
199 | * @todo Either move to async/batch or find ways toward optimizing away operations per object. |
||
200 | * @todo Optionally retain dates and set creator |
||
201 | * |
||
202 | * @param mixed $sourceId |
||
203 | * @param mixed $destinationParentId |
||
204 | * @param int|null $newOwnerId |
||
205 | * |
||
206 | * @return Location the newly created Location. |
||
207 | * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException |
||
208 | */ |
||
209 | public function copySubtree($sourceId, $destinationParentId, $newOwnerId = null) |
||
311 | |||
312 | /** |
||
313 | * Retrieves section ID of the location's content. |
||
314 | * |
||
315 | * @param int $locationId |
||
316 | * |
||
317 | * @return int |
||
318 | */ |
||
319 | private function getSectionId($locationId) |
||
326 | |||
327 | /** |
||
328 | * If the location is the main location for its content, updates subtree section. |
||
329 | * |
||
330 | * @param Location $location |
||
331 | * @param int $sectionId |
||
332 | */ |
||
333 | private function updateSubtreeSectionIfNecessary(Location $location, $sectionId) |
||
339 | |||
340 | /** |
||
341 | * Checks if the location is the main location for its content. |
||
342 | * |
||
343 | * @param Location $location |
||
344 | * |
||
345 | * @return bool |
||
346 | */ |
||
347 | private function isMainLocation(Location $location) |
||
353 | |||
354 | /** |
||
355 | * Moves location identified by $sourceId into new parent identified by $destinationParentId. |
||
356 | * |
||
357 | * Performs a full move of the location identified by $sourceId to a new |
||
358 | * destination, identified by $destinationParentId. Relations do not need |
||
359 | * to be updated, since they refer to Content. URLs are not touched. |
||
360 | * |
||
361 | * @param mixed $sourceId |
||
362 | * @param mixed $destinationParentId |
||
363 | * |
||
364 | * @return bool |
||
365 | */ |
||
366 | public function move($sourceId, $destinationParentId) |
||
387 | |||
388 | /** |
||
389 | * Marks the given nodes and all ancestors as modified. |
||
390 | * |
||
391 | * Optionally a time stamp with the modification date may be specified, |
||
392 | * otherwise the current time is used. |
||
393 | * |
||
394 | * @param int|string $locationId |
||
395 | * @param int $timestamp |
||
396 | */ |
||
397 | public function markSubtreeModified($locationId, $timestamp = null) |
||
403 | |||
404 | /** |
||
405 | * Sets a location to be hidden, and it self + all children to invisible. |
||
406 | * |
||
407 | * @param mixed $id Location ID |
||
408 | */ |
||
409 | public function hide($id) |
||
415 | |||
416 | /** |
||
417 | * Sets a location to be unhidden, and self + children to visible unless a parent is hiding the tree. |
||
418 | * If not make sure only children down to first hidden node is marked visible. |
||
419 | * |
||
420 | * @param mixed $id |
||
421 | */ |
||
422 | public function unHide($id) |
||
428 | |||
429 | /** |
||
430 | * Swaps the content object being pointed to by a location object. |
||
431 | * |
||
432 | * Make the location identified by $locationId1 refer to the Content |
||
433 | * referred to by $locationId2 and vice versa. |
||
434 | * |
||
435 | * @param mixed $locationId1 |
||
436 | * @param mixed $locationId2 |
||
437 | * |
||
438 | * @return bool |
||
439 | */ |
||
440 | public function swap($locationId1, $locationId2) |
||
444 | |||
445 | /** |
||
446 | * Updates an existing location. |
||
447 | * |
||
448 | * @param \eZ\Publish\SPI\Persistence\Content\Location\UpdateStruct $location |
||
449 | * @param int $locationId |
||
450 | */ |
||
451 | public function update(UpdateStruct $location, $locationId) |
||
455 | |||
456 | /** |
||
457 | * Creates a new location rooted at $location->parentId. |
||
458 | * |
||
459 | * @param \eZ\Publish\SPI\Persistence\Content\Location\CreateStruct $createStruct |
||
460 | * |
||
461 | * @return \eZ\Publish\SPI\Persistence\Content\Location |
||
462 | */ |
||
463 | public function create(CreateStruct $createStruct) |
||
475 | |||
476 | /** |
||
477 | * Removes all Locations under and including $locationId. |
||
478 | * |
||
479 | * Performs a recursive delete on the location identified by $locationId, |
||
480 | * including all of its child locations. Content which is not referred to |
||
481 | * by any other location is automatically removed. Content which looses its |
||
482 | * main Location will get the first of its other Locations assigned as the |
||
483 | * new main Location. |
||
484 | * |
||
485 | * @param mixed $locationId |
||
486 | * |
||
487 | * @return bool |
||
488 | */ |
||
489 | public function removeSubtree($locationId) |
||
493 | |||
494 | /** |
||
495 | * Set section on all content objects in the subtree. |
||
496 | * |
||
497 | * @param mixed $locationId |
||
498 | * @param mixed $sectionId |
||
499 | */ |
||
500 | public function setSectionForSubtree($locationId, $sectionId) |
||
504 | |||
505 | /** |
||
506 | * Changes main location of content identified by given $contentId to location identified by given $locationId. |
||
507 | * |
||
508 | * Updates ezcontentobject_tree and eznode_assignment tables (eznode_assignment for content current version number). |
||
509 | * |
||
510 | * @param mixed $contentId |
||
511 | * @param mixed $locationId |
||
512 | */ |
||
513 | public function changeMainLocation($contentId, $locationId) |
||
517 | |||
518 | /** |
||
519 | * Get the total number of all existing Locations. Can be combined with loadAllLocations. |
||
520 | * |
||
521 | * @return int |
||
522 | */ |
||
523 | public function countAllLocations() |
||
527 | |||
528 | /** |
||
529 | * Bulk-load all existing Locations, constrained by $limit and $offset to paginate results. |
||
530 | * |
||
531 | * @param int $offset |
||
532 | * @param int $limit |
||
533 | * |
||
534 | * @return \eZ\Publish\SPI\Persistence\Content\Location[] |
||
535 | */ |
||
536 | public function loadAllLocations($offset, $limit) |
||
542 | } |
||
543 |
Adding a
@return
annotation to a constructor is not recommended, since a constructor does not have a meaningful return value.Please refer to the PHP core documentation on constructors.