ezsystems / ezpublish-kernel

eZ/Bundle/EzPublishCoreBundle/Tests/Imagine/PlaceholderAliasGeneratorTest.php

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 use eZ\Publish\API\Repository\Values\Content\VersionInfo as APIVersionInfo;
 use eZ\Publish\Core\FieldType\Image\Value as ImageValue;
 use eZ\Publish\Core\FieldType\Null\Value as NullValue;
-use eZ\Publish\Core\FieldType\Value as FieldTypeValue;
 use eZ\Publish\Core\FieldType\Value;
 use eZ\Publish\Core\IO\IOServiceInterface;
 use eZ\Publish\Core\IO\Values\BinaryFileCreateStruct;

eZ/Publish/Core/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php

Doc Comments +23 added lines, -20 removed lines

@@ -95,7 +95,7 @@ 
      *
      * @todo optimize
      *
-     * @param mixed $remoteId
+     * @param string $remoteId
      *
      * @return array
      */
@@ -249,7 +249,7 @@ 
     /**
      * Returns data for the first level children of the location identified by given $locationId.
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      *
      * @return array
      */
@@ -376,6 +376,9 @@ 
         }
     }
 
+    /**
+     * @param string $pathString
+     */
     private function isHiddenByParent($pathString, array $rows)
     {
         $parentNodeIds = explode('/', trim($pathString, '/'));
@@ -576,10 +579,10 @@ 
      * Make the location identified by $locationId1 refer to the Content
      * referred to by $locationId2 and vice versa.
      *
-     * @param mixed $locationId1
-     * @param mixed $locationId2
+     * @param integer $locationId1
+     * @param integer $locationId2
      *
-     * @return bool
+     * @return boolean|null
      */
     public function swap($locationId1, $locationId2)
     {
@@ -736,7 +739,7 @@ 
      * Create an entry in the node assignment table.
      *
      * @param \eZ\Publish\SPI\Persistence\Content\Location\CreateStruct $createStruct
-     * @param mixed $parentNodeId
+     * @param string $parentNodeId
      * @param int $type
      */
     public function createNodeAssignment(CreateStruct $createStruct, $parentNodeId, $type = self::NODE_ASSIGNMENT_OP_CODE_CREATE_NOP)
@@ -864,8 +867,8 @@ 
      *
      * Convert existing node assignments into real locations.
      *
-     * @param mixed $contentId
-     * @param mixed $versionNo
+     * @param integer $contentId
+     * @param integer $versionNo
      */
     public function createLocationsFromNodeAssignments($contentId, $versionNo)
     {
@@ -933,8 +936,8 @@ 
     /**
      * Updates all Locations of content identified with $contentId with $versionNo.
      *
-     * @param mixed $contentId
-     * @param mixed $versionNo
+     * @param integer $contentId
+     * @param integer $versionNo
      */
     public function updateLocationsContentVersionNo($contentId, $versionNo)
     {
@@ -1093,8 +1096,8 @@ 
      * the node identified by given $locationId (current main node).
      * Assumes that content has more than one location.
      *
-     * @param mixed $contentId
-     * @param mixed $locationId
+     * @param integer $contentId
+     * @param integer $locationId
      *
      * @return array
      */
@@ -1130,9 +1133,9 @@ 
      *
      * The associated content object is left untouched.
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      *
-     * @return bool
+     * @return boolean|null
      */
     public function trashLocation($locationId)
     {
@@ -1161,8 +1164,8 @@ 
      * at the old position. If this is not possible ( because the old location
      * does not exist any more) and exception is thrown.
      *
-     * @param mixed $locationId
-     * @param mixed|null $newParentId
+     * @param integer $locationId
+     * @param integer $newParentId
      *
      * @return \eZ\Publish\SPI\Persistence\Content\Location
      */
@@ -1415,10 +1418,10 @@ 
      * Updates ezcontentobject_tree table for the given $contentId and eznode_assignment table for the given
      * $contentId, $parentLocationId and $versionNo
      *
-     * @param mixed $contentId
-     * @param mixed $locationId
-     * @param mixed $versionNo version number, needed to update eznode_assignment table
-     * @param mixed $parentLocationId parent location of location identified by $locationId, needed to update
+     * @param integer $contentId
+     * @param integer $locationId
+     * @param integer $versionNo version number, needed to update eznode_assignment table
+     * @param integer $parentLocationId parent location of location identified by $locationId, needed to update
      *        eznode_assignment table
      */
     public function changeMainLocation($contentId, $locationId, $versionNo, $parentLocationId)

eZ/Publish/Core/Repository/Repository.php

Doc Comments +1 added lines, -1 removed lines

@@ -377,7 +377,7 @@
      * @throws \RuntimeException Thrown on recursive sudo() use.
      * @throws \Exception Re throws exceptions thrown inside $callback
      *
-     * @return mixed
+     * @return \eZ\Publish\API\Repository\Values\Content\Content
      */
     public function sudo(Closure $callback, RepositoryInterface $outerRepository = null)
     {

eZ/Publish/Core/SignalSlot/Repository.php

Doc Comments +1 added lines, -1 removed lines

@@ -166,7 +166,7 @@
      * @param \eZ\Publish\Core\SignalSlot\LanguageService $languageService
      * @param \eZ\Publish\Core\SignalSlot\URLService $urlService
      * @param \eZ\Publish\Core\SignalSlot\BookmarkService $bookmarkService
-     * @param \eZ\Publish\API\Repository\NotificationService $notificationService
+     * @param \PHPUnit\Framework\MockObject\MockObject $notificationService
      */
     public function __construct(
         RepositoryInterface $repository,

eZ/Bundle/EzPublishCoreBundle/Tests/Routing/DefaultRouterTest.php

Doc Comments +4 added lines, -1 removed lines

@@ -51,7 +51,7 @@ 
     }
 
     /**
-     * @param array $mockedMethods
+     * @param string[] $mockedMethods
      *
      * @return \PHPUnit\Framework\MockObject\MockObject|DefaultRouter
      */
@@ -318,6 +318,9 @@ 
         ];
     }
 
+    /**
+     * @param string $uri
+     */
     private function getExpectedRequestContext($uri)
     {
         $requestContext = new RequestContext();

eZ/Publish/Core/Persistence/Cache/ContentHandler.php

Doc Comments +2 added lines, -2 removed lines

@@ -419,9 +419,9 @@
      * For use when generating cache, not on invalidation.
      *
      * @param \eZ\Publish\SPI\Persistence\Content\ContentInfo $contentInfo
-     * @param array $tags Optional, can be used to specify other tags.
+     * @param string[] $tags Optional, can be used to specify other tags.
      *
-     * @return array
+     * @return string[]
      */
     private function getCacheTags(ContentInfo $contentInfo, array $tags = [])
     {

eZ/Publish/Core/Persistence/Legacy/Content/Gateway/DoctrineDatabase.php

Doc Comments +7 added lines, -7 removed lines

@@ -117,9 +117,9 @@ 
      * Inserts a new content object.
      *
      * @param \eZ\Publish\SPI\Persistence\Content\CreateStruct $struct
-     * @param mixed $currentVersionNo
+     * @param integer $currentVersionNo
      *
-     * @return int ID
+     * @return string ID
      */
     public function insertContentObject(CreateStruct $struct, $currentVersionNo = 1)
     {
@@ -221,7 +221,7 @@ 
      * @param \eZ\Publish\SPI\Persistence\Content\VersionInfo $versionInfo
      * @param \eZ\Publish\SPI\Persistence\Content\Field[] $fields
      *
-     * @return int ID
+     * @return string ID
      */
     public function insertVersion(VersionInfo $versionInfo, array $fields)
     {
@@ -615,7 +615,7 @@ 
      * @param \eZ\Publish\SPI\Persistence\Content\Field $field
      * @param \eZ\Publish\Core\Persistence\Legacy\Content\StorageFieldValue $value
      *
-     * @return int ID
+     * @return string ID
      */
     public function insertNewField(Content $content, Field $field, StorageFieldValue $value)
     {
@@ -1094,7 +1094,7 @@ 
      *
      * Result is returned with oldest version first (using version id as it has index and is auto increment).
      *
-     * @param mixed $contentId
+     * @param integer $contentId
      * @param mixed|null $status Optional argument to filter versions by status, like {@see VersionInfo::STATUS_ARCHIVED}.
      * @param int $limit Limit for items returned, -1 means none.
      *
@@ -1162,7 +1162,7 @@ 
     /**
      * Returns all version numbers for the given $contentId.
      *
-     * @param mixed $contentId
+     * @param integer $contentId
      *
      * @return int[]
      */
@@ -1860,7 +1860,7 @@ 
      *
      * @param \eZ\Publish\SPI\Persistence\Content\Relation\CreateStruct $createStruct
      *
-     * @return int ID the inserted ID
+     * @return string ID the inserted ID
      */
     public function insertRelation(RelationCreateStruct $createStruct)
     {