Completed
Push — ezp-26146_location_swap_incons... ( baaf24...58154b )
by
unknown
41:06 queued 15:46
created
eZ/Bundle/EzPublishLegacySearchEngineBundle/Command/CreateIndexCommand.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
      * @param \eZ\Publish\Core\Persistence\Database\DatabaseHandler $databaseHandler
149 149
      * @param int $contentObjectStatus ContentInfo constant
150 150
      *
151
-     * @return int
151
+     * @return string
152 152
      */
153 153
     private function getContentObjectsTotalCount(DatabaseHandler $databaseHandler, $contentObjectStatus)
154 154
     {
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
      *
169 169
      * @param \Symfony\Component\Console\Output\OutputInterface $output
170 170
      * @param \Symfony\Component\Console\Helper\ProgressHelper $progress
171
-     * @param $message
171
+     * @param string $message
172 172
      */
173 173
     private function logWarning(OutputInterface $output, ProgressHelper $progress, $message)
174 174
     {
Please login to merge, or discard this patch.
Publish/Core/Search/Legacy/Content/WordIndexer/Gateway/DoctrineDatabase.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,6 @@
 block discarded – undo
14 14
 use eZ\Publish\Core\Search\Legacy\Content\FullTextData;
15 15
 use eZ\Publish\SPI\Persistence\Content;
16 16
 use eZ\Publish\SPI\Persistence\Content\Type\Handler as SPITypeHandler;
17
-use eZ\Publish\SPI\Search\Field;
18 17
 
19 18
 /**
20 19
  * WordIndexer gateway implementation using the Doctrine database.
Please login to merge, or discard this patch.
Publish/Core/Search/Legacy/Content/WordIndexer/Repository/SearchIndex.php 1 patch
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -127,15 +127,15 @@
 block discarded – undo
127 127
      * Link word with specific content object (legacy db table: ezsearch_object_word_link).
128 128
      *
129 129
      * @param $wordId
130
-     * @param $contentId
131
-     * @param $frequency
132
-     * @param $placement
130
+     * @param integer $contentId
131
+     * @param integer $frequency
132
+     * @param integer $placement
133 133
      * @param $nextWordId
134 134
      * @param $prevWordId
135
-     * @param $contentTypeId
135
+     * @param integer $contentTypeId
136 136
      * @param $fieldTypeId
137
-     * @param $published
138
-     * @param $sectionId
137
+     * @param integer $published
138
+     * @param integer $sectionId
139 139
      * @param $identifier
140 140
      * @param $integerValue
141 141
      */
Please login to merge, or discard this patch.
eZ/Publish/Core/Persistence/Database/DatabaseHandler.php 1 patch
Doc Comments   +9 added lines, -4 removed lines patch added patch discarded remove patch
@@ -26,16 +26,19 @@  discard block
 block discarded – undo
26 26
 
27 27
     /**
28 28
      * Begin a transaction.
29
+     * @return void
29 30
      */
30 31
     public function beginTransaction();
31 32
 
32 33
     /**
33 34
      * Commit a transaction.
35
+     * @return void
34 36
      */
35 37
     public function commit();
36 38
 
37 39
     /**
38 40
      * Rollback a transaction.
41
+     * @return void
39 42
      */
40 43
     public function rollBack();
41 44
 
@@ -59,6 +62,7 @@  discard block
 block discarded – undo
59 62
      * Execute a query against the database.
60 63
      *
61 64
      * @param string $query
65
+     * @return void
62 66
      */
63 67
     public function exec($query);
64 68
 
@@ -67,7 +71,7 @@  discard block
 block discarded – undo
67 71
      *
68 72
      * Statements are ducktyped, but need to work like PDOStatement.
69 73
      *
70
-     * @return object
74
+     * @return \Doctrine\DBAL\Driver\Statement
71 75
      */
72 76
     public function prepare($query);
73 77
 
@@ -137,8 +141,9 @@  discard block
 block discarded – undo
137 141
      *
138 142
      * This is an optimization and works around the ezcDB implementation.
139 143
      *
140
-     * @param string $identifier
141 144
      *
145
+     * @param string $name
146
+     * @param string $alias
142 147
      * @return string
143 148
      */
144 149
     public function alias($name, $alias);
@@ -167,7 +172,7 @@  discard block
 block discarded – undo
167 172
      * @param string $table
168 173
      * @param string $column
169 174
      *
170
-     * @return mixed
175
+     * @return string
171 176
      */
172 177
     public function getAutoIncrementValue($table, $column);
173 178
 
@@ -184,7 +189,7 @@  discard block
 block discarded – undo
184 189
     /**
185 190
      * Returns underlying connection (e.g. Doctrine connection object).
186 191
      *
187
-     * @return mixed
192
+     * @return \Doctrine\DBAL\Connection
188 193
      */
189 194
     public function getConnection();
190 195
 }
Please login to merge, or discard this patch.
Core/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php 1 patch
Doc Comments   +26 added lines, -23 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
      *
92 92
      * @todo optimize
93 93
      *
94
-     * @param mixed $remoteId
94
+     * @param string $remoteId
95 95
      *
96 96
      * @return array
97 97
      */
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
     /**
247 247
      * Returns data for the first level children of the location identified by given $locationId.
248 248
      *
249
-     * @param mixed $locationId
249
+     * @param integer $locationId
250 250
      *
251 251
      * @return array
252 252
      */
@@ -373,6 +373,9 @@  discard block
 block discarded – undo
373 373
         }
374 374
     }
375 375
 
376
+    /**
377
+     * @param string $pathString
378
+     */
376 379
     private function isHiddenByParent($pathString, array $rows)
377 380
     {
378 381
         $parentNodeIds = explode('/', trim($pathString, '/'));
@@ -573,10 +576,10 @@  discard block
 block discarded – undo
573 576
      * Make the location identified by $locationId1 refer to the Content
574 577
      * referred to by $locationId2 and vice versa.
575 578
      *
576
-     * @param mixed $locationId1
577
-     * @param mixed $locationId2
579
+     * @param integer $locationId1
580
+     * @param integer $locationId2
578 581
      *
579
-     * @return bool
582
+     * @return false|null
580 583
      */
581 584
     public function swap($locationId1, $locationId2)
582 585
     {
@@ -777,7 +780,7 @@  discard block
 block discarded – undo
777 780
      * Create an entry in the node assignment table.
778 781
      *
779 782
      * @param \eZ\Publish\SPI\Persistence\Content\Location\CreateStruct $createStruct
780
-     * @param mixed $parentNodeId
783
+     * @param string $parentNodeId
781 784
      * @param int $type
782 785
      */
783 786
     public function createNodeAssignment(CreateStruct $createStruct, $parentNodeId, $type = self::NODE_ASSIGNMENT_OP_CODE_CREATE_NOP)
@@ -905,8 +908,8 @@  discard block
 block discarded – undo
905 908
      *
906 909
      * Convert existing node assignments into real locations.
907 910
      *
908
-     * @param mixed $contentId
909
-     * @param mixed $versionNo
911
+     * @param integer $contentId
912
+     * @param integer $versionNo
910 913
      */
911 914
     public function createLocationsFromNodeAssignments($contentId, $versionNo)
912 915
     {
@@ -974,8 +977,8 @@  discard block
 block discarded – undo
974 977
     /**
975 978
      * Updates all Locations of content identified with $contentId with $versionNo.
976 979
      *
977
-     * @param mixed $contentId
978
-     * @param mixed $versionNo
980
+     * @param integer $contentId
981
+     * @param integer $versionNo
979 982
      */
980 983
     public function updateLocationsContentVersionNo($contentId, $versionNo)
981 984
     {
@@ -1134,8 +1137,8 @@  discard block
 block discarded – undo
1134 1137
      * the node identified by given $locationId (current main node).
1135 1138
      * Assumes that content has more than one location.
1136 1139
      *
1137
-     * @param mixed $contentId
1138
-     * @param mixed $locationId
1140
+     * @param integer $contentId
1141
+     * @param integer $locationId
1139 1142
      *
1140 1143
      * @return array
1141 1144
      */
@@ -1171,9 +1174,9 @@  discard block
 block discarded – undo
1171 1174
      *
1172 1175
      * The associated content object is left untouched.
1173 1176
      *
1174
-     * @param mixed $locationId
1177
+     * @param integer $locationId
1175 1178
      *
1176
-     * @return bool
1179
+     * @return boolean|null
1177 1180
      */
1178 1181
     public function trashLocation($locationId)
1179 1182
     {
@@ -1202,8 +1205,8 @@  discard block
 block discarded – undo
1202 1205
      * at the old position. If this is not possible ( because the old location
1203 1206
      * does not exist any more) and exception is thrown.
1204 1207
      *
1205
-     * @param mixed $locationId
1206
-     * @param mixed|null $newParentId
1208
+     * @param integer $locationId
1209
+     * @param integer $newParentId
1207 1210
      *
1208 1211
      * @return \eZ\Publish\SPI\Persistence\Content\Location
1209 1212
      */
@@ -1377,10 +1380,10 @@  discard block
 block discarded – undo
1377 1380
     /**
1378 1381
      * Set section on all content objects in the subtree.
1379 1382
      *
1380
-     * @param mixed $pathString
1381
-     * @param mixed $sectionId
1383
+     * @param string $pathString
1384
+     * @param integer $sectionId
1382 1385
      *
1383
-     * @return bool
1386
+     * @return boolean|null
1384 1387
      */
1385 1388
     public function setSectionForSubtree($pathString, $sectionId)
1386 1389
     {
@@ -1446,10 +1449,10 @@  discard block
 block discarded – undo
1446 1449
      * Updates ezcontentobject_tree table for the given $contentId and eznode_assignment table for the given
1447 1450
      * $contentId, $parentLocationId and $versionNo
1448 1451
      *
1449
-     * @param mixed $contentId
1450
-     * @param mixed $locationId
1451
-     * @param mixed $versionNo version number, needed to update eznode_assignment table
1452
-     * @param mixed $parentLocationId parent location of location identified by $locationId, needed to update
1452
+     * @param integer $contentId
1453
+     * @param integer $locationId
1454
+     * @param integer $versionNo version number, needed to update eznode_assignment table
1455
+     * @param integer $parentLocationId parent location of location identified by $locationId, needed to update
1453 1456
      *        eznode_assignment table
1454 1457
      */
1455 1458
     public function changeMainLocation($contentId, $locationId, $versionNo, $parentLocationId)
Please login to merge, or discard this patch.
Core/Persistence/Legacy/Content/UrlAlias/Gateway/DoctrineDatabase.php 1 patch
Doc Comments   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
      *
251 251
      * @param string $action
252 252
      * @param mixed $languageId
253
-     * @param mixed $newId
253
+     * @param integer $newId
254 254
      * @param mixed $parentId
255 255
      * @param string $textMD5
256 256
      */
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
      * @param mixed $locationId1
323 323
      * @param mixed $locationId2
324 324
      *
325
-     * @return bool
325
+     * @return false|null
326 326
      */
327 327
     public function swap($locationId1, $locationId2)
328 328
     {
@@ -533,8 +533,8 @@  discard block
 block discarded – undo
533 533
      *
534 534
      * Update includes history entries.
535 535
      *
536
-     * @param mixed $oldParentId
537
-     * @param mixed $newParentId
536
+     * @param integer $oldParentId
537
+     * @param integer $newParentId
538 538
      */
539 539
     public function reparent($oldParentId, $newParentId)
540 540
     {
@@ -680,7 +680,7 @@  discard block
 block discarded – undo
680 680
     /**
681 681
      * Returns next value for "id" column.
682 682
      *
683
-     * @return mixed
683
+     * @return string
684 684
      */
685 685
     public function getNextId()
686 686
     {
@@ -995,7 +995,7 @@  discard block
 block discarded – undo
995 995
     /**
996 996
      * Deletes single custom alias row matched by composite primary key.
997 997
      *
998
-     * @param mixed $parentId
998
+     * @param integer $parentId
999 999
      * @param string $textMD5
1000 1000
      *
1001 1001
      * @return bool
@@ -1033,10 +1033,10 @@  discard block
 block discarded – undo
1033 1033
      *
1034 1034
      * If $id is set only autogenerated entries will be removed.
1035 1035
      *
1036
-     * @param mixed $action
1037
-     * @param mixed|null $id
1036
+     * @param string $action
1037
+     * @param integer $id
1038 1038
      *
1039
-     * @return bool
1039
+     * @return boolean|null
1040 1040
      */
1041 1041
     public function remove($action, $id = null)
1042 1042
     {
Please login to merge, or discard this patch.
eZ/Publish/Core/Persistence/Legacy/Content/UrlAlias/Handler.php 1 patch
Doc Comments   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -101,8 +101,8 @@  discard block
 block discarded – undo
101 101
      * $alwaysAvailable controls whether the url alias is accessible in all
102 102
      * languages.
103 103
      *
104
-     * @param mixed $locationId
105
-     * @param mixed $parentLocationId
104
+     * @param integer $locationId
105
+     * @param integer $parentLocationId
106 106
      * @param string $name the new name computed by the name schema or url alias schema
107 107
      * @param string $languageCode
108 108
      * @param bool $alwaysAvailable
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
      * If $languageCode is null the $alias is created in the system's default
232 232
      * language. $alwaysAvailable makes the alias available in all languages.
233 233
      *
234
-     * @param mixed $locationId
234
+     * @param integer $locationId
235 235
      * @param string $path
236 236
      * @param bool $forwarding
237 237
      * @param string $languageCode
@@ -393,7 +393,7 @@  discard block
 block discarded – undo
393 393
     /**
394 394
      * List of user generated or autogenerated url entries, pointing to $locationId.
395 395
      *
396
-     * @param mixed $locationId
396
+     * @param integer $locationId
397 397
      * @param bool $custom if true the user generated aliases are listed otherwise the autogenerated
398 398
      *
399 399
      * @return \eZ\Publish\SPI\Persistence\Content\UrlAlias[]
@@ -523,7 +523,7 @@  discard block
 block discarded – undo
523 523
      * @param mixed $locationId1
524 524
      * @param mixed $locationId2
525 525
      *
526
-     * @return bool
526
+     * @return boolean|null
527 527
      */
528 528
     public function swap($locationId1, $locationId2)
529 529
     {
@@ -535,9 +535,9 @@  discard block
 block discarded – undo
535 535
      *
536 536
      * This method triggers the change of the autogenerated aliases.
537 537
      *
538
-     * @param mixed $locationId
539
-     * @param mixed $oldParentId
540
-     * @param mixed $newParentId
538
+     * @param integer $locationId
539
+     * @param integer $oldParentId
540
+     * @param integer $newParentId
541 541
      */
542 542
     public function locationMoved($locationId, $oldParentId, $newParentId)
543 543
     {
@@ -565,9 +565,9 @@  discard block
 block discarded – undo
565 565
      *
566 566
      * This method triggers the creation of the autogenerated aliases for the copied locations
567 567
      *
568
-     * @param mixed $locationId
569
-     * @param mixed $newLocationId
570
-     * @param mixed $newParentId
568
+     * @param integer $locationId
569
+     * @param integer $newLocationId
570
+     * @param integer $newParentId
571 571
      */
572 572
     public function locationCopied($locationId, $newLocationId, $newParentId)
573 573
     {
@@ -670,7 +670,7 @@  discard block
 block discarded – undo
670 670
     /**
671 671
      * Notifies the underlying engine that a location was deleted or moved to trash.
672 672
      *
673
-     * @param mixed $locationId
673
+     * @param integer $locationId
674 674
      */
675 675
     public function locationDeleted($locationId)
676 676
     {
Please login to merge, or discard this patch.