ContentMatcherFactory::setContainer() - Code Metrics - Inspection of "Fix EZP-25003: clear HTTP cache when trashing cont..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — ezp25003-trash_subitems_count_... ( c4ee15...9f71a1 )

unknown

created 2016-04-19 15:41 UTC

ContentMatcherFactory::setContainer() A

↳ Parent: ContentMatcherFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	4
Ratio	100 %

Metric	Value
dl	4
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

/**
 * File containing the ContentMatcherFactory class.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 *
 * @version //autogentag//
 */
namespace eZ\Bundle\EzPublishCoreBundle\Matcher;

use eZ\Publish\API\Repository\Repository;
use eZ\Publish\Core\MVC\ConfigResolverInterface;
use eZ\Publish\Core\MVC\Symfony\Matcher\ContentMatcherFactory as BaseFactory;
use eZ\Publish\Core\MVC\Symfony\SiteAccess\SiteAccessAware;
use eZ\Publish\Core\MVC\Symfony\SiteAccess;
use Symfony\Component\DependencyInjection\ContainerAwareInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;

/**
 * @deprecated Deprecated since 6.0, will be removed in 6.1. Use the ServiceAwareMatcherFactory instead.
 */
class ContentMatcherFactory extends BaseFactory implements SiteAccessAware, ContainerAwareInterface

{
    /**
     * @var \Symfony\Component\DependencyInjection\ContainerInterface
     */
    private $container;

    /**
     * @var \eZ\Publish\Core\MVC\ConfigResolverInterface;
     */
    private $configResolver;

    public function __construct(ConfigResolverInterface $configResolver, Repository $repository)
    {
        @trigger_error(
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            "ContentMatcherFactory is deprecated, and will be removed in ezpublish-kernel 6.1.\n" .
            'Use the ServiceAwareMatcherFactory with the relative namespace as a constructor argument.',
            E_USER_DEPRECATED
        );

        $this->configResolver = $configResolver;
        parent::__construct(
            $repository,
            $this->configResolver->getParameter('content_view')
        );
    }

    public function setContainer(ContainerInterface $container = null)
    {
        $this->container = $container;
    }

    /**
     * @param string $matcherIdentifier
     *
     * @return \eZ\Publish\Core\MVC\Symfony\Matcher\ContentBased\MatcherInterface
     */
    protected function getMatcher($matcherIdentifier)
    {
        if ($this->container->has($matcherIdentifier)) {
            return $this->container->get($matcherIdentifier);
        }

        return parent::getMatcher($matcherIdentifier);
    }

    /**
     * Changes internal configuration to use the one for passed SiteAccess.
     *
     * @param SiteAccess $siteAccess
     */
    public function setSiteAccess(SiteAccess $siteAccess = null)
    {
        if ($siteAccess === null) {
            return;
        }

        $this->matchConfig = $this->configResolver->getParameter('content_view', 'ezsettings', $siteAccess->name);

    }
}


1		<?php
2
3		/**
4		* File containing the ContentMatcherFactory class.
5		*
6		* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7		* @license For full copyright and license information view LICENSE file distributed with this source code.
8		*
9		* @version //autogentag//
10		*/
11		namespace eZ\Bundle\EzPublishCoreBundle\Matcher;
12
13		use eZ\Publish\API\Repository\Repository;
14		use eZ\Publish\Core\MVC\ConfigResolverInterface;
15		use eZ\Publish\Core\MVC\Symfony\Matcher\ContentMatcherFactory as BaseFactory;
16		use eZ\Publish\Core\MVC\Symfony\SiteAccess\SiteAccessAware;
17		use eZ\Publish\Core\MVC\Symfony\SiteAccess;
18		use Symfony\Component\DependencyInjection\ContainerAwareInterface;
19		use Symfony\Component\DependencyInjection\ContainerInterface;
20
21		/**
22		* @deprecated Deprecated since 6.0, will be removed in 6.1. Use the ServiceAwareMatcherFactory instead.
23		*/
24	View Code Duplication	class ContentMatcherFactory extends BaseFactory implements SiteAccessAware, ContainerAwareInterface
		0 ignored issues – show Deprecated Code introduced 2015-11-21 14:36 UTC by Report Bug Copy Issue Report The class `eZ\Publish\Core\MVC\Symf...r\ContentMatcherFactory` has been deprecated with message: Deprecated since 6.0, will be removed in 6.1. Use the ClassNameMatcherFactory instead. This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead. Loading history... Duplication introduced 2015-11-21 14:37 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25		{
26		/**
27		* @var \Symfony\Component\DependencyInjection\ContainerInterface
28		*/
29		private $container;
30
31		/**
32		* @var \eZ\Publish\Core\MVC\ConfigResolverInterface;
33		*/
34		private $configResolver;
35
36		public function __construct(ConfigResolverInterface $configResolver, Repository $repository)
37		{
38		@trigger_error(
		0 ignored issues – show Security Best Practice introduced 2015-11-21 14:36 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
39		"ContentMatcherFactory is deprecated, and will be removed in ezpublish-kernel 6.1.\n" .
40		'Use the ServiceAwareMatcherFactory with the relative namespace as a constructor argument.',
41		E_USER_DEPRECATED
42		);
43
44		$this->configResolver = $configResolver;
45		parent::__construct(
46		$repository,
47		$this->configResolver->getParameter('content_view')
48		);
49		}
50
51		public function setContainer(ContainerInterface $container = null)
52		{
53		$this->container = $container;
54		}
55
56		/**
57		* @param string $matcherIdentifier
58		*
59		* @return \eZ\Publish\Core\MVC\Symfony\Matcher\ContentBased\MatcherInterface
60		*/
61		protected function getMatcher($matcherIdentifier)
62		{
63		if ($this->container->has($matcherIdentifier)) {
64		return $this->container->get($matcherIdentifier);
65		}
66
67		return parent::getMatcher($matcherIdentifier);
68		}
69
70		/**
71		* Changes internal configuration to use the one for passed SiteAccess.
72		*
73		* @param SiteAccess $siteAccess
74		*/
75		public function setSiteAccess(SiteAccess $siteAccess = null)
76		{
77		if ($siteAccess === null) {
78		return;
79		}
80
81		$this->matchConfig = $this->configResolver->getParameter('content_view', 'ezsettings', $siteAccess->name);
		0 ignored issues – show Documentation Bug introduced 2015-11-21 14:36 UTC by Report Bug Copy Issue Report It seems like `$this->configResolver->g...gs', $siteAccess->name)` of type `*` is incompatible with the declared type `array` of property `$matchConfig`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
82		}
83		}
84

ezsystems / ezpublish-kernel

Push — ezp25003-trash_subitems_count_... ( c4ee15...9f71a1 )

ContentMatcherFactory::setContainer() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like