TrashBase - Code Metrics - Inspection of "EZP-26914: Improve exception message from liip:ima..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — ezp26914-imagine_resolve_excep... ( c5a137...48c7cc )

unknown
created 2017-03-31 11:05 UTC
TrashBase A

↳ Parent: Project
Complexity

Total Complexity
Size/Duplication

Total Lines	452
Duplicated Lines	34.29 %
Coupling/Cohesion

Components	1
Dependencies	15
Importance

Changes
Metric	Value
dl	155
loc	452
rs	9.1666
c	0
b	0
f	0
wmc	22
lcom	1
cbo	15
18 Methods

Rating	Name	Duplication	Size	Complexity
A	testNewClass()	20	20	1
A	testMissingProperty()	0	9	2
A	testReadOnlyProperty()	0	9	2
A	testUnsetProperty()	0	9	2
B	testLoadTrashItem()	27	27	1
A	testLoadTrashItemThrowsNotFoundException()	0	5	1
B	testTrash()	27	27	1
A	testTrashUpdatesMainLocation()	0	23	1
A	testTrashReturnsNull()	16	16	1
B	testRecover()	0	34	1
A	testRecoverNonExistingTrashItem()	7	7	1
B	testRecoverToDifferentLocation()	0	44	1
A	testRecoverToNonExistingLocation()	0	16	1
A	testDeleteTrashItem()	17	17	2
A	testDeleteNonExistingTrashItem()	7	7	1
B	testFindTrashItemsAndEmptyTrash()	0	24	1
B	createTestContentLocation()	34	34	1
A	testIsPropertySet()	0	9	1
How to fix Duplicated Code

<?php

/**
 * File contains: eZ\Publish\Core\Repository\Tests\Service\Integration\TrashBase class.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Publish\Core\Repository\Tests\Service\Integration;

use eZ\Publish\Core\Repository\Tests\Service\Integration\Base as BaseServiceTest;
use eZ\Publish\Core\Repository\Values\Content\TrashItem;
use eZ\Publish\Core\Repository\Values\Content\Location;
use eZ\Publish\API\Repository\Values\Content\Query;
use eZ\Publish\API\Repository\Values\Content\LocationCreateStruct;
use eZ\Publish\API\Repository\Exceptions\PropertyNotFoundException as PropertyNotFound;
use eZ\Publish\API\Repository\Exceptions\PropertyReadOnlyException;
use eZ\Publish\API\Repository\Exceptions\NotFoundException;
use eZ\Publish\API\Repository\Tests\BaseTest as APIBaseTest;

/**
 * Test case for Trash Service.
 */
abstract class TrashBase extends BaseServiceTest
{
    /**
     * Test a new class and default values on properties.
     *
     * @covers \eZ\Publish\API\Repository\Values\Content\TrashItem::__construct
     */
    public function testNewClass()
    {
        $trashItem = new TrashItem();

        $this->assertPropertiesCorrect(
            array(
                'id' => null,
                'priority' => null,
                'hidden' => null,
                'invisible' => null,
                'remoteId' => null,
                'parentLocationId' => null,
                'pathString' => null,
                'depth' => null,
                'sortField' => null,
                'sortOrder' => null,
            ),
            $trashItem
        );
    }

    /**
     * Test retrieving missing property.
     *
     * @covers \eZ\Publish\API\Repository\Values\Content\TrashItem::__get
     */
    public function testMissingProperty()
    {
        try {
            $trashItem = new TrashItem();
            $value = $trashItem->notDefined;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            self::fail('Succeeded getting non existing property');
        } catch (PropertyNotFound $e) {

        }
    }

    /**
     * Test setting read only property.
     *
     * @covers \eZ\Publish\API\Repository\Values\Content\TrashItem::__set
     */
    public function testReadOnlyProperty()
    {
        try {
            $trashItem = new TrashItem();
            $trashItem->id = 42;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            self::fail('Succeeded setting read only property');
        } catch (PropertyReadOnlyException $e) {

        }
    }

    /**
     * Test if property exists.
     *
     * @covers \eZ\Publish\API\Repository\Values\Content\TrashItem::__isset
     */
    public function testIsPropertySet()
    {
        $trashItem = new TrashItem();
        $value = isset($trashItem->notDefined);
        self::assertEquals(false, $value);

        $value = isset($trashItem->id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        self::assertEquals(true, $value);
    }

    /**
     * Test unsetting a property.
     *
     * @covers \eZ\Publish\API\Repository\Values\Content\TrashItem::__unset
     */
    public function testUnsetProperty()
    {
        $trashItem = new TrashItem(array('id' => 2));
        try {
            unset($trashItem->id);
            self::fail('Unsetting read-only property succeeded');
        } catch (PropertyReadOnlyException $e) {

        }
    }

    /**
     * Test loading a trash item.
     *
     * @covers \eZ\Publish\API\Repository\TrashService::loadTrashItem
     */
    public function testLoadTrashItem()
    {
        $locationService = $this->repository->getLocationService();
        $trashService = $this->repository->getTrashService();

        $trashItem = $location = $trashService->trash($locationService->loadLocation(44));
        $loadedTrashItem = $trashService->loadTrashItem($location->id);

        self::assertInstanceOf('\\eZ\\Publish\\API\\Repository\\Values\\Content\\TrashItem', $trashItem);

        self::assertSameClassPropertiesCorrect(
            array(
                'id',
                'priority',
                'hidden',
                'invisible',
                'remoteId',
                'parentLocationId',
                'pathString',
                'depth',
                'sortField',
                'sortOrder',
            ),
            $trashItem,
            $loadedTrashItem
        );
    }

    /**
     * Test loading a trash item throwing NotFoundException.
     *
     * @expectedException \eZ\Publish\API\Repository\Exceptions\NotFoundException
     * @covers \eZ\Publish\API\Repository\TrashService::loadTrashItem
     */
    public function testLoadTrashItemThrowsNotFoundException()
    {
        $trashService = $this->repository->getTrashService();
        $trashService->loadTrashItem(44);
    }

    /**
     * Test sending a location to trash.
     *
     * @covers \eZ\Publish\API\Repository\TrashService::trash
     */
    public function testTrash()
    {
        $locationService = $this->repository->getLocationService();
        $trashService = $this->repository->getTrashService();

        $location = $locationService->loadLocation(44);
        $trashItem = $trashService->trash($location);

        self::assertInstanceOf('\\eZ\\Publish\\API\\Repository\\Values\\Content\\TrashItem', $trashItem);

        self::assertSameClassPropertiesCorrect(
            array(
                'id',
                'priority',
                'hidden',
                'invisible',
                'remoteId',
                'parentLocationId',
                'pathString',
                'depth',
                'sortField',
                'sortOrder',
            ),
            $location,
            $trashItem
        );
    }

    /**
     * Test sending a location to trash.
     *
     * @covers \eZ\Publish\API\Repository\TrashService::trash
     */
    public function testTrashUpdatesMainLocation()
    {
        $contentService = $this->repository->getContentService();
        $locationService = $this->repository->getLocationService();
        $trashService = $this->repository->getTrashService();

        $contentInfo = $contentService->loadContentInfo(42);

        // Create additional location that will become new main location
        $location = $locationService->createLocation(
            $contentInfo,
            new LocationCreateStruct(array('parentLocationId' => 2))
        );

        $trashService->trash(
            $locationService->loadLocation($contentInfo->mainLocationId)
        );

        self::assertEquals(
            $location->id,
            $contentService->loadContentInfo(42)->mainLocationId
        );
    }

    /**
     * Test sending a location to trash.
     *
     * @covers \eZ\Publish\API\Repository\TrashService::trash
     */
    public function testTrashReturnsNull()
    {
        $contentService = $this->repository->getContentService();
        $locationService = $this->repository->getLocationService();
        $trashService = $this->repository->getTrashService();

        // Create additional location to trash
        $location = $locationService->createLocation(
            $contentService->loadContentInfo(42),
            new LocationCreateStruct(array('parentLocationId' => 2))
        );

        $trashItem = $trashService->trash($location);

        self::assertNull($trashItem);
    }

    /**
     * Test recovering a location from trash to original location.
     *
     * @covers \eZ\Publish\API\Repository\TrashService::recover
     */
    public function testRecover()
    {
        $locationService = $this->repository->getLocationService();
        $trashService = $this->repository->getTrashService();

        $location = $locationService->loadLocation(44);
        $trashItem = $trashService->trash($location);

        $recoveredLocation = $trashService->recover($trashItem);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        self::assertInstanceOf('\\eZ\\Publish\\API\\Repository\\Values\\Content\\Location', $recoveredLocation);

        self::assertSameClassPropertiesCorrect(
            array(
                'priority',
                'hidden',
                'invisible',
                'remoteId',
                'parentLocationId',
                'depth',
                'sortField',
                'sortOrder',
            ),
            $location,
            $recoveredLocation
        );

        $parentLocation = $locationService->loadLocation($location->parentLocationId);
        $newPathString = $parentLocation->pathString . $recoveredLocation->id . '/';

        self::assertEquals($newPathString, $recoveredLocation->pathString);
        self::assertGreaterThan(0, $recoveredLocation->id);
        self::assertEquals($recoveredLocation->id, $recoveredLocation->contentInfo->mainLocationId);
    }

    /**
     * Test recovering a non existing trash item.
     *
     * @expectedException \eZ\Publish\API\Repository\Exceptions\NotFoundException
     * @covers \eZ\Publish\API\Repository\TrashService::recover
     */
    public function testRecoverNonExistingTrashItem()
    {
        $trashService = $this->repository->getTrashService();

        $trashItem = new TrashItem(array('id' => APIBaseTest::DB_INT_MAX, 'parentLocationId' => APIBaseTest::DB_INT_MAX));
        $trashService->recover($trashItem);
    }

    /**
     * Test recovering a location from trash to different location.
     *
     * @covers \eZ\Publish\API\Repository\TrashService::recover
     */
    public function testRecoverToDifferentLocation()
    {
        // @todo: remove creating test locations when field types are fully functional
        // Create test locations
        $deleteLocationId = $this->createTestContentLocation(5)->contentInfo->mainLocationId;
        $recoverLocationId = $this->createTestContentLocation(5)->contentInfo->mainLocationId;

        /* BEGIN: Use Case */
        $locationService = $this->repository->getLocationService();
        $trashService = $this->repository->getTrashService();

        $location = $locationService->loadLocation($deleteLocationId);
        $trashItem = $trashService->trash($location);

        $newParentLocation = $locationService->loadLocation($recoverLocationId);

        $recoveredLocation = $trashService->recover($trashItem, $newParentLocation);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
        /* END: Use Case */

        self::assertInstanceOf('\\eZ\\Publish\\API\\Repository\\Values\\Content\\Location', $recoveredLocation);

        self::assertSameClassPropertiesCorrect(
            array(
                'priority',
                'hidden',
                'invisible',
                'remoteId',
                'depth',
                'sortField',
                'sortOrder',
            ),
            $location,
            $recoveredLocation,
            array('depth')
        );

        $parentLocation = $locationService->loadLocation($recoveredLocation->parentLocationId);
        $newPathString = $parentLocation->pathString . $recoveredLocation->id . '/';

        self::assertEquals($parentLocation->depth + 1, $recoveredLocation->depth);
        self::assertEquals($newPathString, $recoveredLocation->pathString);
        self::assertGreaterThan(0, $recoveredLocation->id);
        self::assertEquals($newParentLocation->id, $recoveredLocation->parentLocationId);
    }

    /**
     * Test recovering a location from trash to non existing location.
     *
     * @expectedException \eZ\Publish\API\Repository\Exceptions\NotFoundException
     * @covers \eZ\Publish\API\Repository\TrashService::recover
     */
    public function testRecoverToNonExistingLocation()
    {
        $locationService = $this->repository->getLocationService();
        $trashService = $this->repository->getTrashService();

        $location = $locationService->loadLocation(44);
        $trashItem = $trashService->trash($location);

        $newParentLocation = new Location(
            array(
                'id' => APIBaseTest::DB_INT_MAX,
                'parentLocationId' => APIBaseTest::DB_INT_MAX,
            )
        );
        $trashService->recover($trashItem, $newParentLocation);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
    }

    /**
     * Test deleting a trash item.
     *
     * @covers \eZ\Publish\API\Repository\TrashService::deleteTrashItem
     */
    public function testDeleteTrashItem()
    {
        $locationService = $this->repository->getLocationService();
        $trashService = $this->repository->getTrashService();

        $location = $locationService->loadLocation(44);
        $trashItem = $trashService->trash($location);

        $trashService->deleteTrashItem($trashItem);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        try {
            $trashService->loadTrashItem($trashItem->id);
            self::fail('Succeeded loading deleted trash item');
        } catch (NotFoundException $e) {
            // Do nothing
        }
    }

    /**
     * Test deleting a non existing trash item.
     *
     * @expectedException \eZ\Publish\API\Repository\Exceptions\NotFoundException
     * @covers \eZ\Publish\API\Repository\TrashService::deleteTrashItem
     */
    public function testDeleteNonExistingTrashItem()
    {
        $trashService = $this->repository->getTrashService();

        $trashItem = new TrashItem(array('id' => APIBaseTest::DB_INT_MAX));
        $trashService->deleteTrashItem($trashItem);
    }

    /**
     * Test searching for trash items.
     *
     * @covers \eZ\Publish\API\Repository\TrashService::findTrashItems
     * @covers \eZ\Publish\API\Repository\TrashService::emptyTrash
     */
    public function testFindTrashItemsAndEmptyTrash()
    {
        // @todo: remove creating test location when field types are fully functional
        $newLocationId = $this->createTestContentLocation(5)->contentInfo->mainLocationId;

        $locationService = $this->repository->getLocationService();
        $trashService = $this->repository->getTrashService();

        $searchResult = $trashService->findTrashItems(new Query());
        $countBeforeTrashing = $searchResult->count;

        $location = $locationService->loadLocation($newLocationId);
        $trashService->trash($location);

        $searchResult = $trashService->findTrashItems(new Query());
        $countAfterTrashing = $searchResult->count;

        self::assertGreaterThan($countBeforeTrashing, $countAfterTrashing);

        $trashService->emptyTrash();
        $searchResult = $trashService->findTrashItems(new Query());

        self::assertEquals(0, $searchResult->count);
    }

    /**
     * @param int $parentLocationId
     *
     * @return \eZ\Publish\API\Repository\Values\Content\Content
     */
    protected function createTestContentLocation($parentLocationId)
    {
        $contentService = $this->repository->getContentService();
        $contentTypeService = $this->repository->getContentTypeService();
        // User Group content type
        $contentType = $contentTypeService->loadContentType(3);

        $contentCreate = $contentService->newContentCreateStruct($contentType, 'eng-GB');
        $contentCreate->setField('name', 'dummy value');
        $contentCreate->sectionId = 1;
        $contentCreate->ownerId = 14;
        $contentCreate->remoteId = md5(uniqid(get_class($this), true));
        $contentCreate->alwaysAvailable = true;

        $locationCreates = array(
            new LocationCreateStruct(
                array(
                    //priority = 0
                    //hidden = false
                    'remoteId' => md5(uniqid(get_class($this), true)),
                    //sortField = Location::SORT_FIELD_NAME
                    //sortOrder = Location::SORT_ORDER_ASC
                    'parentLocationId' => $parentLocationId,
                )
            ),
        );

        return $contentService->publishVersion(
            $contentService->createContent(
                $contentCreate,
                $locationCreates
            )->versionInfo
        );
    }
}

ezsystems / ezpublish-kernel

Push — ezp26914-imagine_resolve_excep... ( c5a137...48c7cc )

TrashBase A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

18 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like
