Completed
Push — EZP-29899 ( ab51a2 )
by André
24:48
created
Core/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php 1 patch
Doc Comments   +24 added lines, -21 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
      *
96 96
      * @todo optimize
97 97
      *
98
-     * @param mixed $remoteId
98
+     * @param string $remoteId
99 99
      *
100 100
      * @return array
101 101
      */
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
     /**
250 250
      * Returns data for the first level children of the location identified by given $locationId.
251 251
      *
252
-     * @param mixed $locationId
252
+     * @param integer $locationId
253 253
      *
254 254
      * @return array
255 255
      */
@@ -376,6 +376,9 @@  discard block
 block discarded – undo
376 376
         }
377 377
     }
378 378
 
379
+    /**
380
+     * @param string $pathString
381
+     */
379 382
     private function isHiddenByParent($pathString, array $rows)
380 383
     {
381 384
         $parentNodeIds = explode('/', trim($pathString, '/'));
@@ -576,10 +579,10 @@  discard block
 block discarded – undo
576 579
      * Make the location identified by $locationId1 refer to the Content
577 580
      * referred to by $locationId2 and vice versa.
578 581
      *
579
-     * @param mixed $locationId1
580
-     * @param mixed $locationId2
582
+     * @param integer $locationId1
583
+     * @param integer $locationId2
581 584
      *
582
-     * @return bool
585
+     * @return boolean|null
583 586
      */
584 587
     public function swap($locationId1, $locationId2)
585 588
     {
@@ -736,7 +739,7 @@  discard block
 block discarded – undo
736 739
      * Create an entry in the node assignment table.
737 740
      *
738 741
      * @param \eZ\Publish\SPI\Persistence\Content\Location\CreateStruct $createStruct
739
-     * @param mixed $parentNodeId
742
+     * @param string $parentNodeId
740 743
      * @param int $type
741 744
      */
742 745
     public function createNodeAssignment(CreateStruct $createStruct, $parentNodeId, $type = self::NODE_ASSIGNMENT_OP_CODE_CREATE_NOP)
@@ -864,8 +867,8 @@  discard block
 block discarded – undo
864 867
      *
865 868
      * Convert existing node assignments into real locations.
866 869
      *
867
-     * @param mixed $contentId
868
-     * @param mixed $versionNo
870
+     * @param integer $contentId
871
+     * @param integer $versionNo
869 872
      */
870 873
     public function createLocationsFromNodeAssignments($contentId, $versionNo)
871 874
     {
@@ -933,8 +936,8 @@  discard block
 block discarded – undo
933 936
     /**
934 937
      * Updates all Locations of content identified with $contentId with $versionNo.
935 938
      *
936
-     * @param mixed $contentId
937
-     * @param mixed $versionNo
939
+     * @param integer $contentId
940
+     * @param integer $versionNo
938 941
      */
939 942
     public function updateLocationsContentVersionNo($contentId, $versionNo)
940 943
     {
@@ -1093,8 +1096,8 @@  discard block
 block discarded – undo
1093 1096
      * the node identified by given $locationId (current main node).
1094 1097
      * Assumes that content has more than one location.
1095 1098
      *
1096
-     * @param mixed $contentId
1097
-     * @param mixed $locationId
1099
+     * @param integer $contentId
1100
+     * @param integer $locationId
1098 1101
      *
1099 1102
      * @return array
1100 1103
      */
@@ -1130,9 +1133,9 @@  discard block
 block discarded – undo
1130 1133
      *
1131 1134
      * The associated content object is left untouched.
1132 1135
      *
1133
-     * @param mixed $locationId
1136
+     * @param integer $locationId
1134 1137
      *
1135
-     * @return bool
1138
+     * @return boolean|null
1136 1139
      */
1137 1140
     public function trashLocation($locationId)
1138 1141
     {
@@ -1161,8 +1164,8 @@  discard block
 block discarded – undo
1161 1164
      * at the old position. If this is not possible ( because the old location
1162 1165
      * does not exist any more) and exception is thrown.
1163 1166
      *
1164
-     * @param mixed $locationId
1165
-     * @param mixed|null $newParentId
1167
+     * @param integer $locationId
1168
+     * @param integer $newParentId
1166 1169
      *
1167 1170
      * @return \eZ\Publish\SPI\Persistence\Content\Location
1168 1171
      */
@@ -1415,10 +1418,10 @@  discard block
 block discarded – undo
1415 1418
      * Updates ezcontentobject_tree table for the given $contentId and eznode_assignment table for the given
1416 1419
      * $contentId, $parentLocationId and $versionNo
1417 1420
      *
1418
-     * @param mixed $contentId
1419
-     * @param mixed $locationId
1420
-     * @param mixed $versionNo version number, needed to update eznode_assignment table
1421
-     * @param mixed $parentLocationId parent location of location identified by $locationId, needed to update
1421
+     * @param integer $contentId
1422
+     * @param integer $locationId
1423
+     * @param integer $versionNo version number, needed to update eznode_assignment table
1424
+     * @param integer $parentLocationId parent location of location identified by $locationId, needed to update
1422 1425
      *        eznode_assignment table
1423 1426
      */
1424 1427
     public function changeMainLocation($contentId, $locationId, $versionNo, $parentLocationId)
@@ -1546,7 +1549,7 @@  discard block
 block discarded – undo
1546 1549
     /**
1547 1550
      * Get Query Builder for fetching data of all Locations except the Root node.
1548 1551
      *
1549
-     * @param array $columns list of columns to fetch
1552
+     * @param string[] $columns list of columns to fetch
1550 1553
      *
1551 1554
      * @return \Doctrine\DBAL\Query\QueryBuilder
1552 1555
      */
Please login to merge, or discard this patch.
Core/Persistence/Legacy/Content/UrlAlias/Gateway/DoctrineDatabase.php 1 patch
Doc Comments   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
      *
271 271
      * @param string $action
272 272
      * @param mixed $languageId
273
-     * @param mixed $newId
273
+     * @param integer $newId
274 274
      * @param mixed $parentId
275 275
      * @param string $textMD5
276 276
      */
@@ -444,9 +444,9 @@  discard block
 block discarded – undo
444 444
      *
445 445
      * Removes given $languageId from entry's language mask
446 446
      *
447
-     * @param mixed $parentId
447
+     * @param integer $parentId
448 448
      * @param string $textMD5
449
-     * @param mixed $languageId
449
+     * @param integer $languageId
450 450
      */
451 451
     protected function removeTranslation($parentId, $textMD5, $languageId)
452 452
     {
@@ -529,8 +529,8 @@  discard block
 block discarded – undo
529 529
      *
530 530
      * Update includes history entries.
531 531
      *
532
-     * @param mixed $oldParentId
533
-     * @param mixed $newParentId
532
+     * @param integer $oldParentId
533
+     * @param integer $newParentId
534 534
      */
535 535
     public function reparent($oldParentId, $newParentId)
536 536
     {
@@ -676,7 +676,7 @@  discard block
 block discarded – undo
676 676
     /**
677 677
      * Returns next value for "id" column.
678 678
      *
679
-     * @return mixed
679
+     * @return string
680 680
      */
681 681
     public function getNextId()
682 682
     {
@@ -819,7 +819,7 @@  discard block
 block discarded – undo
819 819
      * Loads autogenerated entry id by given $action and optionally $parentId.
820 820
      *
821 821
      * @param string $action
822
-     * @param mixed|null $parentId
822
+     * @param integer $parentId
823 823
      *
824 824
      * @return array
825 825
      */
@@ -1003,7 +1003,7 @@  discard block
 block discarded – undo
1003 1003
     /**
1004 1004
      * Deletes single custom alias row matched by composite primary key.
1005 1005
      *
1006
-     * @param mixed $parentId
1006
+     * @param integer $parentId
1007 1007
      * @param string $textMD5
1008 1008
      *
1009 1009
      * @return bool
@@ -1041,10 +1041,10 @@  discard block
 block discarded – undo
1041 1041
      *
1042 1042
      * If $id is set only autogenerated entries will be removed.
1043 1043
      *
1044
-     * @param mixed $action
1045
-     * @param mixed|null $id
1044
+     * @param string $action
1045
+     * @param integer $id
1046 1046
      *
1047
-     * @return bool
1047
+     * @return boolean|null
1048 1048
      */
1049 1049
     public function remove($action, $id = null)
1050 1050
     {
Please login to merge, or discard this patch.
eZ/Publish/Core/Repository/Helper/DomainMapper.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -323,7 +323,7 @@  discard block
 block discarded – undo
323 323
      * @param \eZ\Publish\SPI\Persistence\Content\Location $spiLocation
324 324
      * @param \eZ\Publish\SPI\Persistence\Content\ContentInfo $spiContentInfo pre-loaded Content Info
325 325
      *
326
-     * @return \eZ\Publish\API\Repository\Values\Content\Location
326
+     * @return \eZ\Publish\API\Repository\Values\ValueObject
327 327
      *
328 328
      * @throws \eZ\Publish\Core\Base\Exceptions\InvalidArgumentException In case if the given Content does not belong to the given Location
329 329
      */
@@ -394,7 +394,7 @@  discard block
 block discarded – undo
394 394
      * @param \eZ\Publish\API\Repository\Values\Content\Location $parentLocation
395 395
      * @param mixed $mainLocation
396 396
      * @param mixed $contentId
397
-     * @param mixed $contentVersionNo
397
+     * @param null|integer $contentVersionNo
398 398
      *
399 399
      * @return \eZ\Publish\SPI\Persistence\Content\Location\CreateStruct
400 400
      */
Please login to merge, or discard this patch.
eZ/Publish/Core/Repository/Tests/Service/Mock/UrlAliasTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3585,7 +3585,7 @@
 block discarded – undo
3585 3585
     }
3586 3586
 
3587 3587
     /**
3588
-     * @return \PHPUnit_Framework_MockObject_MockObject|\eZ\Publish\Core\Repository\Helper\NameSchemaService
3588
+     * @return \eZ\Publish\Core\Repository\Helper\NameSchemaService
3589 3589
      */
3590 3590
     protected function getNameSchemaServiceMock()
3591 3591
     {
Please login to merge, or discard this patch.
eZ/Publish/Core/Persistence/Legacy/Content/UrlAlias/Handler.php 1 patch
Doc Comments   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
311 311
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException
312 312
      * @throws \eZ\Publish\API\Repository\Exceptions\ForbiddenException
313 313
      *
314
-     * @param mixed $locationId
314
+     * @param integer $locationId
315 315
      * @param string $path
316 316
      * @param bool $forwarding
317 317
      * @param string $languageCode
@@ -479,7 +479,7 @@  discard block
 block discarded – undo
479 479
      *
480 480
      * @throws \eZ\Publish\API\Repository\Exceptions\BadStateException
481 481
      *
482
-     * @param mixed $locationId
482
+     * @param integer $locationId
483 483
      * @param bool $custom if true the user generated aliases are listed otherwise the autogenerated
484 484
      *
485 485
      * @return \eZ\Publish\SPI\Persistence\Content\UrlAlias[]
@@ -615,9 +615,9 @@  discard block
 block discarded – undo
615 615
      *
616 616
      * This method triggers the change of the autogenerated aliases.
617 617
      *
618
-     * @param mixed $locationId
619
-     * @param mixed $oldParentId
620
-     * @param mixed $newParentId
618
+     * @param integer $locationId
619
+     * @param integer $oldParentId
620
+     * @param integer $newParentId
621 621
      */
622 622
     public function locationMoved($locationId, $oldParentId, $newParentId)
623 623
     {
@@ -645,9 +645,9 @@  discard block
 block discarded – undo
645 645
      *
646 646
      * This method triggers the creation of the autogenerated aliases for the copied locations
647 647
      *
648
-     * @param mixed $locationId
649
-     * @param mixed $newLocationId
650
-     * @param mixed $newParentId
648
+     * @param integer $locationId
649
+     * @param integer $newLocationId
650
+     * @param integer $newParentId
651 651
      */
652 652
     public function locationCopied($locationId, $newLocationId, $newParentId)
653 653
     {
@@ -976,7 +976,7 @@  discard block
 block discarded – undo
976 976
     /**
977 977
      * Notifies the underlying engine that a location was deleted or moved to trash.
978 978
      *
979
-     * @param mixed $locationId
979
+     * @param integer $locationId
980 980
      */
981 981
     public function locationDeleted($locationId)
982 982
     {
Please login to merge, or discard this patch.
eZ/Publish/Core/Repository/LocationService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -723,7 +723,7 @@
 block discarded – undo
723 723
      * Instantiates a new location create class.
724 724
      *
725 725
      * @param mixed $parentLocationId the parent under which the new location should be created
726
-     * @param eZ\Publish\API\Repository\Values\ContentType\ContentType|null $contentType
726
+     * @param null|ContentType $contentType
727 727
      *
728 728
      * @return \eZ\Publish\API\Repository\Values\Content\LocationCreateStruct
729 729
      */
Please login to merge, or discard this patch.
eZ/Publish/Core/REST/Client/LocationService.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
      * Instantiates a new location create class.
81 81
      *
82 82
      * @param mixed $parentLocationId the parent under which the new location should be created
83
-     * @param eZ\Publish\API\Repository\Values\ContentType\ContentType|null $contentType
83
+     * @param null|ContentType $contentType
84 84
      *
85 85
      * @return \eZ\Publish\API\Repository\Values\Content\LocationCreateStruct
86 86
      */
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
      * @param \eZ\Publish\API\Repository\Values\Content\ContentInfo $contentInfo
219 219
      * @param \eZ\Publish\API\Repository\Values\Content\Location $rootLocation
220 220
      *
221
-     * @return \eZ\Publish\API\Repository\Values\Content\Location[]
221
+     * @return \eZ\Publish\API\Repository\Values\ValueObject
222 222
      */
223 223
     public function loadLocations(ContentInfo $contentInfo, Location $rootLocation = null)
224 224
     {
Please login to merge, or discard this patch.
eZ/Publish/Core/SignalSlot/LocationService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -723,7 +723,7 @@
 block discarded – undo
723 723
      * Instantiates a new location create class.
724 724
      *
725 725
      * @param mixed $parentLocationId the parent under which the new location should be created
726
-     * @param eZ\Publish\API\Repository\Values\ContentType\ContentType|null $contentType
726
+     * @param null|ContentType $contentType
727 727
      *
728 728
      * @return \eZ\Publish\API\Repository\Values\Content\LocationCreateStruct
729 729
      */
Please login to merge, or discard this patch.
eZ/Publish/Core/Persistence/Legacy/Content/Location/Handler.php 1 patch
Doc Comments   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -209,8 +209,8 @@  discard block
 block discarded – undo
209 209
      * @todo Either move to async/batch or find ways toward optimizing away operations per object.
210 210
      * @todo Optionally retain dates and set creator
211 211
      *
212
-     * @param mixed $sourceId
213
-     * @param mixed $destinationParentId
212
+     * @param integer $sourceId
213
+     * @param integer $destinationParentId
214 214
      * @param int|null $newOwnerId
215 215
      *
216 216
      * @return Location the newly created Location.
@@ -368,10 +368,10 @@  discard block
 block discarded – undo
368 368
      * destination, identified by $destinationParentId. Relations do not need
369 369
      * to be updated, since they refer to Content. URLs are not touched.
370 370
      *
371
-     * @param mixed $sourceId
372
-     * @param mixed $destinationParentId
371
+     * @param integer $sourceId
372
+     * @param integer $destinationParentId
373 373
      *
374
-     * @return bool
374
+     * @return boolean|null
375 375
      */
376 376
     public function move($sourceId, $destinationParentId)
377 377
     {
@@ -414,7 +414,7 @@  discard block
 block discarded – undo
414 414
     /**
415 415
      * Sets a location to be hidden, and it self + all children to invisible.
416 416
      *
417
-     * @param mixed $id Location ID
417
+     * @param integer $id Location ID
418 418
      */
419 419
     public function hide($id)
420 420
     {
@@ -427,7 +427,7 @@  discard block
 block discarded – undo
427 427
      * Sets a location to be unhidden, and self + children to visible unless a parent is hiding the tree.
428 428
      * If not make sure only children down to first hidden node is marked visible.
429 429
      *
430
-     * @param mixed $id
430
+     * @param integer $id
431 431
      */
432 432
     public function unHide($id)
433 433
     {
@@ -442,10 +442,10 @@  discard block
 block discarded – undo
442 442
      * Make the location identified by $locationId1 refer to the Content
443 443
      * referred to by $locationId2 and vice versa.
444 444
      *
445
-     * @param mixed $locationId1
446
-     * @param mixed $locationId2
445
+     * @param integer $locationId1
446
+     * @param integer $locationId2
447 447
      *
448
-     * @return bool
448
+     * @return boolean|null
449 449
      */
450 450
     public function swap($locationId1, $locationId2)
451 451
     {
@@ -492,9 +492,9 @@  discard block
 block discarded – undo
492 492
      * main Location will get the first of its other Locations assigned as the
493 493
      * new main Location.
494 494
      *
495
-     * @param mixed $locationId
495
+     * @param integer $locationId
496 496
      *
497
-     * @return bool
497
+     * @return boolean|null
498 498
      */
499 499
     public function removeSubtree($locationId)
500 500
     {
@@ -505,7 +505,7 @@  discard block
 block discarded – undo
505 505
      * Set section on all content objects in the subtree.
506 506
      *
507 507
      * @param mixed $locationId
508
-     * @param mixed $sectionId
508
+     * @param integer $sectionId
509 509
      */
510 510
     public function setSectionForSubtree($locationId, $sectionId)
511 511
     {
Please login to merge, or discard this patch.