eZ\Publish\Core\Persistence\Legacy\URL\Handler

Complexity

Total Complexity

8

Size/Duplication

Total Lines	95
Duplicated Lines	25.26 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	updateUrl()	0	11	1
A	find()	0	14	1
A	loadById()	12	12	2
A	loadByUrl()	12	12	2
A	findUsages()	0	6	1

<?php

/**
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Publish\Core\Persistence\Legacy\URL;

use eZ\Publish\API\Repository\Values\URL\URLQuery;
use eZ\Publish\Core\Base\Exceptions\NotFoundException;
use eZ\Publish\SPI\Persistence\URL\Handler as HandlerInterface;
use eZ\Publish\SPI\Persistence\URL\URLUpdateStruct;

/**
 * Storage Engine handler for URLs.
 */
class Handler implements HandlerInterface
{
    /** @var \eZ\Publish\Core\Persistence\Legacy\URL\Gateway */
    private $urlGateway;

    /** @var \eZ\Publish\Core\Persistence\Legacy\URL\Mapper */
    private $urlMapper;

    /**
     * Handler constructor.
     *
     * @param \eZ\Publish\Core\Persistence\Legacy\URL\Gateway $gateway
     * @param \eZ\Publish\Core\Persistence\Legacy\URL\Mapper $mapper
     */
    public function __construct(Gateway $gateway, Mapper $mapper)
    {
        $this->urlGateway = $gateway;
        $this->urlMapper = $mapper;
    }

    /**
     * {@inheritdoc}
     */
    public function updateUrl($id, URLUpdateStruct $urlUpdateStruct)
    {
        $url = $this->urlMapper->createURLFromUpdateStruct(
            $urlUpdateStruct
        );
        $url->id = $id;

        $this->urlGateway->updateUrl($url);

        return $url;
    }

    /**
     * {@inheritdoc}
     */
    public function find(URLQuery $query)
    {
        $results = $this->urlGateway->find(
            $query->filter,
            $query->offset,
            $query->limit,
            $query->sortClauses
        );

        return [
            'count' => $results['count'],
            'items' => $this->urlMapper->extractURLsFromRows($results['rows']),
        ];
    }

    /**
     * {@inheritdoc}
     */
    public function loadById($id)
    {
        $url = $this->urlMapper->extractURLsFromRows(
            $this->urlGateway->loadUrlData($id)
        );

        if (count($url) < 1) {
            throw new NotFoundException('URL', $id);
        }

        return reset($url);

The expression reset($url); of type eZ\Publish\SPI\Persistence\URL\URL|false adds false to the return on line 83 which is incompatible with the return type declared by the interface eZ\Publish\SPI\Persistence\URL\Handler::loadById of type eZ\Publish\SPI\Persistence\URL\URL. It seems like you forgot to handle an error condition.

    }

    /**
     * {@inheritdoc}
     */
    public function loadByUrl($url)
    {
        $urls = $this->urlMapper->extractURLsFromRows(
            $this->urlGateway->loadUrlDataByUrl($url)
        );

        if (count($urls) < 1) {
            throw new NotFoundException('URL', $url);
        }

        return reset($urls);

The expression reset($urls); of type eZ\Publish\SPI\Persistence\URL\URL|false adds false to the return on line 99 which is incompatible with the return type declared by the interface eZ\Publish\SPI\Persistence\URL\Handler::loadByUrl of type eZ\Publish\SPI\Persistence\URL\URL. It seems like you forgot to handle an error condition.

    }

    /**
     * {@inheritdoc}
     */
    public function findUsages($id)
    {
        $ids = $this->urlGateway->findUsages($id);

        return $ids;
    }
}