URLServiceTest::serviceProvider() - Code Metrics - Inspection of "Merge branch '6.13' into 7.0" - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 7.0 ( 9f8c87...bcff12 )

by André

created 2018-03-23 11:36 UTC

URLServiceTest::serviceProvider() A

↳ Parent: URLServiceTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	57
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	34
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	57
rs	9.6818

How to fix Long Method

<?php

/**
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Publish\Core\SignalSlot\Tests;

use eZ\Publish\API\Repository\URLService as APIURLService;
use eZ\Publish\API\Repository\Values\URL\SearchResult;
use eZ\Publish\API\Repository\Values\URL\URL;
use eZ\Publish\API\Repository\Values\URL\URLQuery;
use eZ\Publish\API\Repository\Values\URL\URLUpdateStruct;
use eZ\Publish\Core\SignalSlot\SignalDispatcher;
use eZ\Publish\Core\SignalSlot\Signal\URLService\UpdateUrlSignal;
use eZ\Publish\Core\SignalSlot\URLService;

class URLServiceTest extends ServiceTest
{
    public function serviceProvider()
    {
        $url = $this->getApiUrl(12, 'http://ez.no');

        return [
            [
                'updateUrl',
                [
                    $url,
                    new URLUpdateStruct([
                        'url' => 'http://ezplatform.com',
                    ]),
                ],
                $this->getApiUrl(12, 'http://ezplatform.com', true),
                1,
                UpdateUrlSignal::class,
                ['urlId' => $url->id, 'urlChanged' => true],
            ],
            [
                'updateUrl',
                [
                    $url,
                    new URLUpdateStruct([
                        'isValid' => false,
                    ]),
                ],
                $this->getApiUrl(12, 'http://ez.no', false),
                1,
                UpdateUrlSignal::class,
                ['urlId' => $url->id, 'urlChanged' => false],
            ],
            [
                'createUpdateStruct',
                [],
                new URLUpdateStruct(),
                0,
            ],
            [
                'findUrls',
                [new URLQuery()],
                new SearchResult(),
                0,
            ],
            [
                'loadById',
                [12],
                $url,
                0,
            ],
            [
                'loadByUrl',
                ['http://ez.no'],
                $url,
                0,
            ],
        ];
    }

    protected function getServiceMock()
    {
        return $this->createMock(APIURLService::class);
    }

    protected function getSignalSlotService($innerService, SignalDispatcher $dispatcher)
    {
        return new URLService($innerService, $dispatcher);
    }

    private function getApiUrl($id = null, $url = null, $isValid = false)
    {
        return new URL([
            'id' => $id,
            'url' => $url,
            'isValid' => $isValid,
        ]);
    }
}


1			<?php
2
3			/**
4			* @copyright Copyright (C) eZ Systems AS. All rights reserved.
5			* @license For full copyright and license information view LICENSE file distributed with this source code.
6			*/
7			namespace eZ\Publish\Core\SignalSlot\Tests;
8
9			use eZ\Publish\API\Repository\URLService as APIURLService;
10			use eZ\Publish\API\Repository\Values\URL\SearchResult;
11			use eZ\Publish\API\Repository\Values\URL\URL;
12			use eZ\Publish\API\Repository\Values\URL\URLQuery;
13			use eZ\Publish\API\Repository\Values\URL\URLUpdateStruct;
14			use eZ\Publish\Core\SignalSlot\SignalDispatcher;
15			use eZ\Publish\Core\SignalSlot\Signal\URLService\UpdateUrlSignal;
16			use eZ\Publish\Core\SignalSlot\URLService;
17
18			class URLServiceTest extends ServiceTest
19			{
20			public function serviceProvider()
21			{
22			$url = $this->getApiUrl(12, 'http://ez.no');
23
24			return [
25			[
26			'updateUrl',
27			[
28			$url,
29			new URLUpdateStruct([
30			'url' => 'http://ezplatform.com',
31			]),
32			],
33			$this->getApiUrl(12, 'http://ezplatform.com', true),
34			1,
35			UpdateUrlSignal::class,
36			['urlId' => $url->id, 'urlChanged' => true],
37			],
38			[
39			'updateUrl',
40			[
41			$url,
42			new URLUpdateStruct([
43			'isValid' => false,
44			]),
45			],
46			$this->getApiUrl(12, 'http://ez.no', false),
47			1,
48			UpdateUrlSignal::class,
49			['urlId' => $url->id, 'urlChanged' => false],
50			],
51			[
52			'createUpdateStruct',
53			[],
54			new URLUpdateStruct(),
55			0,
56			],
57			[
58			'findUrls',
59			[new URLQuery()],
60			new SearchResult(),
61			0,
62			],
63			[
64			'loadById',
65			[12],
66			$url,
67			0,
68			],
69			[
70			'loadByUrl',
71			['http://ez.no'],
72			$url,
73			0,
74			],
75			];
76			}
77
78			protected function getServiceMock()
79			{
80			return $this->createMock(APIURLService::class);
81			}
82
83			protected function getSignalSlotService($innerService, SignalDispatcher $dispatcher)
84			{
85			return new URLService($innerService, $dispatcher);
86			}
87
88			private function getApiUrl($id = null, $url = null, $isValid = false)
89			{
90			return new URL([
91			'id' => $id,
92			'url' => $url,
93			'isValid' => $isValid,
94			]);
95			}
96			}
97

ezsystems / ezpublish-kernel

Push — 7.0 ( 9f8c87...bcff12 )

URLServiceTest::serviceProvider() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like