Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
16 | abstract class AbstractViewTest extends TestCase |
||
17 | { |
||
18 | abstract protected function createViewUnderTest($template = null, array $parameters = [], $viewType = 'full'): View; |
||
19 | |||
20 | /** |
||
21 | * Returns parameters that are always returned by this view. |
||
22 | * |
||
23 | * @return array |
||
24 | */ |
||
25 | protected function getAlwaysAvailableParams(): array |
||
29 | |||
30 | /** |
||
31 | * @covers \eZ\Publish\Core\MVC\Symfony\View\View::setParameters |
||
32 | * @covers \eZ\Publish\Core\MVC\Symfony\View\View::getParameters |
||
33 | */ |
||
34 | public function testGetSetParameters(): void |
||
46 | |||
47 | /** |
||
48 | * @covers \eZ\Publish\Core\MVC\Symfony\View\View::setParameters |
||
49 | * @covers \eZ\Publish\Core\MVC\Symfony\View\View::getParameters |
||
50 | */ |
||
51 | public function testAddParameters(): void |
||
61 | |||
62 | /** |
||
63 | * @covers \eZ\Publish\Core\MVC\Symfony\View\View::setParameters |
||
64 | * @covers \eZ\Publish\Core\MVC\Symfony\View\View::getParameters |
||
65 | */ |
||
66 | public function testHasParameter(): View |
||
75 | |||
76 | /** |
||
77 | * @depends testHasParameter |
||
78 | * @covers \eZ\Publish\Core\MVC\Symfony\View\View::setParameters |
||
79 | * @covers \eZ\Publish\Core\MVC\Symfony\View\View::getParameters |
||
80 | * |
||
81 | * @param \eZ\Publish\Core\MVC\Symfony\View\View $view |
||
82 | * |
||
83 | * @return \eZ\Publish\Core\MVC\Symfony\View\View |
||
84 | */ |
||
85 | public function testGetParameter(View $view): View |
||
91 | |||
92 | /** |
||
93 | * @depends testGetParameter |
||
94 | * |
||
95 | * @covers \eZ\Publish\Core\MVC\Symfony\View\View::setParameters |
||
96 | * @covers \eZ\Publish\Core\MVC\Symfony\View\View::getParameters |
||
97 | */ |
||
98 | public function testGetParameterFail(View $view): void |
||
104 | |||
105 | /** |
||
106 | * @dataProvider goodTemplateIdentifierProvider |
||
107 | * |
||
108 | * @param string|callable $templateIdentifier |
||
109 | */ |
||
110 | public function testSetTemplateIdentifier($templateIdentifier): void |
||
117 | |||
118 | public function goodTemplateIdentifierProvider(): array |
||
129 | |||
130 | /** |
||
131 | * @dataProvider badTemplateIdentifierProvider |
||
132 | * |
||
133 | * @param mixed $badTemplateIdentifier |
||
134 | */ |
||
135 | public function testSetTemplateIdentifierWrongType($badTemplateIdentifier): void |
||
142 | |||
143 | View Code Duplication | public function badTemplateIdentifierProvider(): array |
|
152 | } |
||
153 |