eZ\Bundle\EzPublishCoreBundle\Fragment\SiteAccessSerializationTrait

Complexity

Total Complexity

3

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	serializeSiteAccess()	0	19	3

<?php

/**
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
declare(strict_types=1);

namespace eZ\Bundle\EzPublishCoreBundle\Fragment;

use eZ\Publish\Core\MVC\Symfony\Component\Serializer\SerializerTrait;
use eZ\Publish\Core\MVC\Symfony\SiteAccess;
use Symfony\Component\HttpKernel\Controller\ControllerReference;

trait SiteAccessSerializationTrait
{
    use SerializerTrait;

    public function serializeSiteAccess(SiteAccess $siteAccess, ControllerReference $uri): void
    {
        // Serialize the siteaccess to get it back after.
        // @see eZ\Publish\Core\MVC\Symfony\EventListener\SiteAccessMatchListener
        $uri->attributes['serialized_siteaccess'] = json_encode($siteAccess);
        $uri->attributes['serialized_siteaccess_matcher'] = $this->getSerializer()->serialize(
            $siteAccess->matcher,
            'json'
        );
        if ($siteAccess->matcher instanceof SiteAccess\Matcher\CompoundInterface) {
            $subMatchers = $siteAccess->matcher->getSubMatchers() ?? null;
            foreach ($subMatchers as $subMatcher) {

The expression $subMatchers of type array<integer,object<eZ\Publish\Core\MVC\Symfony\SiteAccess\Matcher>>|null is not guaranteed to be traversable. How about adding an additional type check?

                $uri->attributes['serialized_siteaccess_sub_matchers'][get_class($subMatcher)] = $this->getSerializer()->serialize(
                    $subMatcher,
                    'json'
                );
            }
        }
    }
}