Completed
Push — EZP-29899 ( 9a7ab6...64c21d )
by André
22:37
created
eZ/Publish/Core/REST/Client/ContentTypeService.php 1 patch
Unused Use Statements   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,8 @@
 block discarded – undo
29 29
 use eZ\Publish\Core\REST\Common\RequestParser;
30 30
 use eZ\Publish\Core\REST\Common\Input\Dispatcher;
31 31
 use eZ\Publish\Core\REST\Common\Output\Visitor;
32
-use eZ\Publish\Core\REST\Common\Message; use eZ\Publish\Core\REST\Client\Exceptions\InvalidArgumentValue;
32
+use eZ\Publish\Core\REST\Common\Message;
33
+use eZ\Publish\Core\REST\Client\Exceptions\InvalidArgumentValue;
33 34
 use eZ\Publish\Core\REST\Common\Exceptions\InvalidArgumentException;
34 35
 use eZ\Publish\Core\REST\Common\Exceptions\ForbiddenException;
35 36
 use eZ\Publish\Core\REST\Client\Exceptions\BadStateException;
Please login to merge, or discard this patch.
eZ/Publish/Core/REST/Server/Controller/Role.php 1 patch
Unused Use Statements   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@  discard block
 block discarded – undo
11 11
 namespace eZ\Publish\Core\REST\Server\Controller;
12 12
 
13 13
 use eZ\Publish\API\Repository\Exceptions\LimitationValidationException;
14
-use eZ\Publish\API\Repository\Exceptions\NotFoundException;
14
+use eZ\Publish\API\Repository\Exceptions\NotFoundException as APINotFoundException;
15 15
 use eZ\Publish\Core\Base\Exceptions\ForbiddenException;
16 16
 use eZ\Publish\Core\Base\Exceptions\InvalidArgumentException;
17 17
 use eZ\Publish\Core\Base\Exceptions\UnauthorizedException;
@@ -25,7 +25,6 @@  discard block
 block discarded – undo
25 25
 use eZ\Publish\API\Repository\LocationService;
26 26
 use eZ\Publish\API\Repository\Values\User\RoleCreateStruct;
27 27
 use eZ\Publish\API\Repository\Values\User\RoleUpdateStruct;
28
-use eZ\Publish\API\Repository\Exceptions\NotFoundException as APINotFoundException;
29 28
 use Symfony\Component\HttpFoundation\Request;
30 29
 
31 30
 /**
Please login to merge, or discard this patch.
Core/REST/Server/Tests/Output/ValueObjectVisitor/RestExecutedViewTest.php 1 patch
Unused Use Statements   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,9 +15,8 @@
 block discarded – undo
15 15
 use eZ\Publish\API\Repository\Values\Content\Search\SearchResult;
16 16
 use eZ\Publish\Core\REST\Common\Tests\Output\ValueObjectVisitorBaseTest;
17 17
 use eZ\Publish\Core\REST\Server\Output\ValueObjectVisitor;
18
-use eZ\Publish\Core\Repository\Values\Content;
19
-use eZ\Publish\Core\REST\Server\Values\RestExecutedView;
20 18
 use eZ\Publish\Core\Repository\Values\Content as ApiValues;
19
+use eZ\Publish\Core\REST\Server\Values\RestExecutedView;
21 20
 
22 21
 class RestExecutedViewTest extends ValueObjectVisitorBaseTest
23 22
 {
Please login to merge, or discard this patch.
eZ/Publish/API/Repository/Tests/LocationServiceTest.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -762,7 +762,7 @@  discard block
 block discarded – undo
762 762
     /**
763 763
      * Test for the loadLocationChildren() method.
764 764
      *
765
-     * @return \eZ\Publish\API\Repository\Values\Content\Location[]
765
+     * @return LocationList
766 766
      *
767 767
      * @see \eZ\Publish\API\Repository\LocationService::loadLocationChildren($location, $offset)
768 768
      * @depends eZ\Publish\API\Repository\Tests\LocationServiceTest::testLoadLocationChildren
@@ -826,7 +826,7 @@  discard block
 block discarded – undo
826 826
     /**
827 827
      * Test for the loadLocationChildren() method.
828 828
      *
829
-     * @return \eZ\Publish\API\Repository\Values\Content\Location[]
829
+     * @return LocationList
830 830
      *
831 831
      * @see \eZ\Publish\API\Repository\LocationService::loadLocationChildren($location, $offset, $limit)
832 832
      * @depends eZ\Publish\API\Repository\Tests\LocationServiceTest::testLoadLocationChildren
@@ -855,7 +855,7 @@  discard block
 block discarded – undo
855 855
     /**
856 856
      * Test for the loadLocationChildren() method.
857 857
      *
858
-     * @param \eZ\Publish\API\Repository\Values\Content\Location[] $locations
858
+     * @param LocationList $locations
859 859
      *
860 860
      * @see \eZ\Publish\API\Repository\LocationService::loadLocationChildren($location, $offset, $limit)
861 861
      * @depends eZ\Publish\API\Repository\Tests\LocationServiceTest::testLoadLocationChildrenWithOffsetAndLimit
@@ -2127,7 +2127,7 @@  discard block
 block discarded – undo
2127 2127
      * Assert generated aliases to expected alias return.
2128 2128
      *
2129 2129
      * @param \eZ\Publish\API\Repository\URLAliasService $urlAliasService
2130
-     * @param array $expectedAliases
2130
+     * @param string[] $expectedAliases
2131 2131
      */
2132 2132
     protected function assertGeneratedAliases($urlAliasService, array $expectedAliases)
2133 2133
     {
@@ -2139,7 +2139,7 @@  discard block
 block discarded – undo
2139 2139
 
2140 2140
     /**
2141 2141
      * @param \eZ\Publish\API\Repository\URLAliasService $urlAliasService
2142
-     * @param array $expectedSubItemAliases
2142
+     * @param string[] $expectedSubItemAliases
2143 2143
      */
2144 2144
     private function assertAliasesBeforeCopy($urlAliasService, array $expectedSubItemAliases)
2145 2145
     {
Please login to merge, or discard this patch.
eZ/Bundle/EzPublishCoreBundle/Features/Context/BasicContentContext.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
      *
114 114
      * @param string $path The content path
115 115
      * @param array $fields
116
-     * @param mixed $contentType The content type identifier
116
+     * @param string $contentType The content type identifier
117 117
      *
118 118
      * @return mixed location id of the created content
119 119
      */
@@ -147,6 +147,7 @@  discard block
 block discarded – undo
147 147
 
148 148
     /**
149 149
      * Maps the path of the content to it's name for later use.
150
+     * @param string $path
150 151
      */
151 152
     private function mapContentPath($path)
152 153
     {
Please login to merge, or discard this patch.
eZ/Bundle/EzPublishCoreBundle/Features/Context/FieldTypeContext.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -228,6 +228,7 @@
 block discarded – undo
228 228
      *
229 229
      * @param string The field name
230 230
      * @param mixed The field value
231
+     * @param string|null $field
231 232
      */
232 233
     private function createAndPublishContent($field, $value)
233 234
     {
Please login to merge, or discard this patch.
eZ/Bundle/EzPublishCoreBundle/Features/Context/UserContext.php 1 patch
Doc Comments   +11 added lines, -8 removed lines patch added patch discarded remove patch
@@ -64,9 +64,9 @@  discard block
 block discarded – undo
64 64
      * Search User with given username, optionally at given location.
65 65
      *
66 66
      * @param string $username name of User to search for
67
-     * @param string $parentGroupLocationId where to search, in User Group tree
67
+     * @param string $parentGroupId where to search, in User Group tree
68 68
      *
69
-     * @return User found
69
+     * @return null|\eZ\Publish\API\Repository\Values\User\User found
70 70
      */
71 71
     public function searchUserByLogin($username, $parentGroupId = null)
72 72
     {
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
      * @param string $name name of User Group to search for
98 98
      * @param string $parentLocationId (optional) parent location id to search in
99 99
      *
100
-     * @return search results
100
+     * @return \eZ\Publish\API\Repository\Values\Content\Search\SearchHit[] results
101 101
      */
102 102
     public function searchUserGroups($name, $parentLocationId = null)
103 103
     {
@@ -120,12 +120,12 @@  discard block
 block discarded – undo
120 120
     /**
121 121
      * Create user inside given User Group; DELETES existing User if login already exists!
122 122
      *
123
-     * @param $username username of the user to create
124
-     * @param $email email address of user to create
125
-     * @param $password account password for user to create
126
-     * @param $parentGroup pathstring wherein to create user
123
+     * @param string $username username of the user to create
124
+     * @param string $email email address of user to create
125
+     * @param string $password account password for user to create
126
+     * @param \eZ\Publish\API\Repository\Values\User\UserGroup $parentGroup pathstring wherein to create user
127 127
      *
128
-     * @return eZ\Publish\API\Repository\Values\User\User
128
+     * @return \eZ\Publish\API\Repository\Values\User\User
129 129
      */
130 130
     protected function createUser($username, $email, $password, $parentGroup = null, $fields = array())
131 131
     {
@@ -319,6 +319,9 @@  discard block
 block discarded – undo
319 319
         return false;
320 320
     }
321 321
 
322
+    /**
323
+     * @param integer $type
324
+     */
322 325
     public function createPasswordHash($login, $password, $type)
323 326
     {
324 327
         switch ($type) {
Please login to merge, or discard this patch.
Publish/Core/Search/Legacy/Content/WordIndexer/Gateway/DoctrineDatabase.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,6 @@
 block discarded – undo
14 14
 use eZ\Publish\Core\Search\Legacy\Content\FullTextData;
15 15
 use eZ\Publish\SPI\Persistence\Content;
16 16
 use eZ\Publish\SPI\Persistence\Content\Type\Handler as SPITypeHandler;
17
-use eZ\Publish\SPI\Search\Field;
18 17
 
19 18
 /**
20 19
  * WordIndexer gateway implementation using the Doctrine database.
Please login to merge, or discard this patch.
eZ/Publish/API/Repository/Tests/SearchEngineIndexingTest.php 1 patch
Unused Use Statements   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -8,11 +8,10 @@
 block discarded – undo
8 8
  */
9 9
 namespace eZ\Publish\API\Repository\Tests;
10 10
 
11
-use eZ\Publish\API\Repository\Tests\SetupFactory\LegacyElasticsearch as LegacyElasticsearchSetupFactory;
11
+use eZ\Publish\API\Repository\Tests\SetupFactory\LegacyElasticsearch;
12 12
 use eZ\Publish\API\Repository\Values\Content\ContentInfo;
13 13
 use eZ\Publish\API\Repository\Exceptions\NotFoundException;
14 14
 use eZ\Publish\API\Repository\SearchService;
15
-use eZ\Publish\API\Repository\Tests\SetupFactory\LegacyElasticsearch;
16 15
 use eZ\Publish\API\Repository\Values\Content\LocationQuery;
17 16
 use eZ\Publish\API\Repository\Values\Content\Query;
18 17
 use eZ\Publish\API\Repository\Values\Content\Query\Criterion;
Please login to merge, or discard this patch.