TrashHandlerTest::testRecover() - Code Metrics - Inspection of "EZP-28680: Error 500 after restoring related item..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ec2de6...d160d9 )

unknown

created 2018-03-26 14:16 UTC

TrashHandlerTest::testRecover() A

↳ Parent: TrashHandlerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	52
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	38
nc	1
nop	0
dl	0
loc	52
rs	9.4929
c	0
b	0
f	0

How to fix Long Method

<?php

/**
 * File contains Test class.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Publish\Core\Persistence\Cache\Tests;

use eZ\Publish\Core\Persistence\Cache\ContentHandler;
use eZ\Publish\Core\Persistence\Cache\LocationHandler;
use eZ\Publish\SPI\Persistence\Content\Location;
use eZ\Publish\SPI\Persistence\Content\Location\Trash\Handler as TrashHandler;

/**
 * Test case for Persistence\Cache\SectionHandler.
 */
class TrashHandlerTest extends AbstractCacheHandlerTest
{
    public function getHandlerMethodName(): string
    {
        return 'trashHandler';
    }

    public function getHandlerClassName(): string
    {
        return TrashHandler::class;
    }

    public function providerForUnCachedMethods(): array
    {
        // string $method, array $arguments, array? $tags, string? $key
        return [
            ['loadTrashItem', [6]],
            ['emptyTrash', []],
            ['deleteTrashItem', [6]],
        ];
    }

    public function providerForCachedLoadMethods(): array
    {
        // string $method, array $arguments, string $key, mixed? $data
        return [
        ];
    }

    public function testRecover()
    {
        $originalLocationId = 6;
        $targetLocationId = 2;
        $contentId = 42;

        $tags = [
            'content-' . $contentId,
            'content-fields-' . $contentId,
            'location-' . $originalLocationId,
            'location-path-' . $originalLocationId,
        ];

        $handlerMethodName = $this->getHandlerMethodName();

        $this->loggerMock->expects($this->once())->method('logCall');

        $innerHandler = $this->createMock($this->getHandlerClassName());
        $contentHandlerMock = $this->createMock(ContentHandler::class);
        $locationHandlerMock = $this->createMock(LocationHandler::class);

        $locationHandlerMock
            ->method('load')
            ->will($this->returnValue(new Location(['id' => $originalLocationId, 'contentId' => $contentId])));

        $this->persistenceHandlerMock
            ->method('contentHandler')
            ->will($this->returnValue($contentHandlerMock));

        $this->persistenceHandlerMock
            ->method('locationHandler')
            ->will($this->returnValue($locationHandlerMock));

        $this->persistenceHandlerMock
            ->expects($this->once())
            ->method($handlerMethodName)
            ->will($this->returnValue($innerHandler));

        $innerHandler
            ->expects($this->once())
            ->method('recover')
            ->with($originalLocationId, $targetLocationId)
            ->will($this->returnValue(null));

        $this->cacheMock
            ->expects($this->once())
            ->method('invalidateTags')
            ->with($tags);

        $handler = $this->persistenceCacheHandler->$handlerMethodName();
        $handler->recover($originalLocationId, $targetLocationId);
    }

    public function testTrashSubtree()
    {
        $locationId = 6;
        $contentId = 42;

        $tags = [
            'content-' . $contentId,
            'content-fields-' . $contentId,
            'location-' . $locationId,
            'location-path-' . $locationId,
        ];

        $handlerMethodName = $this->getHandlerMethodName();

        $this->loggerMock->expects($this->once())->method('logCall');

        $innerHandler = $this->createMock($this->getHandlerClassName());
        $contentHandlerMock = $this->createMock(ContentHandler::class);
        $locationHandlerMock = $this->createMock(LocationHandler::class);

        $locationHandlerMock
            ->method('load')
            ->will($this->returnValue(new Location(['id' => $locationId, 'contentId' => $contentId])));

        $this->persistenceHandlerMock
            ->method('contentHandler')
            ->will($this->returnValue($contentHandlerMock));

        $this->persistenceHandlerMock
            ->method('locationHandler')
            ->will($this->returnValue($locationHandlerMock));

        $this->persistenceHandlerMock
            ->expects($this->once())
            ->method($handlerMethodName)
            ->will($this->returnValue($innerHandler));

        $innerHandler
            ->expects($this->once())
            ->method('trashSubtree')
            ->with($locationId)
            ->will($this->returnValue(null));

        $this->cacheMock
            ->expects($this->once())
            ->method('invalidateTags')
            ->with($tags);

        $handler = $this->persistenceCacheHandler->$handlerMethodName();
        $handler->trashSubtree($locationId);
    }
}


1			<?php
2
3			/**
4			* File contains Test class.
5			*
6			* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7			* @license For full copyright and license information view LICENSE file distributed with this source code.
8			*/
9			namespace eZ\Publish\Core\Persistence\Cache\Tests;
10
11			use eZ\Publish\Core\Persistence\Cache\ContentHandler;
12			use eZ\Publish\Core\Persistence\Cache\LocationHandler;
13			use eZ\Publish\SPI\Persistence\Content\Location;
14			use eZ\Publish\SPI\Persistence\Content\Location\Trash\Handler as TrashHandler;
15
16			/**
17			* Test case for Persistence\Cache\SectionHandler.
18			*/
19			class TrashHandlerTest extends AbstractCacheHandlerTest
20			{
21			public function getHandlerMethodName(): string
22			{
23			return 'trashHandler';
24			}
25
26			public function getHandlerClassName(): string
27			{
28			return TrashHandler::class;
29			}
30
31			public function providerForUnCachedMethods(): array
32			{
33			// string $method, array $arguments, array? $tags, string? $key
34			return [
35			['loadTrashItem', [6]],
36			['emptyTrash', []],
37			['deleteTrashItem', [6]],
38			];
39			}
40
41			public function providerForCachedLoadMethods(): array
42			{
43			// string $method, array $arguments, string $key, mixed? $data
44			return [
45			];
46			}
47
48			public function testRecover()
49			{
50			$originalLocationId = 6;
51			$targetLocationId = 2;
52			$contentId = 42;
53
54			$tags = [
55			'content-' . $contentId,
56			'content-fields-' . $contentId,
57			'location-' . $originalLocationId,
58			'location-path-' . $originalLocationId,
59			];
60
61			$handlerMethodName = $this->getHandlerMethodName();
62
63			$this->loggerMock->expects($this->once())->method('logCall');
64
65			$innerHandler = $this->createMock($this->getHandlerClassName());
66			$contentHandlerMock = $this->createMock(ContentHandler::class);
67			$locationHandlerMock = $this->createMock(LocationHandler::class);
68
69			$locationHandlerMock
70			->method('load')
71			->will($this->returnValue(new Location(['id' => $originalLocationId, 'contentId' => $contentId])));
72
73			$this->persistenceHandlerMock
74			->method('contentHandler')
75			->will($this->returnValue($contentHandlerMock));
76
77			$this->persistenceHandlerMock
78			->method('locationHandler')
79			->will($this->returnValue($locationHandlerMock));
80
81			$this->persistenceHandlerMock
82			->expects($this->once())
83			->method($handlerMethodName)
84			->will($this->returnValue($innerHandler));
85
86			$innerHandler
87			->expects($this->once())
88			->method('recover')
89			->with($originalLocationId, $targetLocationId)
90			->will($this->returnValue(null));
91
92			$this->cacheMock
93			->expects($this->once())
94			->method('invalidateTags')
95			->with($tags);
96
97			$handler = $this->persistenceCacheHandler->$handlerMethodName();
98			$handler->recover($originalLocationId, $targetLocationId);
99			}
100
101			public function testTrashSubtree()
102			{
103			$locationId = 6;
104			$contentId = 42;
105
106			$tags = [
107			'content-' . $contentId,
108			'content-fields-' . $contentId,
109			'location-' . $locationId,
110			'location-path-' . $locationId,
111			];
112
113			$handlerMethodName = $this->getHandlerMethodName();
114
115			$this->loggerMock->expects($this->once())->method('logCall');
116
117			$innerHandler = $this->createMock($this->getHandlerClassName());
118			$contentHandlerMock = $this->createMock(ContentHandler::class);
119			$locationHandlerMock = $this->createMock(LocationHandler::class);
120
121			$locationHandlerMock
122			->method('load')
123			->will($this->returnValue(new Location(['id' => $locationId, 'contentId' => $contentId])));
124
125			$this->persistenceHandlerMock
126			->method('contentHandler')
127			->will($this->returnValue($contentHandlerMock));
128
129			$this->persistenceHandlerMock
130			->method('locationHandler')
131			->will($this->returnValue($locationHandlerMock));
132
133			$this->persistenceHandlerMock
134			->expects($this->once())
135			->method($handlerMethodName)
136			->will($this->returnValue($innerHandler));
137
138			$innerHandler
139			->expects($this->once())
140			->method('trashSubtree')
141			->with($locationId)
142			->will($this->returnValue(null));
143
144			$this->cacheMock
145			->expects($this->once())
146			->method('invalidateTags')
147			->with($tags);
148
149			$handler = $this->persistenceCacheHandler->$handlerMethodName();
150			$handler->trashSubtree($locationId);
151			}
152			}
153

ezsystems / ezpublish-kernel

Push — master ( ec2de6...d160d9 )

TrashHandlerTest::testRecover() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like