ezsystems / ezpublish-kernel

eZ/Publish/Core/Persistence/Legacy/Tests/Content/StorageRegistryTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
     /**
      * Returns a mock for Storage.
      *
-     * @return Storage
+     * @return \PHPUnit\Framework\MockObject\MockObject
      */
     protected function getStorageMock()
     {

eZ/Publish/Core/Persistence/Tests/FieldTypeRegistryTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -130,7 +130,7 @@
     /**
      * Returns a mock for persistence field type.
      *
-     * @return \eZ\Publish\SPI\Persistence\FieldType
+     * @return \PHPUnit\Framework\MockObject\MockObject
      */
     protected function getFieldTypeMock()
     {

eZ/Publish/Core/Persistence/Legacy/Content/Location/Gateway/DoctrineDatabase.php

Doc Comments +20 added lines, -17 removed lines

@@ -247,7 +247,7 @@ 
     /**
      * Returns data for the first level children of the location identified by given $locationId.
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      *
      * @return array
      */
@@ -374,6 +374,9 @@ 
         }
     }
 
+    /**
+     * @param string $pathString
+     */
     private function isHiddenByParent($pathString, array $rows)
     {
         $parentNodeIds = explode('/', trim($pathString, '/'));
@@ -751,7 +754,7 @@ 
      * Create an entry in the node assignment table.
      *
      * @param \eZ\Publish\SPI\Persistence\Content\Location\CreateStruct $createStruct
-     * @param mixed $parentNodeId
+     * @param string $parentNodeId
      * @param int $type
      */
     public function createNodeAssignment(CreateStruct $createStruct, $parentNodeId, $type = self::NODE_ASSIGNMENT_OP_CODE_CREATE_NOP)
@@ -879,8 +882,8 @@ 
      *
      * Convert existing node assignments into real locations.
      *
-     * @param mixed $contentId
-     * @param mixed $versionNo
+     * @param integer $contentId
+     * @param integer $versionNo
      */
     public function createLocationsFromNodeAssignments($contentId, $versionNo)
     {
@@ -948,8 +951,8 @@ 
     /**
      * Updates all Locations of content identified with $contentId with $versionNo.
      *
-     * @param mixed $contentId
-     * @param mixed $versionNo
+     * @param integer $contentId
+     * @param integer $versionNo
      */
     public function updateLocationsContentVersionNo($contentId, $versionNo)
     {
@@ -1108,8 +1111,8 @@ 
      * the node identified by given $locationId (current main node).
      * Assumes that content has more than one location.
      *
-     * @param mixed $contentId
-     * @param mixed $locationId
+     * @param integer $contentId
+     * @param integer $locationId
      *
      * @return array
      */
@@ -1145,9 +1148,9 @@ 
      *
      * The associated content object is left untouched.
      *
-     * @param mixed $locationId
+     * @param integer $locationId
      *
-     * @return bool
+     * @return boolean|null
      */
     public function trashLocation($locationId)
     {
@@ -1177,8 +1180,8 @@ 
      * at the old position. If this is not possible ( because the old location
      * does not exist any more) and exception is thrown.
      *
-     * @param mixed $locationId
-     * @param mixed|null $newParentId
+     * @param integer $locationId
+     * @param integer $newParentId
      *
      * @return \eZ\Publish\SPI\Persistence\Content\Location
      */
@@ -1431,10 +1434,10 @@ 
      * Updates ezcontentobject_tree table for the given $contentId and eznode_assignment table for the given
      * $contentId, $parentLocationId and $versionNo
      *
-     * @param mixed $contentId
-     * @param mixed $locationId
-     * @param mixed $versionNo version number, needed to update eznode_assignment table
-     * @param mixed $parentLocationId parent location of location identified by $locationId, needed to update
+     * @param integer $contentId
+     * @param integer $locationId
+     * @param integer $versionNo version number, needed to update eznode_assignment table
+     * @param integer $parentLocationId parent location of location identified by $locationId, needed to update
      *        eznode_assignment table
      */
     public function changeMainLocation($contentId, $locationId, $versionNo, $parentLocationId)
@@ -1564,7 +1567,7 @@ 
      *
      * @todo Align with createNodeQueryBuilder, removing the need for both(?)
      *
-     * @param array $columns list of columns to fetch
+     * @param string[] $columns list of columns to fetch
      *
      * @return \Doctrine\DBAL\Query\QueryBuilder
      */

eZ/Publish/Core/FieldType/Author/Type.php

Doc Comments +2 added lines, -2 removed lines

@@ -212,7 +212,7 @@ 
      *
      * @param string $name
      *
-     * @return \eZ\Publish\SPI\FieldType\ValidationError|null
+     * @return ValidationError|null
      */
     private function validateSettingName($name)
     {
@@ -236,7 +236,7 @@ 
      * @param string $name
      * @param string $value
      *
-     * @return \eZ\Publish\SPI\FieldType\ValidationError|null
+     * @return ValidationError|null
      */
     private function validateDefaultAuthorSetting($name, $value)
     {

eZ/Publish/API/Repository/Tests/TrashServiceAuthorizationTest.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 namespace eZ\Publish\API\Repository\Tests;
 
 use eZ\Publish\API\Repository\Exceptions\UnauthorizedException;
-use eZ\Publish\API\Repository\Values\Content\Location;
 use eZ\Publish\API\Repository\Values\User\Limitation\ObjectStateLimitation;
 use eZ\Publish\Core\Repository\Repository;
 use eZ\Publish\Core\Repository\TrashService;

eZ/Publish/Core/Persistence/Legacy/Content/Type/Handler.php

Doc Comments +13 added lines, -14 removed lines

@@ -94,7 +94,7 @@ 
     }
 
     /**
-     * @param mixed $groupId
+     * @param integer $groupId
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\BadStateException If type group contains types
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException If type group with id is not found
@@ -175,7 +175,7 @@ 
     }
 
     /**
-     * @param mixed $groupId
+     * @param integer $groupId
      * @param int $status
      *
      * @return Type[]
@@ -237,7 +237,7 @@ 
      *
      * Note: This method is responsible of having the Field Definitions of the loaded ContentType sorted by placement.
      *
-     * @param mixed $remoteId
+     * @param string $remoteId
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException If defined type is not found
      *
@@ -338,7 +338,6 @@ 
     /**
      * @param mixed $typeId
      * @param int $status
-     * @param \eZ\Publish\SPI\Persistence\Content\Type\UpdateStruct $contentType
      *
      * @return Type
      */
@@ -355,7 +354,7 @@ 
     /**
      * @throws \eZ\Publish\API\Repository\Exceptions\BadStateException If type is defined and still has content
      *
-     * @param mixed $contentTypeId
+     * @param integer $contentTypeId
      * @param int $status
      *
      * @return bool
@@ -437,8 +436,8 @@ 
     /**
      * Unlink a content type group from a content type.
      *
-     * @param mixed $groupId
-     * @param mixed $contentTypeId
+     * @param integer $groupId
+     * @param integer $contentTypeId
      * @param int $status
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException If group or type with provided status is not found
@@ -462,8 +461,8 @@ 
     /**
      * Link a content type group with a content type.
      *
-     * @param mixed $groupId
-     * @param mixed $contentTypeId
+     * @param integer $groupId
+     * @param integer $contentTypeId
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException If group or type with provided status is not found
      * @throws \eZ\Publish\API\Repository\Exceptions\BadStateException If type is already part of group
@@ -509,7 +508,7 @@ 
     /**
      * Counts the number of Content instances of the ContentType identified by given $contentTypeId.
      *
-     * @param mixed $contentTypeId
+     * @param integer $contentTypeId
      *
      * @return int
      */
@@ -525,7 +524,7 @@ 
      * added. It does not update existing content objects depending on the
      * field (default) values.
      *
-     * @param mixed $contentTypeId
+     * @param integer $contentTypeId
      * @param int $status One of Type::STATUS_DEFINED|Type::STATUS_DRAFT|Type::STATUS_MODIFIED
      * @param \eZ\Publish\SPI\Persistence\Content\Type\FieldDefinition $fieldDefinition
      */
@@ -548,8 +547,8 @@ 
      * referred to by $fieldDefinitionId removed. It does not update existing
      * content objects depending on the field (default) values.
      *
-     * @param mixed $contentTypeId
-     * @param mixed $fieldDefinitionId
+     * @param integer $contentTypeId
+     * @param integer $fieldDefinitionId
      *
      * @return bool
      */
@@ -568,7 +567,7 @@ 
      * on the
      * field (default) values.
      *
-     * @param mixed $contentTypeId
+     * @param integer $contentTypeId
      * @param \eZ\Publish\SPI\Persistence\Content\Type\FieldDefinition $fieldDefinition
      */
     public function updateFieldDefinition($contentTypeId, $status, FieldDefinition $fieldDefinition)

eZ/Publish/Core/MVC/Symfony/Templating/Twig/Extension/FileSizeExtension.php

Doc Comments +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
     /**
      * Returns a list of filters to add to the existing list.
      *
-     * @return array An array of filters
+     * @return Twig_SimpleFilter[] An array of filters
      */
     public function getFilters()
     {

eZ/Publish/Core/Persistence/Cache/UrlAliasHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -383,7 +383,7 @@
      * @param \eZ\Publish\SPI\Persistence\Content\UrlAlias $urlAlias
      * @param array $tags Optional, can be used to specify other tags.
      *
-     * @return array
+     * @return string[]
      */
     private function getCacheTags(UrlAlias $urlAlias, array $tags = [])
     {

eZ/Publish/Core/Persistence/Legacy/Content/Handler.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 
 use Exception;
 use eZ\Publish\Core\Persistence\Legacy\Content\Location\Gateway as LocationGateway;
-use eZ\Publish\SPI\Persistence\Content\Field;
 use eZ\Publish\SPI\Persistence\Content\Handler as BaseContentHandler;
 use eZ\Publish\SPI\Persistence\Content\Type\Handler as ContentTypeHandler;
 use eZ\Publish\Core\Persistence\Legacy\Content\UrlAlias\SlugConverter;

Doc Comments +7 added lines, -7 removed lines

@@ -150,7 +150,7 @@ 
      * Will contain always a complete list of fields.
      *
      * @param \eZ\Publish\SPI\Persistence\Content\CreateStruct $struct Content creation struct.
-     * @param mixed $versionNo Used by self::copy() to maintain version numbers
+     * @param integer $versionNo Used by self::copy() to maintain version numbers
      *
      * @return \eZ\Publish\SPI\Persistence\Content Content value object
      */
@@ -432,7 +432,7 @@ 
     /**
      * Returns the metadata object for a content identified by $remoteId.
      *
-     * @param mixed $remoteId
+     * @param string $remoteId
      *
      * @return \eZ\Publish\SPI\Persistence\Content\ContentInfo
      */
@@ -593,7 +593,7 @@ 
      *
      * @param int $contentId
      *
-     * @return bool
+     * @return boolean|null
      */
     public function deleteContent($contentId)
     {
@@ -625,7 +625,7 @@ 
      * @param int $contentId
      * @param int $versionNo
      *
-     * @return bool
+     * @return boolean|null
      */
     public function deleteVersion($contentId, $versionNo)
     {
@@ -750,7 +750,7 @@ 
      *
      * @todo Should the existence verifications happen here or is this supposed to be handled at a higher level?
      *
-     * @param mixed $relationId
+     * @param integer $relationId
      * @param int $type {@see \eZ\Publish\API\Repository\Values\Content\Relation::COMMON,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::EMBED,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::LINK,
@@ -764,7 +764,7 @@ 
     /**
      * Loads relations from $sourceContentId. Optionally, loads only those with $type and $sourceContentVersionNo.
      *
-     * @param mixed $sourceContentId Source Content ID
+     * @param integer $sourceContentId Source Content ID
      * @param mixed|null $sourceContentVersionNo Source Content Version, null if not specified
      * @param int|null $type {@see \eZ\Publish\API\Repository\Values\Content\Relation::COMMON,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::EMBED,
@@ -785,7 +785,7 @@ 
      *
      * Only loads relations against published versions.
      *
-     * @param mixed $destinationContentId Destination Content ID
+     * @param integer $destinationContentId Destination Content ID
      * @param int|null $type {@see \eZ\Publish\API\Repository\Values\Content\Relation::COMMON,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::EMBED,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::LINK,