UserTest - Code Metrics - Inspection of "EZP-27498: [API] Add shorthand name property on Co..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — api_content_name_shorthand ( e0a75f )

by André

created 2017-06-16 13:26 UTC

UserTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	100
Duplicated Lines	13 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

Metric	Value
dl	13
loc	100
rs	10
c	0
b	0
f	0
wmc	6
lcom	1
cbo	6

6 Methods

Rating	Name	Duplication	Size	Complexity
A	testNewClass()	0	16	1
A	testGetName()	13	13	1
A	testMissingProperty()	0	6	1
A	testReadOnlyProperty()	0	6	1
A	testIsPropertySet()	0	9	1
A	testUnsetProperty()	0	6	1

How to fix Duplicated Code

<?php

/**
 * File containing the UserTest class.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Publish\Core\Repository\Tests\Values\User;

use eZ\Publish\API\Repository\Tests\Values\ValueObjectTestTrait;
use eZ\Publish\Core\Repository\Values\User\User;
use Mockery;
use PHPUnit_Framework_TestCase;

/**
 * Test internal integrity of @see \eZ\Publish\Core\Repository\Values\User\User ValueObject.
 */
class UserTest extends PHPUnit_Framework_TestCase
{
    use ValueObjectTestTrait;

    /**
     * Test a new class and default values on properties.
     *
     * @covers \eZ\Publish\Core\Repository\Values\User\User::__construct
     */
    public function testNewClass()
    {
        $user = new User();

        $this->assertPropertiesCorrect(
            [
                'login' => null,
                'email' => null,
                'passwordHash' => null,
                'hashAlgorithm' => null,
                'maxLogin' => null,
                'enabled' => false,
            ],
            $user
        );
    }

    /**
     * Test a new class and default values on properties.
     *
     * @covers \eZ\Publish\API\Repository\Values\User\User::__construct
     */
    public function testGetName()
    {
        $name = 'Translated name';
        $contentMock = Mockery::mock('eZ\Publish\API\Repository\Values\Content\Content');
        $versionInfoMock = Mockery::mock('eZ\Publish\API\Repository\Values\Content\VersionInfo');

        $contentMock->shouldReceive('getVersionInfo')->andReturn($versionInfoMock);
        $versionInfoMock->shouldReceive('getName')->andReturn($name);

        $object = new User(['content' => $contentMock]);

        $this->assertEquals($name, $object->getName());
    }


    /**
     * Test retrieving missing property.
     *
     * @covers \eZ\Publish\API\Repository\Values\User\User::__get
     * @expectedException \eZ\Publish\API\Repository\Exceptions\PropertyNotFoundException
     */
    public function testMissingProperty()
    {
        $user = new User();
        $value = $user->notDefined;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        self::fail('Succeeded getting non existing property');
    }

    /**
     * Test setting read only property.
     *
     * @covers \eZ\Publish\API\Repository\Values\User\User::__set
     * @expectedException \eZ\Publish\API\Repository\Exceptions\PropertyReadOnlyException
     */
    public function testReadOnlyProperty()
    {
        $user = new User();
        $user->login = 'user';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        self::fail('Succeeded setting read only property');
    }

    /**
     * Test if property exists.
     *
     * @covers \eZ\Publish\API\Repository\Values\User\User::__isset
     */
    public function testIsPropertySet()
    {
        $user = new User();
        $value = isset($user->notDefined);
        self::assertEquals(false, $value);

        $value = isset($user->login);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        self::assertEquals(true, $value);
    }

    /**
     * Test unsetting a property.
     *
     * @covers \eZ\Publish\API\Repository\Values\User\User::__unset
     * @expectedException \eZ\Publish\API\Repository\Exceptions\PropertyReadOnlyException
     */
    public function testUnsetProperty()
    {
        $user = new User(['login' => 'admin']);
        unset($user->login);
        self::fail('Unsetting read-only property succeeded');
    }
}


1		<?php
2
3		/**
4		* File containing the UserTest class.
5		*
6		* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7		* @license For full copyright and license information view LICENSE file distributed with this source code.
8		*/
9		namespace eZ\Publish\Core\Repository\Tests\Values\User;
10
11		use eZ\Publish\API\Repository\Tests\Values\ValueObjectTestTrait;
12		use eZ\Publish\Core\Repository\Values\User\User;
13		use Mockery;
14		use PHPUnit_Framework_TestCase;
15
16		/**
17		* Test internal integrity of @see \eZ\Publish\Core\Repository\Values\User\User ValueObject.
18		*/
19		class UserTest extends PHPUnit_Framework_TestCase
20		{
21		use ValueObjectTestTrait;
22
23		/**
24		* Test a new class and default values on properties.
25		*
26		* @covers \eZ\Publish\Core\Repository\Values\User\User::__construct
27		*/
28		public function testNewClass()
29		{
30		$user = new User();
31
32		$this->assertPropertiesCorrect(
33		[
34		'login' => null,
35		'email' => null,
36		'passwordHash' => null,
37		'hashAlgorithm' => null,
38		'maxLogin' => null,
39		'enabled' => false,
40		],
41		$user
42		);
43		}
44
45		/**
46		* Test a new class and default values on properties.
47		*
48		* @covers \eZ\Publish\API\Repository\Values\User\User::__construct
49		*/
50	View Code Duplication	public function testGetName()
51		{
52		$name = 'Translated name';
53		$contentMock = Mockery::mock('eZ\Publish\API\Repository\Values\Content\Content');
54		$versionInfoMock = Mockery::mock('eZ\Publish\API\Repository\Values\Content\VersionInfo');
55
56		$contentMock->shouldReceive('getVersionInfo')->andReturn($versionInfoMock);
57		$versionInfoMock->shouldReceive('getName')->andReturn($name);
58
59		$object = new User(['content' => $contentMock]);
60
61		$this->assertEquals($name, $object->getName());
62		}
63
64
65		/**
66		* Test retrieving missing property.
67		*
68		* @covers \eZ\Publish\API\Repository\Values\User\User::__get
69		* @expectedException \eZ\Publish\API\Repository\Exceptions\PropertyNotFoundException
70		*/
71		public function testMissingProperty()
72		{
73		$user = new User();
74		$value = $user->notDefined;
		0 ignored issues – show Documentation introduced 2017-04-18 15:26 UTC by Report Bug Copy Issue Report The property `notDefined` does not exist on `object<eZ\Publish\Core\R...itory\Values\User\User>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Unused Code introduced 2017-04-18 15:26 UTC by Report Bug Copy Issue Report `$value` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
75		self::fail('Succeeded getting non existing property');
76		}
77
78		/**
79		* Test setting read only property.
80		*
81		* @covers \eZ\Publish\API\Repository\Values\User\User::__set
82		* @expectedException \eZ\Publish\API\Repository\Exceptions\PropertyReadOnlyException
83		*/
84		public function testReadOnlyProperty()
85		{
86		$user = new User();
87		$user->login = 'user';
		0 ignored issues – show Documentation introduced 2017-04-18 15:26 UTC by Report Bug Copy Issue Report The property `$login` is declared protected in `eZ\Publish\API\Repository\Values\User\User`. Since you implemented `__set()`, maybe consider adding a @property or @property-write annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
88		self::fail('Succeeded setting read only property');
89		}
90
91		/**
92		* Test if property exists.
93		*
94		* @covers \eZ\Publish\API\Repository\Values\User\User::__isset
95		*/
96		public function testIsPropertySet()
97		{
98		$user = new User();
99		$value = isset($user->notDefined);
100		self::assertEquals(false, $value);
101
102		$value = isset($user->login);
		0 ignored issues – show Documentation introduced 2017-04-18 15:26 UTC by Report Bug Copy Issue Report The property `$login` is declared protected in `eZ\Publish\API\Repository\Values\User\User`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
103		self::assertEquals(true, $value);
104		}
105
106		/**
107		* Test unsetting a property.
108		*
109		* @covers \eZ\Publish\API\Repository\Values\User\User::__unset
110		* @expectedException \eZ\Publish\API\Repository\Exceptions\PropertyReadOnlyException
111		*/
112		public function testUnsetProperty()
113		{
114		$user = new User(['login' => 'admin']);
115		unset($user->login);
116		self::fail('Unsetting read-only property succeeded');
117		}
118		}
119

ezsystems / ezpublish-kernel

Push — api_content_name_shorthand ( e0a75f )

UserTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like