UserHandler::assignRole() - Code Metrics - Inspection of "[7.x] Refactor to use Symfony Cache for performanc..." - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — sf_cache ( 18214b...3b3329 )

by André

created 2017-03-20 18:30 UTC

UserHandler::assignRole() A

↳ Parent: UserHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	5
nc	1
nop	3
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0

<?php

/**
 * File containing a User Handler impl.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Publish\Core\Persistence\Cache;

use eZ\Publish\SPI\Persistence\User\Handler as UserHandlerInterface;
use eZ\Publish\SPI\Persistence\User;
use eZ\Publish\SPI\Persistence\User\Role;
use eZ\Publish\SPI\Persistence\User\RoleAssignment;
use eZ\Publish\SPI\Persistence\User\RoleCreateStruct;
use eZ\Publish\SPI\Persistence\User\RoleUpdateStruct;
use eZ\Publish\SPI\Persistence\User\Policy;

/**
 * Cache handler for user module.
 */
class UserHandler extends AbstractHandler implements UserHandlerInterface
{
    /**
     * {@inheritdoc}
     */
    public function create(User $user)
    {
        $this->logger->logCall(__METHOD__, array('struct' => $user));
        $return = $this->persistenceHandler->userHandler()->create($user);

        // Clear corresponding content cache as creation of the User changes it's external data
        $this->cache->invalidateTags(['content-fields-' . $user->id]);

        return $return;
    }

    /**
     * {@inheritdoc}
     */
    public function load($userId)
    {
        $cacheItem = $this->cache->getItem("ez-user-${userId}");
        if ($cacheItem->isHit()) {
            return $cacheItem->get();
        }

        $this->logger->logCall(__METHOD__, array('user' => $userId));
        $user = $this->persistenceHandler->userHandler()->load($userId);

        $cacheItem->set($user);
        $cacheItem->tag(['content-' . $user->id, 'user-' . $user->id]);
        $this->cache->save($cacheItem);

        return $user;
    }

    /**
     * {@inheritdoc}
     */
    public function loadByLogin($login)
    {
        $cacheItem = $this->cache->getItem("ez-user-${login}-by-login");
        if ($cacheItem->isHit()) {
            return $cacheItem->get();
        }

        $this->logger->logCall(__METHOD__, array('user' => $login));
        $user = $this->persistenceHandler->userHandler()->loadByLogin($login);

        $cacheItem->set($user);
        $cacheItem->tag(['content-' . $user->id, 'user-' . $user->id]);
        $this->cache->save($cacheItem);

        return $user;
    }

    /**
     * {@inheritdoc}
     */
    public function loadByEmail($email)
    {
        $cacheItem = $this->cache->getItem('ez-user-' . str_replace('@', '§', $email) . '-by-email');
        if ($cacheItem->isHit()) {
            return $cacheItem->get();
        }

        $this->logger->logCall(__METHOD__, array('email' => $email));
        $users = $this->persistenceHandler->userHandler()->loadByEmail($email);

        $cacheItem->set($users);
        $cacheTags = [];
        foreach ($users as $user) {
            $cacheTags[] = 'content-' . $user->id;
            $cacheTags[] = 'user-' . $user->id;
        }
        $cacheItem->tag($cacheTags);
        $this->cache->save($cacheItem);

        return $users;
    }

    /**
     * {@inheritdoc}
     */
    public function update(User $user)
    {
        $this->logger->logCall(__METHOD__, array('struct' => $user));
        $return = $this->persistenceHandler->userHandler()->update($user);

        // Clear corresponding content cache as update of the User changes it's external data
        $this->cache->invalidateTags(['content-fields-' . $user->id, 'user-' . $user->id]);

        return $return;
    }

    /**
     * {@inheritdoc}
     */
    public function delete($userId)
    {
        $this->logger->logCall(__METHOD__, array('user' => $userId));
        $return = $this->persistenceHandler->userHandler()->delete($userId);

        // user id == content id == group id
        $this->cache->invalidateTags(['content-fields-' . $userId, 'user-' . $userId]);

        return $return;
    }

    /**
     * {@inheritdoc}
     */
    public function createRole(RoleCreateStruct $createStruct)
    {
        $this->logger->logCall(__METHOD__, array('struct' => $createStruct));

        return $this->persistenceHandler->userHandler()->createRole($createStruct);
    }

    /**
     * {@inheritdoc}
     */
    public function createRoleDraft($roleId)
    {
        $this->logger->logCall(__METHOD__, array('role' => $roleId));

        return $this->persistenceHandler->userHandler()->createRoleDraft($roleId);
    }

    /**
     * {@inheritdoc}
     */
    public function loadRole($roleId, $status = Role::STATUS_DEFINED)
    {
        if ($status !== Role::STATUS_DEFINED) {
            $this->logger->logCall(__METHOD__, array('role' => $roleId));

            return $this->persistenceHandler->userHandler()->loadRole($roleId, $status);
        }

        $cacheItem = $this->cache->getItem("ez-role-${roleId}");
        if ($cacheItem->isHit()) {
            return $cacheItem->get();
        }

        $this->logger->logCall(__METHOD__, array('role' => $roleId));
        $role = $this->persistenceHandler->userHandler()->loadRole($roleId, $status);

        $cacheItem->set($role);
        $cacheItem->tag(['role-' . $role->id]);
        $this->cache->save($cacheItem);

        return $role;
    }

    /**
     * {@inheritdoc}
     */
    public function loadRoleByIdentifier($identifier, $status = Role::STATUS_DEFINED)
    {
        if ($status !== Role::STATUS_DEFINED) {
            $this->logger->logCall(__METHOD__, array('role' => $identifier));

            return $this->persistenceHandler->userHandler()->loadRoleByIdentifier($identifier, $status);
        }

        $cacheItem = $this->cache->getItem("ez-role-${identifier}-by-identifier");
        if ($cacheItem->isHit()) {
            return $cacheItem->get();
        }

        $this->logger->logCall(__METHOD__, array('role' => $identifier));
        $role = $this->persistenceHandler->userHandler()->loadRoleByIdentifier($identifier, $status);

        $cacheItem->set($role);
        $cacheItem->tag(['role-' . $role->id]);
        $this->cache->save($cacheItem);

        return $role;
    }

    /**
     * {@inheritdoc}
     */
    public function loadRoleDraftByRoleId($roleId)
    {
        $this->logger->logCall(__METHOD__, array('role' => $roleId));

        return $this->persistenceHandler->userHandler()->loadRoleDraftByRoleId($roleId);
    }

    /**
     * {@inheritdoc}
     */
    public function loadRoles()
    {
        $this->logger->logCall(__METHOD__);

        return $this->persistenceHandler->userHandler()->loadRoles();
    }

    /**
     * {@inheritdoc}
     */
    public function loadRoleAssignment($roleAssignmentId)
    {
        $cacheItem = $this->cache->getItem("ez-role-assignment-${roleAssignmentId}");
        if ($cacheItem->isHit()) {
            return $cacheItem->get();
        }

        $this->logger->logCall(__METHOD__, array('assignment' => $roleAssignmentId));
        $roleAssignment = $this->persistenceHandler->userHandler()->loadRoleAssignment($roleAssignmentId);

        $cacheItem->set($roleAssignment);
        $cacheItem->tag($this->getCacheTagsForRoleAssignment($roleAssignment));
        $this->cache->save($cacheItem);

        return $roleAssignment;
    }

    /**
     * {@inheritdoc}
     */
    public function loadRoleAssignmentsByRoleId($roleId)
    {
        $cacheItem = $this->cache->getItem("ez-role-assignment-${roleId}-by-role");
        if ($cacheItem->isHit()) {
            return $cacheItem->get();
        }

        $this->logger->logCall(__METHOD__, array('role' => $roleId));
        $roleAssignments = $this->persistenceHandler->userHandler()->loadRoleAssignmentsByRoleId($roleId);

        $cacheItem->set($roleAssignments);
        $cacheTags = ['role-assignment-role-list-' . $roleId];
        foreach ($roleAssignments as $roleAssignment) {
            $cacheTags = $this->getCacheTagsForRoleAssignment($roleAssignment, $cacheTags);
        }
        $cacheItem->tag($cacheTags);
        $this->cache->save($cacheItem);

        return $roleAssignments;
    }

    /**
     * {@inheritdoc}
     */
    public function loadRoleAssignmentsByGroupId($groupId, $inherit = false)
    {
        if ($inherit) {
            $cacheItem = $this->cache->getItem("ez-role-assignment-${groupId}-by-group-inherited");
        } else {
            $cacheItem = $this->cache->getItem("ez-role-assignment-${groupId}-by-group");
        }

        if ($cacheItem->isHit()) {
            return $cacheItem->get();
        }

        $this->logger->logCall(__METHOD__, array('group' => $groupId, 'inherit' => $inherit));
        $roleAssignments = $this->persistenceHandler->userHandler()->loadRoleAssignmentsByGroupId($groupId, $inherit);

        $cacheItem->set($roleAssignments);
        // Tag below is for empty results,  non empty it might have duplicated tags but cache will reduce those.
        $cacheTags = ['role-assignment-group-list-' . $groupId];
        foreach ($roleAssignments as $roleAssignment) {
            $cacheTags = $this->getCacheTagsForRoleAssignment($roleAssignment, $cacheTags);
        }

        // To make sure tree operations affecting this can clear the permission cache
        $locations = $this->persistenceHandler->locationHandler()->loadLocationsByContent($groupId);
        foreach ($locations as $location) {

            foreach (explode('/', trim($location->pathString, '/')) as $pathId) {
                $cacheTags[] = 'location-path-' . $pathId;
            }
        }

        $cacheItem->tag($cacheTags);
        $this->cache->save($cacheItem);

        return $roleAssignments;
    }

    /**
     * {@inheritdoc}
     */
    public function updateRole(RoleUpdateStruct $struct)
    {
        $this->logger->logCall(__METHOD__, array('struct' => $struct));
        $this->persistenceHandler->userHandler()->updateRole($struct);

        $this->cache->invalidateTags(['role-' . $struct->id]);
    }

    /**
     * {@inheritdoc}
     */
    public function deleteRole($roleId, $status = Role::STATUS_DEFINED)
    {
        $this->logger->logCall(__METHOD__, array('role' => $roleId));
        $return = $this->persistenceHandler->userHandler()->deleteRole($roleId, $status);

        if ($status === Role::STATUS_DEFINED) {
            $this->cache->invalidateTags(['role-' . $roleId, 'role-assignment-role-list-' . $roleId]);
        }

        return $return;
    }

    /**
     * {@inheritdoc}
     */
    public function publishRoleDraft($roleDraftId)
    {
        $this->logger->logCall(__METHOD__, array('role' => $roleDraftId));
        $userHandler = $this->persistenceHandler->userHandler();
        $roleDraft = $userHandler->loadRole($roleDraftId, Role::STATUS_DRAFT);
        $return = $userHandler->publishRoleDraft($roleDraftId);

        // If there was a original role for the draft, then we clean cache for it
        if ($roleDraft->originalId > -1) {
            $this->cache->invalidateTags(['role-' . $roleDraft->originalId]);
        }

        return $return;
    }

    /**
     * {@inheritdoc}
     */
    public function addPolicyByRoleDraft($roleId, Policy $policy)
    {
        $this->logger->logCall(__METHOD__, array('role' => $roleId, 'struct' => $policy));

        return $this->persistenceHandler->userHandler()->addPolicyByRoleDraft($roleId, $policy);
    }

    /**
     * {@inheritdoc}
     */
    public function addPolicy($roleId, Policy $policy)
    {
        $this->logger->logCall(__METHOD__, array('role' => $roleId, 'struct' => $policy));
        $return = $this->persistenceHandler->userHandler()->addPolicy($roleId, $policy);

        $this->cache->invalidateTags(['role-' . $roleId]);

        return $return;
    }

    /**
     * {@inheritdoc}
     */
    public function updatePolicy(Policy $policy)
    {
        $this->logger->logCall(__METHOD__, array('struct' => $policy));
        $return = $this->persistenceHandler->userHandler()->updatePolicy($policy);

        $this->cache->invalidateTags(['policy-' . $policy->id, 'role-' . $policy->roleId]);

        return $return;
    }

    /**
     * {@inheritdoc}
     */
    public function deletePolicy($policyId, $roleId)
    {
        $this->logger->logCall(__METHOD__, array('policy' => $policyId));
        $this->persistenceHandler->userHandler()->deletePolicy($policyId, $roleId);

        $this->cache->invalidateTags(['policy-' . $policyId, 'role-' . $roleId]);
    }

    /**
     * {@inheritdoc}
     */
    public function loadPoliciesByUserId($userId)
    {
        $this->logger->logCall(__METHOD__, array('user' => $userId));

        return $this->persistenceHandler->userHandler()->loadPoliciesByUserId($userId);

    }

    /**
     * {@inheritdoc}
     */
    public function assignRole($contentId, $roleId, array $limitation = null)
    {
        $this->logger->logCall(__METHOD__, array('group' => $contentId, 'role' => $roleId, 'limitation' => $limitation));
        $return = $this->persistenceHandler->userHandler()->assignRole($contentId, $roleId, $limitation);

        $this->cache->invalidateTags(['role-assignment-group-list-' . $contentId, 'role-assignment-role-list-' . $roleId]);

        return $return;
    }

    /**
     * {@inheritdoc}
     */
    public function unassignRole($contentId, $roleId)
    {
        $this->logger->logCall(__METHOD__, array('group' => $contentId, 'role' => $roleId));
        $return = $this->persistenceHandler->userHandler()->unassignRole($contentId, $roleId);

        $this->cache->invalidateTags(['role-assignment-group-list-' . $contentId, 'role-assignment-role-list-' . $roleId]);

        return $return;
    }

    /**
     * {@inheritdoc}
     */
    public function removeRoleAssignment($roleAssignmentId)
    {
        $this->logger->logCall(__METHOD__, array('assignment' => $roleAssignmentId));
        $return = $this->persistenceHandler->userHandler()->removeRoleAssignment($roleAssignmentId);

        $this->cache->invalidateTags(['role-assignment-' . $roleAssignmentId]);

        return $return;
    }

    /**
     * Reusable function to return relevant role assignment tags so cache can be purged reliably.
     *
     * @param \eZ\Publish\SPI\Persistence\User\RoleAssignment $roleAssignment
     * @param array $tags Optional, can be used to specify other tags.
     *
     * @return array
     */
    private function getCacheTagsForRoleAssignment(RoleAssignment $roleAssignment, array $tags = [])
    {
        $tags[] = 'role-assignment-' . $roleAssignment->id;
        $tags[] = 'role-assignment-group-list-' . $roleAssignment->contentId;
        $tags[] = 'role-assignment-role-list-' . $roleAssignment->roleId;

        return $tags;
    }
}


1		<?php
2
3		/**
4		* File containing a User Handler impl.
5		*
6		* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7		* @license For full copyright and license information view LICENSE file distributed with this source code.
8		*/
9		namespace eZ\Publish\Core\Persistence\Cache;
10
11		use eZ\Publish\SPI\Persistence\User\Handler as UserHandlerInterface;
12		use eZ\Publish\SPI\Persistence\User;
13		use eZ\Publish\SPI\Persistence\User\Role;
14		use eZ\Publish\SPI\Persistence\User\RoleAssignment;
15		use eZ\Publish\SPI\Persistence\User\RoleCreateStruct;
16		use eZ\Publish\SPI\Persistence\User\RoleUpdateStruct;
17		use eZ\Publish\SPI\Persistence\User\Policy;
18
19		/**
20		* Cache handler for user module.
21		*/
22		class UserHandler extends AbstractHandler implements UserHandlerInterface
23		{
24		/**
25		* {@inheritdoc}
26		*/
27		public function create(User $user)
28		{
29		$this->logger->logCall(__METHOD__, array('struct' => $user));
30		$return = $this->persistenceHandler->userHandler()->create($user);
31
32		// Clear corresponding content cache as creation of the User changes it's external data
33		$this->cache->invalidateTags(['content-fields-' . $user->id]);
34
35		return $return;
36		}
37
38		/**
39		* {@inheritdoc}
40		*/
41	View Code Duplication	public function load($userId)
42		{
43		$cacheItem = $this->cache->getItem("ez-user-${userId}");
44		if ($cacheItem->isHit()) {
45		return $cacheItem->get();
46		}
47
48		$this->logger->logCall(__METHOD__, array('user' => $userId));
49		$user = $this->persistenceHandler->userHandler()->load($userId);
50
51		$cacheItem->set($user);
52		$cacheItem->tag(['content-' . $user->id, 'user-' . $user->id]);
53		$this->cache->save($cacheItem);
54
55		return $user;
56		}
57
58		/**
59		* {@inheritdoc}
60		*/
61	View Code Duplication	public function loadByLogin($login)
62		{
63		$cacheItem = $this->cache->getItem("ez-user-${login}-by-login");
64		if ($cacheItem->isHit()) {
65		return $cacheItem->get();
66		}
67
68		$this->logger->logCall(__METHOD__, array('user' => $login));
69		$user = $this->persistenceHandler->userHandler()->loadByLogin($login);
70
71		$cacheItem->set($user);
72		$cacheItem->tag(['content-' . $user->id, 'user-' . $user->id]);
73		$this->cache->save($cacheItem);
74
75		return $user;
76		}
77
78		/**
79		* {@inheritdoc}
80		*/
81	View Code Duplication	public function loadByEmail($email)
82		{
83		$cacheItem = $this->cache->getItem('ez-user-' . str_replace('@', '§', $email) . '-by-email');
84		if ($cacheItem->isHit()) {
85		return $cacheItem->get();
86		}
87
88		$this->logger->logCall(__METHOD__, array('email' => $email));
89		$users = $this->persistenceHandler->userHandler()->loadByEmail($email);
90
91		$cacheItem->set($users);
92		$cacheTags = [];
93		foreach ($users as $user) {
94		$cacheTags[] = 'content-' . $user->id;
95		$cacheTags[] = 'user-' . $user->id;
96		}
97		$cacheItem->tag($cacheTags);
98		$this->cache->save($cacheItem);
99
100		return $users;
101		}
102
103		/**
104		* {@inheritdoc}
105		*/
106	View Code Duplication	public function update(User $user)
107		{
108		$this->logger->logCall(__METHOD__, array('struct' => $user));
109		$return = $this->persistenceHandler->userHandler()->update($user);
110
111		// Clear corresponding content cache as update of the User changes it's external data
112		$this->cache->invalidateTags(['content-fields-' . $user->id, 'user-' . $user->id]);
113
114		return $return;
115		}
116
117		/**
118		* {@inheritdoc}
119		*/
120		public function delete($userId)
121		{
122		$this->logger->logCall(__METHOD__, array('user' => $userId));
123		$return = $this->persistenceHandler->userHandler()->delete($userId);
124
125		// user id == content id == group id
126		$this->cache->invalidateTags(['content-fields-' . $userId, 'user-' . $userId]);
127
128		return $return;
129		}
130
131		/**
132		* {@inheritdoc}
133		*/
134		public function createRole(RoleCreateStruct $createStruct)
135		{
136		$this->logger->logCall(__METHOD__, array('struct' => $createStruct));
137
138		return $this->persistenceHandler->userHandler()->createRole($createStruct);
139		}
140
141		/**
142		* {@inheritdoc}
143		*/
144		public function createRoleDraft($roleId)
145		{
146		$this->logger->logCall(__METHOD__, array('role' => $roleId));
147
148		return $this->persistenceHandler->userHandler()->createRoleDraft($roleId);
149		}
150
151		/**
152		* {@inheritdoc}
153		*/
154		public function loadRole($roleId, $status = Role::STATUS_DEFINED)
155		{
156		if ($status !== Role::STATUS_DEFINED) {
157		$this->logger->logCall(__METHOD__, array('role' => $roleId));
158
159		return $this->persistenceHandler->userHandler()->loadRole($roleId, $status);
160		}
161
162		$cacheItem = $this->cache->getItem("ez-role-${roleId}");
163		if ($cacheItem->isHit()) {
164		return $cacheItem->get();
165		}
166
167		$this->logger->logCall(__METHOD__, array('role' => $roleId));
168		$role = $this->persistenceHandler->userHandler()->loadRole($roleId, $status);
169
170		$cacheItem->set($role);
171		$cacheItem->tag(['role-' . $role->id]);
172		$this->cache->save($cacheItem);
173
174		return $role;
175		}
176
177		/**
178		* {@inheritdoc}
179		*/
180		public function loadRoleByIdentifier($identifier, $status = Role::STATUS_DEFINED)
181		{
182		if ($status !== Role::STATUS_DEFINED) {
183		$this->logger->logCall(__METHOD__, array('role' => $identifier));
184
185		return $this->persistenceHandler->userHandler()->loadRoleByIdentifier($identifier, $status);
186		}
187
188		$cacheItem = $this->cache->getItem("ez-role-${identifier}-by-identifier");
189		if ($cacheItem->isHit()) {
190		return $cacheItem->get();
191		}
192
193		$this->logger->logCall(__METHOD__, array('role' => $identifier));
194		$role = $this->persistenceHandler->userHandler()->loadRoleByIdentifier($identifier, $status);
195
196		$cacheItem->set($role);
197		$cacheItem->tag(['role-' . $role->id]);
198		$this->cache->save($cacheItem);
199
200		return $role;
201		}
202
203		/**
204		* {@inheritdoc}
205		*/
206		public function loadRoleDraftByRoleId($roleId)
207		{
208		$this->logger->logCall(__METHOD__, array('role' => $roleId));
209
210		return $this->persistenceHandler->userHandler()->loadRoleDraftByRoleId($roleId);
211		}
212
213		/**
214		* {@inheritdoc}
215		*/
216		public function loadRoles()
217		{
218		$this->logger->logCall(__METHOD__);
219
220		return $this->persistenceHandler->userHandler()->loadRoles();
221		}
222
223		/**
224		* {@inheritdoc}
225		*/
226		public function loadRoleAssignment($roleAssignmentId)
227		{
228		$cacheItem = $this->cache->getItem("ez-role-assignment-${roleAssignmentId}");
229		if ($cacheItem->isHit()) {
230		return $cacheItem->get();
231		}
232
233		$this->logger->logCall(__METHOD__, array('assignment' => $roleAssignmentId));
234		$roleAssignment = $this->persistenceHandler->userHandler()->loadRoleAssignment($roleAssignmentId);
235
236		$cacheItem->set($roleAssignment);
237		$cacheItem->tag($this->getCacheTagsForRoleAssignment($roleAssignment));
238		$this->cache->save($cacheItem);
239
240		return $roleAssignment;
241		}
242
243		/**
244		* {@inheritdoc}
245		*/
246	View Code Duplication	public function loadRoleAssignmentsByRoleId($roleId)
247		{
248		$cacheItem = $this->cache->getItem("ez-role-assignment-${roleId}-by-role");
249		if ($cacheItem->isHit()) {
250		return $cacheItem->get();
251		}
252
253		$this->logger->logCall(__METHOD__, array('role' => $roleId));
254		$roleAssignments = $this->persistenceHandler->userHandler()->loadRoleAssignmentsByRoleId($roleId);
255
256		$cacheItem->set($roleAssignments);
257		$cacheTags = ['role-assignment-role-list-' . $roleId];
258		foreach ($roleAssignments as $roleAssignment) {
259		$cacheTags = $this->getCacheTagsForRoleAssignment($roleAssignment, $cacheTags);
260		}
261		$cacheItem->tag($cacheTags);
262		$this->cache->save($cacheItem);
263
264		return $roleAssignments;
265		}
266
267		/**
268		* {@inheritdoc}
269		*/
270		public function loadRoleAssignmentsByGroupId($groupId, $inherit = false)
271		{
272		if ($inherit) {
273		$cacheItem = $this->cache->getItem("ez-role-assignment-${groupId}-by-group-inherited");
274		} else {
275		$cacheItem = $this->cache->getItem("ez-role-assignment-${groupId}-by-group");
276		}
277
278		if ($cacheItem->isHit()) {
279		return $cacheItem->get();
280		}
281
282		$this->logger->logCall(__METHOD__, array('group' => $groupId, 'inherit' => $inherit));
283		$roleAssignments = $this->persistenceHandler->userHandler()->loadRoleAssignmentsByGroupId($groupId, $inherit);
284
285		$cacheItem->set($roleAssignments);
286		// Tag below is for empty results, non empty it might have duplicated tags but cache will reduce those.
287		$cacheTags = ['role-assignment-group-list-' . $groupId];
288		foreach ($roleAssignments as $roleAssignment) {
289		$cacheTags = $this->getCacheTagsForRoleAssignment($roleAssignment, $cacheTags);
290		}
291
292		// To make sure tree operations affecting this can clear the permission cache
293		$locations = $this->persistenceHandler->locationHandler()->loadLocationsByContent($groupId);
294	View Code Duplication	foreach ($locations as $location) {
		0 ignored issues – show Duplication introduced 2017-03-15 15:12 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
295		foreach (explode('/', trim($location->pathString, '/')) as $pathId) {
296		$cacheTags[] = 'location-path-' . $pathId;
297		}
298		}
299
300		$cacheItem->tag($cacheTags);
301		$this->cache->save($cacheItem);
302
303		return $roleAssignments;
304		}
305
306		/**
307		* {@inheritdoc}
308		*/
309	View Code Duplication	public function updateRole(RoleUpdateStruct $struct)
310		{
311		$this->logger->logCall(__METHOD__, array('struct' => $struct));
312		$this->persistenceHandler->userHandler()->updateRole($struct);
313
314		$this->cache->invalidateTags(['role-' . $struct->id]);
315		}
316
317		/**
318		* {@inheritdoc}
319		*/
320		public function deleteRole($roleId, $status = Role::STATUS_DEFINED)
321		{
322		$this->logger->logCall(__METHOD__, array('role' => $roleId));
323		$return = $this->persistenceHandler->userHandler()->deleteRole($roleId, $status);
324
325		if ($status === Role::STATUS_DEFINED) {
326		$this->cache->invalidateTags(['role-' . $roleId, 'role-assignment-role-list-' . $roleId]);
327		}
328
329		return $return;
330		}
331
332		/**
333		* {@inheritdoc}
334		*/
335		public function publishRoleDraft($roleDraftId)
336		{
337		$this->logger->logCall(__METHOD__, array('role' => $roleDraftId));
338		$userHandler = $this->persistenceHandler->userHandler();
339		$roleDraft = $userHandler->loadRole($roleDraftId, Role::STATUS_DRAFT);
340		$return = $userHandler->publishRoleDraft($roleDraftId);
341
342		// If there was a original role for the draft, then we clean cache for it
343		if ($roleDraft->originalId > -1) {
344		$this->cache->invalidateTags(['role-' . $roleDraft->originalId]);
345		}
346
347		return $return;
348		}
349
350		/**
351		* {@inheritdoc}
352		*/
353		public function addPolicyByRoleDraft($roleId, Policy $policy)
354		{
355		$this->logger->logCall(__METHOD__, array('role' => $roleId, 'struct' => $policy));
356
357		return $this->persistenceHandler->userHandler()->addPolicyByRoleDraft($roleId, $policy);
358		}
359
360		/**
361		* {@inheritdoc}
362		*/
363		public function addPolicy($roleId, Policy $policy)
364		{
365		$this->logger->logCall(__METHOD__, array('role' => $roleId, 'struct' => $policy));
366		$return = $this->persistenceHandler->userHandler()->addPolicy($roleId, $policy);
367
368		$this->cache->invalidateTags(['role-' . $roleId]);
369
370		return $return;
371		}
372
373		/**
374		* {@inheritdoc}
375		*/
376	View Code Duplication	public function updatePolicy(Policy $policy)
377		{
378		$this->logger->logCall(__METHOD__, array('struct' => $policy));
379		$return = $this->persistenceHandler->userHandler()->updatePolicy($policy);
380
381		$this->cache->invalidateTags(['policy-' . $policy->id, 'role-' . $policy->roleId]);
382
383		return $return;
384		}
385
386		/**
387		* {@inheritdoc}
388		*/
389	View Code Duplication	public function deletePolicy($policyId, $roleId)
390		{
391		$this->logger->logCall(__METHOD__, array('policy' => $policyId));
392		$this->persistenceHandler->userHandler()->deletePolicy($policyId, $roleId);
393
394		$this->cache->invalidateTags(['policy-' . $policyId, 'role-' . $roleId]);
395		}
396
397		/**
398		* {@inheritdoc}
399		*/
400		public function loadPoliciesByUserId($userId)
401		{
402		$this->logger->logCall(__METHOD__, array('user' => $userId));
403
404		return $this->persistenceHandler->userHandler()->loadPoliciesByUserId($userId);
		0 ignored issues – show Deprecated Code introduced 2017-01-18 23:10 UTC by Report Bug Copy Issue Report The method `eZ\Publish\SPI\Persisten...:loadPoliciesByUserId()` has been deprecated with message: Since 6.8, not currently in use as permission system needs to know about role assignment limitations. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
405		}
406
407		/**
408		* {@inheritdoc}
409		*/
410		public function assignRole($contentId, $roleId, array $limitation = null)
411		{
412		$this->logger->logCall(__METHOD__, array('group' => $contentId, 'role' => $roleId, 'limitation' => $limitation));
413		$return = $this->persistenceHandler->userHandler()->assignRole($contentId, $roleId, $limitation);
414
415		$this->cache->invalidateTags(['role-assignment-group-list-' . $contentId, 'role-assignment-role-list-' . $roleId]);
416
417		return $return;
418		}
419
420		/**
421		* {@inheritdoc}
422		*/
423	View Code Duplication	public function unassignRole($contentId, $roleId)
424		{
425		$this->logger->logCall(__METHOD__, array('group' => $contentId, 'role' => $roleId));
426		$return = $this->persistenceHandler->userHandler()->unassignRole($contentId, $roleId);
427
428		$this->cache->invalidateTags(['role-assignment-group-list-' . $contentId, 'role-assignment-role-list-' . $roleId]);
429
430		return $return;
431		}
432
433		/**
434		* {@inheritdoc}
435		*/
436	View Code Duplication	public function removeRoleAssignment($roleAssignmentId)
437		{
438		$this->logger->logCall(__METHOD__, array('assignment' => $roleAssignmentId));
439		$return = $this->persistenceHandler->userHandler()->removeRoleAssignment($roleAssignmentId);
440
441		$this->cache->invalidateTags(['role-assignment-' . $roleAssignmentId]);
442
443		return $return;
444		}
445
446		/**
447		* Reusable function to return relevant role assignment tags so cache can be purged reliably.
448		*
449		* @param \eZ\Publish\SPI\Persistence\User\RoleAssignment $roleAssignment
450		* @param array $tags Optional, can be used to specify other tags.
451		*
452		* @return array
453		*/
454		private function getCacheTagsForRoleAssignment(RoleAssignment $roleAssignment, array $tags = [])
455		{
456		$tags[] = 'role-assignment-' . $roleAssignment->id;
457		$tags[] = 'role-assignment-group-list-' . $roleAssignment->contentId;
458		$tags[] = 'role-assignment-role-list-' . $roleAssignment->roleId;
459
460		return $tags;
461		}
462		}
463

ezsystems / ezpublish-kernel

Push — sf_cache ( 18214b...3b3329 )

UserHandler::assignRole() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like