URLAlias::visitURLAliasAttributes() - Code Metrics - Inspection of "Merge branch '7.1'" - ezsystems/ezpublish-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 553bc5...721b68 )

unknown

created 2018-05-08 08:45 UTC

URLAlias::visitURLAliasAttributes() A

↳ Parent: URLAlias

Complexity

Conditions	2
Paths	2

Size

Total Lines	57
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	39
nc	2
nop	3
dl	0
loc	57
rs	9.6818
c	0
b	0
f	0

How to fix Long Method

<?php

/**
 * File containing the URLAlias ValueObjectVisitor class.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Publish\Core\REST\Server\Output\ValueObjectVisitor;

use eZ\Publish\Core\REST\Common\Output\ValueObjectVisitor;
use eZ\Publish\Core\REST\Common\Output\Generator;
use eZ\Publish\Core\REST\Common\Output\Visitor;
use eZ\Publish\API\Repository\Values;
use eZ\Publish\API\Repository\Values\Content\URLAlias as URLAliasValue;

/**
 * URLAlias value object visitor.
 */
class URLAlias extends ValueObjectVisitor
{
    /**
     * Visit struct returned by controllers.
     *
     * @param \eZ\Publish\Core\REST\Common\Output\Visitor $visitor
     * @param \eZ\Publish\Core\REST\Common\Output\Generator $generator
     * @param \eZ\Publish\API\Repository\Values\Content\URLAlias $data
     */
    public function visit(Visitor $visitor, Generator $generator, $data)
    {
        $generator->startObjectElement('UrlAlias');
        $visitor->setHeader('Content-Type', $generator->getMediaType('UrlAlias'));
        $this->visitURLAliasAttributes($visitor, $generator, $data);
        $generator->endObjectElement('UrlAlias');
    }

    /**
     * Serializes the given $urlAliasType to a string representation.
     *
     * @param int $urlAliasType
     *
     * @return string
     */
    protected function serializeType($urlAliasType)
    {
        switch ($urlAliasType) {
            case Values\Content\URLAlias::LOCATION:
                return 'LOCATION';

            case Values\Content\URLAlias::RESOURCE:
                return 'RESOURCE';

            case Values\Content\URLAlias::VIRTUAL:
                return 'VIRTUAL';
        }

        throw new \RuntimeException("Unknown URL alias type: '{$urlAliasType}'.");
    }

    protected function visitURLAliasAttributes(Visitor $visitor, Generator $generator, URLAliasValue $data)

    {
        $generator->startAttribute(
            'href',
            $this->router->generate('ezpublish_rest_loadURLAlias', array('urlAliasId' => $data->id))
        );
        $generator->endAttribute('href');

        $generator->startAttribute('id', $data->id);
        $generator->endAttribute('id');

        $generator->startAttribute('type', $this->serializeType($data->type));
        $generator->endAttribute('type');

        if ($data->type === Values\Content\URLAlias::LOCATION) {
            $generator->startObjectElement('location', 'Location');
            $generator->startAttribute(
                'href',
                $this->router->generate('ezpublish_rest_loadLocation', array('locationPath' => $data->destination))
            );
            $generator->endAttribute('href');
            $generator->endObjectElement('location');
        } else {
            $generator->startValueElement('resource', $data->destination);
            $generator->endValueElement('resource');
        }

        $generator->startValueElement('path', $data->path);
        $generator->endValueElement('path');

        $generator->startValueElement('languageCodes', implode(',', $data->languageCodes));
        $generator->endValueElement('languageCodes');

        $generator->startValueElement(
            'alwaysAvailable',
            $this->serializeBool($generator, $data->alwaysAvailable)
        );
        $generator->endValueElement('alwaysAvailable');

        $generator->startValueElement(
            'isHistory',
            $this->serializeBool($generator, $data->isHistory)
        );
        $generator->endValueElement('isHistory');

        $generator->startValueElement(
            'forward',
            $this->serializeBool($generator, $data->forward)
        );
        $generator->endValueElement('forward');

        $generator->startValueElement(
            'custom',
            $this->serializeBool($generator, $data->isCustom)
        );
        $generator->endValueElement('custom');
    }
}


1			<?php
2
3			/**
4			* File containing the URLAlias ValueObjectVisitor class.
5			*
6			* @copyright Copyright (C) eZ Systems AS. All rights reserved.
7			* @license For full copyright and license information view LICENSE file distributed with this source code.
8			*/
9			namespace eZ\Publish\Core\REST\Server\Output\ValueObjectVisitor;
10
11			use eZ\Publish\Core\REST\Common\Output\ValueObjectVisitor;
12			use eZ\Publish\Core\REST\Common\Output\Generator;
13			use eZ\Publish\Core\REST\Common\Output\Visitor;
14			use eZ\Publish\API\Repository\Values;
15			use eZ\Publish\API\Repository\Values\Content\URLAlias as URLAliasValue;
16
17			/**
18			* URLAlias value object visitor.
19			*/
20			class URLAlias extends ValueObjectVisitor
21			{
22			/**
23			* Visit struct returned by controllers.
24			*
25			* @param \eZ\Publish\Core\REST\Common\Output\Visitor $visitor
26			* @param \eZ\Publish\Core\REST\Common\Output\Generator $generator
27			* @param \eZ\Publish\API\Repository\Values\Content\URLAlias $data
28			*/
29			public function visit(Visitor $visitor, Generator $generator, $data)
30			{
31			$generator->startObjectElement('UrlAlias');
32			$visitor->setHeader('Content-Type', $generator->getMediaType('UrlAlias'));
33			$this->visitURLAliasAttributes($visitor, $generator, $data);
34			$generator->endObjectElement('UrlAlias');
35			}
36
37			/**
38			* Serializes the given $urlAliasType to a string representation.
39			*
40			* @param int $urlAliasType
41			*
42			* @return string
43			*/
44			protected function serializeType($urlAliasType)
45			{
46			switch ($urlAliasType) {
47			case Values\Content\URLAlias::LOCATION:
48			return 'LOCATION';
49
50			case Values\Content\URLAlias::RESOURCE:
51			return 'RESOURCE';
52
53			case Values\Content\URLAlias::VIRTUAL:
54			return 'VIRTUAL';
55			}
56
57			throw new \RuntimeException("Unknown URL alias type: '{$urlAliasType}'.");
58			}
59
60			protected function visitURLAliasAttributes(Visitor $visitor, Generator $generator, URLAliasValue $data)
			0 ignored issues – show Unused Code introduced 2018-05-08 08:27 UTC by Report Bug Copy Issue Report The parameter `$visitor` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
61			{
62			$generator->startAttribute(
63			'href',
64			$this->router->generate('ezpublish_rest_loadURLAlias', array('urlAliasId' => $data->id))
65			);
66			$generator->endAttribute('href');
67
68			$generator->startAttribute('id', $data->id);
69			$generator->endAttribute('id');
70
71			$generator->startAttribute('type', $this->serializeType($data->type));
72			$generator->endAttribute('type');
73
74			if ($data->type === Values\Content\URLAlias::LOCATION) {
75			$generator->startObjectElement('location', 'Location');
76			$generator->startAttribute(
77			'href',
78			$this->router->generate('ezpublish_rest_loadLocation', array('locationPath' => $data->destination))
79			);
80			$generator->endAttribute('href');
81			$generator->endObjectElement('location');
82			} else {
83			$generator->startValueElement('resource', $data->destination);
84			$generator->endValueElement('resource');
85			}
86
87			$generator->startValueElement('path', $data->path);
88			$generator->endValueElement('path');
89
90			$generator->startValueElement('languageCodes', implode(',', $data->languageCodes));
91			$generator->endValueElement('languageCodes');
92
93			$generator->startValueElement(
94			'alwaysAvailable',
95			$this->serializeBool($generator, $data->alwaysAvailable)
96			);
97			$generator->endValueElement('alwaysAvailable');
98
99			$generator->startValueElement(
100			'isHistory',
101			$this->serializeBool($generator, $data->isHistory)
102			);
103			$generator->endValueElement('isHistory');
104
105			$generator->startValueElement(
106			'forward',
107			$this->serializeBool($generator, $data->forward)
108			);
109			$generator->endValueElement('forward');
110
111			$generator->startValueElement(
112			'custom',
113			$this->serializeBool($generator, $data->isCustom)
114			);
115			$generator->endValueElement('custom');
116			}
117			}
118

ezsystems / ezpublish-kernel

Push — master ( 553bc5...721b68 )

URLAlias::visitURLAliasAttributes() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like