eZ\Publish\Core\REST\Server\Output\ValueObjectVisitor\Policy

Complexity

Total Complexity

6

Size/Duplication

Total Lines	54
Duplicated Lines	35.19 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	visit()	8	8	2
B	visitPolicyAttributes()	11	35	4

<?php

/**
 * File containing the Policy ValueObjectVisitor class.
 *
 * @copyright Copyright (C) eZ Systems AS. All rights reserved.
 * @license For full copyright and license information view LICENSE file distributed with this source code.
 */
namespace eZ\Publish\Core\REST\Server\Output\ValueObjectVisitor;

use eZ\Publish\API\Repository\Values\User\PolicyDraft;
use eZ\Publish\Core\REST\Common\Output\ValueObjectVisitor;
use eZ\Publish\Core\REST\Common\Output\Generator;
use eZ\Publish\Core\REST\Common\Output\Visitor;
use eZ\Publish\API\Repository\Values\User\Policy as PolicyValue;

/**
 * Policy value object visitor.
 */
class Policy extends ValueObjectVisitor
{
    /**
     * Visit struct returned by controllers.
     *
     * @param \eZ\Publish\Core\REST\Common\Output\Visitor $visitor
     * @param \eZ\Publish\Core\REST\Common\Output\Generator $generator
     * @param Policy|PolicyDraft $data
     */
    public function visit(Visitor $visitor, Generator $generator, $data)
    {
        $generator->startObjectElement('Policy');
        $visitor->setHeader('Content-Type', $generator->getMediaType($data instanceof PolicyDraft ? 'PolicyDraft' : 'Policy'));
        $visitor->setHeader('Accept-Patch', $generator->getMediaType('PolicyUpdate'));
        $this->visitPolicyAttributes($visitor, $generator, $data);

It seems like $data defined by parameter $data on line 29 can also be of type object<eZ\Publish\Core\REST\Server\Output\ValueObjectVisitor\Policy>; however, eZ\Publish\Core\REST\Server\Output\ValueObjectVisitor\Policy::visitPolicyAttributes() does only seem to accept object<eZ\Publish\API\Repository\Values\User\Policy>, maybe add an additional type check?

        $generator->endObjectElement('Policy');
    }

    protected function visitPolicyAttributes(Visitor $visitor, Generator $generator, PolicyValue $data)

The parameter $visitor is not used and could be removed.

    {
        $generator->startAttribute(
            'href',
            $this->router->generate('ezpublish_rest_loadPolicy', array('roleId' => $data->roleId, 'policyId' => $data->id))
        );
        $generator->endAttribute('href');

        $generator->startValueElement('id', $data->id);
        $generator->endValueElement('id');

        if ($data instanceof PolicyDraft) {
            $generator->startValueElement('originalId', $data->originalId);
            $generator->endValueElement('originalId');
        }

        $generator->startValueElement('module', $data->module);
        $generator->endValueElement('module');

        $generator->startValueElement('function', $data->function);
        $generator->endValueElement('function');

        $limitations = $data->getLimitations();
        if (!empty($limitations)) {

This code seems to be duplicated across your project.

            $generator->startHashElement('limitations');
            $generator->startList('limitation');

            foreach ($limitations as $limitation) {
                $this->visitLimitation($generator, $limitation);
            }

            $generator->endList('limitation');
            $generator->endHashElement('limitations');
        }
    }
}