ezsystems / ezpublish-kernel

eZ/Publish/Core/Search/Legacy/Content/WordIndexer/Gateway/DoctrineDatabase.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use eZ\Publish\Core\Search\Legacy\Content\FullTextData;
 use eZ\Publish\SPI\Persistence\Content;
 use eZ\Publish\SPI\Persistence\Content\Type\Handler as SPITypeHandler;
-use eZ\Publish\SPI\Search\Field;
 
 /**
  * WordIndexer gateway implementation using the Doctrine database.

Doc Comments +1 added lines, -1 removed lines

@@ -184,7 +184,7 @@
      * Ported from the legacy code
      * @see https://github.com/ezsystems/ezpublish-legacy/blob/master/kernel/search/plugins/ezsearchengine/ezsearchengine.php#L386
      *
-     * @param mixed $contentId
+     * @param integer $contentId
      * @param mixed|null $versionId
      *
      * @return bool

eZ/Publish/Core/Search/Legacy/Content/WordIndexer/Repository/SearchIndex.php

Doc Comments +6 added lines, -6 removed lines

@@ -127,15 +127,15 @@
      * Link word with specific content object (legacy db table: ezsearch_object_word_link).
      *
      * @param $wordId
-     * @param $contentId
-     * @param $frequency
-     * @param $placement
+     * @param integer $contentId
+     * @param integer $frequency
+     * @param integer $placement
      * @param $nextWordId
      * @param $prevWordId
-     * @param $contentTypeId
+     * @param integer $contentTypeId
      * @param $fieldTypeId
-     * @param $published
-     * @param $sectionId
+     * @param integer $published
+     * @param integer $sectionId
      * @param $identifier
      * @param $integerValue
      */

eZ/Publish/Core/REST/Server/Output/ValueObjectVisitor/Role.php

Doc Comments +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
      *
      * @param \eZ\Publish\Core\REST\Common\Output\Visitor $visitor
      * @param \eZ\Publish\Core\REST\Common\Output\Generator $generator
-     * @param Role|RoleDraft $data
+     * @param \eZ\Publish\Core\REST\Server\Values\RestRole $data
      */
     public function visit(Visitor $visitor, Generator $generator, $data)
     {

eZ/Publish/Core/Persistence/Database/DatabaseHandler.php

Doc Comments +9 added lines, -4 removed lines

@@ -26,16 +26,19 @@ 
 
     /**
      * Begin a transaction.
+     * @return void
      */
     public function beginTransaction();
 
     /**
      * Commit a transaction.
+     * @return void
      */
     public function commit();
 
     /**
      * Rollback a transaction.
+     * @return void
      */
     public function rollBack();
 
@@ -59,6 +62,7 @@ 
      * Execute a query against the database.
      *
      * @param string $query
+     * @return void
      */
     public function exec($query);
 
@@ -67,7 +71,7 @@ 
      *
      * Statements are ducktyped, but need to work like PDOStatement.
      *
-     * @return object
+     * @return \Doctrine\DBAL\Driver\Statement
      */
     public function prepare($query);
 
@@ -137,8 +141,9 @@ 
      *
      * This is an optimization and works around the ezcDB implementation.
      *
-     * @param string $identifier
      *
+     * @param string $name
+     * @param string $alias
      * @return string
      */
     public function alias($name, $alias);
@@ -167,7 +172,7 @@ 
      * @param string $table
      * @param string $column
      *
-     * @return mixed
+     * @return string
      */
     public function getAutoIncrementValue($table, $column);
 
@@ -184,7 +189,7 @@ 
     /**
      * Returns underlying connection (e.g. Doctrine connection object).
      *
-     * @return mixed
+     * @return \Doctrine\DBAL\Connection
      */
     public function getConnection();
 }

eZ/Publish/Core/MVC/Symfony/Routing/RouteReference.php

Doc Comments +5 added lines, -2 removed lines

@@ -31,7 +31,7 @@ 
     }
 
     /**
-     * @param mixed $route
+     * @param string $route
      */
     public function setRoute($route)
     {
@@ -69,7 +69,7 @@ 
      * Returns a route parameter.
      *
      * @param string $parameterName
-     * @param mixed $defaultValue
+     * @param string $defaultValue
      * @param bool $deep
      *
      * @return mixed
@@ -79,6 +79,9 @@ 
         return $this->params->get($parameterName, $defaultValue, $deep);
     }
 
+    /**
+     * @param string $parameterName
+     */
     public function has($parameterName)
     {
         return $this->params->has($parameterName);

eZ/Publish/Core/REST/Server/Controller/User.php

Doc Comments +5 added lines, -5 removed lines

@@ -141,7 +141,7 @@ 
      *
      * @param $groupPath
      *
-     * @return \eZ\Publish\Core\REST\Server\Values\RestUserGroup
+     * @return Values\CachedValue
      */
     public function loadUserGroup($groupPath)
     {
@@ -178,7 +178,7 @@ 
      *
      * @param $userId
      *
-     * @return \eZ\Publish\Core\REST\Server\Values\RestUser
+     * @return Values\CachedValue
      */
     public function loadUser($userId)
     {
@@ -711,7 +711,7 @@ 
      *
      * @param $groupPath
      *
-     * @return \eZ\Publish\Core\REST\Server\Values\UserGroupList|\eZ\Publish\Core\REST\Server\Values\UserGroupRefList
+     * @return Values\CachedValue
      */
     public function loadSubUserGroups($groupPath, Request $request)
     {
@@ -767,7 +767,7 @@ 
      *
      * @param $userId
      *
-     * @return \eZ\Publish\Core\REST\Server\Values\UserGroupRefList
+     * @return Values\CachedValue
      */
     public function loadUserGroupsOfUser($userId, Request $request)
     {
@@ -807,7 +807,7 @@ 
      *
      * @param $groupPath
      *
-     * @return \eZ\Publish\Core\REST\Server\Values\UserList|\eZ\Publish\Core\REST\Server\Values\UserRefList
+     * @return Values\CachedValue
      */
     public function loadUsersFromGroup($groupPath, Request $request)
     {

eZ/Publish/API/Repository/Tests/SearchEngineIndexingTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -742,8 +742,8 @@
      * $parentLocationIdList.
      *
      * @param string $contentName
-     * @param $contentDescription
-     * @param array $parentLocationIdList
+     * @param string $contentDescription
+     * @param integer[] $parentLocationIdList
      *
      * @return \eZ\Publish\API\Repository\Values\Content\Content
      */

Unused Use Statements +1 added lines, -2 removed lines

@@ -8,11 +8,10 @@
  */
 namespace eZ\Publish\API\Repository\Tests;
 
-use eZ\Publish\API\Repository\Tests\SetupFactory\LegacyElasticsearch as LegacyElasticsearchSetupFactory;
+use eZ\Publish\API\Repository\Tests\SetupFactory\LegacyElasticsearch;
 use eZ\Publish\API\Repository\Values\Content\ContentInfo;
 use eZ\Publish\API\Repository\Exceptions\NotFoundException;
 use eZ\Publish\API\Repository\SearchService;
-use eZ\Publish\API\Repository\Tests\SetupFactory\LegacyElasticsearch;
 use eZ\Publish\API\Repository\Values\Content\LocationQuery;
 use eZ\Publish\API\Repository\Values\Content\Query;
 use eZ\Publish\API\Repository\Values\Content\Query\Criterion;

eZ/Publish/API/Repository/Tests/Values/User/Limitation/RolePolicyLimitationTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
     /**
      * Perform search by the Subtree Criterion for the given subtree path and return results count.
      *
-     * @param $subtreePathString
+     * @param string $subtreePathString
      * @return int|null
      */
     protected function getSubtreeLocationsCount($subtreePathString)

eZ/Publish/Core/Search/Common/Indexer.php

Doc Comments +2 added lines, -2 removed lines

@@ -70,7 +70,7 @@ 
     /**
      * Get PDOStatement to fetch metadata about content objects to be indexed.
      *
-     * @param array $fields Select fields
+     * @param string[] $fields Select fields
      * @return \PDOStatement
      */
     protected function getContentDbFieldsStmt(array $fields)
@@ -108,7 +108,7 @@ 
      * Log warning while progress bar is shown.
      *
      * @param \Symfony\Component\Console\Helper\ProgressBar $progress
-     * @param $message
+     * @param string $message
      */
     protected function logWarning(ProgressBar $progress, $message)
     {